Re: [PHP-DEV] About SUCCESS/FAILURE

2014-12-25 Thread Xinchen Hui
Hey: On Fri, Dec 26, 2014 at 5:33 AM, Michael Wallner wrote: > There's already ZEND_RESULT_CODE, or did I miss anything? yes, we were talking about use ZEND_RESULT_CODE as return type hinting for those functions use SUCCSS/FAILURE .. furthermore, maybe we could use it as all ZEND_API's return

Re: [PHP-DEV] About SUCCESS/FAILURE

2014-12-25 Thread Levi Morrison
On Thu, Dec 25, 2014 at 2:33 PM, Michael Wallner wrote: > There's already ZEND_RESULT_CODE, or did I miss anything? According to lxr.php.net, this symbol ZEND_RESULT_CODE is not referenced in any place except its definition. We can begin using it if we like, or even rename it. Theoretically renam

Re: [PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-25 Thread Pierre Joye
On Fri, Dec 26, 2014 at 1:20 PM, Sara Golemon wrote: > On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon wrote: >> While playing around with Andrea's unicode literals syntax proposal, I >> was reminded of just how little of ICU is exposed. I've put up a >> short proposal for adding IntlChar exportin

[PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-25 Thread Sara Golemon
On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon wrote: > While playing around with Andrea's unicode literals syntax proposal, I > was reminded of just how little of ICU is exposed. I've put up a > short proposal for adding IntlChar exporting these APIs as static > methods (with a matching non-oop i

Re: [PHP-DEV] About SUCCESS/FAILURE

2014-12-25 Thread Pierre Joye
On Fri, Dec 26, 2014 at 8:33 AM, Michael Wallner wrote: > There's already ZEND_RESULT_CODE, or did I miss anything? Yes, to read the thread :) We are not talking about the lack of a status typedef but about the inconsistencies across PHP internal APIs. And what Xinchen suggests below is to begin

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Pierre Joye
On Dec 26, 2014 4:58 AM, "Stanislav Malyshev" wrote: > > Hi! > > > At the very least that sounds like a less intrusive step, as methods and > > classes are usually already written "correctly". > > To me, it sounds like needless nuisance - the code works, but wastes > time to produce warnings that

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Andrea, I am not a specialist in float numbers, but I think integral float numbers have a fractional part with value 0. JSON_FLOAT_ADD_POINT_ZERO can be confuse for regular floats with non-zero as fractional part. Seems you are going to add a point zero in a regular float with point something. A

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Andrea Faulds
> On 25 Dec 2014, at 19:32, Juan Basso wrote: > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fractional_part Hey Juan, A further thought: is “Preserve Fractional Part” the best name? Integral floats like float(12) don’t have any fractional part, and besides, the name

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Exactly. The idea of this RFC is just to add as a new option and not enabled by default. The idea to enable it by default was discussed before and I just added as future scope since it is not an easy decision, especially because the backward compatibility. The main goal is to have the option to ch

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Stanislav Malyshev
Hi! > At the very least that sounds like a less intrusive step, as methods and > classes are usually already written "correctly". To me, it sounds like needless nuisance - the code works, but wastes time to produce warnings that nobody reads. If your have a code that relies on autoloaders and cas

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Stanislav Malyshev
Hi! > Good evening and merry christmas, > > After some discussion in a separated thread I created the RFC to discuss > about the implementation of another json_encode option. > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fractional_part Completely makes sense for me as

Re: [PHP-DEV] About SUCCESS/FAILURE

2014-12-25 Thread Michael Wallner
There's already ZEND_RESULT_CODE, or did I miss anything? On 25 Dec 2014 06:45, "Xinchen Hui" wrote: > Hey: > > On Thu, Dec 25, 2014 at 12:38 PM, Pierre Joye > wrote: > > On Thu, Dec 25, 2014 at 3:06 PM, Andrea Faulds wrote: > >> > >>> On 24 Dec 2014, at 23:53, Levi Morrison wrote: > >>> > >>

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Ferenc Kovacs
On Thu, Dec 25, 2014 at 9:05 PM, Andrea Faulds wrote: > > > On 25 Dec 2014, at 19:32, Juan Basso wrote: > > > > Good evening and merry christmas, > > > > After some discussion in a separated thread I created the RFC to discuss > > about the implementation of another json_encode option. > > > > T

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Andrea Faulds
> On 25 Dec 2014, at 19:32, Juan Basso wrote: > > Good evening and merry christmas, > > After some discussion in a separated thread I created the RFC to discuss > about the implementation of another json_encode option. > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fra

[PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Good evening and merry christmas, After some discussion in a separated thread I created the RFC to discuss about the implementation of another json_encode option. The RFC can be found here: https://wiki.php.net/rfc/json_preserve_fractional_part Juan Basso

Re: [PHP-DEV] CVE-2014-8142 is not mentioned in 5.6.4 changelog

2014-12-25 Thread Lior Kaplan
Fixed. http://git.php.net/?p=web/php.git;a=commitdiff;h=52cb11fca4c343f0529ceecfdc5372b49b966435 (should be refreshed on the website soon enough) On Wed, Dec 24, 2014 at 6:58 AM, Yasuo Ohgaki wrote: > Hi, > > http://php.net/ChangeLog-5.php#5.4.36 > does not mention CVE-2014-8142. > > Fixed bug

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Pierre Joye
On Dec 25, 2014 7:08 PM, "Nikita Popov" wrote: > May I recommend to only target class and class-like names for an initial RFC? Those have the strongest argument in favor of case-sensitivity given how current autoloader implementations work - essentially the case-insensitivity doesn't properly wor

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Nikita Popov
On Thu, Dec 25, 2014 at 4:40 AM, François Laupretre wrote: > > > De : Pierre Joye [mailto:pierre@gmail.com] > > > > > Anyone dying while waiting to see PHP having case sensitive symbols > > > handling should go ahead with a RFC. > > For those interested, I just created a PR to raise an E_STRI

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Alain Williams
On Thu, Dec 25, 2014 at 10:18:13PM +1100, Pierre Joye wrote: > Forgot reply all? :) Yes - thanks. Reformatted: On Thu, Dec 25, 2014 at 09:53:11PM +1100, Pierre Joye wrote: > I do not see a reason why some code having ran out of the box for more > than a decade should be changed for 7 for purely

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Pierre Joye
On Thu, Dec 25, 2014 at 9:05 PM, Alain Williams wrote: > On Thu, Dec 25, 2014 at 04:40:09AM +0100, François Laupretre wrote: > >> > He will also have to deal with >> > file ops while being at it. Should they remain case insensitive? Do >> > manual checks to match the path actually being requested

Re: [PHP-DEV] Proposal for PHP 7 : case-sensitive symbols

2014-12-25 Thread Alain Williams
On Thu, Dec 25, 2014 at 04:40:09AM +0100, François Laupretre wrote: > > He will also have to deal with > > file ops while being at it. Should they remain case insensitive? Do > > manual checks to match the path actually being requested (ie. possible > > on windows using meta info), or keep everyth