Hi,
I made a quick code review, and I don't see any technical problems in
implementation.
1) Anyway, I think it's a bad idea to rename EngineException (and others)
into Error(s).
This will prevent using class Error in applications, and may potentially
break some of them.
I also don't like
I see only the test for packed array. You may create similar hash
array, initializing it in reverse order.
In my experiments packed arrays are slightly (8%) faster.
$ sapi/cli/php packed.php
Time: 0.022471189498901
Time: 0.012310028076172
$ sapi/cli/php hash.php
Time: 0.024425029754639
Time:
Hi Dmitry,
-Original Message-
From: Dmitry Stogov [mailto:dmi...@zend.com]
Sent: Monday, June 15, 2015 10:53 AM
To: Aaron Piotrowski
Cc: Anatol Belski; PHP Internals
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
Hi,
I made a quick code review, and I don't see any technical
Hi Hannes,
Nope, it's the same source and the same tag is always used. The tag is the
actual reference for any release. But usually people on Windows don't have
things like tar,gz and others. Even if they have - the compatibility might be
just bad. So it's zipped.
Regards
Anatol
What is the difference between Windows Sources and our official releases?
Did windows.php.net fork php or something? Embedded other things?
Are the binaries really not generated from the official sources?
This sounds like a horrible idea if true.
-Hannes
On Mon, Jun 15, 2015 at 5:39 AM,
Then this fix doesn't make any sense -- you are saying if I download
the .tar.gz and .zip and extract those two, I will have precisely the
same sources?
Then this fix should be reverted as there is isn't any special Windows
Sources and the official releases should work just fine.
-Hannes
On
2015-06-12 10:10 GMT+02:00 Tony Marston tonymars...@hotmail.com:
And what is the benefit in userland?
That is the question.
I think clean global namespace isn't enough argument, we can exist in
the current situation and considering the fact that most of the new
PHP applications have their own
Hello,
What is the needed configuration to be able to run the whole LDAP test suite?
It connects with cn=Manager,dc=my-domain,dc=com but then tries to create
dc=my-domain,dc=com.
How can cn=Manager,dc=my-domain,dc=com exist if dc=my-domain,dc=com does
not?
Is there any information about a
On Jun 15, 2015, at 6:56 AM, Anatol Belski anatol@belski.net wrote:
Hi Dmitry,
-Original Message-
From: Dmitry Stogov [mailto:dmi...@zend.com]
Sent: Monday, June 15, 2015 10:53 AM
To: Aaron Piotrowski
Cc: Anatol Belski; PHP Internals
Subject: Re: [PHP-DEV] [RFC] Throwable
On 15 June 2015 at 14:02, Côme BERNIGAUD come.bernig...@opensides.be
wrote:
Hello,
What is the needed configuration to be able to run the whole LDAP test
suite?
It connects with cn=Manager,dc=my-domain,dc=com but then tries to create
dc=my-domain,dc=com.
How can
On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski aa...@icicle.io wrote:
On Jun 15, 2015, at 6:56 AM, Anatol Belski anatol@belski.net wrote:
Hi Dmitry,
-Original Message-
From: Dmitry Stogov [mailto:dmi...@zend.com dmi...@zend.com]
Sent: Monday, June 15, 2015 10:53 AM
To:
On 2015-06-15 17:22, Michael Wallner wrote:
Check out ext/ldap/tests/connect.inc; you can pass various parameters
from the environment.
I know that, but we can’t select the base, and it does not change anything to
the fact that it tries to add the base, which have to already exists for the
Yep, the generated files in Windows are just the same as in the tag. But what
I’m talking about the package format itself. As the difference in the generated
files doesn’t mean something changed in the release itself.
Regards
Anatol
From: Ferenc Kovacs [mailto:tyr...@gmail.com]
Hi,
2015-06-15 16:09 GMT+02:00 Jakub Kubíček kelerest...@gmail.com:
I think clean global namespace isn't enough argument, we can exist in
the current situation and considering the fact that most of the new
PHP applications have their own namespaces, it could probably make
more sense to
Sebastian B.-Hagensen wrote:
On an unrelated note:
http://php.net/manual/en/userlandnaming.tips.php should hint towards
real namespaces.
There is already a respective ticket:
https://bugs.php.net/bug.php?id=69369. :)
--
Christoph M. Becker
--
PHP Internals - PHP Runtime Development
Yeah, it makes sense, just if you look into the bug #69829 . It was extracted
from the tarball packaged on Linux, and it went wrong. Also I've just found the
same issue reported with drupal - https://groups.drupal.org/node/315878
PaxHeaders and all that. We probably don't want to receive more
On Mon, 2015-06-15 at 16:20 +0200, Christoph Becker wrote:
Hannes Magnusson wrote:
Then this fix doesn't make any sense -- you are saying if I download
the .tar.gz and .zip and extract those two, I will have precisely the
same sources?
Then this fix should be reverted as there is isn't
I thought the files generated by genfiles for the linux tarballs are
different in the windows zips.
On Mon, Jun 15, 2015 at 4:02 PM, Anatol Belski anatol@belski.net
wrote:
Hi Hannes,
Nope, it's the same source and the same tag is always used. The tag is the
actual reference for any
On 15/06/15 15:43, Chris Wright wrote:
On 15 June 2015 at 14:02, Côme BERNIGAUD come.bernig...@opensides.be
wrote:
Hello,
What is the needed configuration to be able to run the whole LDAP test
suite?
It connects with cn=Manager,dc=my-domain,dc=com but then tries to create
Hi Johannes,
-Original Message-
From: Johannes Schlüter [mailto:johan...@schlueters.de]
Sent: Monday, June 15, 2015 4:52 PM
To: Christoph Becker
Cc: Hannes Magnusson; Anatol Belski; PHP Development; PHP Webmaster ML
Subject: Re: [PHP-DEV] PHP7 releases vs Windows Sources?
On Mon,
On Jun 15, 2015 10:38 PM, Anatol Belski anatol@belski.net wrote:
Hi Johannes,
-Original Message-
From: Johannes Schlüter [mailto:johan...@schlueters.de]
Sent: Monday, June 15, 2015 4:52 PM
To: Christoph Becker
Cc: Hannes Magnusson; Anatol Belski; PHP Development; PHP
On Sat, Jun 13, 2015 at 11:46 AM, Rowan Collins rowan.coll...@gmail.com
wrote:
On 12 June 2015 02:31:18 BST, Tjerk Meesters tjerk.meest...@gmail.com
wrote:
Hi,
I've created a PR here: https://github.com/php/php-src/pull/1325
This enhancement allows for properties on objects to work in
On Mon, Jun 15, 2015 at 8:38 AM, Anatol Belski anatol@belski.net wrote:
Hi Johannes,
-Original Message-
From: Johannes Schlüter [mailto:johan...@schlueters.de]
Sent: Monday, June 15, 2015 4:52 PM
To: Christoph Becker
Cc: Hannes Magnusson; Anatol Belski; PHP Development; PHP
Johannes Schlüter in php.internals (Mon, 15 Jun 2015 16:52:12 +0200):
If there is a need for zip archives I'd put them next to tar.gz etc. and
distribute them via our mirror network.
On github they are next to each other:
https://github.com/php/php-src/releases
Most of the times I use the zips,
Anatol Belski in php.internals (Sun, 14 Jun 2015 20:45:24 +0200):
Hi Jan,
-Original Message-
From: Jan Ehrhardt [mailto:php...@ehrhardt.nl]
OK, I recmpiled my Windows builds with --enable-opcache-file:
https://www.apachelounge.com/viewtopic.php?p=30718#30718
Example of a generated
On Mon, Jun 15, 2015 at 12:51 PM, Anatol Belski anatol@belski.net wrote:
Hi Hannes,
-Original Message-
From: Hannes Magnusson [mailto:hannes.magnus...@gmail.com]
Sent: Monday, June 15, 2015 8:34 PM
To: Anatol Belski
Cc: Johannes Schlüter; Christoph Becker; PHP Development; PHP
Hi,
I found a problem with spaceship operator.
It doesn't define result for comparison with NaN.
$ sapi/cli/php -r 'var_dump(sqrt(-1) = 0);'
int(-1)
$ sapi/cli/php -r 'var_dump(0 = sqrt(-1));'
int(-1)
$ sapi/cli/php -r 'var_dump(0 sqrt(-1));'
bool(false)
all other comparison operators return
On 15 June 2015 20:55:04 BST, Bob Weinand bobw...@hotmail.com wrote:
As far as I know, we made it that way in order to enforce an int return
type all the time.
int(-1) is indeed the sensible value for this. (Mainly int(0) does not
work because it'd mean equality and so we're left with int(-1) and
Hi Hannes,
-Original Message-
From: Hannes Magnusson [mailto:hannes.magnus...@gmail.com]
Sent: Monday, June 15, 2015 8:34 PM
To: Anatol Belski
Cc: Johannes Schlüter; Christoph Becker; PHP Development; PHP Webmaster ML
Subject: Re: [PHP-DEV] PHP7 releases vs Windows Sources?
On
Hi Jan,
-Original Message-
From: Jan Ehrhardt [mailto:php...@ehrhardt.nl]
Sent: Monday, June 15, 2015 6:29 PM
To: internals@lists.php.net
Subject: Re: [PHP-DEV] PHP 7.0.0alpha1 Released for Testing!
Anatol Belski in php.internals (Sun, 14 Jun 2015 20:45:24 +0200):
Hi Jan,
On Mon, 2015-06-15 at 18:41 +0200, Jan Ehrhardt wrote:
On github they are next to each other:
https://github.com/php/php-src/releases
Those don't include the generated parsers etc. we should disable these,
while I couldn't find an option for that on github's site.
johannes
signature.asc
On Mon, Jun 15, 2015 at 4:53 PM, Dmitry Stogov dmi...@zend.com wrote:
On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski aa...@icicle.io wrote:
On Jun 15, 2015, at 6:56 AM, Anatol Belski anatol@belski.net wrote:
Hi Dmitry,
-Original Message-
From: Dmitry Stogov
Hi!
I found a problem with spaceship operator.
It doesn't define result for comparison with NaN.
$ sapi/cli/php -r 'var_dump(sqrt(-1) = 0);'
int(-1)
$ sapi/cli/php -r 'var_dump(0 = sqrt(-1));'
int(-1)
$ sapi/cli/php -r 'var_dump(0 sqrt(-1));'
bool(false)
all other comparison
As far as I know, we made it that way in order to enforce an int return type
all the time.
int(-1) is indeed the sensible value for this. (Mainly int(0) does not work
because it'd mean equality and so we're left with int(-1) and int(1).)
Just because other comparison ops already return a bool,
-Original Message-
From: Bob Weinand [mailto:bobw...@hotmail.com]
Sent: Monday, June 15, 2015 9:55 PM
To: Dmitry Stogov
Cc: da...@php.net; Andrea Faulds; Stanislav Malyshev; Anatol Belski; Kalle
Sommer Nielsen; PHP Internals
Subject: Re: [PHP-DEV] Spaceship and NaNs
As far as I
-Original Message-
From: Hannes Magnusson [mailto:hannes.magnus...@gmail.com]
Sent: Monday, June 15, 2015 10:29 PM
To: Anatol Belski
Cc: Johannes Schlüter; Christoph Becker; PHP Development; PHP Webmaster ML
Subject: Re: [PHP-DEV] PHP7 releases vs Windows Sources?
On Mon, Jun
Hi Dmitry,
On Mon, Jun 15, 2015 at 6:06 PM, Dmitry Stogov dmi...@zend.com wrote:
I see only the test for packed array. You may create similar hash
array, initializing it in reverse order.
It's better approach to see the difference because the array content is
basically the same.
In my
On Mon, Jun 15, 2015 at 4:45 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
On 15 June 2015 20:55:04 BST, Bob Weinand bobw...@hotmail.com wrote:
As far as I know, we made it that way in order to enforce an int return
type all the time.
int(-1) is indeed the sensible value for this. (Mainly
Johannes Schlüter wrote:
On Mon, 2015-06-15 at 16:20 +0200, Christoph Becker wrote:
There is some difference (timestamps?) which causes building from the
tarred sources to fail on Windows (see bug #69829).
touching generated files as part of the packaging process is a good
idea for all
I think REGISTER_INTERFACE() macro in zend_interfaces.h is better.
Actually, it's not related to ITERATORs at all.
Thanks. Dmitry.
On Tue, Jun 16, 2015 at 12:48 AM, Aaron Piotrowski aa...@icicle.io wrote:
On Jun 15, 2015, at 9:53 AM, Dmitry Stogov dmi...@zend.com wrote:
On Mon, Jun 15,
Hi!
Just because other comparison ops already return a bool, we can return
bool(false) there.
But we can not return bool from operator that is declared as returning
int, and adding extra type would make this operator essentially useless,
as it is meant to be a concise way of comparing two
On Jun 15, 2015, at 9:53 AM, Dmitry Stogov dmi...@zend.com wrote:
On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski aa...@icicle.io
mailto:aa...@icicle.io wrote:
On Jun 15, 2015, at 6:56 AM, Anatol Belski anatol@belski.net
mailto:anatol@belski.net wrote:
Would you like me
Jan Ehrhardt wrote:
Johannes Schlüter in php.internals (Mon, 15 Jun 2015 22:28:37 +0200):
On Mon, 2015-06-15 at 18:41 +0200, Jan Ehrhardt wrote:
On github they are next to each other:
https://github.com/php/php-src/releases
Those don't include the generated parsers etc. we should disable
-Original Message-
From: Nikita Popov [mailto:nikita@gmail.com]
Sent: Monday, June 15, 2015 10:36 PM
To: Dmitry Stogov
Cc: Aaron Piotrowski; Anatol Belski; PHP Internals
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
On Mon, Jun 15, 2015 at 4:53 PM, Dmitry Stogov
Johannes Schlüter in php.internals (Mon, 15 Jun 2015 22:28:37 +0200):
On Mon, 2015-06-15 at 18:41 +0200, Jan Ehrhardt wrote:
On github they are next to each other:
https://github.com/php/php-src/releases
Those don't include the generated parsers etc. we should disable these,
while I couldn't
Anatol Belski in php.internals (Mon, 15 Jun 2015 22:14:41 +0200):
From: Jan Ehrhardt [mailto:php...@ehrhardt.nl]
BTW: libssh2 also has an update.
Thanks for the info. It's planned to do full dependencies rebuild once
VS2015 goes final.
Some remarks:
OpenSSL 1.0.1o and 1.0.2c have a problem
On Mon, Jun 15, 2015 at 3:46 PM, Stanislav Malyshev smalys...@gmail.com wrote:
Hi!
It's a worthy goal IMHO. Currently it all is done manually as you know.
What! No, I didn't know.
I was describing how the process used to be, and I thought it still was.
I think making auto-release is a
Hi!
gpg-agent forwarding over ssh?
Well, if that works then fine. I never tried it (actually didn't use the
agent that much at all) but why not.
- Goto https://release.php.net/
- Login with your master credentials (only allows logins for whitelisted
users).
- White page suggest you are
Hi,
2015-06-15 19:25 GMT-03:00 Aaron Piotrowski aa...@icicle.io:
On Jun 15, 2015, at 4:02 PM, Anatol Belski anatol@belski.net wrote:
I would then suggest Aaron to stick to the minimal voting period (announcing
this as early as possible), if the voting passes - then merge the branch on
On Tue, 2015-06-16 at 00:02 +0200, Christoph Becker wrote:
Why should these downloads be disabled? They contain exactly what could
be checked out from the respective tag.
It is not including the generated parsers. This means the user might use
a different version, which might cause a bug
On Jun 15, 2015, at 4:02 PM, Anatol Belski anatol@belski.net wrote:
I would then suggest Aaron to stick to the minimal voting period (announcing
this as early as possible), if the voting passes - then merge the branch on
Wednesday. This way we would have nearly one week to test and do
Hi!
Then this fix doesn't make any sense -- you are saying if I download
the .tar.gz and .zip and extract those two, I will have precisely the
same sources?
Should be the same sources. We shouldn't distribute anything that isn't
under the respective tag as official sources, so I assume they
Hi!
It's a worthy goal IMHO. Currently it all is done manually as you know.
What! No, I didn't know.
I was describing how the process used to be, and I thought it still was.
I think making auto-release is a nice idea, but what about signing? I'm
surely not leaving my personal private key
On Mon, 2015-06-15 at 23:09 +0200, Jan Ehrhardt wrote:
Is that a real problem? I always use those sources for my own Windows
builds, because they are the first publicly available tarballs of a new
release.
They are made available by github, but no official php.net downloads.
Until the release
Christoph Becker in php.internals (Tue, 16 Jun 2015 00:02:12 +0200):
Have you already tried to compile an php-7.0.0alpha1.tar.* on Windows.
I suppose that would fail, see http://news.php.net/php.internals/86685.
It does not fail with
https://github.com/php/php-src/archive/php-7.0.0alpha1.tar.gz
Christoph Becker in php.internals (Tue, 16 Jun 2015 00:02:12 +0200):
Jan Ehrhardt wrote:
Johannes Schlüter in php.internals (Mon, 15 Jun 2015 22:28:37 +0200):
On Mon, 2015-06-15 at 18:41 +0200, Jan Ehrhardt wrote:
On github they are next to each other:
https://github.com/php/php-src/releases
Johannes Schlüter wrote:
On Tue, 2015-06-16 at 00:02 +0200, Christoph Becker wrote:
Why should these downloads be disabled? They contain exactly what could
be checked out from the respective tag.
It is not including the generated parsers. This means the user might use
a different
Johannes Schlüter in php.internals (Tue, 16 Jun 2015 01:48:15 +0200):
On Mon, 2015-06-15 at 23:09 +0200, Jan Ehrhardt wrote:
Is that a real problem? I always use those sources for my own Windows
builds, because they are the first publicly available tarballs of a new
release.
They are made
On Jun 16, 2015 1:34 AM, Hannes Magnusson .
Thats what we want. We want the official release balls to be generated
by an official server using the official toolchain.
For the tarballs? Yes. Only that it does not happen last time I checked.
There should never be a time when a Release
59 matches
Mail list logo
