Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Robert Landers
On Fri, Jun 17, 2022 at 6:14 PM Sara Golemon wrote: > > On Thu, Jun 16, 2022 at 2:10 AM Pierrick Charron wrote: > > > For a long time, ext/curl worked with handles as "curl resources" and > > functions mapped to the libcurl functions, but since PHP8.0 "curl > > resources" were converted to

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Go Kudo
2022年6月18日(土) 4:50 Tim Düsterhus : > Hi > > On 6/17/22 21:41, Go Kudo wrote: > > https://wiki.php.net/rfc/random_extension_improvement > > > > There's still a section for array_rand() at the top of the RFC > ( >

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 21:41, Go Kudo wrote: https://wiki.php.net/rfc/random_extension_improvement There's still a section for array_rand() at the top of the RFC (https://wiki.php.net/rfc/random_extension_improvement#randomizer_lacks_array_rand_replacement_method), but no voting section. My

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月18日(土) 4:16 Tim Düsterhus : > Hi > > On 6/17/22 20:37, Go Kudo wrote: > > For the reasons stated above, we will abandon the addition of new > methods. > > sorry. > > Okay, that's fine for me, no problem. > > > `str_shuffle()` and `shuffleString()` already have similar problems. So > >

[PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Go Kudo
Hi internals. An RFC has been created to fix an issue in Random Extension 5.x. https://wiki.php.net/rfc/random_extension_improvement Voting on this RFC will begin in two weeks (2022-07-02), in time for the PHP 8.2 Feature Freeze. (Vote finished in 2022-07-16, Feature Freeze is 2022-07-19) In

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 20:37, Go Kudo wrote: For the reasons stated above, we will abandon the addition of new methods. sorry. Okay, that's fine for me, no problem. `str_shuffle()` and `shuffleString()` already have similar problems. So perhaps an alternative method name for `str_shuffle()` might be

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月18日(土) 3:13 Tim Düsterhus : > Hi > > On 6/17/22 19:46, Go Kudo wrote: > > I was fundamentally wrong, I understand now. > > As you said, there was no interoperability with `pickArrayKey()` in the > > first place... > > > >> stringFromAlphabet() > > > > Hmmm. I guess randomString would be

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 19:46, Go Kudo wrote: I was fundamentally wrong, I understand now. As you said, there was no interoperability with `pickArrayKey()` in the first place... stringFromAlphabet() Hmmm. I guess randomString would be better then. At the same time, it would be nice to have an array

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月18日(土) 2:37 Tim Düsterhus : > Hi > > On 6/17/22 19:28, Go Kudo wrote > >> I don't think that ->pickString() is a good name > > > > I see. But I think `randomString()` is ambiguous with `getBytes()`. > > > > `stringFromCharset(string $string, int $num): string` solves that, but I > > think

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 19:28, Go Kudo wrote I don't think that ->pickString() is a good name I see. But I think `randomString()` is ambiguous with `getBytes()`. `stringFromCharset(string $string, int $num): string` solves that, but I think it is possible that the meaning of "char" is not well known

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月18日(土) 2:14 Tim Düsterhus : > Hi > > On 6/17/22 19:04, Go Kudo wrote: > > RFC has been updated. Includes corrections to areas pointed out by Tim > and > > changes MersenneTwister to MT19937. > > I also made it possible to vote for each item. > > I suggest to split the "PCG is not so

Re: [PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 18:06, Guilliam Xavier wrote: https://github.com/php/php-src/pull/8819 Just so that it can't be said that it hasn't been asked: what about iterator_count(), and iterator_apply()? I also came across those, while implementing the PR, but I intentionally did not touch them

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 19:04, Go Kudo wrote: RFC has been updated. Includes corrections to areas pointed out by Tim and changes MersenneTwister to MT19937. I also made it possible to vote for each item. I suggest to split the "PCG is not so famous" vote into 2 votes to make it clear how exactly the

[PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月14日(火) 9:01 Go Kudo : > Hello internals. > > Voting began on 2022-06-14 00:00:00 (UTC) and will end on 2022-06-28 > 00:00:00 (UTC). > > https://wiki.php.net/rfc/rng_extension > > The implementation is not yet complete and has some issues. > See TODO in Pull Request for details. > >

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Sara Golemon
On Thu, Jun 16, 2022 at 2:10 AM Pierrick Charron wrote: > For a long time, ext/curl worked with handles as "curl resources" and > functions mapped to the libcurl functions, but since PHP8.0 "curl > resources" were converted to opaque classes with no methods. So my main > goal here is to come up

Re: [PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-17 Thread Guilliam Xavier
>https://github.com/php/php-src/pull/8819 Just so that it can't be said that it hasn't been asked: what about iterator_count(), and iterator_apply()? Regards, -- Guilliam Xavier -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 14:52, Go Kudo wrote: (3) This is a very tricky problem. As you point out, it took me a while to figure out PCG64 too. However, after statistical testing PCG64 (pcg_oneseq-128-xsl-rr-64) seems to do a good job. (Though Xoshiro256** does as well, and has a more obvious name.)

Re: [PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-17 Thread Larry Garfield
On Fri, Jun 17, 2022, at 10:20 AM, Tim Düsterhus wrote: > Hi Internals > > I've come across a case where it would've been useful if > `iterator_to_array()` would accept iterable instead of Traversable to > avoid checking whether the input variable already is an array. > > To not repeat what I've

Re: [PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-17 Thread G. P. B.
On Fri, 17 Jun 2022 at 16:20, Tim Düsterhus wrote: > Hi Internals > > I've come across a case where it would've been useful if > `iterator_to_array()` would accept iterable instead of Traversable to > avoid checking whether the input variable already is an array. > > To not repeat what I've

[PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-17 Thread Tim Düsterhus
Hi Internals I've come across a case where it would've been useful if `iterator_to_array()` would accept iterable instead of Traversable to avoid checking whether the input variable already is an array. To not repeat what I've already written in my proposed PR, please see:

[PHP-DEV] [RFC] [VOTE] Disjunctive Normal Form Types

2022-06-17 Thread G. P. B.
Hello internals, I've started the vote for the Disjunctive Normal Form Types RFC: https://wiki.php.net/rfc/dnf_types The vote will last for 2 weeks and end on the 1st of July Best regards, George P. Banyard

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Rowan Tommins
Hi Pierrick, On Thu, 16 Jun 2022 at 22:44, Pierrick Charron wrote: > Is it OK to have one part > that is a thin wrapper and another part that is a "remodeling" of the API ? > (This is not a rhetorical question, I really ask myself the question). > I agree with others that the new API should

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月16日(木) 22:37 Tim Düsterhus : > Hi > > On 6/16/22 14:52, Tim Düsterhus wrote: > > (3) Naming of PCG64: > > > > I must admit that the fact that PCG is a full family of similar, but not > > identical generators is one thing that made me (and still makes me) > > prefer the xoshiro family which

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-17 Thread Go Kudo
2022年6月16日(木) 19:56 Guilliam Xavier : > Hi, > > > https://wiki.php.net/rfc/random_extension_improvement > > Thanks; some editorial remarks: > > - I think "Engine is not final" should rather be "Engine > implementations are not final", and similarly in the text: "Even if > the native class is

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Pierrick Charron
Hi Lynn, You have to be careful, even though most developers associate curl with an http client and only use this feature, it's only part of what it is. It's a multiprotocol file transfer library that supports DICT, FILE, FTP, FTPS, GOPHER, GOPHERS, HTTP, HTTPS, IMAP, IMAPS, LDAP, LDAPS, MQTT,

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Craig Francis
On 17 Jun 2022, at 09:27, Lynn wrote: > ... That said, we should avoid having: cURL procedural + cURL procedural in > objects + cURL OOP. Having 2 different object based libraries to do the same > thing PHP is confusing and will just end up in way too many Stack Overflow > questions. > >

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-17 Thread Lynn
Good timezone! On Thu, Jun 16, 2022 at 11:44 PM Pierrick Charron wrote: > About making a "Good OOP API", of course the goal is to make a *Good* OOP > API. But there are things to take into consideration. The proposal here is > yes to expose the new Curl URL API which is quite small, but also to