On Sat, Jan 12, 2013 at 12:21 AM, Nikita Popov wrote:
> Voting no, because - even though I like this feature in principle - I think
> it's much better solved by introducing list comprehensions (which cover
> this and many more cases in a consistent and elegant syntax), which is
> something I have
On Wed, Jan 23, 2013 at 10:35 PM, Clint Priest wrote:
> On 1/23/2013 3:17 PM, Levi Morrison wrote:
>> Clint: I'm sorry that you spent all that time without hearing feedback
>> from a lot of the "No" voters. Had they been participating all along
>> perhaps it could have been avoided. We'll never kn
On Mon, Jan 28, 2013 at 10:24 PM, Ferenc Kovacs wrote:
> On Mon, Jan 28, 2013 at 11:11 PM, Patrick ALLAERT >wrote:
> > It's perfectly valid to accept an RFC and comment on the
> > implementation on what should be improved or what sucks in it.
> >
> > If one is voting "no" mostly because of the i
On Thu, Mar 7, 2013 at 9:58 PM, Anthony Ferrara wrote:
> Well, this passed with 62.8%. Property accessors failed with 60.7%. The
> target for acceptance is 66.6%. So 3.8% is enough to throw away, but 5.9%
> isn't?
>
94% voted to integrate ZO+.
> Either we stick to the rules, or we throw them o
Hi Pierrick,
Why the big rush? There have been three more votes against removing it in
PHP 5.5 since your last email yesterday so I don't think closing the vote
early is warranted, but I'm in general confused about the rush to do this
in PHP 5.5 anyway.
In principle I'm in favour of moving it to
On Thu, Jun 27, 2013 at 1:36 AM, Yasuo Ohgaki wrote:
> Hi,
>
> Sorry for the long delay, I've sent pull requests
>
> https://github.com/php/php-src/pull/368
> https://github.com/php/php-src/pull/367
> https://github.com/php/php-src/pull/366
>
>
Hi,
I see the strict mode check is now implemented
On Fri, Jul 19, 2013 at 5:36 PM, Daniel Lowrey wrote:
> How deeply ingrained into the engine is this behavior? Is there any chance
> of language constructs ever passing the tests for callability or is that
> just a pipe dream that's not worth the implementation effort?
>
It's actually pretty tri
On Fri, Jul 19, 2013 at 6:28 PM, Daniel Lowrey wrote:
> While it works, it somewhat obscures what you're trying to accomplish in
> the code. The maintainability nightmare alone may be enough to
> counterbalance any benefits. Then again, who needs
> readability/maintainability when you can write h
On Sat, Jul 20, 2013 at 9:24 AM, Lester Caine wrote:
> Stas Malyshev wrote:
>
>> Is there a reason that echo/print couldn't be implemented as functions
>>> >with some sort of backwards compatibility layer? isset/etc make sense to
>>>
>>
> Yes, the reason is not fixing what isn't broken:)
>>
>
>
g this properly in PHP.next? My
arguments against this version of the patch still stand:
On Thu, Jun 27, 2013 at 11:51 AM, Yasuo Ohgaki wrote:
> Hi Arpad,
>
> 2013/6/27 Arpad Ray
>
>> I see the strict mode check is now implemented in the handlers and not
>> session.c,
Hi Yasuo,
On Mon, Aug 5, 2013 at 10:50 AM, Yasuo Ohgaki wrote:
> On Mon, Aug 5, 2013 at 6:22 PM, Arpad Ray wrote:
>
>> I thought we were in agreement about doing this properly in PHP.next? My
>> arguments against this version of the patch still stand:
>
>
> We had
Hi Yasuo,
On Mon, Aug 5, 2013 at 11:10 AM, Yasuo Ohgaki wrote:
>
> On Mon, Aug 5, 2013 at 7:05 PM, Arpad Ray wrote:
>
>> I'm not against the idea in principle but still think having a security
>> feature which just quietly fails if you're not using one of two mod
Hi Yasuo,
On Mon, Aug 5, 2013 at 11:38 AM, Yasuo Ohgaki wrote:
> On Mon, Aug 5, 2013 at 7:26 PM, Arpad Ray wrote:
>
>> Could you point me to where this was decided please? I don't see a vote
>> or anything like a consensus in the previous threads.
>
>
> There is
Hi Yasuo,
On Mon, Aug 5, 2013 at 7:46 PM, Yasuo Ohgaki wrote:
> On Tue, Aug 6, 2013 at 1:04 AM, Arpad Ray wrote:
>
>> I think there really should be a vote.
>
>
> This means you don't really understand the true risk of this vulnerability.
> It allows permanent ses
Hi Stas,
On Mon, Aug 5, 2013 at 8:23 PM, Stas Malyshev wrote:
> > I'm not going to repeat my arguments against the committed solution yet
> > again, but I really think we need a better one.
>
> You are free to propose a better one. Since this topic is being
> discussed for almost 2 years and nobo
On Fri, Aug 16, 2013 at 1:00 AM, Sara Golemon wrote:
> I wasn't going to bring this up, but an intersectional idea I had a few
> years ago Static Constructor. Just like an instance constructor, but
> called on initial load.
>
> class Foo {
> public static __static_construct(/* no args all
Hi,
On Thu, Aug 18, 2011 at 12:12 PM, Paul Dragoonis wrote:
> Hey guys,
>
> After a brief discussion with Pierre I'm taking this discussion to here.
> We have the igbinary pecl extension available [1], however not many of our
> userbase are familiar that it even exists.
> Here [2] is the performa
On Fri, Aug 19, 2011 at 1:04 PM, Ferenc Kovacs wrote:
> this could still cause problems, as pointed out before (when you
> change your handler, or when you pass serialized data between
> different php installs, etc.), so I really like what Kiall Mac Innes
> suggested: prefix the data with the seri
On Fri, Aug 19, 2011 at 1:40 PM, Ferenc Kovacs wrote:
> On Fri, Aug 19, 2011 at 2:31 PM, Arpad Ray wrote:
>> On Fri, Aug 19, 2011 at 1:04 PM, Ferenc Kovacs wrote:
>>> the downside would be that if you want to serialize/unserialize the
>>> data outside of php, your
Hi,
Haven't had much of a look yet but I really like the concept :)
A couple of minor things to note:
- Now would be a good time to make it follow the PHP coding standards,
before it gets much larger or other devs get involved.
- Variable declarations should always begin a block, some platforms
w
On Fri, Nov 11, 2011 at 12:17 AM, Rasmus Lerdorf wrote:
> Hey Arpad, looking through the code you added to
> ext/standard/basic_functions.c it looks like you are doing some weird
> key handling in the shutdown function hash.
>
>
Hi Rasmus,
Thanks for the heads up, just fixed these.
Cheers,
Arp
Hi Kris,
On 20 Mar 2012 23:29, "Kris Craig" wrote:
>
> On Tue, Mar 20, 2012 at 4:08 PM, Ferenc Kovacs wrote:
> >
> >> But just because you and a few other stuffed shirts don't understand
the
> >> value of dissenting viewpoints,
> >
> >
> > that's so nice of you
> >
>
> You're welcome.
>
Your to
Hi,
On 26 Mar 2012 17:13, "Martin Amps" wrote:
> Is there any notable difference or advantage to either method? The only
thing I can think of is in the code you could fallback to another handler
if a Memcache server was unavailable, or use a slave.
This kind of question should be on the general
Please excuse me for butting in without immediate context. I'd just like to
support the idea of a vote on this concept without getting into specifics.
If the vote is positive then we can argue the various merits of the
competing RFCs knowing that we at least agree in general. On the other hand
if
2010/5/13 Johannes Schlüter
> To your issue: That's related to the way the session module serializes
> data, which is non-standard serialize due to register_globals. Most
> likely php.next, where r_g is gone will use standard serialization where
> this would be fixed. till then a session key has
On Mon, Nov 8, 2010 at 1:33 PM, Alexandr Verbitsky
wrote:
> Hi all.
> I am investigate in the reason Bug #52477 (http://bugs.php.net/52477) and
> found that it appear because in PHP 5.2.14 there are two constant
> PS_DELIMITER and PS_UNDEF_MARKER. The value it's constants not allow to use
> in the
On Wed, Apr 20, 2011 at 11:50 PM, Mark wrote:
> On Wednesday, April 20, 2011, D. Dante Lorenso wrote:
>> On 4/20/11 9:55 AM, Mark wrote:
>>
>> Hi,
>> This proposal is for the often called line like this:
>> $var = isset($_GET['var']) ? $_GET['var'] : '';
>> Only a shorter and imho a cleaner solut
On Thu, Apr 14, 2011 at 3:05 PM, Hannes Landeholm wrote:
> Some suggested that the ternary if comparison should suppress the notice
> automatically. This would break existing code and also be confusing since
> people expect a ternary if and normal if to work the same way.
>
> Some suggested ?? as
On Thu, Apr 21, 2011 at 12:56 AM, Arpad Ray wrote:
> I've pined for something like coalesce($_GET['foo'], $defaults['foo'],
> 42) for years, and I think that style is far more in keeping with the
> PHP ethos, and far more readily understandable than this sugge
Hi,
A while ago I submitted a patch to allow session_set_save_handler() to
accept a class, and support the inheritance of the default session
handler's methods.
The RFC has a more detailed description and the current patch:
https://wiki.php.net/rfc/session-oo
Changes since this was last discusse
On Mon, Jun 6, 2011 at 5:31 PM, Richard Quadling wrote:
> Not an internals expert, but I do have a question.
>
> When would the session handler object be destroyed?
>
> If sessions are being logged to a DB (maybe via a userland PHP class),
> is internal reference counting enough to handle the orde
Hi,
This patch implements unregister_shutdown_function(), which removes a
function already registered with register_shutdown_function().
It resolves request #53702 (according to google, not sure if it's
still active) and I've thought it a curious absence for a while.
The patch (against trunk) is
2011/6/20 Johannes Schlüter :
>
> (any reason you sent this privately?)
Nope, must have hit the wrong button ;) back to the list now.
>
> On Mon, 20 Jun 2011 18:38:50 +0100, Arpad Ray wrote:
>> 2011/6/20 Johannes Schlüter :
>>> Why do you register a shutdown functi
On Mon, Jun 20, 2011 at 10:37 AM, Richard Quadling wrote:
> On 20 June 2011 01:39, Arpad Ray wrote:
>> On Mon, Jun 6, 2011 at 5:31 PM, Richard Quadling wrote:
>>> Not an internals expert, but I do have a question.
>>>
>>> When would the session handler obje
Hi,
I've updated the patches again.
The most significant change is that the shutdown function registers
another shutdown function when it's called, to (almost) ensure that
it's always the last one, and therefore user shutdown functions should
always find the session available as expected. I'd esp
On Sat, Jun 25, 2011 at 6:13 AM, Arpad Ray wrote:
> The most significant change is that the shutdown function registers
> another shutdown function when it's called, to (almost) ensure that
> it's always the last one, and therefore user shutdown functions should
> a
On Mon, Jun 27, 2011 at 5:00 PM, Arpad Ray wrote:
> On Mon, Jun 27, 2011 at 4:52 AM, Larry Garfield
> wrote:
>> I'm a bit confused. If the session handler goes out of its way to ensure
>> that it's the last thing to run, wouldn't that cause an issue if it tri
Hi,
This little patch makes the following changes to the CLI web server's
console logging:
- Compacts messages to one line, so a 404 doesn't occupy three lines.
- Includes the response status code
- Colours messages according to their response code (success=green,
client error=yellow, server error
Hi,
There's now a request for this:
https://bugs.php.net/bug.php?id=55109
Colours are now toggled by the ini setting cli_server.color.
I'm still looking into means of excluding the more deceptively
incapable terminals but I will support having colours on by default
anyway.
Regards,
Arpad
--
Hi,
Voting is now open for object oriented session handlers.
The RFC and patch can be found here:
https://wiki.php.net/rfc/session-oo
You can vote here:
https://wiki.php.net/rfc/session-oo/vote
Regards,
Arpad
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http
Hi,
Voting for the Object oriented session handlers RFC is now closed.
Results can be found here:
https://wiki.php.net/rfc/session-oo/vote
The RFC was accepted (22 for, 0 against.)
There's a minor change to the patch which I haven't got around to yet
(see Felipe's mail on the RFC thread) - I
On Sun, Jul 3, 2011 at 4:15 PM, Felipe Pena wrote:
> I like the idea (and voted +1 on it), but I've some consideration to do:
>
> +/* {{{ proto bool SessionHandler::open(string save_path, string session_name)
> + Wraps the old open handler */
> +PHP_METHOD(SessionHandler, open)
> +{
> + PS
Hi,
https://bugs.php.net/patch-display.php?bug_id=55158&patch=trunk-multisort-natural&revision=latest
adds the flags SORT_NATURAL and SORT_CASE to array_multisort. The
SORT_NATURAL flag is well explained by the request the patch is
attached to: https://bugs.php.net/bug.php?id=55158
SORT_CASE can
Hi all,
I'm curious about something with magic_quotes_gpc - it ignores the keys
of array values in $_GET etc, despite escaping keys of scalar values and
all keys in contained arrays. For example, the query string ?a'b=1
yields $_GET[a\'b] = 1, but ?a'b[a'b]=1 yields $_GET[a'b][a\'b] = 1.
Whi
Arpad Ray wrote:
So, is this behaviour deliberate, and if so, what's the rationale?
The problem seems to be in (5.2.x CVS) php_variables.c, lines 161-166:
if (PG(magic_quotes_gpc) && (index != var)) {
/* no need to addslashes() the index if i
David Zülke wrote:
Yes, BC. magic_quotes is crappy/complicated enough to deal with
already, please don't make it behave differently between PHP5
versions. No need to. Nobody should use it anymore, so there is no
reason to change behavior again anyway.
What we seem to have here is a bug in a
Update: I raised this issue as a bug (#41093) because of lack of
interest here. It's now been fixed in CVS and will therefore be in 5.2.2
RC2 (thanks Ilia).
Arpad
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Emil Ivanov wrote:
The case is simple:
A user is allowed to upload files to the server, which are store in a
temporary location and their filenames are stored in the session.
The user leaves the site and the session gets destroyed, but the files
remain untouched.
If I can hook to the gc session
Dmitry Stogov wrote:
The patch is already committed to the HEAD.
Dmitry.
There seem to be some problems with importing across files. The tests
currently in CVS are all in single files so it's not immediately
obvious. When a namespace is declared in one file and imported in
another, classes
|
+ | If you did not receive a copy of the PHP license and are unable to |
+ | obtain it through the world-wide-web, please send a note to |
+ | lice...@php.net so we can mail you a
Hi,
Attached is a patch (against HEAD) which adapts the default ("php") session
serializer to serialize the whole array using php_var_serialize instead of
calling it once per element.
This simplifies the serialization code, and allows unicode session keys, or
even ascii keys containing the pipe c
On Thu, Nov 26, 2009 at 2:23 PM, Antony Dovgal wrote:
> On 26.11.2009 03:43, Stanislav Malyshev wrote:
> > I think it makes sense. One note: your code allows numeric session keys,
> > previously not allowed. Not sure if it's important.
>
> This might be important for 32bit<->64bit interaction usi
On Fri, Nov 27, 2009 at 11:57 AM, Lukas Kahwe Smith wrote:
>
> sounds useful. i assume with this i could extend for example the session
> handler that comes with the Memcached extension? could you provide a code
> example of how that would look like?
>
Right, the SessionHandler class represents t
the following url: |
+ | http://www.php.net/license/3_01.txt |
+ | If you did not receive a copy of the PHP license and are unable to |
+ | obtain it through the world-wide-web, please send a note to |
+ | lice...@php.net so we can mai
Hi,
On Wed, Dec 9, 2009 at 11:16 PM, Stanislav Malyshev wrote:
> It now raises an error rather than segfaulting if the user module is
>> selected but no handler has been registered. This should really halt
>> execution which it doesn't at the moment but I'll raise that separately.
>>
>
> I'd say
working on a couple of PEAR packages, pear/Validate_UK and pear/HTML_AJAX.
Pierre (cvs user: pajoye) will sort out the karma
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
"Stefan Esser" <[EMAIL PROTECTED]> wrote:
> sesserWed Mar 22 08:21:01 2006 UTC
>
> Modified files:
> /php-src README.UPDATING_TO_PHP6
> Log:
> Fix the bullshit register_globals emulation
>
> 1) S is not _SESSION but _SERVER
> 2) EXTR_OVERWRITE is e
If you set post_max_size to 0, you can parse the post data yourself from
php://input. Combine that with the Content-Length value from
apache_request_headers() and you have everything you need for a progress
monitor.
I don't mean to detract from the hopefully soon-to-come support in the
core,
Unknown W. Brackets wrote:
Fair enough. I was under the (now obviously wrong) impression that
setting post_max_size to 0 wouldn't let me get to the post data.
Of course then $_POST isn't available, so if you want to handle normal
POST data in the same request it also has to be manually pars
Richard Quadling wrote:
But even with ...
always_populate_raw_post_dataOn
I get ...
Notice: Undefined variable: HTTP_RAW_POST_DATA (for
$HTTP_RAW_POST_DATA) and Notice: Undefined index: HTTP_RAW_POST_DATA
(for $_SERVER['HTTP_RAW_POST_DATA']).
Assuming you CAN get the length, it may be th
Actually it seems to be near Yerushalayim (Jerusalem?), Israel which
makes some sense given Zend's origins.
http://www.mapquest.com/maps/map.adp?searchtype=address&formtype=address&latlongtype=decimal&latitude=31.7667&longitude=35.2333
Arpad
Derick Rethans wrote:
On Thu, 12 Oct 2006, Richard Q
appreciate
any feedback, especially since this is my first patch :)
Thanks,
Arpad Ray
Index: ext/standard/array.c
===
RCS file: /repository/php-src/ext/standard/array.c,v
retrieving revision 1.308.2.10
diff -u -u -b -B -r1.308.2.
For the assign-if-not-set operator, I like the idea of:
$foo ?= 'bar';
? implies a condition, and the = immediately following will raise a parse
error in older versions.
There's admittedly potential for confusion with the ternary operator, but
since that's most commonly used for conditional as
Sebastian wrote:
> But what about the use of ? as an infix operator? that wouldn't work
> out so well because of the ternary ?:
>
Right, which is why I didn't suggest that.
I think Greg's idea of first-existing: is an interesting one (and by the sound
of it the most robust).
Personally I'd like
Bob Silva wrote:
> This makes perfect sense (to me at least):
>
> $localvar = isset($_REQUEST['globalvar'], "default value 1", ...);
>
The obvious problem there being that isset() currently takes multiple
variables as arguments and checks that they're all set. From the manual:
bool isset ( mixed
65 matches
Mail list logo
