Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Yasuo Ohgaki
Hi Stats, 2012/1/20 Stas Malyshev : > I'd propose to make a binary-compatible change for 5.3 and 5.4.1, and > discuss what we do for trunk - I still like the idea of keeping less > handlers better, and if that means we can have the same patch for all > branches, then it's an added bonus. Ok, then

Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Stas Malyshev
Hi! We can make new session ID in PS_OPEN_FUNC() or PS_READ_FUNC() always when ID is not already initialized one, by calling private validation function from PS_OPEN_FUNC() or PS_READ_FUNC(). However, I think it's more cleaner to keep PS module's modular architecture. Current session module's c

Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Yasuo Ohgaki
Hi Stats, 2012/1/20 Stas Malyshev : > Hi! > > >> Hi Stats, >> >> Ok, I'll hold committing to 5.4, but commit it only to trunk. >> >> Any comments form anyone? for committing to trunk? >> Patch details and user land counter measure are in RFC. > > > Re-reading the discussion, I see that the questi

Re: [PHP-DEV] Code freeze for 5.4

2012-01-19 Thread Stas Malyshev
Hi! Hi Stats, Ok, I'll hold committing to 5.4, but commit it only to trunk. Any comments form anyone? for committing to trunk? Patch details and user land counter measure are in RFC. Re-reading the discussion, I see that the question of why we need separate validator handler is still unreso

Re: [PHP-DEV] Code freeze for 5.4

2012-01-19 Thread Yasuo Ohgaki
Hi Stats, Ok, I'll hold committing to 5.4, but commit it only to trunk. Any comments form anyone? for committing to trunk? Patch details and user land counter measure are in RFC. https://wiki.php.net/rfc/strict_sessions BTW, if we hold this patch, I think we should write patch that does not tou

Re: [PHP-DEV] Code freeze for 5.4

2012-01-19 Thread Pierrick Charron
I added a patch to bug #60809. If it's ok I can commit it. Pierrick On 19 January 2012 20:55, Stas Malyshev wrote: > Hi! > > >> I would like to commit session adaption patch to 5.4, since it >> does not change current session module behavior by default >> and affected application can be protecte

Re: [PHP-DEV] Code freeze for 5.4

2012-01-19 Thread Stas Malyshev
Hi! I would like to commit session adaption patch to 5.4, since it does not change current session module behavior by default and affected application can be protected by changing php.ini setting. As you already know, it requires structure changes and it would be binary incompatible if add it l

Re: [PHP-DEV] Code freeze for 5.4

2012-01-19 Thread Yasuo Ohgaki
Hi Stats, I would like to commit session adaption patch to 5.4, since it does not change current session module behavior by default and affected application can be protected by changing php.ini setting. As you already know, it requires structure changes and it would be binary incompatible if add

Re: [PHP-DEV] Code freeze for 5.4

2012-01-09 Thread Pierre Joye
hi Marius, You can do it yourself :-) Cheers, On Tue, Jan 10, 2012 at 7:50 AM, marius adrian popa wrote: > On Sun, Jan 8, 2012 at 12:40 AM, Stas Malyshev wrote: >> Hi! >> >> As we are nearing the release of 5.4.0, I'd like to ask everybody not to >> commit anything to 5.4 branch without the ap

Re: [PHP-DEV] Code freeze for 5.4

2012-01-09 Thread marius adrian popa
On Sun, Jan 8, 2012 at 12:40 AM, Stas Malyshev wrote: > Hi! > > As we are nearing the release of 5.4.0, I'd like to ask everybody not to > commit anything to 5.4 branch without the approval of one of the RMs (myself > or David) from now until release of 5.4.0. Unless something critical for > 5.4.0

Re: [PHP-DEV] Code freeze for 5.4

2012-01-08 Thread Pierre Joye
ah right, thanks Patrick :) On Sun, Jan 8, 2012 at 1:41 PM, Sebastian Bergmann wrote: > Am 08.01.2012 13:37, schrieb Pierre Joye: >> As far as I know, the only BC so far is the request time float >> addition to restore the previous behavior. I will do it this afternoon >> if nobody catches up wit

Re: [PHP-DEV] Code freeze for 5.4

2012-01-08 Thread Sebastian Bergmann
Am 08.01.2012 13:37, schrieb Pierre Joye: > As far as I know, the only BC so far is the request time float > addition to restore the previous behavior. I will do it this afternoon > if nobody catches up with it before :) That was already restored (in r321828). -- Sebastian Bergmann

Re: [PHP-DEV] Code freeze for 5.4

2012-01-08 Thread Pierre Joye
hi David, Stas, As far as I know, the only BC so far is the request time float addition to restore the previous behavior. I will do it this afternoon if nobody catches up with it before :) Cheers, On Sat, Jan 7, 2012 at 11:40 PM, Stas Malyshev wrote: > Hi! > > As we are nearing the release of 5

[PHP-DEV] Code freeze for 5.4

2012-01-07 Thread Stas Malyshev
Hi! As we are nearing the release of 5.4.0, I'd like to ask everybody not to commit anything to 5.4 branch without the approval of one of the RMs (myself or David) from now until release of 5.4.0. Unless something critical for 5.4.0 is found, we'd like RC6 (planned on Jan 19) to be the final