[GitHub] ivankelly closed pull request #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly closed pull request #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sijie closed issue #211: Support listing logs by prefix

2017-10-18 Thread GitBox
sijie closed issue #211: Support listing logs by prefix URL: https://github.com/apache/distributedlog/issues/211 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145556774 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557168 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r14855 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557540 ## File path: bookkeeper-server/src/main/proto/DataFormats.proto ## @@ -58,6 +58,15 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557421 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145556916 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] asfgit commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
asfgit commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337739488 Refer to this link for build results (access rights to CI server needed):

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145548754 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145502271 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145542490 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145501999 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145540992 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145500487 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145551983 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145502370 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145542430 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145499216 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145499417 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145501811 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145549021 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145495100 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145494666 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145492698 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145493594 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145493659 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145543784 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145551162 ## File path:

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538441 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337733438 There is a later change with tests, but it depends on a bunch of other things in between. @eolivelli

[GitHub] ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337733438 There is a later change with tests, but it depends on a bunch of other things in between.

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145537353 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -1343,17

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145536889 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -84,15 +85,32

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145534484 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java ## @@ -293,7 +294,9 @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145537764 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java ## @@ -198,21

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538292 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r14559 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/SyncSupported.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145535636 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@ -32,6

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145544977 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145543045 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] eolivelli commented on issue #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview

2017-10-18 Thread GitBox
eolivelli commented on issue #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview URL: https://github.com/apache/bookkeeper/pull/531#issuecomment-337721735 Closing. Superseded by new set of patches This is

[GitHub] ivankelly closed pull request #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
ivankelly closed pull request #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r14556 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ## @@

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145531204 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@ message

[GitHub] ivankelly commented on issue #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
ivankelly commented on issue #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644#issuecomment-337717529 Test failures are flakes. This is an automated message from the Apache Git

[GitHub] sijie closed issue #200: Meet java.lang.CloneNotSupportedException in TestDistributedLogConfiguration

2017-10-18 Thread GitBox
sijie closed issue #200: Meet java.lang.CloneNotSupportedException in TestDistributedLogConfiguration URL: https://github.com/apache/distributedlog/issues/200 This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #200: Meet java.lang.CloneNotSupportedException in TestDistributedLogConfiguration

2017-10-18 Thread GitBox
sijie commented on issue #200: Meet java.lang.CloneNotSupportedException in TestDistributedLogConfiguration URL: https://github.com/apache/distributedlog/issues/200#issuecomment-337713337 @jiazhai I think #199 already fixed this issue. closed this as 'won't fix'

[GitHub] sijie closed issue #207: Support GetFirstLogRecord

2017-10-18 Thread GitBox
sijie closed issue #207: Support GetFirstLogRecord URL: https://github.com/apache/distributedlog/issues/207 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie closed pull request #206: Issue 205: Avoid copying bytebuf for constructing log record to write

2017-10-18 Thread GitBox
sijie closed pull request #206: Issue 205: Avoid copying bytebuf for constructing log record to write URL: https://github.com/apache/distributedlog/pull/206 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed pull request #204: Issue 201: Fix the flaky test TestBKDistributedLogManager.deleteDuringRead

2017-10-18 Thread GitBox
sijie closed pull request #204: Issue 201: Fix the flaky test TestBKDistributedLogManager.deleteDuringRead URL: https://github.com/apache/distributedlog/pull/204 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] sijie closed issue #173: Namespace should implement AutoCloseable

2017-10-18 Thread GitBox
sijie closed issue #173: Namespace should implement AutoCloseable URL: https://github.com/apache/distributedlog/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #173: Namespace should implement AutoCloseable

2017-10-18 Thread GitBox
sijie commented on issue #173: Namespace should implement AutoCloseable URL: https://github.com/apache/distributedlog/issues/173#issuecomment-337699329 This is fixed at #215 (by @ArvinDevel ) This is an automated message from

[GitHub] sijie closed pull request #214: Issue173: Implement AutoCloseable in BKDistributedLogNamespace

2017-10-18 Thread GitBox
sijie closed pull request #214: Issue173: Implement AutoCloseable in BKDistributedLogNamespace URL: https://github.com/apache/distributedlog/pull/214 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed pull request #215: Issue 213: Correct logger name in BKLogWriteHandler

2017-10-18 Thread GitBox
sijie closed pull request #215: Issue 213: Correct logger name in BKLogWriteHandler URL: https://github.com/apache/distributedlog/pull/215 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] asfgit commented on issue #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
asfgit commented on issue #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644#issuecomment-337698613 Refer to this link for build results (access rights to CI server needed):

[GitHub] sijie closed issue #213: BKLogWriteHandler use wrong log name

2017-10-18 Thread GitBox
sijie closed issue #213: BKLogWriteHandler use wrong log name URL: https://github.com/apache/distributedlog/issues/213 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337656565 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
asfgit commented on issue #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#issuecomment-337638751 Refer to this link for build results (access rights to CI server needed):

[GitHub] eolivelli closed issue #530: BP-14 Relax Durability - protocol changes preview

2017-10-18 Thread GitBox
eolivelli closed issue #530: BP-14 Relax Durability - protocol changes preview URL: https://github.com/apache/bookkeeper/issues/530 This is an automated message from the Apache Git Service. To respond to the message, please

Build failed in Jenkins: bookkeeper-master #1921

2017-10-18 Thread Apache Jenkins Server
See Changes: [eolivelli] ISSUE #559: Fix findbugs error on SyncCallbackUtils [eolivelli] Fix for BookKeeperBuildersTest [eolivelli] Recycle buffers used in EntryLogger#addEntry [eolivelli] Use ByteBuf for

[GitHub] eolivelli closed issue #591: Clean up Public Client Bootstrap API

2017-10-18 Thread GitBox
eolivelli closed issue #591: Clean up Public Client Bootstrap API URL: https://github.com/apache/bookkeeper/issues/591 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] eolivelli commented on issue #591: Clean up Public Client Bootstrap API

2017-10-18 Thread GitBox
eolivelli commented on issue #591: Clean up Public Client Bootstrap API URL: https://github.com/apache/bookkeeper/issues/591#issuecomment-337569978 Resolved with bp15 This is an automated message from the Apache Git Service.

Jenkins build is still unstable: distributedlog-release-nightly-snapshot #56

2017-10-18 Thread Apache Jenkins Server
See