Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221419564
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55 @@
+/*
--- E
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221420261
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55 @@
+/*
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2779
@chenliang613 I think it is not possible to add lazy variable without
breaking spark 2.2 integration. Since this class is small, I think it is ok to
have a separate one for spark 2.3 integration
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2779
I think it is not possible to add lazy variable without breaking spark 2.2
integration. Since this class is small, I think it is ok to have a separate one
for spark 2.3 integration
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2781
LGTM
I think this PR is OK. @ravipesala please check again
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2778
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/844/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2778
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8912/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2786
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/650/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2738
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/652/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/651/
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2779
@sujith71955 any suggestion for this?
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2791
[HOTFIX]correct the exception handling in lookup relation
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any inte
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r221423350
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -90,6 +91,33 @@ public T readNextRow() throws IOException,
In
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2786
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/845/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8914/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2786
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8913/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2791
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/653/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2738
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/654/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/846/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2738
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8917/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2738
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/849/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2791
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/848/
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2780
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2791
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8916/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/655/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8918/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2780
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/850/
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221444503
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55 @@
+/*
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM
---
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2782#discussion_r221444696
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
---
@@ -2327,7 +2371,7 @@ class TestStreamin
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM Even though SPARK-PR#21815 changes is a workaround solution and in
future its subjected to change. Need a caution here. Can you please add this
PR reference in the modified code of th
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221445524
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55 @@
+/*
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2792
[CARBONDATA-2981] Support read primitive data type in CSDK
[CARBONDATA-2981] Support read primitive data type in CSDK
1.support readNextCarbonRow
2.support rea
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221446374
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -296,7 +296,7 @@ object CarbonReflectionUtils
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221446372
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55 @@
+/*
+ * L
[
https://issues.apache.org/jira/browse/CARBONDATA-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633208#comment-16633208
]
jiangmanhua commented on CARBONDATA-2928:
-
Hi, the error message said it can
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/657/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2779
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/656/
---
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221447092
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -18,6 +18,7 @@ package or
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2791
@akashrn5 It will be very helpful if you can provide proper descriptions
for the PR.
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2786
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2786#discussion_r221447268
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala
---
@@ -80,6 +82,20 @@ case class CarbonDatasour
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221447314
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -157,7 +158,13 @@ class I
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8919/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2786
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/658/
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221448493
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -18,6 +18,7 @@ package org.a
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221448520
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -157,7 +158,13 @@ class InMe
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2793
[CARBONDATA-2990] Fixed JVM crash when rebuilding bloom datamap.
Problem: while rebuilding the datamap it access the datamap store so it
builds datamap and store in unsafe onheap storage. Bu
Ravindra Pesala created CARBONDATA-2990:
---
Summary: JVM crashes when rebuilding the datamap.
Key: CARBONDATA-2990
URL: https://issues.apache.org/jira/browse/CARBONDATA-2990
Project: CarbonData
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2779
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/852/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2779
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8920/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/851/
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221448768
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -18,6 +18,7 @@ package or
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2793
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/659/
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221449001
--- Diff:
integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
---
@@ -157,7 +158,13 @@ class I
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221449108
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -208,7 +209,10 @@ class CarbonFileMetastore
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2778
LGTM
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2778
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2779
the failed test case is not related to this pr, right?
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r221449294
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -208,7 +209,10 @@ class CarbonFileMetastore
[
https://issues.apache.org/jira/browse/CARBONDATA-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manish Gupta resolved CARBONDATA-2980.
--
Resolution: Fixed
Fix Version/s: 1.5.0
> clear bloomindex cache when droppi
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
I think better to re-trigger once
---
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
retest this please
---
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2779
Seems to be impact of this PR , please recheck once
---
67 matches
Mail list logo