[jira] [Comment Edited] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

2019-09-26 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939125#comment-16939125 ] Peter Verhas edited comment on LANG-1491 at 9/27/19 5:02 AM: - Here you are.

[jira] [Commented] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

2019-09-26 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939125#comment-16939125 ] Peter Verhas commented on LANG-1491: Here you are. Welcome. > Unit tests visibility is non-conforming

[GitHub] [commons-lang] verhas opened a new pull request #461: Lang 1491

2019-09-26 Thread GitBox
verhas opened a new pull request #461: Lang 1491 URL: https://github.com/apache/commons-lang/pull/461 Removing all public modifiers that are not needed anymore when we are using JUnit 5 and not JUnit 4. This is an automated

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319313 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535749533 > > > Please merge it instead of nitpicking. > > > That's not the best attitude IMO. > > I said

[jira] [Commented] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

2019-09-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939063#comment-16939063 ] Gary D. Gregory commented on LANG-1491: --- Hi [~pe...@verhas.com], PRs are welcome on GitHub. Gary

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319311 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319310 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] verhas commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
verhas commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535748891 >>Please merge it instead of nitpicking. >That's not the best attitude IMO. I said please. Btw: I

[GitHub] [commons-lang] garydgregory edited a comment on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
garydgregory edited a comment on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535747664 > Please merge it instead of nitpicking. That's not the best attitude IMO. If you

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319308=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319308 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535747664 > Please merge it instead of nitpicking. That's not the best attitude IMO.

[jira] [Updated] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

2019-09-26 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Verhas updated LANG-1491: --- Description: The used JUnit 5 library does not require that the unit test classes and methods be

[jira] [Created] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

2019-09-26 Thread Peter Verhas (Jira)
Peter Verhas created LANG-1491: -- Summary: Unit tests visibility is non-conforming with JUnit 5 Key: LANG-1491 URL: https://issues.apache.org/jira/browse/LANG-1491 Project: Commons Lang Issue

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319303 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r328881438 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ##

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319302 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r328881438 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ##

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319300 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r328881421 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ##

[GitHub] [commons-imaging] kinow commented on issue #49: Add support for EXIF 2.32

2019-09-26 Thread GitBox
kinow commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-535682893 Hi @GITNE >I have added terminal newlines where applicable but Travis CI still fails for some unrelated reason. You have to rebase your

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319195=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319195 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535668589 Because all other tests are public. IOW, consistency.

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

2019-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319139 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

2019-09-26 Thread GitBox
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r328774255 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ##

[GitHub] [commons-csv] garydgregory commented on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames

2019-09-26 Thread GitBox
garydgregory commented on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames URL: https://github.com/apache/commons-csv/pull/43#issuecomment-535624098 @macsharker6 I think a week or maybe two. I have two other releases to do first.

[GitHub] [commons-cli] garydgregory merged pull request #31: Switch from Oracle JDK 8 to Open JDK 8

2019-09-26 Thread GitBox
garydgregory merged pull request #31: Switch from Oracle JDK 8 to Open JDK 8 URL: https://github.com/apache/commons-cli/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (RNG-119) Add LongJumpable support to XorShiRo generators

2019-09-26 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved RNG-119. -- Fix Version/s: 1.3 Resolution: Implemented In git master. > Add LongJumpable support to XorShiRo

[GitHub] [commons-rng] asfgit merged pull request #69: RNG-119: Add LongJumpable support to XoShiRo generators.

2019-09-26 Thread GitBox
asfgit merged pull request #69: RNG-119: Add LongJumpable support to XoShiRo generators. URL: https://github.com/apache/commons-rng/pull/69 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-rng] coveralls commented on issue #69: RNG-119: Add LongJumpable support to XoShiRo generators.

2019-09-26 Thread GitBox
coveralls commented on issue #69: RNG-119: Add LongJumpable support to XoShiRo generators. URL: https://github.com/apache/commons-rng/pull/69#issuecomment-535596703 [![Coverage Status](https://coveralls.io/builds/25953368/badge)](https://coveralls.io/builds/25953368) Coverage

[jira] [Commented] (NET-642) using execPROT on FTPSClients with Proxy Settings removes Proxy Settings

2019-09-26 Thread Danish Kamaal (Jira)
[ https://issues.apache.org/jira/browse/NET-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938804#comment-16938804 ] Danish Kamaal commented on NET-642: --- I am writing a fix for this. This issue has been open for too long

[jira] [Resolved] (RNG-117) RandomSource to support creating byte[] seed for implementing class.

2019-09-26 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved RNG-117. -- Fix Version/s: 1.3 Resolution: Implemented In git master. > RandomSource to support creating

[GitHub] [commons-imaging] GITNE commented on issue #49: Add support for EXIF 2.32

2019-09-26 Thread GitBox
GITNE commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-535581417 I have added terminal newlines where applicable but Travis CI still fails for some unrelated reason. Btw, personally I consider tools which require

[GitHub] [commons-rng] asfgit merged pull request #70: Changed samplers parametric test failure probability.

2019-09-26 Thread GitBox
asfgit merged pull request #70: Changed samplers parametric test failure probability. URL: https://github.com/apache/commons-rng/pull/70 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [commons-rng] aherbert opened a new pull request #70: Changed samplers parametric test failure probability.

2019-09-26 Thread GitBox
aherbert opened a new pull request #70: Changed samplers parametric test failure probability. URL: https://github.com/apache/commons-rng/pull/70 Only 1 re-run is allowed and the number of samplers is high enough that spurious failures are realistic for the samplers. Changed the

[GitHub] [commons-rng] aherbert opened a new pull request #69: RNG-119: Add LongJumpable support to XoShiRo generators.

2019-09-26 Thread GitBox
aherbert opened a new pull request #69: RNG-119: Add LongJumpable support to XoShiRo generators. URL: https://github.com/apache/commons-rng/pull/69 This adds the long jump function to those generators previously supporting only a jump function.

[jira] [Created] (RNG-119) Add LongJumpable support to XorShiRo generators

2019-09-26 Thread Alex Herbert (Jira)
Alex Herbert created RNG-119: Summary: Add LongJumpable support to XorShiRo generators Key: RNG-119 URL: https://issues.apache.org/jira/browse/RNG-119 Project: Commons RNG Issue Type: New

[GitHub] [commons-cli] mincong-h opened a new pull request #31: Switch from Oracle JDK 8 to Open JDK 8

2019-09-26 Thread GitBox
mincong-h opened a new pull request #31: Switch from Oracle JDK 8 to Open JDK 8 URL: https://github.com/apache/commons-cli/pull/31 Fix broken build [589473088](https://travis-ci.org/apache/commons-cli/builds/589473088) (triggered by

[jira] [Commented] (GEOMETRY-30) VectorBuilder?D Classes

2019-09-26 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938701#comment-16938701 ] Gilles Sadowski commented on GEOMETRY-30: - In order to figure what is actually necessary,

[jira] [Created] (FILEUPLOAD-301) Problems uploading files greater than 100kb using HTTPS

2019-09-26 Thread Andrea (Jira)
Andrea created FILEUPLOAD-301: - Summary: Problems uploading files greater than 100kb using HTTPS Key: FILEUPLOAD-301 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-301 Project: Commons FileUpload

[GitHub] [commons-rng] asfgit merged pull request #68: RNG-117: RandomSource to support creating byte[] seed for implementing class.

2019-09-26 Thread GitBox
asfgit merged pull request #68: RNG-117: RandomSource to support creating byte[] seed for implementing class. URL: https://github.com/apache/commons-rng/pull/68 This is an automated message from the Apache Git Service. To

[jira] [Commented] (GEOMETRY-30) VectorBuilder?D Classes

2019-09-26 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938578#comment-16938578 ] Gilles Sadowski commented on GEOMETRY-30: - bq. avoid unnecessary vector creation. At some

[GitHub] [commons-geometry] asfgit closed pull request #39: GEOMETRY-46: Add additional UnitVector methods

2019-09-26 Thread GitBox
asfgit closed pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (RNG-118) XoRoShiRo PlusPlus generators

2019-09-26 Thread Alex Herbert (Jira)
Alex Herbert created RNG-118: Summary: XoRoShiRo PlusPlus generators Key: RNG-118 URL: https://issues.apache.org/jira/browse/RNG-118 Project: Commons RNG Issue Type: New Feature

[jira] [Created] (GEOMETRY-62) Fix "CheckStyle" errors

2019-09-26 Thread Gilles Sadowski (Jira)
Gilles Sadowski created GEOMETRY-62: --- Summary: Fix "CheckStyle" errors Key: GEOMETRY-62 URL: https://issues.apache.org/jira/browse/GEOMETRY-62 Project: Apache Commons Geometry Issue Type:

[jira] [Commented] (GEOMETRY-30) VectorBuilder?D Classes

2019-09-26 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938549#comment-16938549 ] Matt Juntunen commented on GEOMETRY-30: ---

[jira] [Commented] (GEOMETRY-54) Cleanup Checkstyle Reported issues

2019-09-26 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938542#comment-16938542 ] Matt Juntunen commented on GEOMETRY-54: --- Is there a pull request for this? It seems like we should

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-26 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938541#comment-16938541 ] Matt Juntunen commented on GEOMETRY-46: --- Sounds good to me! > Additional UnitVector methods >

[jira] [Created] (GEOMETRY-61) Provide "unit" vector concept

2019-09-26 Thread Gilles Sadowski (Jira)
Gilles Sadowski created GEOMETRY-61: --- Summary: Provide "unit" vector concept Key: GEOMETRY-61 URL: https://issues.apache.org/jira/browse/GEOMETRY-61 Project: Apache Commons Geometry Issue

[jira] [Created] (CODEC-263) Base64.decodeBase64 throw exception

2019-09-26 Thread xie tao (Jira)
xie tao created CODEC-263: - Summary: Base64.decodeBase64 throw exception Key: CODEC-263 URL: https://issues.apache.org/jira/browse/CODEC-263 Project: Commons Codec Issue Type: Bug Affects

[GitHub] [commons-lang] michael-o commented on issue #460: Lang-1465: Fix the ZZ time zone format

2019-09-26 Thread GitBox
michael-o commented on issue #460: Lang-1465: Fix the ZZ time zone format URL: https://github.com/apache/commons-lang/pull/460#issuecomment-535423035 The `Z` modifier here is not the same as within Java itself. Therefore, rejecting it. Moreover, your usecase is nonsense because the format

[GitHub] [commons-csv] macsharker6 edited a comment on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames

2019-09-26 Thread GitBox
macsharker6 edited a comment on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames URL: https://github.com/apache/commons-csv/pull/43#issuecomment-533182150 Hi @garydgregory, any update for the release 1.8? Thanks in advance. macsharker6

[jira] [Comment Edited] (COLLECTIONS-674) Add Collections Drain Method

2019-09-26 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938352#comment-16938352 ] Chen edited comment on COLLECTIONS-674 at 9/26/19 7:06 AM: --- {code:java}

[jira] [Commented] (COLLECTIONS-674) Add Collections Drain Method

2019-09-26 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938352#comment-16938352 ] Chen commented on COLLECTIONS-674: -- {code:java} public static Collection drain(Collection input,