[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761566=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761566
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
kinow commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1108008975
Also created a follow-up issue,
https://issues.apache.org/jira/browse/COLLECTIONS-811, to consider adding
Guava's testlib or similar solution to our tests/CI.
--
This is an
Bruno P. Kinoshita created COLLECTIONS-811:
--
Summary: Consider integration Guava testlib tests
Key: COLLECTIONS-811
URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
Project: Commons
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761563=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761563
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
kinow commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1108007330
Thanks @ben-manes, much easier now to run the tests and compare the results
with your updated test.
For `master`:
```bash
[ERROR] Failures:
[ERROR]
[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527276#comment-17527276
]
Matt Juntunen commented on GEOMETRY-144:
Having thought on this some more, I believe the best
[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527270#comment-17527270
]
Matt Juntunen commented on GEOMETRY-144:
{quote}Could different algorithms have their
[
https://issues.apache.org/jira/browse/GEOMETRY-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527268#comment-17527268
]
Matt Juntunen commented on GEOMETRY-146:
{{neighborEntriesFullBaseline}} was a baseline
dependabot[bot] opened a new pull request, #52:
URL: https://github.com/apache/commons-scxml/pull/52
Bumps [nashorn-core](https://github.com/openjdk/nashorn) from 15.3 to 15.4.
Changelog
Sourced from https://github.com/openjdk/nashorn/blob/main/CHANGELOG.md;>nashorn-core's
dependabot[bot] opened a new pull request, #51:
URL: https://github.com/apache/commons-scxml/pull/51
Bumps [maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin)
from 3.0.0 to 3.1.0.
Commits
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated COLLECTIONS-802:
--
Attachment: ApacheMapTest-1.java
> ReferenceMap iterator remove violates contract
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761531=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761531
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
ben-manes commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107935459
Checking and I accidentally attached the wrong version of `ApacheMapTest`.
The flag `allowNulls` should have been false for `ReferenceMap`, and was
there just
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761530=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761530
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
kinow commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107932772
> oops. I must have forgotten, not realized, or master has new failures. I
very much like Guava’s collection tests as reusable and catch these minor
mistakes. I’d recommend
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761529=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761529
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
ben-manes commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107932533
oops. I must have forgotten, not realized, or master has new failures. I
very much like Guava’s collection tests as reusable and catch these minor
mistakes. I’d recommend
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761526=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761526
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
kinow commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107931652
Ah, I think I may have spoken too fast. I executed the `ApacheMapTest`
against `master`, and got this:
```
[ERROR] Tests run: 25662, Failures: 8, Errors: 139, Skipped:
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527256#comment-17527256
]
Bruno P. Kinoshita edited comment on COLLECTIONS-802 at 4/24/22 10:28 PM:
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527256#comment-17527256
]
Bruno P. Kinoshita commented on COLLECTIONS-802:
ApacheMapTest failed for me. Left a
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761525=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761525
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
kinow commented on code in PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#discussion_r857185327
##
src/test/java/org/apache/commons/collections4/map/ReferenceMapTest.java:
##
@@ -315,6 +316,24 @@ public void testDataSizeAfterSerialization() throws
[
https://issues.apache.org/jira/browse/GEOMETRY-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527251#comment-17527251
]
Gilles Sadowski commented on GEOMETRY-146:
--
I don't understand
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761522
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
codecov-commenter commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107921839
#
[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527250#comment-17527250
]
Gilles Sadowski commented on GEOMETRY-144:
--
Could different algorithms have their respective
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527209#comment-17527209
]
Ben Manes commented on COLLECTIONS-802:
---
Thanks! Can you run {{ApacheMapTest}} locally then to
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527207#comment-17527207
]
Ng Tsz Sum commented on COLLECTIONS-802:
I raised a PR
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761470=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761470
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF
samabcde opened a new pull request, #300:
URL: https://github.com/apache/commons-collections/pull/300
…y and currentValue.
- The problem occur when the iterator called `hasNext` and return false,
which set null to `currentKey`. Hence `remove` method calling
garydgregory commented on PR #92:
URL: https://github.com/apache/commons-jcs/pull/92#issuecomment-1107824750
@CAIWan1998
You made the same PR in Commons IO where it was turned down. My comment is
the same here.
--
This is an automated message from the Apache Git Service.
To respond
32 matches
Mail list logo
