[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434988#comment-13434988
]
Luc Maisonobe commented on MATH-811:
Patch welcome ...
> Improve event
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461819#comment-13461819
]
Yannick TANGUY commented on MATH-811:
-
Ok, here is a patch and a simple unitary test (in
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462488#comment-13462488
]
Dennis Hendriks commented on MATH-811:
--
bq. Ok, here is a patch [...]
It seems you use
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462511#comment-13462511
]
Yannick TANGUY commented on MATH-811:
-
Ok, sorry for the tabs. Here is a new patch with
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462529#comment-13462529
]
Dennis Hendriks commented on MATH-811:
--
bq. Ok, sorry for the tabs. Here is a new patch
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462530#comment-13462530
]
Thomas Neidhart commented on MATH-811:
--
Hi Yannick,
I had the same problem when creati
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462565#comment-13462565
]
Yannick TANGUY commented on MATH-811:
-
Hi Thomas and Dennis,
Ok, I'll redo the patch. B
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462662#comment-13462662
]
Gilles commented on MATH-811:
-
bq. We added a "int getSlopeSelection()"
Instead of an "int", an
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462667#comment-13462667
]
Yannick TANGUY commented on MATH-811:
-
First I wanted to use enum, but it was simple to
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462698#comment-13462698
]
Gilles commented on MATH-811:
-
IMHO, that code is no correct (even if it behaves correctly): boo
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462778#comment-13462778
]
Yannick TANGUY commented on MATH-811:
-
Ok Gilles, I agree with you about the truth table
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463644#comment-13463644
]
Gilles commented on MATH-811:
-
bq. I think an enum with three choices (increasing, decreasing, b
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463668#comment-13463668
]
Dennis Hendriks commented on MATH-811:
--
bq. public enum SlopeDirectionSelector {
Maybe
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463689#comment-13463689
]
Gilles commented on MATH-811:
-
bq. as the enumeration itself does not select anything (it is not
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463732#comment-13463732
]
Yannick TANGUY commented on MATH-811:
-
I like the idea of "SlopeDirectionSelector" with
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464686#comment-13464686
]
Yannick TANGUY commented on MATH-811:
-
Here is a new version of the patch (JIRA-811_slop
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464711#comment-13464711
]
Luc Maisonobe commented on MATH-811:
The fact we use g0positive and not g(ta) is intenti
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464732#comment-13464732
]
Yannick TANGUY commented on MATH-811:
-
Hello Luc,
Ok, but could you explain a little bi
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464765#comment-13464765
]
Luc Maisonobe commented on MATH-811:
This is exactly the point.
The code snippet you sh
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464817#comment-13464817
]
Yannick TANGUY commented on MATH-811:
-
Ok, thanks for the explanation. I put back that f
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464834#comment-13464834
]
Luc Maisonobe commented on MATH-811:
When the bug was fixed, yes there was a test dedica
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465448#comment-13465448
]
Yannick TANGUY commented on MATH-811:
-
Here's the new patch (V3) !
> I
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465614#comment-13465614
]
Dennis Hendriks commented on MATH-811:
--
bq. Here's the new patch (V3) !
This one has a
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465672#comment-13465672
]
Yannick TANGUY commented on MATH-811:
-
-> Ok, the EventState class is ok now and I've ch
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466482#comment-13466482
]
Luc Maisonobe commented on MATH-811:
I looked at the patch.
It seems to work, but I am
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467797#comment-13467797
]
Yannick TANGUY commented on MATH-811:
-
Ok, I notice that it won't be commited in 3.1.
A
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467880#comment-13467880
]
Luc Maisonobe commented on MATH-811:
I'll have a more thorough look into it when I have
[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468379#comment-13468379
]
Yannick TANGUY commented on MATH-811:
-
Your idea seems interesting, but I think it depen
28 matches
Mail list logo
