Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37141049
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698510#comment-14698510
]
ASF GitHub Bot commented on FLINK-2477:
---
Github user HuangWHWHW commented on the
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-131473233
Ok, I`ve done it.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131474758
Hi @chiwanpark, thanks for reviewing this. This was my first time working
in Scala, so I hope you'll forgive the slight mistakes (oversights, perhaps?).
I've
Sachin Goel created FLINK-2528:
--
Summary: MatchTaskTest failure
Key: FLINK-2528
URL: https://issues.apache.org/jira/browse/FLINK-2528
Project: Flink
Issue Type: Bug
Reporter: Sachin
Huang Wei created FLINK-2529:
Summary: fix on some unused code for flink-runtime
Key: FLINK-2529
URL: https://issues.apache.org/jira/browse/FLINK-2529
Project: Flink
Issue Type: Improvement
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37141028
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37141076
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,108 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1003#issuecomment-131477326
A stand-alone parameter server service will require setting up and tearing
down of the client every time the user, say, opens and closes a Rich function
while
[
https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698529#comment-14698529
]
ASF GitHub Bot commented on FLINK-2529:
---
GitHub user HuangWHWHW opened a pull
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/1022
[FLINK-2529][runtime]remove some unused code
There are some reviews:
1.var consumerGraph is never used in public Boolean call() throws Exception.
2.In my learned knowledge, function
GitHub user Rucongzhang opened a pull request:
https://github.com/apache/flink/pull/1021
[FLINK-2478]fix the array may have out of bounds
In getNestedDelta function, the array length of oldDatapoint and the array
length of newDatapoint are notbeen ensured same.So add the
[
https://issues.apache.org/jira/browse/FLINK-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698207#comment-14698207
]
ASF GitHub Bot commented on FLINK-2478:
---
GitHub user Rucongzhang opened a pull
Gabor Gevay created FLINK-2527:
--
Summary: If a VertexUpdateFunction calls setNewVertexValue more
than once, the MessagingFunction will only see the first value set
Key: FLINK-2527
URL:
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698160#comment-14698160
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user zentol commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698179#comment-14698179
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin commented on the pull
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131314931
@zentol Hello! Thank you for your suggestion.I have add exception message
in log.
---
If your project is set up for it, you can reply to this email and have your
reply
fangfengbin created FLINK-2526:
--
Summary: Add catch{} for task when it stop running
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
GitHub user chenliang613 opened a pull request:
https://github.com/apache/flink/pull/1019
Some updates for programming_guide.md
Some updates for the section Program Skeleton of programming_guide.md
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1020
[FLINK-2526]Add try-catch for task when it stop running
inputProcessor cleanup() may throw IOException.If do not catch it, the next
line outputHandler .flushOutputs() will not work and cause output
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698153#comment-14698153
]
ASF GitHub Bot commented on FLINK-2526:
---
GitHub user ffbin opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698362#comment-14698362
]
Stephan Ewen commented on FLINK-2334:
-
Is this problem actually reproducible, or was
[
https://issues.apache.org/jira/browse/FLINK-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698363#comment-14698363
]
ASF GitHub Bot commented on FLINK-2478:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1021#issuecomment-131402990
If the two arrays are of different lengths, should this throw an exception?
After all, the cosine distance is not well defined then and returning 0 may
give the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131403119
Most of this is good, but in parts, it confuses the `DataSet` and
`DataStream` API. The `DataSet` API has no functionality to write to sockets.
---
If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/967#issuecomment-131403208
@nltran How would your use of the parameter server work together with what
is proposed in #1003 ?
---
If your project is set up for it, you can reply to this email
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1003#issuecomment-131403660
This is again baked into the Flink runtime. Is there a way to keep this
separate?
I am still a bit puzzled if this is the pattern with which people use
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137570
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
@@ -119,4 +120,30 @@ object MLUtils {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137605
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137592
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131405427
ok, update the sockets part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137631
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137647
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137658
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137718
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137756
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137749
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137752
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137762
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137774
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137811
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137819
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137821
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137856
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137866
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137965
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37138026
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/ContinuousHistogram.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-2512.
-
Resolution: Fixed
Fix Version/s: 0.10
Fixed via c2b1eb7961ed16b8985d7f8c02e87c0964b818e8
[
https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-2512.
---
Thank you for the contribution
Add client.close() before throw RuntimeException
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37138063
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,108 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37138093
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,108 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
[
https://issues.apache.org/jira/browse/FLINK-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698399#comment-14698399
]
Vasia Kalavri commented on FLINK-2527:
--
I think (3) would break the model semantics.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131425060
Hi @sachingoel0101, Thanks for your contribution. I reviewed this PR and
commented the source code.
There are some problems which aren't commented. In
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131390701
The pull request #1017 actually fixes this as well, together with a lot of
other things (similar problems are in many places).
Can you have a look at #1017
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698306#comment-14698306
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user StephanEwen commented on the
[
https://issues.apache.org/jira/browse/FLINK-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-2486.
-
Resolution: Won't Fix
Valid sanity check, won't fix.
Remove unwanted null check in
[
https://issues.apache.org/jira/browse/FLINK-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-2486.
---
Remove unwanted null check in removeInstance function
[
https://issues.apache.org/jira/browse/FLINK-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-2516.
-
Resolution: Won't Fix
As per discussion in the issue, this will not be changed.
Remove unwanted
[
https://issues.apache.org/jira/browse/FLINK-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-2516.
---
Remove unwanted log.isInfoEnabled check
---
Key:
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698413#comment-14698413
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1017#issuecomment-131431977
Fixed the issues with the tests. Builds locally, waiting for Travis to
confirm.
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/FLINK-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698423#comment-14698423
]
Gabor Gevay commented on FLINK-2527:
I'm also leaning towards (1) now. I have actually
63 matches
Mail list logo
