[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-10 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1981 [Flink-2971][table] Add outer joins to the Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279511#comment-15279511 ] ASF GitHub Bot commented on FLINK-3780: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-10 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1980 [FLINK-3780] [gelly] Jaccard Similarity The Jaccard Index measures the similarity between vertex neighborhoods. Scores range from 0.0 (no common neighbors) to 1.0 (all neighbors are common). You

[jira] [Updated] (FLINK-3897) why does jobmanager process has too many ForkJoinTask object

2016-05-10 Thread ZhengBowen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengBowen updated FLINK-3897: -- Description: jmap -histo 21415 |head -10 num #instances #bytes class name --

[jira] [Created] (FLINK-3897) why does jobmanager process has too many ForkJoinTask object

2016-05-10 Thread ZhengBowen (JIRA)
ZhengBowen created FLINK-3897: - Summary: why does jobmanager process has too many ForkJoinTask object Key: FLINK-3897 URL: https://issues.apache.org/jira/browse/FLINK-3897 Project: Flink Issue T

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-05-10 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279438#comment-15279438 ] Yijie Shen commented on FLINK-3891: --- I think it will be great to implement this, looking

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279400#comment-15279400 ] Tzu-Li (Gordon) Tai commented on FLINK-3852: Hi Mark, I think replacing the S

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279399#comment-15279399 ] Tzu-Li (Gordon) Tai commented on FLINK-3852: Hi Mark, I think replacing the S

[jira] [Issue Comment Deleted] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-3852: --- Comment: was deleted (was: Hi Mark, I think replacing the StreamingJob skeleton as th

[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar

2016-05-10 Thread scosenza
Github user scosenza commented on the pull request: https://github.com/apache/flink/pull/1972#issuecomment-218318387 Hi Robert, Typically, a test-jar would not contain JUnit test classes unless they are designed to be extended. On a related note, it's also good to avoid includ

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Mark Reddy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279155#comment-15279155 ] Mark Reddy commented on FLINK-3852: --- I can take this. One quick question after taking

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279033#comment-15279033 ] ASF GitHub Bot commented on FLINK-3758: --- Github user knaufk closed the pull request

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk reopened a pull request: https://github.com/apache/flink/pull/1979 [FLINK-3758] Add possibility to register accumulators in custom triggers Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consid

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279035#comment-15279035 ] ASF GitHub Bot commented on FLINK-3758: --- GitHub user knaufk reopened a pull request:

[GitHub] flink pull request: [Flink 3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1979 [Flink 3758] Add possibility to register accumulators in custom triggers 1 of 1 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[jira] [Closed] (FLINK-3882) Errors in sample Java code for the Elasticsearch 2.x sink

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3882. Resolution: Fixed Fix Version/s: 1.1.0 Fixed with 43bd6f6e4020d4102c34c5874ddfa850a281c8c8 >

[jira] [Commented] (FLINK-3821) Reduce Guava usage in flink-java

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278823#comment-15278823 ] ASF GitHub Bot commented on FLINK-3821: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-3821) Reduce Guava usage in flink-java

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3821. Resolution: Implemented Implemented with 15f52112af1e3cca86094b5c6c1ef31157e073df > Reduce Guava us

[jira] [Closed] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3842. Resolution: Fixed Fix Version/s: 1.1.0 Fixed with 08e80546e20a24bdf204dec485d3ade83cf7804c >

[jira] [Commented] (FLINK-3882) Errors in sample Java code for the Elasticsearch 2.x sink

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278822#comment-15278822 ] ASF GitHub Bot commented on FLINK-3882: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3821] Reduce Guava usage in flink-java

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1938 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278824#comment-15278824 ] ASF GitHub Bot commented on FLINK-3842: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3882][docs] Fix errors in sample Java c...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62745064 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/expression/ScalarFunctionsTest.scala --- @@ -215,7 +215,7 @@ class ScalarFunct

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278805#comment-15278805 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278792#comment-15278792 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on the pull re

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1958#issuecomment-218278581 Hi @fhueske, part of the comments are resolved and updated, two TODOs: - [ ] Type coercion for expressions, for example: - `Add(int, long)` should be auto co

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278778#comment-15278778 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62742492 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62742390 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278777#comment-15278777 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62731427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -92,8 +93,7 @@ abstract class StreamTable

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278682#comment-15278682 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278516#comment-15278516 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62715643 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278512#comment-15278512 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62715347 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -92,8 +93,7 @@ abstract class StreamTableE

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278505#comment-15278505 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62714636 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3667) Generalize client<->cluster communication

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278495#comment-15278495 ] ASF GitHub Bot commented on FLINK-3667: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request: [FLINK-3667] refactor client communication

2016-05-10 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1978 [FLINK-3667] refactor client communication This is mainly an effort to refactor the client side of the cluster instantiation and communication. This pull request moves around many things which were alr

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278482#comment-15278482 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62712828 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278470#comment-15278470 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3882][docs] Fix errors in sample Java c...

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1971#issuecomment-218223297 merging this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62711917 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1974#issuecomment-218223867 Yes, you are right @dawidwys. I'm usually batching several PRs and trigger another build just to be on the safe side ;-) --- If your project is set up for it, you

[jira] [Commented] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278466#comment-15278466 ] ASF GitHub Bot commented on FLINK-3842: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3882) Errors in sample Java code for the Elasticsearch 2.x sink

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278463#comment-15278463 ] ASF GitHub Bot commented on FLINK-3882: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1974#issuecomment-218221293 I think those failing tests are unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278448#comment-15278448 ] ASF GitHub Bot commented on FLINK-3842: --- Github user dawidwys commented on the pull

[GitHub] flink pull request: [FLINK-3821] Reduce Guava usage in flink-java

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1938#issuecomment-218220824 Thanks @zentol. Will merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (FLINK-3821) Reduce Guava usage in flink-java

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278445#comment-15278445 ] ASF GitHub Bot commented on FLINK-3821: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278437#comment-15278437 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62709108 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3768) Clustering Coefficient

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278427#comment-15278427 ] ASF GitHub Bot commented on FLINK-3768: --- Github user greghogan commented on a diff i

[jira] [Commented] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278430#comment-15278430 ] ASF GitHub Bot commented on FLINK-3842: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1974#issuecomment-218218785 Thanks @twalthr, the PR looks good. Will merge it after the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3768] [gelly] Clustering Coefficient

2016-05-10 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1896#discussion_r62708062 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/LocalClusteringCoefficient.java --- @@ -0,0 +1,125 @@ +/*

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62708060 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278426#comment-15278426 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278407#comment-15278407 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62705691 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3768) Clustering Coefficient

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278391#comment-15278391 ] ASF GitHub Bot commented on FLINK-3768: --- Github user hsaputra commented on a diff in

[GitHub] flink pull request: [FLINK-3768] [gelly] Clustering Coefficient

2016-05-10 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/1896#discussion_r62704246 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/LocalClusteringCoefficient.java --- @@ -0,0 +1,125 @@ +/*

[jira] [Commented] (FLINK-3856) Create types for java.sql.Date/Time/Timestamp

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278371#comment-15278371 ] ASF GitHub Bot commented on FLINK-3856: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278385#comment-15278385 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62703535 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala --- @@ -152,13 +160,13 @@ abstract class TableEnvironm

[jira] [Commented] (FLINK-3768) Clustering Coefficient

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278380#comment-15278380 ] ASF GitHub Bot commented on FLINK-3768: --- Github user hsaputra commented on the pull

[GitHub] flink pull request: [FLINK-3768] [gelly] Clustering Coefficient

2016-05-10 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1896#issuecomment-218210466 Please address my comments about adding Javadoc header info to ALL new Java class added to source repo. Thx! --- If your project is set up for it, you can reply to thi

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278377#comment-15278377 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in t

[jira] [Commented] (FLINK-3856) Create types for java.sql.Date/Time/Timestamp

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278378#comment-15278378 ] ASF GitHub Bot commented on FLINK-3856: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3856] [core] Create types for java.sql....

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1959#issuecomment-218210159 @twalthr, should `SqlTimeTypeInfo` implement `TypeInformation`? What do you think? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62703065 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala --- @@ -152,13 +160,13 @@ abstract class TableEnvironme

[GitHub] flink pull request: [FLINK-3856] [core] Create types for java.sql....

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1959#discussion_r62702515 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/SqlTimeTypeInfo.java --- @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (FLINK-3896) Allow a StreamTask to be Externally Cancelled.

2016-05-10 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-3896: -- Description: When implementing a custom operator, it may be useful to be able to cancel the tas

[jira] [Created] (FLINK-3896) Allow a StreamTask to be Externally Cancelled.

2016-05-10 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-3896: - Summary: Allow a StreamTask to be Externally Cancelled. Key: FLINK-3896 URL: https://issues.apache.org/jira/browse/FLINK-3896 Project: Flink Issue Type: Bu

[jira] [Commented] (FLINK-3768) Clustering Coefficient

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278278#comment-15278278 ] ASF GitHub Bot commented on FLINK-3768: --- Github user greghogan commented on the pull

[jira] [Updated] (FLINK-3895) Remove Docs for Program Packaging via Plans

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-3895: - Summary: Remove Docs for Program Packaging via Plans (was: Remove Focs for Program Packaging via

[GitHub] flink pull request: [FLINK-3768] [gelly] Clustering Coefficient

2016-05-10 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1896#issuecomment-218194878 I have rebased this PR against the newly committed dependent features so it should be good for discussion. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-3826) Broken test: StreamCheckpointingITCase

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278261#comment-15278261 ] ASF GitHub Bot commented on FLINK-3826: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-3826] Broken test: StreamCheckpointingI...

2016-05-10 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1977#issuecomment-218191358 @kl0u Could you stop posting a comment in every PR right after you opened it? You can add whatever you want to say to the main post. could we now remove the hasFa

[jira] [Commented] (FLINK-3893) LeaderChangeStateCleanupTest times out

2016-05-10 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278245#comment-15278245 ] Maximilian Michels commented on FLINK-3893: --- After fixing this, I get the follow

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278209#comment-15278209 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3895) Remove Focs for Program Packaging via Plans

2016-05-10 Thread Ken Krugler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278231#comment-15278231 ] Ken Krugler commented on FLINK-3895: Maybe "Remove Docs for Program..."? :) > Remove

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62685650 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/exceptions.scala --- @@ -0,0 +1,20 @@ +/* + * Licensed to th

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62680102 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala --- @@ -197,6 +209,17 @@ abstract class TableEnvironme

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278205#comment-15278205 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1958#issuecomment-218182019 Hi @yjshen, sorry for the time it took to review the PR. I like the approach and the PR looks good, IMO. I had a few minor comments and questions. Let me know what you t

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278214#comment-15278214 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278204#comment-15278204 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278212#comment-15278212 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278199#comment-15278199 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683790 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-3701) Cant call execute after first execution

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278197#comment-15278197 ] ASF GitHub Bot commented on FLINK-3701: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683921 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK-3701] reuse serializer lists in Executi...

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1913#discussion_r62683914 --- Diff: flink-core/src/main/java/org/apache/flink/util/SerializableCacheableValue.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278196#comment-15278196 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in

  1   2   >