[jira] [Closed] (FLINK-4278) Unclosed FSDataOutputStream in multiple files in the project

2016-09-05 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian closed FLINK-4278. -- Resolution: Not A Problem > Unclosed FSDataOutputStream in multiple files in the

[GitHub] flink issue #2425: FLINK-3930 Added shared secret based authorization for Fl...

2016-09-05 Thread vijikarthi
Github user vijikarthi commented on the issue: https://github.com/apache/flink/pull/2425 > T2-3 is not about the web interface netty, its about the data transfer netty In Flink, we are using netty for (at least) three things: - Akka is using Netty. This is addressed in t

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466600#comment-15466600 ] ASF GitHub Bot commented on FLINK-3930: --- Github user vijikarthi commented on the iss

[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...

2016-09-05 Thread liuyuzhong
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 Test Result (失败) ``` org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should detect a failing task manager org.apache.flink.api.scala.runtime.tas

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-09-05 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466242#comment-15466242 ] Josep Rubió commented on FLINK-1707: Hi [~vkalavri], I have updated the code if you w

[jira] [Updated] (FLINK-3801) Upgrade Joda-Time library to 2.9.3

2016-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-3801: -- Description: Currently yoda-time 2.5 is used which was very old. We should upgrade to 2.9.3 was: Currently y

[jira] [Updated] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2016-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4534: -- Description: Iteration over state.bucketStates is protected by synchronization in other methods, except for the

[jira] [Updated] (FLINK-4533) Unprotected access to meters in StatsDReporter#report()

2016-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4533: -- Description: Access to meters in AbstractReporter is protected by AbstractReporter.this. Access to meters in S

[jira] [Comment Edited] (FLINK-4482) numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock

2016-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459062#comment-15459062 ] Ted Yu edited comment on FLINK-4482 at 9/6/16 12:23 AM: [~StephanE

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465855#comment-15465855 ] ASF GitHub Bot commented on FLINK-3929: --- Github user vijikarthi commented on the iss

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-09-05 Thread vijikarthi
Github user vijikarthi commented on the issue: https://github.com/apache/flink/pull/2275 @mxm I believe the ZK timeout issue occurs from LocalFlinkMiniClusterITCase->testLocalFlinkMiniClusterWithMultipleTaskManagers test case but it is not consistent. I ran the Kafka test case alone a

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465491#comment-15465491 ] ASF GitHub Bot commented on FLINK-2055: --- Github user ramkrish86 commented on a diff

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547915 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46 @@

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465487#comment-15465487 ] ASF GitHub Bot commented on FLINK-2055: --- Github user ramkrish86 commented on a diff

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547840 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46 @@

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465479#comment-15465479 ] ASF GitHub Bot commented on FLINK-2055: --- Github user ramkrish86 commented on a diff

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547550 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java --- @@ -0,0 +1,69 @@

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465326#comment-15465326 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77540987 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java --- @@ -35,109 +46,111 @@ final Map taskM

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465303#comment-15465303 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77540202 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java --- @@ -35,109 +46,111 @@ final Map taskM

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465265#comment-15465265 ] ASF GitHub Bot commented on FLINK-4389: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77538038 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java --- @@ -35,109 +46,111 @@ final Map taskManager

[jira] [Resolved] (FLINK-4479) Replace trademark (tm) with registered trademark (R) sign on Flink website

2016-09-05 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-4479. --- Resolution: Fixed Resolved with https://github.com/apache/flink-web/commit/f2053d28b123905392

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-09-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2275 The Kafka tests fail: ``` Running org.apache.flink.streaming.connectors.kafka.Kafka09SecureRunITCase org.I0Itec.zkclient.exception.ZkTimeoutException: Unable to connect to zookeeper serve

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465144#comment-15465144 ] ASF GitHub Bot commented on FLINK-3929: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465132#comment-15465132 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2363 I think the changes look good. Thanks for your work @zentol :-) I only had a minor question whether we can substitute the explicit category information by the type information of the metric dump

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465125#comment-15465125 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[jira] [Resolved] (FLINK-4073) YARNSessionCapacitySchedulerITCase.testTaskManagerFailure failed on Travis

2016-09-05 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-4073. --- Resolution: Fixed Assignee: Maximilian Michels Fix Version/s: 1.2.0 Fi

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77529056 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java --- @@ -25,6 +25,7 @@ public static final byte METRI

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465122#comment-15465122 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77528928 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java --- @@ -25,6 +25,7 @@ public static final byte METRI

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465111#comment-15465111 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465112#comment-15465112 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77528158 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java --- @@ -0,0 +1,269 @@ +/* + * Licensed

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77528207 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java --- @@ -0,0 +1,269 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465108#comment-15465108 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77527822 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465106#comment-15465106 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77527854 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77527637 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java --- @@ -35,109 +46,111 @@ final Map taskM

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465103#comment-15465103 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465100#comment-15465100 ] ASF GitHub Bot commented on FLINK-4389: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2363#discussion_r77527444 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java --- @@ -35,109 +46,111 @@ final Map taskM

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465061#comment-15465061 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allocation ...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2463 Thanks for your work @mxm. I've had some comments which you can find inline. I think the implementation of the slot request logic made another step in the right direction with this PR. --- If

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77524626 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java --- @@ -15,11 +15,27 @@ * See the License fo

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465054#comment-15465054 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465044#comment-15465044 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77524466 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java --- @@ -0,0 +1,228 @@ +/* + * L

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465037#comment-15465037 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77524239 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java --- @@ -46,13 +47,21 @@ /** if the slot is allocated

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77523985 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java --- @@ -32,4 +33,11 @@ //

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465028#comment-15465028 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465023#comment-15465023 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77523806 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java --- @@ -0,0 +1,228 @@ +/* + * L

[jira] [Commented] (FLINK-4579) Add StateBackendFactory for RocksDB Backend

2016-09-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465025#comment-15465025 ] Aljoscha Krettek commented on FLINK-4579: - Should be as easy as that, yes. > Add

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77522737 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -131,9 +149,16 @@ public RegistrationResponse

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465005#comment-15465005 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2463#discussion_r77522339 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -52,15 +58,28 @@ * */ publi

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465000#comment-15465000 ] ASF GitHub Bot commented on FLINK-4538: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464917#comment-15464917 ] ASF GitHub Bot commented on FLINK-4458: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2450: [FLINK-4458] Replace ForkableFlinkMiniCluster by LocalFli...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2450 I've re-introduced the `ForkableFlinkMiniCluster`. However, this time it only starts the normal distributed component classes (e.g. `JobManager` instead of `TestingJobManager`, etc.). This impli

[jira] [Commented] (FLINK-4456) Replace ActorGateway in Task by interface

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464910#comment-15464910 ] ASF GitHub Bot commented on FLINK-4456: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2456: [FLINK-4456] Replace ActorGateway in Task and RuntimeEnvi...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2456 I've addressed the comments. In order to solve the problem with the user code class loader, I decided to pass it into the `InputSplitProvider` via the `getNextInputSplit` method. That way, we do

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464874#comment-15464874 ] ASF GitHub Bot commented on FLINK-3929: --- Github user mxm commented on the issue:

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-09-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2275 Thank you. Testing again and merging if nothing fails. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[jira] [Commented] (FLINK-4579) Add StateBackendFactory for RocksDB Backend

2016-09-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464832#comment-15464832 ] Jark Wu commented on FLINK-4579: +1 for adding rocksdb to the standard distribution lib. S

[jira] [Commented] (FLINK-4456) Replace ActorGateway in Task by interface

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464801#comment-15464801 ] ASF GitHub Bot commented on FLINK-4456: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4456) Replace ActorGateway in Task by interface

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464799#comment-15464799 ] ASF GitHub Bot commented on FLINK-4456: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2456: [FLINK-4456] Replace ActorGateway in Task and Runt...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2456#discussion_r77508870 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/InputSplitProvider.java --- @@ -35,4 +35,16 @@ * task sha

[GitHub] flink pull request #2456: [FLINK-4456] Replace ActorGateway in Task and Runt...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2456#discussion_r77508917 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskExecutionStateListener.java --- @@ -0,0 +1,29 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4456) Replace ActorGateway in Task by interface

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464788#comment-15464788 ] ASF GitHub Bot commented on FLINK-4456: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2456: [FLINK-4456] Replace ActorGateway in Task and Runt...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2456#discussion_r77508238 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/CheckpointNotifier.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to the

[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL

2016-09-05 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2454 Hi @fhueske , thanks for reviewing, I updated this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-4546) Remove STREAM keyword in Stream SQL

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464784#comment-15464784 ] ASF GitHub Bot commented on FLINK-4546: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-4505) Implement TaskManagerFactory to bring up TaskManager for different modes

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464772#comment-15464772 ] ASF GitHub Bot commented on FLINK-4505: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4546) Remove STREAM keyword in Stream SQL

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464771#comment-15464771 ] ASF GitHub Bot commented on FLINK-4546: --- Github user wuchong commented on a diff in

[GitHub] flink issue #2461: [FLINK-4505][Cluster Management] Implement TaskManagerFac...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2461 I think you should have at least another method `startComponents` which starts the different components. Everything else can be added later when we see that it would be helpful. --- If your pr

[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...

2016-09-05 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2454#discussion_r77507678 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala --- @@ -18,22 +18,11 @@ package

[jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464765#comment-15464765 ] ASF GitHub Bot commented on FLINK-4458: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2450: [FLINK-4458] Replace ForkableFlinkMiniCluster by LocalFli...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2450 I will re-introduce the `ForkableFlinkMiniCluster` which is simply extending the `LocalFlinkMiniCluster`. --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (FLINK-4505) Implement TaskManagerFactory to bring up TaskManager for different modes

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464709#comment-15464709 ] ASF GitHub Bot commented on FLINK-4505: --- Github user wangzhijiang999 commented on th

[GitHub] flink issue #2461: [FLINK-4505][Cluster Management] Implement TaskManagerFac...

2016-09-05 Thread wangzhijiang999
Github user wangzhijiang999 commented on the issue: https://github.com/apache/flink/pull/2461 Yes, that also make sense. For testing purpose it is very clear, so we do not need do anything currently, all the components in `TaskManager` constructor can be mocked implicitly. Fo

[jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464700#comment-15464700 ] ASF GitHub Bot commented on FLINK-4458: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2450: [FLINK-4458] Replace ForkableFlinkMiniCluster by LocalFli...

2016-09-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2450 Yes that is true. However, the `flink-test-utils` have not been guaranteed to be stable if I'm not mistaken. The changes one has to apply is to replace the `ForkableFlinkMiniCluster` with the `L

[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464682#comment-15464682 ] ASF GitHub Bot commented on FLINK-4580: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2473: [FLINK-4580] [rpc] Verify that the rpc endpoint su...

2016-09-05 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2473 [FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at connect time When calling RpcService.connect it is checked that the rpc endpoint supports the specified rpc gate

[GitHub] flink pull request #2452: [Flink-4450] add a new module "flink-apache-storm"...

2016-09-05 Thread liuyuzhong
GitHub user liuyuzhong reopened a pull request: https://github.com/apache/flink/pull/2452 [Flink-4450] add a new module "flink-apache-storm" to support new storm verion program (higher than 1.0.0) @StephanEwen 1. Create new module "flink-apache-storm" copy from flink-cont

[GitHub] flink pull request #2452: [Flink-4450] add a new module "flink-apache-storm"...

2016-09-05 Thread liuyuzhong
Github user liuyuzhong closed the pull request at: https://github.com/apache/flink/pull/2452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...

2016-09-05 Thread liuyuzhong
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2452 build success ``` [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:28 h [INFO] Finished at: 2016-0

[jira] [Updated] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-05 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4329: -- Fix Version/s: (was: 1.1.2) 1.1.3 > Fix Streaming File Source Timestamps/

[jira] [Updated] (FLINK-4396) GraphiteReporter class not found at startup of jobmanager

2016-09-05 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4396: -- Fix Version/s: (was: 1.1.2) 1.1.3 > GraphiteReporter class not found at s

[jira] [Updated] (FLINK-4513) Kafka connector documentation refers to Flink 1.1-SNAPSHOT

2016-09-05 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4513: -- Fix Version/s: (was: 1.1.2) 1.1.3 > Kafka connector documentation refers

[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...

2016-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2454#discussion_r77494279 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala --- @@ -18,22 +18,11 @@ package

[GitHub] flink issue #2471: Broken links on website

2016-09-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2471 Thank your for reporting this issue. The Apache Flink project uses JIRA to track issues, not GitHub pull requests, so it would be nice if you could close this PR and file a ticket on [JIRA](https://i

[jira] [Commented] (FLINK-4546) Remove STREAM keyword in Stream SQL

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464577#comment-15464577 ] ASF GitHub Bot commented on FLINK-4546: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL

2016-09-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2454 Hi @wuchong, thanks for the PR. Just had two minor comments. Thanks, Fabian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-4546) Remove STREAM keyword in Stream SQL

2016-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464574#comment-15464574 ] ASF GitHub Bot commented on FLINK-4546: --- Github user fhueske commented on a diff in

  1   2   >