[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141208#comment-16141208 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135184770 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -135,4 +138,177 @@

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135181433 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -100,6 +108,17 @@

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141143#comment-16141143 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141140#comment-16141140 ] ASF GitHub Bot commented on FLINK-7206: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4355: [FLINK-7206] [table] Implementation of DataView to suppor...

2017-08-24 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4355 The new created method `open(ctx)` and `close()` of `GeneratedAggregations` are not called by `AggregateAggFunction` which is used in window aggregate. I suggest to call the `open(ctx)` method but

[jira] [Created] (FLINK-7509) Refactorings to AggregateCodeGenerator

2017-08-24 Thread Jark Wu (JIRA)
Jark Wu created FLINK-7509: -- Summary: Refactorings to AggregateCodeGenerator Key: FLINK-7509 URL: https://issues.apache.org/jira/browse/FLINK-7509 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141123#comment-16141123 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135179322 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/DataViewSpec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141121#comment-16141121 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141120#comment-16141120 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135179087 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135179101 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -178,13 +294,15 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141085#comment-16141085 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135173258 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135172148 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -759,10 +786,12 @@ object

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141078#comment-16141078 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135171980 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -356,6 +486,9 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141075#comment-16141075 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[jira] [Commented] (FLINK-5479) Per-partition watermarks in FlinkKafkaConsumer should consider idle partitions

2017-08-24 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141068#comment-16141068 ] Eron Wright commented on FLINK-5479: - Thinking out loud here, consider making use of Kafka's

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141044#comment-16141044 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4562: [FLINK-7402] Fix ineffective null check in NettyMessage#w...

2017-08-24 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @NicoK Great, tt's too useful for me, thank you very much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140995#comment-16140995 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135163096 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -135,4 +138,177 @@

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140991#comment-16140991 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135162070 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[jira] [Updated] (FLINK-7490) UDF Agg throws Exception when flink-table is loaded with AppClassLoader

2017-08-24 Thread Miguel Rui Pereira Marques (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miguel Rui Pereira Marques updated FLINK-7490: -- Affects Version/s: 1.4.0 > UDF Agg throws Exception when flink-table is

[jira] [Created] (FLINK-7508) switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

2017-08-24 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7508: --- Summary: switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode Key: FLINK-7508 URL: https://issues.apache.org/jira/browse/FLINK-7508

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140796#comment-16140796 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112454 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewSerializer.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135128323 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -135,4 +138,177 @@ public

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140788#comment-16140788 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140784#comment-16140784 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135140565 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/DataViewSpec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135126762 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -100,6 +108,17 @@ abstract

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140799#comment-16140799 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135109036 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135121779 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112753 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewTypeInfo.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140780#comment-16140780 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140797#comment-16140797 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140803#comment-16140803 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140808#comment-16140808 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135125473 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135131075 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -79,13 +95,15 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140812#comment-16140812 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140793#comment-16140793 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140805#comment-16140805 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140809#comment-16140809 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140804#comment-16140804 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140790#comment-16140790 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135133385 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140792#comment-16140792 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140791#comment-16140791 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140781#comment-16140781 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135125391 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135135021 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140779#comment-16140779 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140795#comment-16140795 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140801#comment-16140801 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140807#comment-16140807 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140786#comment-16140786 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140783#comment-16140783 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140782#comment-16140782 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140798#comment-16140798 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140802#comment-16140802 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140811#comment-16140811 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140806#comment-16140806 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140810#comment-16140810 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135134452 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135110707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,121 @@ +/* + *

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140789#comment-16140789 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140787#comment-16140787 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140785#comment-16140785 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140800#comment-16140800 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140794#comment-16140794 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135125423 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1469,4 +1526,26 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135124865 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1398,14 +1440,29 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135134994 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112227 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135124134 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -759,10 +786,12 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135107609 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala --- @@ -0,0 +1,188 @@ +/* + * Licensed to

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135110511 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112047 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewSerializer.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112662 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewSerializer.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135109902 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135117112 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -307,6 +312,139 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135135051 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,108 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135107708 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135138596 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -178,13 +294,15 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135139164 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -356,6 +486,9 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135128744 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -135,4 +138,177 @@ public

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135112266 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewTypeInfo.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135108408 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1458,9 +1459,10 @@ abstract class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135106244 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135107137 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala --- @@ -0,0 +1,188 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7484) com.esotericsoftware.kryo.KryoException: java.lang.IndexOutOfBoundsException: Index: 7, Size: 5

2017-08-24 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140606#comment-16140606 ] Shashank Agarwal commented on FLINK-7484: - Got another crash. I have not used any INR class in

[jira] [Closed] (FLINK-7460) Close all ColumnFamilyHandles when restoring rescaled incremental checkpoints

2017-08-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-7460. - Resolution: Fixed merged in ca87bec4f7. > Close all ColumnFamilyHandles when restoring rescaled

[jira] [Closed] (FLINK-7505) Use lambdas in suppressed exception idiom

2017-08-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-7505. - Resolution: Fixed merged in 5456cf9f8f. > Use lambdas in suppressed exception idiom >

[jira] [Closed] (FLINK-7461) Remove Backwards compatibility for Flink 1.1 from Flink 1.4

2017-08-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-7461. - Resolution: Fixed merged in 6642768ad8. > Remove Backwards compatibility for Flink 1.1 from

  1   2   >