[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148570875 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148599978 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148570094 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148570278 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148571514 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148570569 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148598542 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -1006,7 +1044,13 @@ public boolean

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148591926 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -262,23 +263,36 @@ public void disconnectResourceManager()

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148602423 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148570658 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolRpcTest.java --- @@ -99,4 +108,129 @@ public void

[jira] [Updated] (FLINK-7934) Upgrade Calcite dependency to 1.15

2017-11-02 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7934: - Issue Type: Task (was: Bug) > Upgrade Calcite dependency to 1.15 >

[jira] [Commented] (FLINK-7153) Eager Scheduling can't allocate source for ExecutionGraph correctly

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236126#comment-16236126 ] ASF GitHub Bot commented on FLINK-7153: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-7153) Eager Scheduling can't allocate source for ExecutionGraph correctly

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7153. -- Resolution: Fixed Fix Version/s: (was: 1.3.3) Fixed via

[GitHub] flink pull request #4916: [FLINK-7153] Re-introduce preferred locations for ...

2017-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4916 ---

[jira] [Commented] (FLINK-4272) Create a JobClient for job control and monitoring

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236117#comment-16236117 ] ASF GitHub Bot commented on FLINK-4272: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2732: [FLINK-4272] Create a JobClient for job control and monit...

2017-11-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2732 No work yet, but we still need it. 😅 ---

[jira] [Created] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7967: Summary: Deprecate Hadoop specific Flink configuration options Key: FLINK-7967 URL: https://issues.apache.org/jira/browse/FLINK-7967 Project: Flink Issue

[jira] [Updated] (FLINK-7964) Add Apache Kafka 1.0 connector

2017-11-02 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhou UTC+8 updated FLINK-7964: -- Summary: Add Apache Kafka 1.0 connector (was: Add Apache Kafka 1.0.0 connector) > Add Apache

[jira] [Commented] (FLINK-4272) Create a JobClient for job control and monitoring

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236029#comment-16236029 ] ASF GitHub Bot commented on FLINK-4272: --- Github user mxm commented on the issue:

[GitHub] flink issue #2732: [FLINK-4272] Create a JobClient for job control and monit...

2017-11-02 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2732 This probably needs an overhaul by now. Have there been any efforts undergone to introduce a job client? ---

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236006#comment-16236006 ] ASF GitHub Bot commented on FLINK-7764: --- Github user xccui closed the pull request at:

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236005#comment-16236005 ] ASF GitHub Bot commented on FLINK-7764: --- Github user xccui commented on the issue:

[GitHub] flink pull request #4790: [FLINK-7764] [kafka] Enable the operator settings ...

2017-11-02 Thread xccui
Github user xccui closed the pull request at: https://github.com/apache/flink/pull/4790 ---

[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...

2017-11-02 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4790 Thanks! ---

[jira] [Closed] (FLINK-6529) Rework the shading model in Flink

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-6529. --- > Rework the shading model in Flink > - > > Key:

[jira] [Resolved] (FLINK-6529) Rework the shading model in Flink

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-6529. - Resolution: Fixed Fix Version/s: 1.4.0 Completed by resolution of all subtasks > Rework

[jira] [Resolved] (FLINK-7779) Relocate Curator

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-7779. - Resolution: Fixed Fixed in d368a07a2146c45a7f994cab0bb55524432a843d > Relocate Curator >

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236002#comment-16236002 ] ASF GitHub Bot commented on FLINK-7764: --- Github user xccui closed the pull request at:

[GitHub] flink issue #4819: [FLINK-7764] [kafka] Fix the operator setting problem of ...

2017-11-02 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4819 Thanks @aljoscha. Will close this PR. ---

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236001#comment-16236001 ] ASF GitHub Bot commented on FLINK-7764: --- Github user xccui commented on the issue:

[GitHub] flink pull request #4819: [FLINK-7764] [kafka] Fix the operator setting prob...

2017-11-02 Thread xccui
Github user xccui closed the pull request at: https://github.com/apache/flink/pull/4819 ---

[jira] [Closed] (FLINK-7779) Relocate Curator

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-7779. --- > Relocate Curator > > > Key: FLINK-7779 > URL:

[jira] [Closed] (FLINK-7778) Relocate ZooKeeper

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-7778. --- > Relocate ZooKeeper > -- > > Key: FLINK-7778 > URL:

[jira] [Resolved] (FLINK-7778) Relocate ZooKeeper

2017-11-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-7778. - Resolution: Fixed Fixed in d368a07a2146c45a7f994cab0bb55524432a843d > Relocate ZooKeeper >

[jira] [Commented] (FLINK-7778) Relocate ZooKeeper

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235997#comment-16235997 ] ASF GitHub Bot commented on FLINK-7778: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4927: [FLINK-7778] [build] Shade Curator/ZooKeeper depen...

2017-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4927 ---

[jira] [Created] (FLINK-7966) Create flink-connector-kafka-1.0 submodule

2017-11-02 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7966: - Summary: Create flink-connector-kafka-1.0 submodule Key: FLINK-7966 URL: https://issues.apache.org/jira/browse/FLINK-7966 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7764. --- Resolution: Fixed Fix Version/s: 1.3.3 1.4.0 Fixed on master in

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235947#comment-16235947 ] ASF GitHub Bot commented on FLINK-7764: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4819: [FLINK-7764] [kafka] Fix the operator setting problem of ...

2017-11-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4819 I also merged this one. 👍 Could you please close the PR? ---

[jira] [Commented] (FLINK-7764) FlinkKafkaProducer010 does not accept name, uid, or parallelism

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235914#comment-16235914 ] ASF GitHub Bot commented on FLINK-7764: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...

2017-11-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4790 Thanks, @xccui! 😃 I merged this, could you please close the PR? ---

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4769 @tzulitai , confirm. because the `FlinkKafkaConsumer011` extend from `FlinkKafkaConsumer010` and `Kafka010Fetcher` extend from `Kafka09Fetcher`, for Kafka connector only need to fix

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235882#comment-16235882 ] ASF GitHub Bot commented on FLINK-7758: --- Github user yew1eb commented on the issue:

[jira] [Closed] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-11-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7784. --- Resolution: Fixed Fixed in 8cdf2ff7e5817acc0c239ce31c098daf33d326b7 > Don't fail

[jira] [Commented] (FLINK-7866) Weigh list of preferred locations for scheduling

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235869#comment-16235869 ] Till Rohrmann commented on FLINK-7866: -- [~sihuazhou] after addressing this issue, it might make sense

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235865#comment-16235865 ] Till Rohrmann commented on FLINK-7873: -- [~stefanrichte...@gmail.com] are there already any other open

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235850#comment-16235850 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235847#comment-16235847 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235846#comment-16235846 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235848#comment-16235848 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235845#comment-16235845 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235849#comment-16235849 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148553179 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -399,6 +399,26 @@ public void

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148550603 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java --- @@ -71,6 +71,18 @@

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148552085 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java --- @@ -52,4 +52,6 @@ *

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r14869 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -363,6 +363,9 @@ private void

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148552792 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -874,6 +894,13 @@ public void

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148551966 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -302,7 +302,12 @@ public boolean

[jira] [Commented] (FLINK-7843) Improve and enhance documentation for system metrics

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235836#comment-16235836 ] ASF GitHub Bot commented on FLINK-7843: --- Github user yew1eb commented on the issue:

[jira] [Commented] (FLINK-7746) move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235835#comment-16235835 ] ASF GitHub Bot commented on FLINK-7746: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink issue #4869: [FLINK-7843][docs] Improve documentation for metrics

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4869 @zentol , thinks for your reviewing. I addressed some of your comments. ---

[GitHub] flink pull request #4759: [FLINK-7746][network] move ResultPartitionWriter#w...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4759#discussion_r148553146 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java --- @@ -293,6 +293,27 @@ public void add(Buffer

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235832#comment-16235832 ] ASF GitHub Bot commented on FLINK-7608: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4826: [FLINK-7608][metric] Refactor latency statistics metric

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4826 Sorry to reply late, @zentol could you will merge this PR? ---

[GitHub] flink issue #4794: [build][minor] Add missing licenses

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4794 @StephanEwen, @greghogan , I'm sorry to reply late, a little busy recently. Stephan, I agree with you. This PR has been updated. ---

[jira] [Closed] (FLINK-7948) YarnApplicationMaster should also load hdfs-site.xml

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7948. Resolution: Duplicate > YarnApplicationMaster should also load hdfs-site.xml >

[jira] [Commented] (FLINK-7965) Docker-Flink: TaskManagers can't find JobManager when in different nodes in Docker Swarm

2017-11-02 Thread Thalita Vergilio (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235799#comment-16235799 ] Thalita Vergilio commented on FLINK-7965: - And here is the log from the container running

[jira] [Commented] (FLINK-7965) Docker-Flink: TaskManagers can't find JobManager when in different nodes in Docker Swarm

2017-11-02 Thread Thalita Vergilio (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235798#comment-16235798 ] Thalita Vergilio commented on FLINK-7965: - Full log from the container running JobManager:

[jira] [Updated] (FLINK-7965) Docker-Flink: TaskManagers can't find JobManager when in different nodes in Docker Swarm

2017-11-02 Thread Thalita Vergilio (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thalita Vergilio updated FLINK-7965: Description: This happens even when the nodes are in the same subnet. I am using the

[jira] [Created] (FLINK-7965) Docker-Flink: TaskManagers can't find JobManager when in different nodes in Docker Swarm

2017-11-02 Thread Thalita Vergilio (JIRA)
Thalita Vergilio created FLINK-7965: --- Summary: Docker-Flink: TaskManagers can't find JobManager when in different nodes in Docker Swarm Key: FLINK-7965 URL: https://issues.apache.org/jira/browse/FLINK-7965

[jira] [Commented] (FLINK-7960) ExecutionGraphRestartTest fails sporadically

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235790#comment-16235790 ] ASF GitHub Bot commented on FLINK-7960: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4933: [FLINK-7960] [tests] Fix race conditions in Execut...

2017-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4933 ---

[jira] [Resolved] (FLINK-7960) ExecutionGraphRestartTest fails sporadically

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7960. -- Resolution: Fixed Fixed via f9b475f5528ed6a85e27ad167086f98c1121ae20 >

[jira] [Commented] (FLINK-7706) Port JobAccumulatorsHandler to new REST endpoint

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235785#comment-16235785 ] ASF GitHub Bot commented on FLINK-7706: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4898: [FLINK-7706] [flip6] Add JobAccumulatorsHandler for new R...

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4898 @tillrohrmann, could you please take a look? :) ---

[jira] [Commented] (FLINK-7153) Eager Scheduling can't allocate source for ExecutionGraph correctly

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235780#comment-16235780 ] ASF GitHub Bot commented on FLINK-7153: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4916: [FLINK-7153] Re-introduce preferred locations for schedul...

2017-11-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4916 Thanks for the follow-up! +1 to merge this ---

[jira] [Commented] (FLINK-7960) ExecutionGraphRestartTest fails sporadically

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235779#comment-16235779 ] ASF GitHub Bot commented on FLINK-7960: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4933: [FLINK-7960] [tests] Fix race conditions in ExecutionGrap...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4933 Thanks a lot for your review @GJL. Merging this PR. ---

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235762#comment-16235762 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235760#comment-16235760 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235764#comment-16235764 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235758#comment-16235758 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235759#comment-16235759 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235763#comment-16235763 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235761#comment-16235761 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148534322 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148531290 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousBufferFileWriter.java --- @@ -31,9 +31,26 @@ protected

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148531416 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java --- @@ -108,11 +108,7 @@ int

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148537550 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -231,31 +255,48 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148532775 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148533217 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r148532507 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[jira] [Commented] (FLINK-4228) YARN artifact upload does not work with S3AFileSystem

2017-11-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235755#comment-16235755 ] Nico Kruber commented on FLINK-4228: I was working a bit with the initial PR and have a fix (with unit

[jira] [Closed] (FLINK-7951) YarnApplicationMaster does not load HDFSConfiguration

2017-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7951. Resolution: Invalid It appears that the problem was not that we don't explicitly load the

[jira] [Commented] (FLINK-7951) YarnApplicationMaster does not load HDFSConfiguration

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235751#comment-16235751 ] ASF GitHub Bot commented on FLINK-7951: --- Github user tillrohrmann closed the pull request at:

[jira] [Commented] (FLINK-7951) YarnApplicationMaster does not load HDFSConfiguration

2017-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235750#comment-16235750 ] ASF GitHub Bot commented on FLINK-7951: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4926: [FLINK-7951] Load YarnConfiguration with default Hadoop c...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4926 Alright, thanks for the infos @steveloughran. After an offline discussion with @StephanEwen, we decided that we should probably not try to explicitly load a Hadoop configuration file

[GitHub] flink pull request #4926: [FLINK-7951] Load YarnConfiguration with default H...

2017-11-02 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/4926 ---

<    1   2   3   >