[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326834#comment-16326834 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

2018-01-15 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4552 @NicoK , thanks for your reviews! I have submitted all the patches you provided offline to address above issues. 1. Remove `FLINK-8425` from this PR. 2. Do you think I should add

[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326818#comment-16326818 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on the issue:

[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326815#comment-16326815 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink issue #5274: [FLINK-8401][Cassandra Connector]Refactor CassandraOutput...

2018-01-15 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5274 Thanks a lot, @tillrohrmann . Added javadoc. Please take another look. ---

[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326817#comment-16326817 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672700 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672687 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[jira] [Commented] (FLINK-7777) Bump japicmp to 0.11.0

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326804#comment-16326804 ] ASF GitHub Bot commented on FLINK-: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #5302: [FLINK-7777][build] Bump japicmp to 0.11.0

2018-01-15 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5302 [FLINK-][build] Bump japicmp to 0.11.0 ## What is the purpose of the change Currently, flink used japicmp-maven-plugin version is 0.7.0, I observed some warning messages , detail:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326793#comment-16326793 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326792#comment-16326792 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161667346 --- Diff: flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java --- @@ -59,7 +59,7 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161667234 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java --- @@ -84,7 +84,7 @@ public void

[jira] [Closed] (FLINK-4504) Support user to decide whether the result of an operator is presistent

2018-01-15 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu closed FLINK-4504. --- Resolution: Won't Fix > Support user to decide whether the result of an operator is presistent >

[jira] [Closed] (FLINK-4444) Add a DFSInputChannel and DFSSubPartition

2018-01-15 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu closed FLINK-. --- Resolution: Won't Fix > Add a DFSInputChannel and DFSSubPartition > -

[jira] [Closed] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-15 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu closed FLINK-8289. --- Resolution: Fixed Fix Version/s: 1.5.0 > The RestServerEndpoint should return the address with real ip

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/5190 ---

[jira] [Commented] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326756#comment-16326756 ] ASF GitHub Bot commented on FLINK-8289: --- Github user shuai-xu closed the pull request at:

[jira] [Closed] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-8322. --- Resolution: Won't Fix > support getting number of existing timers in TimerService >

[jira] [Commented] (FLINK-8267) update Kinesis Producer example for setting Region key

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326639#comment-16326639 ] ASF GitHub Bot commented on FLINK-8267: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Pr...

2018-01-15 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5301 [FLINK-8267] [Kinesis Connector] update Kinesis Producer example for setting Region key ## What is the purpose of the change Update doc to guide users to use KPL's native keys to set

[jira] [Updated] (FLINK-8267) update Kinesis Producer example for setting Region key

2018-01-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8267: Summary: update Kinesis Producer example for setting Region key (was: Kinesis Producer example setting

[jira] [Updated] (FLINK-8411) HeapListState#add(null) will wipe out entire list state

2018-01-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8411: Summary: HeapListState#add(null) will wipe out entire list state (was: inconsistent behavior between

[jira] [Commented] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326633#comment-16326633 ] ASF GitHub Bot commented on FLINK-8411: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #5300: [FLINK-8411] [State Backends] inconsistent behavio...

2018-01-15 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5300 [FLINK-8411] [State Backends] inconsistent behavior between HeapListState#add() and RocksDBListState#add() ## What is the purpose of the change `HeapListState#add(null)` will result in

[jira] [Updated] (FLINK-8411) inconsistent behavior between HeapListState#add() and RocksDBListState#add()

2018-01-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8411: Component/s: State Backends, Checkpointing > inconsistent behavior between HeapListState#add() and

[jira] [Assigned] (FLINK-8188) Clean up flink-contrib

2018-01-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-8188: --- Assignee: Bowen Li > Clean up flink-contrib > -- > > Key:

[GitHub] flink pull request #5299: [Hotfix][Doc][DataStream API] Fix Scala code examp...

2018-01-15 Thread elbaulp
GitHub user elbaulp opened a pull request: https://github.com/apache/flink/pull/5299 [Hotfix][Doc][DataStream API] Fix Scala code example in Controlling Latency section You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326461#comment-16326461 ] ASF GitHub Bot commented on FLINK-7938: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5281: [FLINK-7938] support addAll() in ListState

2018-01-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5281 Hi guys, can @StefanRRichter @aljoscha or any committer else take a look at this PR? I'll host the Seattle Apache Flink Meetup this Wednesday and give a talk. I want to talk about the

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326451#comment-16326451 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

2018-01-15 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4552 one thing which we talked about offline: as a precaution, we should keep the old implementation around and allow the users to basically turn the credit-based flow control algorithm on/off (the

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326442#comment-16326442 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326430#comment-16326430 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326439#comment-16326439 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326435#comment-16326435 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161568012 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java --- @@ -119,6 +119,7 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326448#comment-16326448 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326443#comment-16326443 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161576253 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java --- @@ -84,7 +84,7 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161565565 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +78,142 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161570121 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java --- @@ -119,6 +119,7 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326433#comment-16326433 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326436#comment-16326436 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326440#comment-16326440 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326437#comment-16326437 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161567305 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +78,142 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326444#comment-16326444 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326445#comment-16326445 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161546145 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -372,16 +379,18 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326431#comment-16326431 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161559926 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +77,95 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326447#comment-16326447 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326446#comment-16326446 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326432#comment-16326432 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326438#comment-16326438 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161578518 --- Diff: flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java --- @@ -59,7 +59,7 @@ public void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326434#comment-16326434 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326441#comment-16326441 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161573976 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -238,6 +238,7 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161569135 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java --- @@ -134,13 +135,22 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161567331 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +78,142 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161559642 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +77,95 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161547041 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +77,95 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161559690 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +77,95 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161559913 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +77,95 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161565896 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java --- @@ -71,4 +78,142 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161546199 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -372,16 +379,18 @@ public void

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161485403 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -434,6 +443,29 @@ private

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r161545040 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -277,23 +277,31 @@ public void

[jira] [Assigned] (FLINK-8407) Setting the parallelism after a partitioning operation should be forbidden

2018-01-15 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui reassigned FLINK-8407: -- Assignee: Xingcan Cui > Setting the parallelism after a partitioning operation should be

[jira] [Commented] (FLINK-8316) The CsvTableSink and the CsvInputFormat are not in sync

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326371#comment-16326371 ] ASF GitHub Bot commented on FLINK-8316: --- Github user xccui commented on the issue:

[GitHub] flink issue #5210: [FLINK-8316] [table] The CsvTableSink and the CsvInputFor...

2018-01-15 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5210 Hi @sunjincheng121, thanks for your reply. I think an example would be that, for some non-standard CSV files like `a, b , c,`, if the boolean flag `trailingDelimiter=false`, the file will be parsed

[GitHub] flink pull request #:

2018-01-15 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/5623ac66bd145d52f3488ac2fff9dbc762d0bda1#commitcomment-26867793 @zentol @rmetzger I think this is not correct. The RocksDB state backend is in `lib` by default. This is only relevant for

[jira] [Commented] (FLINK-5886) Python API for streaming applications

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326332#comment-16326332 ] ASF GitHub Bot commented on FLINK-5886: --- Github user zentol commented on the issue:

[GitHub] flink issue #3838: [FLINK-5886] Python API for streaming applications

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3838 Here's a preliminary changelog: General: - rebase branch to current master - incremented version to 1.5-SNAPSHOT - fixed kafka-connector dependency declaration - set to

[jira] [Commented] (FLINK-5886) Python API for streaming applications

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326327#comment-16326327 ] ASF GitHub Bot commented on FLINK-5886: --- Github user zentol commented on the issue:

[GitHub] flink issue #3838: [FLINK-5886] Python API for streaming applications

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3838 I've been digging into this for the past week. I found a number of things to improve and did so in a local branch. Once I've finalized/tests things (probably tomorrow) I'll link the branch here or

[jira] [Commented] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326323#comment-16326323 ] Till Rohrmann commented on FLINK-7949: -- Fixed in 1.4.1 via 7d040fd40c2816e829c81cb38177b6e1579c761c

[jira] [Updated] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-7949: - Fix Version/s: 1.4.1 > AsyncWaitOperator is not restarting when queue is full >

[jira] [Commented] (FLINK-7738) Create WebSocket handler (server)

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326322#comment-16326322 ] ASF GitHub Bot commented on FLINK-7738: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...

2018-01-15 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4767 Hi @EronWright, yes I think we still need support for web sockets. The first REST based client won't use this but later on we should definitely add this functionality. At the moment we try hard

[jira] [Commented] (FLINK-8082) Bump version compatibility check to 1.4

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326318#comment-16326318 ] ASF GitHub Bot commented on FLINK-8082: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5289: [hotfix] [docs] Fix typos

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5289 ---

[GitHub] flink pull request #5262: [FLINK-8082][build] Bump flink version for japicmp...

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5262 ---

[GitHub] flink pull request #5293: [hotfix][docs] Mention maven dependency for RocksD...

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5293 ---

[GitHub] flink pull request #5133: [hotfix] Fix typo in AkkaUtils method

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5133 ---

[jira] [Closed] (FLINK-8082) Bump version compatibility check to 1.4

2018-01-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8082. --- Resolution: Fixed master: 4e0ca93d3f496b410452ab31485ed920e9ab2702 > Bump version

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326315#comment-16326315 ] ASF GitHub Bot commented on FLINK-8399: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5271: [FLINK-8399] [runtime] use independent configurati...

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5271 ---

[jira] [Resolved] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8399. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 

[jira] [Updated] (FLINK-8435) Adding BloomFilter/HyperLogLog state as Managed once

2018-01-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8435: Environment: (was: Many times doing something approximately is enough for users (Such

[jira] [Updated] (FLINK-8435) Adding BloomFilter/HyperLogLog state as Managed once

2018-01-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8435: Description: Many times doing something approximately is enough for users (Such as

[jira] [Created] (FLINK-8435) Adding BloomFilter/HyperLogLog state as Managed once

2018-01-15 Thread Moein Hosseini (JIRA)
Moein Hosseini created FLINK-8435: - Summary: Adding BloomFilter/HyperLogLog state as Managed once Key: FLINK-8435 URL: https://issues.apache.org/jira/browse/FLINK-8435 Project: Flink Issue

[jira] [Commented] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326285#comment-16326285 ] Greg Hogan commented on FLINK-8414: --- You certainly can measure scalability but as you have discovered

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326275#comment-16326275 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

2018-01-15 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4552 @NicoK , I have submitted all the modifications based on the patches you provided. The tests for `nextBufferIsEvent` will be added in a new commit tomorrow. ---

[jira] [Resolved] (FLINK-6730) Activate strict checkstyle for flink-optimizer

2018-01-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan resolved FLINK-6730. --- Resolution: Won't Fix Closing per comment from #5294: "I would ignore the optimizer module TBH. There

[jira] [Commented] (FLINK-8427) Checkstyle for org.apache.flink.optimizer.costs

2018-01-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326243#comment-16326243 ] ASF GitHub Bot commented on FLINK-8427: --- Github user greghogan closed the pull request at:

  1   2   >