[jira] [Created] (FLINK-11834) Introduce flink logical relational nodes

2019-03-05 Thread godfrey he (JIRA)
godfrey he created FLINK-11834: -- Summary: Introduce flink logical relational nodes Key: FLINK-11834 URL: https://issues.apache.org/jira/browse/FLINK-11834 Project: Flink Issue Type: New Feature

[GitHub] [flink] sunsence edited a comment on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern

2019-03-05 Thread GitBox
sunsence edited a comment on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern URL: https://github.com/apache/flink/pull/6124#issuecomment-469992799 @dawidwys The proper AfterMatchSkip strategy can only work on some situations, such as

[GitHub] [flink] hustclf closed pull request #7901: [FLINK-11819][Documentation] Fix wrong description about attribute order by supported now

2019-03-05 Thread GitBox
hustclf closed pull request #7901: [FLINK-11819][Documentation] Fix wrong description about attribute order by supported now URL: https://github.com/apache/flink/pull/7901 This is an automated message from the Apache Git

[GitHub] [flink] sunsence edited a comment on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern

2019-03-05 Thread GitBox
sunsence edited a comment on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern URL: https://github.com/apache/flink/pull/6124#issuecomment-469992799 @dawidwys The proper AfterMatchSkip strategy can only work on some situations, such as `List

[jira] [Commented] (FLINK-11825) Resolve name clash of StateTTL TimeCharacteristic class

2019-03-05 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785282#comment-16785282 ] Congxian Qiu(klion26) commented on FLINK-11825: --- [~fhueske] If you do not mind, I could

[GitHub] [flink] sunsence commented on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern

2019-03-05 Thread GitBox
sunsence commented on issue #6124: [FLINK-8914][CEP]Fix wrong semantic when greedy pattern is the head of the pattern URL: https://github.com/apache/flink/pull/6124#issuecomment-469992799 @dawidwys The proper AfterMatchSkip strategy can only work on some situations, such as `List strings

[GitHub] [flink] flinkbot commented on issue #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-05 Thread GitBox
flinkbot commented on issue #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend URL: https://github.com/apache/flink/pull/7909#issuecomment-469992524 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[jira] [Updated] (FLINK-11833) Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11833: --- Labels: pull-request-available (was: ) > Cleanup unnecessary createKeyedStateBackend

[GitHub] [flink] carp84 opened a new pull request #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-05 Thread GitBox
carp84 opened a new pull request #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend URL: https://github.com/apache/flink/pull/7909 ## What is the purpose of the change This PR is a simple cleanup of `StateBackend` interface

[jira] [Created] (FLINK-11833) Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-05 Thread Yu Li (JIRA)
Yu Li created FLINK-11833: - Summary: Cleanup unnecessary createKeyedStateBackend methods in StateBackend Key: FLINK-11833 URL: https://issues.apache.org/jira/browse/FLINK-11833 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
flinkbot edited a comment on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-469954507 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] KurtYoung commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-469988390 @flinkbot approve all

[GitHub] [flink] KurtYoung commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-469988363 +1 to merge This is

[jira] [Updated] (FLINK-11827) Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11827: --- Labels: pull-request-available (was: ) > Introduce DataFormatConverters to convert

[GitHub] [flink] KurtYoung closed pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung closed pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904 This is an automated

[GitHub] [flink] zhangchj1990 closed pull request #7908: blink first commit

2019-03-05 Thread GitBox
zhangchj1990 closed pull request #7908: blink first commit URL: https://github.com/apache/flink/pull/7908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] KurtYoung commented on issue #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on issue #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#issuecomment-469985857 LGTM, merging...

[GitHub] [flink] klion26 commented on issue #7908: blink first commit

2019-03-05 Thread GitBox
klion26 commented on issue #7908: blink first commit URL: https://github.com/apache/flink/pull/7908#issuecomment-469985351 hi, @zhangchj1990, I think this pr is not needed, could you please close it? This is an automated

[GitHub] [flink] JingsongLi commented on issue #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on issue #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#issuecomment-469983837 Hi @KurtYoung @wuchong , thanks for reviewing. I addressed your

[GitHub] [flink] flinkbot commented on issue #7908: blink first commit

2019-03-05 Thread GitBox
flinkbot commented on issue #7908: blink first commit URL: https://github.com/apache/flink/pull/7908#issuecomment-469983741 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to

[GitHub] [flink] zhangchj1990 opened a new pull request #7908: blink first commit

2019-03-05 Thread GitBox
zhangchj1990 opened a new pull request #7908: blink first commit URL: https://github.com/apache/flink/pull/7908 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid

[jira] [Updated] (FLINK-11829) [checkpoint] FsCheckpointStateOutputStream might store state in files even state size below fileStateThreshold

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11829: --- Labels: pull-request-available (was: ) > [checkpoint] FsCheckpointStateOutputStream might

[GitHub] [flink] Myasuka opened a new pull request #7907: [FLINK-11829][checkpoint] Avoid FsCheckpointStateOutputStream to store state in files when size below fileStateThreshold

2019-03-05 Thread GitBox
Myasuka opened a new pull request #7907: [FLINK-11829][checkpoint] Avoid FsCheckpointStateOutputStream to store state in files when size below fileStateThreshold URL: https://github.com/apache/flink/pull/7907 ## What is the purpose of the change Avoid

[GitHub] [flink] flinkbot commented on issue #7907: [FLINK-11829][checkpoint] Avoid FsCheckpointStateOutputStream to store state in files when size below fileStateThreshold

2019-03-05 Thread GitBox
flinkbot commented on issue #7907: [FLINK-11829][checkpoint] Avoid FsCheckpointStateOutputStream to store state in files when size below fileStateThreshold URL: https://github.com/apache/flink/pull/7907#issuecomment-469982746 Thanks a lot for your contribution to the Apache Flink project.

[GitHub] [flink] tweise commented on issue #7900: [FLINK-11826] Test fix to flaky Kafka ratelimiter test

2019-03-05 Thread GitBox
tweise commented on issue #7900: [FLINK-11826] Test fix to flaky Kafka ratelimiter test URL: https://github.com/apache/flink/pull/7900#issuecomment-469979750 The test passed 5 times in a row in the following build: https://travis-ci.org/apache/flink/builds/502314378 @tillrohrmann

[GitHub] [flink] wuchong commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-469978297 Hi @JingsongLi @KurtYoung , thanks for reviewing. I agree with your ideas and

[GitHub] [flink] wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262797613 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262795882 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262795899 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262795438 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-05 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262789933 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262789132 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-05 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262788648 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-05 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262788274 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262788012 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-05 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262787909 ## File path:

[jira] [Created] (FLINK-11832) Convert some InternalType property related functions to InternalType's method

2019-03-05 Thread Kurt Young (JIRA)
Kurt Young created FLINK-11832: -- Summary: Convert some InternalType property related functions to InternalType's method Key: FLINK-11832 URL: https://issues.apache.org/jira/browse/FLINK-11832 Project:

[GitHub] [flink] KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262785754 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262784896 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262784965 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262787322 ## File path:

[jira] [Commented] (FLINK-11832) Convert some InternalType property related functions to InternalType's method

2019-03-05 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785208#comment-16785208 ] Kurt Young commented on FLINK-11832: The TypeCheckUtils.isComparable is also very error prone >

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-05 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262784641 ## File path:

[jira] [Created] (FLINK-11831) Separate CodeGeneratorContext for different generation targets

2019-03-05 Thread Kurt Young (JIRA)
Kurt Young created FLINK-11831: -- Summary: Separate CodeGeneratorContext for different generation targets Key: FLINK-11831 URL: https://issues.apache.org/jira/browse/FLINK-11831 Project: Flink

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262783913 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262783618 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262782535 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262782646 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262782592 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262783703 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262784143 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#discussion_r262783043 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
wuchong commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262782786 ## File path:

[GitHub] [flink] flinkbot commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
flinkbot commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-469954507 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] wuchong opened a new pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-05 Thread GitBox
wuchong opened a new pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906 ## What is the purpose of the change Introduce `CodeGeneratorContext` to maintain reusable

[jira] [Updated] (FLINK-11830) Introduce CodeGeneratorContext to maintain reusable statements for code generation

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11830: --- Labels: pull-request-available (was: ) > Introduce CodeGeneratorContext to maintain

[jira] [Closed] (FLINK-11510) Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums )

2019-03-05 Thread wangpeibin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangpeibin closed FLINK-11510. -- Resolution: Won't Do > Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] >

[GitHub] [flink] wangpeibin713 closed pull request #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums )

2019-03-05 Thread GitBox
wangpeibin713 closed pull request #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums ) URL: https://github.com/apache/flink/pull/7638 This is an automated

[GitHub] [flink] flinkbot edited a comment on issue #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums )

2019-03-05 Thread GitBox
flinkbot edited a comment on issue #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums ) URL: https://github.com/apache/flink/pull/7638#issuecomment-459738297 Thanks a lot for your contribution to the Apache Flink project. I'm

[GitHub] [flink] wangpeibin713 commented on issue #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums )

2019-03-05 Thread GitBox
wangpeibin713 commented on issue #7638: [FLINK-11510] [DataStream] Add the MultiFieldSumAggregator to support KeyedStream.sum(int[] positionToSums ) URL: https://github.com/apache/flink/pull/7638#issuecomment-469952353 > limited > @flinkbot disapprove consensus > > I

[jira] [Updated] (FLINK-11788) Support Code Generation for RexNode

2019-03-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-11788: Description: Introduce {{ExprCodeGenerator}} to support generate codes from RexNode. (was: Introduce

[jira] [Updated] (FLINK-11830) Introduce CodeGeneratorContext to maintain reusable statements for code generation

2019-03-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-11830: Environment: (was: The CodeGeneratorContext will keep all the reusable statements which will be the

[jira] [Updated] (FLINK-11830) Introduce CodeGeneratorContext to maintain reusable statements for code generation

2019-03-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-11830: Description: The CodeGeneratorContext will keep all the reusable statements which will be the basic class

[jira] [Created] (FLINK-11830) Introduce CodeGeneratorContext to maintain reusable statements for code generation

2019-03-05 Thread Jark Wu (JIRA)
Jark Wu created FLINK-11830: --- Summary: Introduce CodeGeneratorContext to maintain reusable statements for code generation Key: FLINK-11830 URL: https://issues.apache.org/jira/browse/FLINK-11830 Project:

[jira] [Commented] (FLINK-11789) Checkpoint directories are not cleaned up after job termination

2019-03-05 Thread shengjk1 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785178#comment-16785178 ] shengjk1 commented on FLINK-11789: -- i agree  [~yunta] , I also think it would be worthy to discuss

[GitHub] [flink] JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262778438 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262777146 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262776626 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
JingsongLi commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262775882 ## File path:

[jira] [Commented] (FLINK-11819) Additional attribute for order by not support by flink sql, but told supported in doc

2019-03-05 Thread Lifei Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785168#comment-16785168 ] Lifei Chen commented on FLINK-11819: Thanks  [~xccui],  maybe I have a misunderstanding about the

[jira] [Commented] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-05 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785163#comment-16785163 ] Hequn Cheng commented on FLINK-11818: - [~yanghua] It's an interesting feature! Do you have any ideas

[GitHub] [flink] sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-05 Thread GitBox
sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-469938485 Thanks a lot for the big merging @twalthr This

[GitHub] [flink] KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262762103 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262761747 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262759077 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format

2019-03-05 Thread GitBox
KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262762245 ## File path:

[GitHub] [flink] leesf commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-05 Thread GitBox
leesf commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#issuecomment-469927116 @mikeholler you can see examples in

[GitHub] [flink] leesf commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-05 Thread GitBox
leesf commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#discussion_r262757924 ## File path: docs/tutorials/datastream_api.md ## @@ -240,13 +255,28 @@ public class

[GitHub] [flink] TisonKun edited a comment on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-05 Thread GitBox
TisonKun edited a comment on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-469921493 @azagrebin agree that we gain not too much speed up. My concern is that it is a more natural dependency.

[GitHub] [flink] TisonKun commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-05 Thread GitBox
TisonKun commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-469921493 @azagrebin agree that we gain not too much speed up. My concern is that it is a more natural dependency. After all,

[GitHub] [flink] tweise merged pull request #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer

2019-03-05 Thread GitBox
tweise merged pull request #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer URL: https://github.com/apache/flink/pull/7905 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] glaksh100 commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer

2019-03-05 Thread GitBox
glaksh100 commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer URL: https://github.com/apache/flink/pull/7905#issuecomment-469853572 LGTM. Thanks for hot-fixing. This is an automated message

[GitHub] [flink] flinkbot commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer

2019-03-05 Thread GitBox
flinkbot commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer URL: https://github.com/apache/flink/pull/7905#issuecomment-469849363 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] tweise commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer

2019-03-05 Thread GitBox
tweise commented on issue #7905: [FLINK-11826] [hotfix] Ignore flaky testRateLimitedConsumer URL: https://github.com/apache/flink/pull/7905#issuecomment-469849189 CC: @glaksh100 This is an automated message from the Apache

[jira] [Updated] (FLINK-11826) Kafka09ITCase.testRateLimitedConsumer fails on Travis

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11826: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] tweise opened a new pull request #7905: [FLINK-11826] Ignore flaky testRateLimitedConsumer

2019-03-05 Thread GitBox
tweise opened a new pull request #7905: [FLINK-11826] Ignore flaky testRateLimitedConsumer URL: https://github.com/apache/flink/pull/7905 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than

[GitHub] [flink] tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-05 Thread GitBox
tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262639558 ## File path:

[jira] [Commented] (FLINK-9650) Support Protocol Buffers formats

2019-03-05 Thread Arup Malakar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784743#comment-16784743 ] Arup Malakar commented on FLINK-9650: - Hi [~yanghua] I had taken care of the checkstyle, there is

[jira] [Comment Edited] (FLINK-11779) CLI ignores -m parameter if high-availability is ZOOKEEPER

2019-03-05 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784722#comment-16784722 ] Gary Yao edited comment on FLINK-11779 at 3/5/19 6:16 PM: -- The current behavior

[jira] [Commented] (FLINK-11779) CLI ignores -m parameter if high-availability is ZOOKEEPER

2019-03-05 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784722#comment-16784722 ] Gary Yao commented on FLINK-11779: -- The current behavior already gives precedence to ZooKeeper? Would

[jira] [Created] (FLINK-11829) [checkpoint] FsCheckpointStateOutputStream might store state in files even state size below fileStateThreshold

2019-03-05 Thread Yun Tang (JIRA)
Yun Tang created FLINK-11829: Summary: [checkpoint] FsCheckpointStateOutputStream might store state in files even state size below fileStateThreshold Key: FLINK-11829 URL:

[jira] [Assigned] (FLINK-11826) Kafka09ITCase.testRateLimitedConsumer fails on Travis

2019-03-05 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lakshmi Rao reassigned FLINK-11826: --- Assignee: Lakshmi Rao > Kafka09ITCase.testRateLimitedConsumer fails on Travis >

[jira] [Commented] (FLINK-11826) Kafka09ITCase.testRateLimitedConsumer fails on Travis

2019-03-05 Thread Thomas Weise (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784686#comment-16784686 ] Thomas Weise commented on FLINK-11826: -- Should we mark the test ignored until flakiness is

[GitHub] [flink] GJL commented on issue #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-05 Thread GitBox
GJL commented on issue #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7883#issuecomment-469769702 Thanks for the review @dawidwys. Merging as soon as build is green.

[GitHub] [flink] GJL closed pull request #7884: [BP-1.8][FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-05 Thread GitBox
GJL closed pull request #7884: [BP-1.8][FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7884 This is an automated message from the

[GitHub] [flink] GJL commented on issue #7884: [BP-1.8][FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-05 Thread GitBox
GJL commented on issue #7884: [BP-1.8][FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7884#issuecomment-469768503 Merging manually.

[GitHub] [flink] GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-05 Thread GitBox
GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7883#discussion_r262567282 ## File path:

[jira] [Comment Edited] (FLINK-11779) CLI ignores -m parameter if high-availability is ZOOKEEPER

2019-03-05 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784645#comment-16784645 ] TisonKun edited comment on FLINK-11779 at 3/5/19 4:51 PM: -- Oops, it's my

[jira] [Commented] (FLINK-11779) CLI ignores -m parameter if high-availability is ZOOKEEPER

2019-03-05 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784645#comment-16784645 ] TisonKun commented on FLINK-11779: -- Oops, it's my misunderstanding. For respecting the specified

[GitHub] [flink] azagrebin commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-05 Thread GitBox
azagrebin commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262562979 ## File path:

  1   2   3   >