[jira] [Commented] (FLINK-12681) Make SimpleCounter thread-safe.

[ https://issues.apache.org/jira/browse/FLINK-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851560#comment-16851560 ] Biao Liu commented on FLINK-12681: -- The {{SimpleCounter}} is widely used. Especially in

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

WeiZhong94 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288871625 ## File path: flink-dist/pom.xml ## @@ -573,7 +573,7 @@ under the License.

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288868329 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink

[GitHub] [flink] sunhaibotb commented on issue #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on issue #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#issuecomment-497209723 Thank you for reviewing and merging. @tillrohrmann -

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288862873 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink

[jira] [Comment Edited] (FLINK-12047) Savepoint connector to read / write / process savepoints

[ https://issues.apache.org/jira/browse/FLINK-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851513#comment-16851513 ] Tzu-Li (Gordon) Tai edited comment on FLINK-12047 at 5/30/19 5:09 AM:

[jira] [Commented] (FLINK-12047) Savepoint connector to read / write / process savepoints

[ https://issues.apache.org/jira/browse/FLINK-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851513#comment-16851513 ] Tzu-Li (Gordon) Tai commented on FLINK-12047: - [~gyfora] I think with the cu

[jira] [Commented] (FLINK-12047) Savepoint connector to read / write / process savepoints

[ https://issues.apache.org/jira/browse/FLINK-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851508#comment-16851508 ] Tzu-Li (Gordon) Tai commented on FLINK-12047: - For the records, there is a F

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288852908 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on issue #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-497198811 Thanks for the updates @Aitozi ! I left some inline comments. -

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288852908 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288853879 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288853879 ## File path: flink-runtime/src/main/java/org/apache/fli

[jira] [Commented] (FLINK-11947) Support MapState value schema evolution for RocksDB

[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851503#comment-16851503 ] Congxian Qiu(klion26) commented on FLINK-11947: --- hi, [~cre...@gmail.com] 

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288852908 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288852908 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288852438 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288851783 ## File path: flink-runtime/src/main/java/org/apache/fli

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851502#comment-16851502 ] Yingjie Cao commented on FLINK-12070: - Because the test result is fairly long, I pos

[jira] [Updated] (FLINK-12681) Make SimpleCounter thread-safe.

[ https://issues.apache.org/jira/browse/FLINK-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12681: - Description: While adding metrics to Elasticsearch connector, we noticed that the SimpleCounter

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288849334 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288850477 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288849334 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] bowenli86 commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#issuecomment-497192607 sounds good, I'm also fine if we create a JIRA as followup :) -

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r288849162 ## File path: flink-runtime/src/main/java/org/apache/fli

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Description: As discussed in [PR#8309|https://github.com/apache/flink/pull/8309#discussion_r287190944], need

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Description: As discussed in [PR#8309|[https://github.com/apache/flink/pull/8309#discussion_r287190944],]  n

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Description: As discussed in [PR#8309|[https://github.com/apache/flink/pull/8309#discussion_r287190944],]  n

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Description: As discussed in [PR#8309|[https://github.com/apache/flink/pull/8309#discussion_r287190944],]  n

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288845771 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288845434 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288845200 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] becketqin commented on issue #8331: [FLINK-11987][flink-connector-kafka-0.11] convert NEXT_TRANSACTIONAL_ID_HINT_DESCRIPTOR to a non-static variabl…

becketqin commented on issue #8331: [FLINK-11987][flink-connector-kafka-0.11] convert NEXT_TRANSACTIONAL_ID_HINT_DESCRIPTOR to a non-static variabl… URL: https://github.com/apache/flink/pull/8331#issuecomment-497186051 > Thanks for the analysis @becketqin , and I also agree that we'd better

[GitHub] [flink] lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#issuecomment-497186057 > Thanks @lirui-apache for the PR. > > My main concern is that how shim layer determines hive version

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[GitHub] [flink] zhijiangW commented on a change in pull request #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength

zhijiangW commented on a change in pull request #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559#discussion_r288842591 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[GitHub] [flink] zhijiangW commented on a change in pull request #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength

zhijiangW commented on a change in pull request #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559#discussion_r288842591 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager

zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager URL: https://github.com/apache/flink/pull/8566#discussion_r288840346 ## File path: flink-runtime/src/main/j

[GitHub] [flink] zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager

zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager URL: https://github.com/apache/flink/pull/8566#discussion_r288838989 ## File path: flink-runtime/src/main/j

[GitHub] [flink] lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#issuecomment-497178679 @bowenli86 sorry for overlooking some comments. Will update soon

[GitHub] [flink] Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength

Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-497178442 Thanks @pnowojski for review, I will look into these comments and fix accordingly. -

[GitHub] [flink] bowenli86 commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table SQL DDL

bowenli86 commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r288836928 ## File path: flink-table/flink-sql-parser/src/main/codegen/config.fmpp ## @@ -0,0 +1,41 @@ +# Licens

[GitHub] [flink] flinkbot commented on issue #8568: [FLINK-7697][connectors] Add metrics for ElasticSearchSink

flinkbot commented on issue #8568: [FLINK-7697][connectors] Add metrics for ElasticSearchSink URL: https://github.com/apache/flink/pull/8568#issuecomment-497177755 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-7697) Add metrics for Elasticsearch Sink

[ https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7697: -- Labels: pull-request-available (was: ) > Add metrics for Elasticsearch Sink >

[GitHub] [flink] piygoyal opened a new pull request #8568: [FLINK-7697][connectors] Add metrics for ElasticSearchSink

piygoyal opened a new pull request #8568: [FLINK-7697][connectors] Add metrics for ElasticSearchSink URL: https://github.com/apache/flink/pull/8568 ## What is the purpose of the change This pull request add metrics to the Elasticsearch connectors, to make it easier to operat

[GitHub] [flink] bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#issuecomment-497176604 cc @xuefuz @lirui-apache @zjuwangg -

[jira] [Commented] (FLINK-12642) OutputBufferPoolUsageGauge can fail with NPE

[ https://issues.apache.org/jira/browse/FLINK-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851462#comment-16851462 ] zhijiang commented on FLINK-12642: -- Yes, that is the ideal way which we confirmed befor

[jira] [Commented] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851459#comment-16851459 ] vinoyang commented on FLINK-12680: -- Hi [~pgoyal] thanks for your proposal. I think this

[jira] [Updated] (FLINK-12681) Make SimpleCounter thread-safe.

[ https://issues.apache.org/jira/browse/FLINK-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12681: - Description: While adding metrics to Elasticsearch connector we noticed that the SimpleCounter

[jira] [Created] (FLINK-12681) Make SimpleCounter thread-safe.

Piyush Goyal created FLINK-12681: Summary: Make SimpleCounter thread-safe. Key: FLINK-12681 URL: https://issues.apache.org/jira/browse/FLINK-12681 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[jira] [Updated] (FLINK-12680) Add timer type to metric system

[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Goyal updated FLINK-12680: - Description: Currently Flink metric system supports counter, gauge, histogram and meter. For ca

[jira] [Created] (FLINK-12680) Add timer type to metric system

Piyush Goyal created FLINK-12680: Summary: Add timer type to metric system Key: FLINK-12680 URL: https://issues.apache.org/jira/browse/FLINK-12680 Project: Flink Issue Type: Improvement

[jira] [Comment Edited] (FLINK-10455) Potential Kafka producer leak in case of failures

[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851427#comment-16851427 ] Chris Slotterback edited comment on FLINK-10455 at 5/30/19 12:30 AM: -

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851427#comment-16851427 ] Chris Slotterback commented on FLINK-10455: --- [~sunjincheng121] I think it shou

[GitHub] [flink] sunjincheng121 commented on issue #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s…

sunjincheng121 commented on issue #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s… URL: https://github.com/apache/flink/pull/8563#issuecomment-497154451 @flinkbot attention @zentol This is an aut

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851414#comment-16851414 ] sunjincheng commented on FLINK-10455: - Thanks for the quick reply [~azagrebin]! and

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288813133 ## File path: flink-dist/pom.xml ## @@ -573,7 +573,7 @@ under the License.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812260 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812196 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812068 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288808775 ## File path: flink-python/pyflink/table/table_descriptor.py ## @@ -285,6 +289,10 @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288808037 ## File path: flink-python/pyflink/table/table_descriptor.py ## @@ -177,6 +177,10 @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288806998 ## File path: flink-python/pyflink/table/table.py ## @@ -532,6 +533,9 @@ def insert_

[GitHub] [flink] xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r288804130 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/t

[GitHub] [flink] xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r288803725 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/b

[GitHub] [flink] xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r288803493 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/b

[GitHub] [flink] xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

xuefuz commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r288803435 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/b

[GitHub] [flink] xuefuz commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

xuefuz commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r288802922 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connecto

[jira] [Commented] (FLINK-12642) OutputBufferPoolUsageGauge can fail with NPE

[ https://issues.apache.org/jira/browse/FLINK-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851278#comment-16851278 ] Andrey Zagrebin commented on FLINK-12642: -  When we have a single-threaded acces

[GitHub] [flink] azagrebin commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

azagrebin commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#issuecomment-497091861 Thanks for the reviews @tillrohrmann @zhijiangW ! I squashed the commits and adjusted the comments. --

[GitHub] [flink] flinkbot commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

flinkbot commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#issuecomment-497078037 Thanks a lot for your contribution to the Apache Flink proj

[jira] [Updated] (FLINK-12676) Add descriptor, validator, and factory for GenericInMemoryCatalog

[ https://issues.apache.org/jira/browse/FLINK-12676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12676: --- Labels: pull-request-available (was: ) > Add descriptor, validator, and factory for Generic

[GitHub] [flink] bowenli86 opened a new pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

bowenli86 opened a new pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567 ## What is the purpose of the change This PR adds descriptor, valid

[jira] [Created] (FLINK-12679) Support 'default-database' config for catalog entries in SQL CLI yaml file

Bowen Li created FLINK-12679: Summary: Support 'default-database' config for catalog entries in SQL CLI yaml file Key: FLINK-12679 URL: https://issues.apache.org/jira/browse/FLINK-12679 Project: Flink

[jira] [Created] (FLINK-12678) Add AbstractCatalog to manage the common catalog name and default database name for catalogs

Bowen Li created FLINK-12678: Summary: Add AbstractCatalog to manage the common catalog name and default database name for catalogs Key: FLINK-12678 URL: https://issues.apache.org/jira/browse/FLINK-12678

[GitHub] [flink] xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288713086 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table

[GitHub] [flink] xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288709371 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table

[GitHub] [flink] xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

xuefuz commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288708313 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r288705640 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catal

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r288705640 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catal

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r288705640 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catal

[jira] [Updated] (FLINK-12676) Add descriptor, validator, and factory for GenericInMemoryCatalog

[ https://issues.apache.org/jira/browse/FLINK-12676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12676: - Summary: Add descriptor, validator, and factory for GenericInMemoryCatalog (was: add descriptor, valida

[jira] [Created] (FLINK-12677) Add descriptor, validator, and factory for HiveCatalog

Bowen Li created FLINK-12677: Summary: Add descriptor, validator, and factory for HiveCatalog Key: FLINK-12677 URL: https://issues.apache.org/jira/browse/FLINK-12677 Project: Flink Issue Type: Su

[jira] [Created] (FLINK-12676) add descriptor, validator, and factory for GenericInMemoryCatalog

Bowen Li created FLINK-12676: Summary: add descriptor, validator, and factory for GenericInMemoryCatalog Key: FLINK-12676 URL: https://issues.apache.org/jira/browse/FLINK-12676 Project: Flink Is

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288684388 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288695430 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288693247 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288696305 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288695139 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288692112 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288681134 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288686542 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288686679 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288681953 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288682697 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288679281 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

  1   2   3   4   >