[GitHub] [flink] godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296102664 ## File path:

[GitHub] [flink] flinkbot commented on issue #8820: [FLINK-12916][tests] Retry cancelWithSavepoint on cancellation barrier in AbstractOperatorRestoreTestBase

2019-06-20 Thread GitBox
flinkbot commented on issue #8820: [FLINK-12916][tests] Retry cancelWithSavepoint on cancellation barrier in AbstractOperatorRestoreTestBase URL: https://github.com/apache/flink/pull/8820#issuecomment-504296833 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Updated] (FLINK-12916) KeyedComplexChainTest.testMigrationAndRestore failed on Travis

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12916: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] Myasuka opened a new pull request #8820: [FLINK-12916][tests] Retry cancelWithSavepoint on cancellation barrier in AbstractOperatorRestoreTestBase

2019-06-20 Thread GitBox
Myasuka opened a new pull request #8820: [FLINK-12916][tests] Retry cancelWithSavepoint on cancellation barrier in AbstractOperatorRestoreTestBase URL: https://github.com/apache/flink/pull/8820 ## What is the purpose of the change Add retry logical for checkpoint failure reason on

[GitHub] [flink] JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296096283 ## File path:

[GitHub] [flink] zhijiangW commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-20 Thread GitBox
zhijiangW commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#issuecomment-504288046 @azagrebin thanks for the reviews! I have updated the codes for addressing the comments and

[GitHub] [flink] zhijiangW commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-20 Thread GitBox
zhijiangW commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#discussion_r296094858 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296078676 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296078539 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296091739 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296091478 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296091344 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296091185 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296090612 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296090504 ## File path:

[GitHub] [flink] synckey commented on issue #8799: [FLINK-11612][chinese-translation,Documentation] Translate the "Proje…

2019-06-20 Thread GitBox
synckey commented on issue #8799: [FLINK-11612][chinese-translation,Documentation] Translate the "Proje… URL: https://github.com/apache/flink/pull/8799#issuecomment-504282422 I have no idea. Looks lit its travis-ci's problem.

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296089885 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-06-20 Thread GitBox
xuyang1706 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r296089776 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType

2019-06-20 Thread GitBox
wuchong commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType URL: https://github.com/apache/flink/pull/8730#discussion_r296087336 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType

2019-06-20 Thread GitBox
wuchong commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType URL: https://github.com/apache/flink/pull/8730#discussion_r296087906 ## File path:

[GitHub] [flink] liyafan82 commented on a change in pull request #8511: [FLINK-12319][Library/CEP]Change the logic of releasing node from recursive to non-recursive

2019-06-20 Thread GitBox
liyafan82 commented on a change in pull request #8511: [FLINK-12319][Library/CEP]Change the logic of releasing node from recursive to non-recursive URL: https://github.com/apache/flink/pull/8511#discussion_r296088014 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296084274 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296084274 ## File path:

[jira] [Comment Edited] (FLINK-12886) Support container memory segment

2019-06-20 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869126#comment-16869126 ] Liya Fan edited comment on FLINK-12886 at 6/21/19 3:27 AM: --- [~ykt836],

[jira] [Commented] (FLINK-12886) Support container memory segment

2019-06-20 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869126#comment-16869126 ] Liya Fan commented on FLINK-12886: -- [~ykt836], [~lzljs3620320] Another advantage I can think of is

[GitHub] [flink] WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-504273756 @sunjincheng121 Thanks for your comments! I have reordered the packages in `index.rst` and `pyflink.rst`.

[GitHub] [flink] flinkbot commented on issue #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

2019-06-20 Thread GitBox
flinkbot commented on issue #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge URL: https://github.com/apache/flink/pull/8819#issuecomment-504273318 Thanks a lot for your contribution to the Apache Flink

[GitHub] [flink] godfreyhe commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink

2019-06-20 Thread GitBox
godfreyhe commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-504273271 LGTM

[GitHub] [flink] wuchong opened a new pull request #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

2019-06-20 Thread GitBox
wuchong opened a new pull request #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge URL: https://github.com/apache/flink/pull/8819 ## What is the purpose of the change This is a simple

[jira] [Updated] (FLINK-12911) Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

2019-06-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-12911: Description: This is a simple issue to port these interface from scala to java and move to

[jira] [Updated] (FLINK-12911) Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12911: --- Labels: pull-request-available (was: ) > Port AppendStreamTableSink,

[jira] [Updated] (FLINK-12920) Drop support for register_table_sink with field_names and field_types parameters

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12920: --- Labels: pull-request-available (was: ) > Drop support for register_table_sink with

[jira] [Assigned] (FLINK-12916) KeyedComplexChainTest.testMigrationAndRestore failed on Travis

2019-06-20 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-12916: Assignee: Yun Tang > KeyedComplexChainTest.testMigrationAndRestore failed on Travis >

[GitHub] [flink] flinkbot commented on issue #8818: [FLINK-12794][table] Support ACC mode for non-window streaming FlatAggregate on Table API

2019-06-20 Thread GitBox
flinkbot commented on issue #8818: [FLINK-12794][table] Support ACC mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8818#issuecomment-504271546 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] hequn8128 opened a new pull request #8818: [FLINK-12794][table] Support ACC mode for non-window streaming FlatAggregate on Table API

2019-06-20 Thread GitBox
hequn8128 opened a new pull request #8818: [FLINK-12794][table] Support ACC mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8818 ## What is the purpose of the change [FLINK-12401](https://issues.apache.org/jira/browse/FLINK-12401)

[GitHub] [flink] flinkbot commented on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-20 Thread GitBox
flinkbot commented on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817#issuecomment-504271371 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot.

[jira] [Updated] (FLINK-12794) Support ACC mode for non-window streaming FlatAggregate on Table API

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12794: --- Labels: pull-request-available (was: ) > Support ACC mode for non-window streaming

[GitHub] [flink] JingsongLi commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType

2019-06-20 Thread GitBox
JingsongLi commented on a change in pull request #8730: [FLINK-12834][table-planner-blink] Support CharType and BinaryType URL: https://github.com/apache/flink/pull/8730#discussion_r296080979 ## File path:

[GitHub] [flink] dianfu opened a new pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-20 Thread GitBox
dianfu opened a new pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817 ## What is the purpose of the change *The following API registerTableSink in TableEnvironment

[jira] [Commented] (FLINK-12887) Schedule UnfencedMessage would lost envelope info

2019-06-20 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869118#comment-16869118 ] Xiaogang Shi commented on FLINK-12887: -- [~till.rohrmann] I am also very curious on the method we

[GitHub] [flink] lirui-apache commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink

2019-06-20 Thread GitBox
lirui-apache commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-504270519 Thanks @wuchong for updating. LGTM now.

[GitHub] [flink] xintongsong commented on issue #8740: [FLINK-12763][runtime] Fail job immediately if tasks’ resource needs can not be satisfied.

2019-06-20 Thread GitBox
xintongsong commented on issue #8740: [FLINK-12763][runtime] Fail job immediately if tasks’ resource needs can not be satisfied. URL: https://github.com/apache/flink/pull/8740#issuecomment-504269702 @flinkbot attention @tillrohrmann

[GitHub] [flink] xintongsong commented on issue #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-06-20 Thread GitBox
xintongsong commented on issue #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#issuecomment-504269649 @flinkbot attention @tillrohrmann This is an automated

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r296075037 ## File path: flink-python/docs/index.rst ## @@ -25,6 +25,9 @@

[GitHub] [flink] wuchong commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink

2019-06-20 Thread GitBox
wuchong commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-504268118 After discussed with @lirui-apache offline, I

[GitHub] [flink] JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

2019-06-20 Thread GitBox
JingsongLi commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296078197 ## File path:

[jira] [Updated] (FLINK-12921) Flink Job Scheduling

2019-06-20 Thread vim (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vim updated FLINK-12921: Environment: flink 1.8.0 jdk8 was: flink 1.7.0 jdk8 > Flink Job Scheduling > > >

[jira] [Created] (FLINK-12921) Flink Job Scheduling

2019-06-20 Thread vim (JIRA)
vim created FLINK-12921: --- Summary: Flink Job Scheduling Key: FLINK-12921 URL: https://issues.apache.org/jira/browse/FLINK-12921 Project: Flink Issue Type: Improvement Components: API /

[GitHub] [flink] sunhaibotb commented on issue #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput

2019-06-20 Thread GitBox
sunhaibotb commented on issue #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput URL: https://github.com/apache/flink/pull/8731#issuecomment-504266752 It seems that unstable case led to the failure of Travis. I have re-triggered the

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r296074512 ## File path: flink-python/pyflink/table/table_config.py ## @@

[GitHub] [flink] WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-504262776 @sunjincheng121 Thanks for your review! I have addressed you comments in the new commit.

[GitHub] [flink] WeiZhong94 edited a comment on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
WeiZhong94 edited a comment on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-504262776 @sunjincheng121 Thanks for your review! I have addressed your comments in the new commit.

[jira] [Created] (FLINK-12920) Drop support for register_table_sink with field_names and field_types parameters

2019-06-20 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12920: --- Summary: Drop support for register_table_sink with field_names and field_types parameters Key: FLINK-12920 URL: https://issues.apache.org/jira/browse/FLINK-12920 Project:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-20 Thread GitBox
WeiZhong94 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r296074136 ## File path: flink-python/pyflink/table/table_config.py ## @@ -119,7

[GitHub] [flink] wuchong commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableT

2019-06-20 Thread GitBox
wuchong commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#discussion_r296072983 ## File path:

[GitHub] [flink] asfgit closed pull request #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
asfgit closed pull request #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] sunjincheng121 commented on issue #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
sunjincheng121 commented on issue #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816#issuecomment-504260056 Thanks for the quick review! @dianfu Merging This is an

[GitHub] [flink] flinkbot commented on issue #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
flinkbot commented on issue #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816#issuecomment-504260040 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] sunjincheng121 commented on issue #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
sunjincheng121 commented on issue #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816#issuecomment-504260078 @flinkbot approve all This is an automated message from

[GitHub] [flink] dianfu commented on issue #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
dianfu commented on issue #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816#issuecomment-504259902 @sunjincheng121 Thanks a lot for the PR. LGTM. +1 to merge. This is

[GitHub] [flink] sunjincheng121 opened a new pull request #8816: [hotfix][python] Exclude header check for python Docs

2019-06-20 Thread GitBox
sunjincheng121 opened a new pull request #8816: [hotfix][python] Exclude header check for python Docs URL: https://github.com/apache/flink/pull/8816 Hotfix: Exclude header check for python Docs. This is an automated message

[GitHub] [flink] KurtYoung commented on a change in pull request #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables

2019-06-20 Thread GitBox
KurtYoung commented on a change in pull request #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables URL: https://github.com/apache/flink/pull/8809#discussion_r296071379 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables

2019-06-20 Thread GitBox
KurtYoung commented on a change in pull request #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables URL: https://github.com/apache/flink/pull/8809#discussion_r296071128 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -60,6 +60,13 @@ under

[jira] [Commented] (FLINK-11622) Translate the "Command-Line Interface" page into Chinese

2019-06-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869089#comment-16869089 ] Jark Wu commented on FLINK-11622: - Hi [~nicholasjiang], are you still working on this issue? Do you mind

[jira] [Commented] (FLINK-12887) Schedule UnfencedMessage would lost envelope info

2019-06-20 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869086#comment-16869086 ] Xiaogang Shi commented on FLINK-12887: -- Hi [~till.rohrmann], now we are using many unfenced

[GitHub] [flink] sunjincheng121 commented on issue #8783: [FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl

2019-06-20 Thread GitBox
sunjincheng121 commented on issue #8783: [FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl URL: https://github.com/apache/flink/pull/8783#issuecomment-504257108 Hi @tillrohrmann, Thanks for work on this PR! Although this is the blocker that we released

[jira] [Closed] (FLINK-12919) flink-connector-hive compilation error in travis

2019-06-20 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf closed FLINK-12919. - Resolution: Fixed > flink-connector-hive compilation error in travis >

[jira] [Commented] (FLINK-12919) flink-connector-hive compilation error in travis

2019-06-20 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869081#comment-16869081 ] leesf commented on FLINK-12919: --- Need to rebased on master. > flink-connector-hive compilation error in

[jira] [Created] (FLINK-12919) flink-connector-hive compilation error in travis

2019-06-20 Thread leesf (JIRA)
leesf created FLINK-12919: - Summary: flink-connector-hive compilation error in travis Key: FLINK-12919 URL: https://issues.apache.org/jira/browse/FLINK-12919 Project: Flink Issue Type: Bug

[GitHub] [flink] mans2singh commented on issue #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-20 Thread GitBox
mans2singh commented on issue #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#issuecomment-504250711 @zentol @rmetzger - Please let me know if you can review this request or point me to someone who can advice on

[GitHub] [flink] flinkbot commented on issue #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

2019-06-20 Thread GitBox
flinkbot commented on issue #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl URL: https://github.com/apache/flink/pull/8815#issuecomment-504250745 Thanks a lot for your contribution to the Apache Flink project.

[GitHub] [flink] bowenli86 opened a new pull request #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

2019-06-20 Thread GitBox
bowenli86 opened a new pull request #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl URL: https://github.com/apache/flink/pull/8815 ## What is the purpose of the change This PR unifies implementations of

[jira] [Updated] (FLINK-12918) unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12918: --- Labels: pull-request-available (was: ) > unify GenericCatalogTable, HiveCatalogTable and

[jira] [Updated] (FLINK-12918) unify catalog table implementations

2019-06-20 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12918: - Description: unify {{GenericCatalogTable}}, {{HiveCatalogTable}} and {{AbstractCatalogTable}} into

[jira] [Updated] (FLINK-12918) unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

2019-06-20 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12918: - Summary: unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

[jira] [Updated] (FLINK-12918) unify catalog table implementations

2019-06-20 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12918: - Summary: unify catalog table implementations (was: unify catalog table implementation) > unify

[jira] [Created] (FLINK-12918) unify catalog table implementation

2019-06-20 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12918: Summary: unify catalog table implementation Key: FLINK-12918 URL: https://issues.apache.org/jira/browse/FLINK-12918 Project: Flink Issue Type: Sub-task

[GitHub] [flink] zuoinlv commented on issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task cancellation is stuck

2019-06-20 Thread GitBox
zuoinlv commented on issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task cancellation is stuck URL: https://github.com/apache/flink/pull/2652#issuecomment-504248827 Do we have other option when task cancel timeout is greater than TASK_CANCELLATION_TIMEOUT_MILLIS, rather

[jira] [Commented] (FLINK-11622) Translate the "Command-Line Interface" page into Chinese

2019-06-20 Thread Jasper Yue (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869056#comment-16869056 ] Jasper Yue commented on FLINK-11622: Hi [~jark], can I assign this issue to me? > Translate the

[GitHub] [flink] yuezhuangshi commented on issue #8799: [FLINK-11612][chinese-translation,Documentation] Translate the "Proje…

2019-06-20 Thread GitBox
yuezhuangshi commented on issue #8799: [FLINK-11612][chinese-translation,Documentation] Translate the "Proje… URL: https://github.com/apache/flink/pull/8799#issuecomment-504246977 @synckey Is there anything I can do if travis-ci build failed?

[GitHub] [flink] tillrohrmann commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-20 Thread GitBox
tillrohrmann commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r296051333 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions

2019-06-20 Thread GitBox
bowenli86 commented on issue #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions URL: https://github.com/apache/flink/pull/8814#issuecomment-504234134 cc @xuefuz @JingsongLi @lirui-apache @zjuwangg

[GitHub] [flink] bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296048166 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -41,18

[GitHub] [flink] bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296048166 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -41,18

[GitHub] [flink] bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296048778 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -41,18

[GitHub] [flink] bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296048716 ## File path:

[GitHub] [flink] flinkbot commented on issue #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions

2019-06-20 Thread GitBox
flinkbot commented on issue #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions URL: https://github.com/apache/flink/pull/8814#issuecomment-504232118 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] bowenli86 opened a new pull request #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions

2019-06-20 Thread GitBox
bowenli86 opened a new pull request #8814: [FLINK-12917][hive] support complex type of array, map, struct for Hive functions URL: https://github.com/apache/flink/pull/8814 ## What is the purpose of the change This PR adds support of array, map, and struct for Hive functions,

[jira] [Updated] (FLINK-12917) support complex type of array, map, struct for Hive functions

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12917: --- Labels: pull-request-available (was: ) > support complex type of array, map, struct for

[jira] [Commented] (FLINK-12895) TaskManagerProcessFailureBatchRecoveryITCase.testTaskManagerProcessFailure failed on travis

2019-06-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869017#comment-16869017 ] Till Rohrmann commented on FLINK-12895: --- I looked into the problem and I think that the original

[jira] [Created] (FLINK-12917) support complex type of array, map, struct for Hive functions

2019-06-20 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12917: Summary: support complex type of array, map, struct for Hive functions Key: FLINK-12917 URL: https://issues.apache.org/jira/browse/FLINK-12917 Project: Flink Issue

[GitHub] [flink] xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296045736 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296042944 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/…

2019-06-20 Thread GitBox
xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create HiveTableFactory that creates TableSource/… URL: https://github.com/apache/flink/pull/8785#discussion_r296041062 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables

2019-06-20 Thread GitBox
bowenli86 commented on issue #8809: [FLIN-12663]Implement HiveTableSource to read Hive tables URL: https://github.com/apache/flink/pull/8809#issuecomment-504190679 The other thing I noticed is that Hive table source and sink impl have quite a few duplication in logic. Maybe that's

[jira] [Commented] (FLINK-12916) KeyedComplexChainTest.testMigrationAndRestore failed on Travis

2019-06-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868941#comment-16868941 ] Till Rohrmann commented on FLINK-12916: --- The problem seems to be that we trigger a savepoint for

[jira] [Issue Comment Deleted] (FLINK-12916) KeyedComplexChainTest.testMigrationAndRestore failed on Travis

2019-06-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12916: -- Comment: was deleted (was: Might be related to FLINK-12895) >

[GitHub] [flink] bowenli86 commented on issue #8813: [FLINK-12891][hive] remove hadoop/hive writable from boundaries of Hive functions and Flink

2019-06-20 Thread GitBox
bowenli86 commented on issue #8813: [FLINK-12891][hive] remove hadoop/hive writable from boundaries of Hive functions and Flink URL: https://github.com/apache/flink/pull/8813#issuecomment-504183144 cc @xuefuz @JingsongLi @lirui-apache @zjuwangg

[GitHub] [flink] flinkbot commented on issue #8813: [FLINK-12891][hive] remove hadoop/hive writable from boundaries of Hive functions and Flink

2019-06-20 Thread GitBox
flinkbot commented on issue #8813: [FLINK-12891][hive] remove hadoop/hive writable from boundaries of Hive functions and Flink URL: https://github.com/apache/flink/pull/8813#issuecomment-504182815 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-12891) remove hadoop/hive writable from boundaries of Hive functions and Flink

2019-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12891: --- Labels: pull-request-available (was: ) > remove hadoop/hive writable from boundaries of

  1   2   3   4   5   >