[jira] [Closed] (FLINK-11775) Introduce MemorySegmentWritable to let Segments direct copy to internal bytes

2019-07-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11775. -- Resolution: Implemented Fix Version/s: 1.9.0 merged in 1.9.0: 99a94edf543fb28ccc8e34b886a67763f

[GitHub] [flink] KurtYoung closed pull request #8775: [FLINK-11775][runtime][table-runtime-blink] Introduce MemorySegmentWritable to let Segments direct copy to internal bytes

2019-07-03 Thread GitBox
KurtYoung closed pull request #8775: [FLINK-11775][runtime][table-runtime-blink] Introduce MemorySegmentWritable to let Segments direct copy to internal bytes URL: https://github.com/apache/flink/pull/8775 This is an automa

[jira] [Closed] (FLINK-13091) Translate "kubernetes" page into Chinese

2019-07-03 Thread yelun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yelun closed FLINK-13091. - Resolution: Invalid > Translate "kubernetes" page into Chinese > > >

[GitHub] [flink] GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy URL: https://github.com/apache/flink/pull/8972#discussion_r300250505 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy URL: https://github.com/apache/flink/pull/8972#discussion_r300247058 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[GitHub] [flink] GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy URL: https://github.com/apache/flink/pull/8972#discussion_r300247346 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[GitHub] [flink] GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8972: [FLINK-13060][coordination] Respect restart constraints in new RegionFailover strategy URL: https://github.com/apache/flink/pull/8972#discussion_r300244942 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[jira] [Updated] (FLINK-13091) Translate "kubernetes" page into Chinese

2019-07-03 Thread yelun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yelun updated FLINK-13091: -- External issue ID: FLINK-11529 > Translate "kubernetes" page into Chinese > --

[jira] [Created] (FLINK-13091) Translate "kubernetes" page into Chinese

2019-07-03 Thread yelun (JIRA)
yelun created FLINK-13091: - Summary: Translate "kubernetes" page into Chinese Key: FLINK-13091 URL: https://issues.apache.org/jira/browse/FLINK-13091 Project: Flink Issue Type: Task Compone

[jira] [Updated] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-12852: Description: When running tests with an upstream vertex and downstream vertex, deadlock occurs when submi

[GitHub] [flink] AjaxXu commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
AjaxXu commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#issuecomment-508360811 > @AjaxXu Good job! Now I think it is ready to be merged. Thanks you and Jark's review.

[GitHub] [flink] dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan

2019-07-03 Thread GitBox
dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan URL: https://github.com/apache/flink/pull/8973#discussion_r300248205 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/

[GitHub] [flink] dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan

2019-07-03 Thread GitBox
dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan URL: https://github.com/apache/flink/pull/8973#discussion_r300248597 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/

[GitHub] [flink] dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan

2019-07-03 Thread GitBox
dawidwys commented on a change in pull request #8973: [FLINK-13081][table-planner][table-api-java] Supports explain DAG plan URL: https://github.com/apache/flink/pull/8973#discussion_r300247688 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300222311 ## File path: flink-table/flink-table-plan

[jira] [Assigned] (FLINK-11607) Translate the "DataStream API Tutorial" page into Chinese

2019-07-03 Thread LakeShen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LakeShen reassigned FLINK-11607: Assignee: LakeShen (was: Zhang Ziqiang) > Translate the "DataStream API Tutorial" page into Chin

[GitHub] [flink] JingsongLi commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
JingsongLi commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#issuecomment-508354954 @AjaxXu Good job! Now I think it is ready to be merged. --

[GitHub] [flink] cshuo commented on issue #8562: [FLINK-12665] [table-planner-blink] Introduce MiniBatchIntervalInferRule and watermark assigner operators

2019-07-03 Thread GitBox
cshuo commented on issue #8562: [FLINK-12665] [table-planner-blink] Introduce MiniBatchIntervalInferRule and watermark assigner operators URL: https://github.com/apache/flink/pull/8562#issuecomment-508354768 Looks good. đź‘Ť Thi

[GitHub] [flink] klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300240845 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License.

[GitHub] [flink] klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300240882 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License.

[GitHub] [flink] ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300240463 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License. *

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300238992 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/T

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300238905 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/sqle

[GitHub] [flink] xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-07-03 Thread GitBox
xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#discussion_r300238485 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/Resour

[GitHub] [flink] xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-07-03 Thread GitBox
xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#discussion_r300238299 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/Resour

[GitHub] [flink] xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-07-03 Thread GitBox
xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#discussion_r300238018 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/Resour

[jira] [Assigned] (FLINK-11638) Translate "Savepoints" page into Chinese

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-11638: --- Assignee: Forward Xu (was: yelun) > Translate "Savepoints" page into Chinese > ---

[jira] [Commented] (FLINK-11638) Translate "Savepoints" page into Chinese

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878324#comment-16878324 ] Jark Wu commented on FLINK-11638: - Hi [~guanghui], [~x1q1j1] has assign this issue to hi

[jira] [Closed] (FLINK-11638) Translate "Savepoints" page into Chinese

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-11638. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 4ad19eff713284c0f30c7dba3cd21095baf18d42 > Tr

[jira] [Comment Edited] (FLINK-11638) Translate "Savepoints" page into Chinese

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878324#comment-16878324 ] Jark Wu edited comment on FLINK-11638 at 7/4/19 5:48 AM: - Hi [~g

[GitHub] [flink] asfgit closed pull request #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese

2019-07-03 Thread GitBox
asfgit closed pull request #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese URL: https://github.com/apache/flink/pull/8300 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] flinkbot commented on issue #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API

2019-07-03 Thread GitBox
flinkbot commented on issue #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API URL: https://github.com/apache/flink/pull/8979#issuecomment-508346981 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[jira] [Updated] (FLINK-13087) Add group window Aggregate operator to Table API

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13087: --- Labels: pull-request-available (was: ) > Add group window Aggregate operator to Table API >

[GitHub] [flink] hequn8128 opened a new pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API

2019-07-03 Thread GitBox
hequn8128 opened a new pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API URL: https://github.com/apache/flink/pull/8979 ## What is the purpose of the change This pull request adds row-based group window Aggregate operator to Table API.

[jira] [Created] (FLINK-13090) Test Hive connector with hive runner

2019-07-03 Thread Rui Li (JIRA)
Rui Li created FLINK-13090: -- Summary: Test Hive connector with hive runner Key: FLINK-13090 URL: https://issues.apache.org/jira/browse/FLINK-13090 Project: Flink Issue Type: Sub-task Compo

[GitHub] [flink] lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable…

2019-07-03 Thread GitBox
lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable… URL: https://github.com/apache/flink/pull/8965#issuecomment-508344669 Thanks @xuefuz and @bowenli86 for the review. Please take another look. --

[GitHub] [flink] lirui-apache commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-03 Thread GitBox
lirui-apache commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs URL: https://github.com/apache/flink/pull/8976#discussion_r300233788 ## File path: docs/dev/table/catalog.md ## @@ -0,0 +1,345 @@ +--- +title: "Catalog" +

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300221923 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300223062 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/T

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300221812 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-07-03 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r300232263 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300221301 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dd

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300222616 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300222001 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300221845 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300223365 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/sqle

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-07-03 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r300215868 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-07-03 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r300223762 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300222783 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300222964 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/ope

[GitHub] [flink] xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-07-03 Thread GitBox
xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#discussion_r300232458 ## File path: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java

[GitHub] [flink] klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300227447 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License.

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-03 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300226601 ## File path: flink-table/flink-table-runtime-blink/

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-03 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300226648 ## File path: flink-table/flink-table-runtime-blink/

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-03 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300226705 ## File path: flink-table/flink-table-runtime-blink/

[GitHub] [flink] wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-03 Thread GitBox
wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r300217135 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/Table

[GitHub] [flink] wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-03 Thread GitBox
wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r300217863 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/Table

[GitHub] [flink] wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-03 Thread GitBox
wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r300215876 ## File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.java

[GitHub] [flink] wuchong commented on issue #8937: [FLINK-13040] promote blink table config and add to document

2019-07-03 Thread GitBox
wuchong commented on issue #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#issuecomment-508335301 Btw, I also suggest to split this pull request into 2 commits: 1. add documentation annotation for table 2. improve opti

[GitHub] [flink] wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-03 Thread GitBox
wuchong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r300215596 ## File path: docs/ops/config.md ## @@ -209,6 +209,13 @@ You have to configure `jobmanager

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300226150 ## File path: flink-table/flink-table-plan

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300226114 ## File path: flink-table/flink-table-plan

[GitHub] [flink] flinkbot commented on issue #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join and add join it cases in blink

2019-07-03 Thread GitBox
flinkbot commented on issue #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join and add join it cases in blink URL: https://github.com/apache/flink/pull/8978#issuecomment-508334487 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I h

[jira] [Updated] (FLINK-13089) Implement batch nested loop join in blink

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13089: --- Labels: pull-request-available (was: ) > Implement batch nested loop join in blink > --

[GitHub] [flink] xintongsong commented on issue #8704: [FLINK-12812][runtime] Set resource profiles for task slots

2019-07-03 Thread GitBox
xintongsong commented on issue #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#issuecomment-508334308 Thanks for the review, @StephanEwen. I would like to explain regarding your concern about the assumption of RM/TM

[GitHub] [flink] JingsongLi opened a new pull request #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join in blink

2019-07-03 Thread GitBox
JingsongLi opened a new pull request #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join in blink URL: https://github.com/apache/flink/pull/8978 ## What is the purpose of the change Nested loop join has two advantages: 1.Nested loop join is quicker when

[jira] [Updated] (FLINK-13089) Implement batch nested loop join in blink

2019-07-03 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-13089: - Description: Nested loop join has two advantages: 1.Nested loop join is quicker when build row

[jira] [Updated] (FLINK-13086) add Chinese documentation for catalogs

2019-07-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-13086: - Description: the ticket for corresponding English documentation is FLINK-12277 > add Chinese documentat

[jira] [Created] (FLINK-13089) Implement batch nested loop join in blink

2019-07-03 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13089: Summary: Implement batch nested loop join in blink Key: FLINK-13089 URL: https://issues.apache.org/jira/browse/FLINK-13089 Project: Flink Issue Type: New Fea

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300223342 ## File path: flink-table/flink-table-plan

[GitHub] [flink] banmoy commented on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable

2019-07-03 Thread GitBox
banmoy commented on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable URL: https://github.com/apache/flink/pull/8611#issuecomment-508331445 @StefanRRichter Thanks for the review. I have addressed the comments, and please help to review again. ---

[jira] [Comment Edited] (FLINK-12926) Main thread checking in some tests fails

2019-07-03 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878302#comment-16878302 ] Zhu Zhu edited comment on FLINK-12926 at 7/4/19 4:12 AM: - Hi [~t

[jira] [Comment Edited] (FLINK-12926) Main thread checking in some tests fails

2019-07-03 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878302#comment-16878302 ] Zhu Zhu edited comment on FLINK-12926 at 7/4/19 4:10 AM: - Hi [~t

[GitHub] [flink] banmoy commented on a change in pull request #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable

2019-07-03 Thread GitBox
banmoy commented on a change in pull request #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable URL: https://github.com/apache/flink/pull/8611#discussion_r300222482 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateTable.

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300222311 ## File path: flink-table/flink-table-plan

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300222038 ## File path: flink-table/flink-table-plan

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300221925 ## File path: flink-table/flink-table-plan

[jira] [Commented] (FLINK-11607) Translate the "DataStream API Tutorial" page into Chinese

2019-07-03 Thread LakeShen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878304#comment-16878304 ] LakeShen commented on FLINK-11607: -- Hi Zhang Ziqiang,have you work on this?If not ,coul

[jira] [Comment Edited] (FLINK-12926) Main thread checking in some tests fails

2019-07-03 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878302#comment-16878302 ] Zhu Zhu edited comment on FLINK-12926 at 7/4/19 3:56 AM: - Hi [~t

[jira] [Commented] (FLINK-12926) Main thread checking in some tests fails

2019-07-03 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878302#comment-16878302 ] Zhu Zhu commented on FLINK-12926: - >From my observation, the issue is happening though i

[GitHub] [flink] tianchen92 closed pull request #8624: [FLINK-10932]Initial flink-kubernetes module with empty implementation

2019-07-03 Thread GitBox
tianchen92 closed pull request #8624: [FLINK-10932]Initial flink-kubernetes module with empty implementation URL: https://github.com/apache/flink/pull/8624 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] tianchen92 opened a new pull request #8624: [FLINK-10932]Initial flink-kubernetes module with empty implementation

2019-07-03 Thread GitBox
tianchen92 opened a new pull request #8624: [FLINK-10932]Initial flink-kubernetes module with empty implementation URL: https://github.com/apache/flink/pull/8624 ## What is the purpose of the change *Initialize the skeleton module to start native k8s integration, related to [FLI

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300220124 ## File path: flink-table/flink-table-plan

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300219868 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300213699 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300213763 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300215701 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300215015 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300215219 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300215614 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300213615 ## File path: flink-table/flink-table-plan

[GitHub] [flink] JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300215120 ## File path: flink-table/flink-table-plan

[GitHub] [flink] ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300216656 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License. *

[GitHub] [flink] ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300218022 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License. *

[jira] [Comment Edited] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878289#comment-16878289 ] zhijiang edited comment on FLINK-12852 at 7/4/19 3:27 AM: -- Netw

[GitHub] [flink] XuQianJin-Stars edited a comment on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese

2019-07-03 Thread GitBox
XuQianJin-Stars edited a comment on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese URL: https://github.com/apache/flink/pull/8300#issuecomment-508323987 hi @klion26 @wuchong I have change it already. -

[GitHub] [flink] ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300216919 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License. *

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878289#comment-16878289 ] zhijiang commented on FLINK-12852: -- Network resource matching in slot has many unsettin

[GitHub] [flink] XuQianJin-Stars commented on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese

2019-07-03 Thread GitBox
XuQianJin-Stars commented on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese URL: https://github.com/apache/flink/pull/8300#issuecomment-508323987 hi @klion26 @wuchong I have me change it already.

[GitHub] [flink] ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
ye-lun commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r300216656 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License. *

  1   2   3   4   5   6   >