[GitHub] [flink-statefun-playground] tillrohrmann commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

2022-02-15 Thread GitBox
tillrohrmann commented on a change in pull request #26: URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807137563 ## File path: java/greeter/docker-compose.yml ## @@ -35,51 +35,12 @@ services:

[GitHub] [flink] GOODBOY008 removed a comment on pull request #18778: [FLINK-26150][connector/pulsar] enable requestTimeoutMs configuration.

2022-02-15 Thread GitBox
GOODBOY008 removed a comment on pull request #18778: URL: https://github.com/apache/flink/pull/18778#issuecomment-1040380762 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] matriv commented on pull request #18756: [FLINK-26075][table-api][table-planner] Persist node configuration

2022-02-15 Thread GitBox
matriv commented on pull request #18756: URL: https://github.com/apache/flink/pull/18756#issuecomment-1040549939 @twalthr @slinkydeveloper - Currently, I have the commit that reads and uses the persisted config separately but I will squash it after the review - I need to add some

[GitHub] [flink-statefun-playground] tillrohrmann commented on pull request #25: [FLINK-26155] Add Playground ingress/egress that allows to ingest and consume messages via curl

2022-02-15 Thread GitBox
tillrohrmann commented on pull request #25: URL: https://github.com/apache/flink-statefun-playground/pull/25#issuecomment-1040419576 Thanks for the review @igalshilman. I've added an `EgressRecord` that takes a topic and payload as Strings. The `PlaygroundEgress` expects to receive such

[GitHub] [flink] flinkbot commented on pull request #18781: [FLINK-26159][doc] add description for MAX_FETCH_RECORD related question

2022-02-15 Thread GitBox
flinkbot commented on pull request #18781: URL: https://github.com/apache/flink/pull/18781#issuecomment-1040303315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807008892 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java ## @@ -107,6

[GitHub] [flink] tillrohrmann commented on a change in pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-02-15 Thread GitBox
tillrohrmann commented on a change in pull request #18757: URL: https://github.com/apache/flink/pull/18757#discussion_r807052941 ## File path: docs/content/docs/deployment/adaptive_batch_scheduler.md ## @@ -0,0 +1,63 @@ +--- +title: Adaptive Batch Scheduler +weight: 5 +type:

[GitHub] [flink] nyingping commented on pull request #18722: [hotfix][docs]fixed some causing ambiguities including the 'shit' comment

2022-02-15 Thread GitBox
nyingping commented on pull request #18722: URL: https://github.com/apache/flink/pull/18722#issuecomment-1040329157 > @RyanSkraba thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] dannycranmer commented on pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on pull request #18733: URL: https://github.com/apache/flink/pull/18733#issuecomment-1040593983 I have been taking a deeper dive into this issue and am no longer inclined to make this change. I have verified that when running on a cluster, each job creates it's own

[GitHub] [flink] autophagy commented on a change in pull request #18678: [FLINK-24474] Default rest.bind-address to localhost in flink-conf.yaml

2022-02-15 Thread GitBox
autophagy commented on a change in pull request #18678: URL: https://github.com/apache/flink/pull/18678#discussion_r806935197 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java

[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

2022-02-15 Thread GitBox
dawidwys commented on a change in pull request #18726: URL: https://github.com/apache/flink/pull/18726#discussion_r807008383 ## File path: flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java ## @@ -63,29

[GitHub] [flink] gaborgsomogyi commented on pull request #18687: [FLINK-24169][tests] Add TimeBased rolling policy and delete OnStartupTriggeringPolicy

2022-02-15 Thread GitBox
gaborgsomogyi commented on pull request #18687: URL: https://github.com/apache/flink/pull/18687#issuecomment-1040283835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18782: [FLINK-26148][runtime] Change the format of adaptive batch scheduler config option to jobmanager.adaptive-batch-scheduler.XXX

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18782: URL: https://github.com/apache/flink/pull/18782#issuecomment-1040321537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] gaoyunhaii commented on pull request #18736: [hotfix][datastream] move the change and restore of env parallelism into the adjusTransformations method.

2022-02-15 Thread GitBox
gaoyunhaii commented on pull request #18736: URL: https://github.com/apache/flink/pull/18736#issuecomment-1039884452 Very thanks @JingGe for the PR and @fapaul for the review~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #18658: [FLINK-26002][tests] Added RestoreUpgradedJobITCase for checking situ…

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18658: URL: https://github.com/apache/flink/pull/18658#issuecomment-1032365173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] PatrickRen commented on a change in pull request #18496: [FLINK-25289][tests] add sink test suite in connector testframe

2022-02-15 Thread GitBox
PatrickRen commented on a change in pull request #18496: URL: https://github.com/apache/flink/pull/18496#discussion_r806652616 ## File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/source/FromElementsSource.java ##

[GitHub] [flink] flinkbot edited a comment on pull request #18738: [FLINK-24745][format][json] Add support for Oracle OGG JSON format parser

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18738: URL: https://github.com/apache/flink/pull/18738#issuecomment-1037051889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18780: [FLINK-26160][pulsar][doc] update the doc of setUnboundedStopCursor()

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18780: URL: https://github.com/apache/flink/pull/18780#issuecomment-1040253405 ## CI report: * da76073dfc386e3159e933945d3bdb0ab8c824a9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18787: [FLINK-26165][tests] Don't test NATIVE savepoints with Changelog enabled

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18787: URL: https://github.com/apache/flink/pull/18787#issuecomment-1040578372 ## CI report: * 06f475e3de4a40847a5e63117da792ef22198b41 Azure:

[GitHub] [flink] zentol commented on a change in pull request #18749: [FLINK-26117] Adds GloballyCleanableResource to JobManagerMetricGroup

2022-02-15 Thread GitBox
zentol commented on a change in pull request #18749: URL: https://github.com/apache/flink/pull/18749#discussion_r806852636 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableResource.java ## @@ -24,12 +24,11 @@ import

[GitHub] [flink] flinkbot edited a comment on pull request #18783: [FLINK-26164] Document watermark alignment

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18783: URL: https://github.com/apache/flink/pull/18783#issuecomment-1040430684 ## CI report: * 0ffb4a7c310d5ec719c3e81ab838b60eada1e5d9 Azure:

[GitHub] [flink] XComp commented on pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
XComp commented on pull request #18692: URL: https://github.com/apache/flink/pull/18692#issuecomment-1039342747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dmvk commented on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-02-15 Thread GitBox
dmvk commented on pull request #18757: URL: https://github.com/apache/flink/pull/18757#issuecomment-1040348759 I'm not sure whether ABS should have its own "top level" section under the deployment menu. Would it make sense to incorporate this into elastic scaling page? -- This is an

[GitHub] [flink] masteryhx commented on a change in pull request #18224: [FLINK-25143][test] Add ITCase for periodic materialization

2022-02-15 Thread GitBox
masteryhx commented on a change in pull request #18224: URL: https://github.com/apache/flink/pull/18224#discussion_r807107658 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogPeriodicMaterializationITCase.java ## @@ -0,0 +1,190 @@ +/* + *

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
CrynetLogistics commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806683366 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7

[GitHub] [flink] rmetzger commented on pull request #17834: [FLINK-24941][datadog] Support Boolean gauges

2022-02-15 Thread GitBox
rmetzger commented on pull request #17834: URL: https://github.com/apache/flink/pull/17834#issuecomment-1040155522 Sorry, the label was added automatically. I guess @zentol would be the right committer to take a look at this PR. -- This is an automated message from the Apache Git

[GitHub] [flink-statefun] tillrohrmann commented on a change in pull request #301: [FLINK-25898] Add README.md to statefun-sdk-js

2022-02-15 Thread GitBox
tillrohrmann commented on a change in pull request #301: URL: https://github.com/apache/flink-statefun/pull/301#discussion_r806575847 ## File path: statefun-sdk-python/README.md ## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully

[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18450: URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18666: [FLINK-25571] Update Elasticsearch Sink to use decomposed interfaces

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18666: URL: https://github.com/apache/flink/pull/18666#issuecomment-1032818588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18680: [FLINK-25583] Support compacting small files for FileSink.

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18680: URL: https://github.com/apache/flink/pull/18680#issuecomment-1033512635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18762: [Flink-26112][k8s]Port getRestEndpoint method to the specific service type subclass

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18762: URL: https://github.com/apache/flink/pull/18762#issuecomment-1039236688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zhuzhurk commented on pull request #18715: [FLINK-25046][runtime] Convert unspecified edge to rescale when using adapive batch scheduler

2022-02-15 Thread GitBox
zhuzhurk commented on pull request #18715: URL: https://github.com/apache/flink/pull/18715#issuecomment-1039829498 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] twalthr commented on a change in pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline

2022-02-15 Thread GitBox
twalthr commented on a change in pull request #18755: URL: https://github.com/apache/flink/pull/18755#discussion_r806658241 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamStatementSet.java ## @@ -38,18 +40,26

[GitHub] [flink] zhuzhurk commented on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-02-15 Thread GitBox
zhuzhurk commented on pull request #18757: URL: https://github.com/apache/flink/pull/18757#issuecomment-1039857272 @tillrohrmann @dmvk would you help to take a look at the EN version document if it is convenient? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] leonardBang closed pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-02-15 Thread GitBox
leonardBang closed pull request #18516: URL: https://github.com/apache/flink/pull/18516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #18774: [FLINK-25701][kafka] Add Flink API annotation to all connector classes based on the new Source/Sink design

2022-02-15 Thread GitBox
flinkbot commented on pull request #18774: URL: https://github.com/apache/flink/pull/18774#issuecomment-1040085044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18771: [FLINK-26119][connectors/common] AsyncSinkWriterStateSerializer to @PublicEvolving

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18771: URL: https://github.com/apache/flink/pull/18771#issuecomment-1039998775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18686: [FLINK-25977][connectors/kinesis] Closing http & sdk clients in sink …

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18686: URL: https://github.com/apache/flink/pull/18686#issuecomment-1033839484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18770: [FLINK-26132][table-planner] Now anonymous tables serialization won't use the flag CatalogPlanCompilation anymore

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18770: URL: https://github.com/apache/flink/pull/18770#issuecomment-1039994674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] rkhachatryan merged pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests

2022-02-15 Thread GitBox
rkhachatryan merged pull request #18556: URL: https://github.com/apache/flink/pull/18556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wanglijie95 commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader

2022-02-15 Thread GitBox
wanglijie95 commented on pull request #18450: URL: https://github.com/apache/flink/pull/18450#issuecomment-1039916159 @wangyang0918 The [FLINK-24897](https://issues.apache.org/jira/browse/FLINK-24897) has been merged, and according to your last comments, I have update the "Fix comments"

[GitHub] [flink] zhuzhurk closed pull request #18715: [FLINK-25046][runtime] Convert unspecified edge to rescale when using adapive batch scheduler

2022-02-15 Thread GitBox
zhuzhurk closed pull request #18715: URL: https://github.com/apache/flink/pull/18715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18755: URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zentol edited a comment on pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
zentol edited a comment on pull request #18692: URL: https://github.com/apache/flink/pull/18692#issuecomment-1040251026 > We do. The Presto S3 Filesystem requires it. That's what [FLINK-26061](https://issues.apache.org/jira/browse/FLINK-26061) is about. I'm wondering if that isn't

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] aubdiy commented on a change in pull request #16927: [FLINK-18592][Connectors/FileSystem] StreamingFileSink fails due to truncating HDFS file failure

2022-02-15 Thread GitBox
aubdiy commented on a change in pull request #16927: URL: https://github.com/apache/flink/pull/16927#discussion_r806597516 ## File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java ## @@ -53,7 +56,9

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #21: [hotfix] Commit operation should not create specific manifest file for new changes

2022-02-15 Thread GitBox
JingsongLi commented on a change in pull request #21: URL: https://github.com/apache/flink-table-store/pull/21#discussion_r806558516 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestFileMeta.java ## @@ -162,54 +176,44 @@

[GitHub] [flink] twalthr closed pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline

2022-02-15 Thread GitBox
twalthr closed pull request #18755: URL: https://github.com/apache/flink/pull/18755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18747: [FLINK-26095][metrics] Respect bind-host for MQS actor system

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18747: URL: https://github.com/apache/flink/pull/18747#issuecomment-1038986787 ## CI report: * 46197f8345730f99a2f9e39f6642ccee9ea66622 Azure:

[GitHub] [flink] XComp commented on a change in pull request #18750: [FLINK-25973][FLINK-25978][FLINK-26017] Applies minor code changes that didn't make it in any of the other JRS-related PRS

2022-02-15 Thread GitBox
XComp commented on a change in pull request #18750: URL: https://github.com/apache/flink/pull/18750#discussion_r806135454 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java ## @@ -1041,6 +1041,9 @@ protected CleanupJobState

[GitHub] [flink] flinkbot commented on pull request #18777: [FLINK-26016][hive] Fix FileSystemLookupFunction can't build correct cache when reading columnar storage table

2022-02-15 Thread GitBox
flinkbot commented on pull request #18777: URL: https://github.com/apache/flink/pull/18777#issuecomment-1040126423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18689: [FLINK-21439][runtime] Exception history adaptive scheduler

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18689: URL: https://github.com/apache/flink/pull/18689#issuecomment-1033918208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] rkhachatryan commented on a change in pull request #18224: [FLINK-25143][test] Add ITCase for periodic materialization

2022-02-15 Thread GitBox
rkhachatryan commented on a change in pull request #18224: URL: https://github.com/apache/flink/pull/18224#discussion_r806684012 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogPeriodicMaterializationITCase.java ## @@ -0,0 +1,190 @@ +/* +

[GitHub] [flink] flinkbot edited a comment on pull request #18774: [FLINK-25701][kafka] Add Flink API annotation to all connector classes based on the new Source/Sink design

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18774: URL: https://github.com/apache/flink/pull/18774#issuecomment-1040091754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18678: [FLINK-24474] Default rest.bind-address to localhost in flink-conf.yaml

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18678: URL: https://github.com/apache/flink/pull/18678#issuecomment-1033466685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #18763: .[FLINK-26133][docus] Fixed Kafka Connector deserializer demo code error

2022-02-15 Thread GitBox
flinkbot commented on pull request #18763: URL: https://github.com/apache/flink/pull/18763#issuecomment-1039248746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] gaoyunhaii closed pull request #18758: [FLINK-25583][connectors/filesystem] Prepare resources for serializer migration tests.

2022-02-15 Thread GitBox
gaoyunhaii closed pull request #18758: URL: https://github.com/apache/flink/pull/18758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18752: [FLINK-25651][docs] Fixed a problem with kafka.md

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18752: URL: https://github.com/apache/flink/pull/18752#issuecomment-1038991196 ## CI report: * fa6559d3b1a249686c75aed1512b591effad58a9 Azure:

[GitHub] [flink] flinkbot commented on pull request #18779: Misprint in javadoc at QuadFunction.java

2022-02-15 Thread GitBox
flinkbot commented on pull request #18779: URL: https://github.com/apache/flink/pull/18779#issuecomment-1040236268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18748: [FLINK-25821][python][doc] Add the doc of execution mode in PyFlink

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18748: URL: https://github.com/apache/flink/pull/18748#issuecomment-1038986841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fapaul commented on pull request #18666: [FLINK-25571] Update Elasticsearch Sink to use decomposed interfaces

2022-02-15 Thread GitBox
fapaul commented on pull request #18666: URL: https://github.com/apache/flink/pull/18666#issuecomment-1039989551 @afedulov there are still test failures related to the ES sink test. Can you fix them? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #18756: [FLINK-26075][table-api][table-planner] Persist node configuration

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18756: URL: https://github.com/apache/flink/pull/18756#issuecomment-1039112190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18556: URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dianfu commented on a change in pull request #18748: [FLINK-25821][python][doc] Add the doc of execution mode in PyFlink

2022-02-15 Thread GitBox
dianfu commented on a change in pull request #18748: URL: https://github.com/apache/flink/pull/18748#discussion_r806412814 ## File path: docs/content.zh/docs/dev/python/python_execution_mode.md ## @@ -0,0 +1,100 @@ +--- +title: "执行模式" +weight: 40 +type: docs +--- + + +#

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #17: [FLINK-25994] Implement FileStoreExpire

2022-02-15 Thread GitBox
JingsongLi commented on a change in pull request #17: URL: https://github.com/apache/flink-table-store/pull/17#discussion_r806637699 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java ## @@ -0,0 +1,155 @@

[GitHub] [flink] fapaul merged pull request #18681: [FLINK-25906][streaming] check explicit env allowed on StreamExecutionEnvironment own.

2022-02-15 Thread GitBox
fapaul merged pull request #18681: URL: https://github.com/apache/flink/pull/18681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dannycranmer commented on a change in pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18773: URL: https://github.com/apache/flink/pull/18773#discussion_r806652615 ## File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java ## @@ -63,13

[GitHub] [flink] gaoyunhaii commented on pull request #18758: [FLINK-25583][connectors/filesystem] Prepare resources for serializer migration tests.

2022-02-15 Thread GitBox
gaoyunhaii commented on pull request #18758: URL: https://github.com/apache/flink/pull/18758#issuecomment-1039787704 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zhuzhurk commented on a change in pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-02-15 Thread GitBox
zhuzhurk commented on a change in pull request #18757: URL: https://github.com/apache/flink/pull/18757#discussion_r806435641 ## File path: docs/content.zh/docs/deployment/adaptive_batch_scheduler.md ## @@ -0,0 +1,63 @@ +--- +title: Adaptive Batch Scheduler +weight: 5 +type:

[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18757: URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dmvk commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dmvk commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806060325 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @@

[GitHub] [flink] RocMarshal commented on a change in pull request #18718: [FLINK-25782] [docs] Translate datastream filesystem.md page into Chi…

2022-02-15 Thread GitBox
RocMarshal commented on a change in pull request #18718: URL: https://github.com/apache/flink/pull/18718#discussion_r806733589 ## File path: docs/content.zh/docs/connectors/datastream/filesystem.md ## @@ -27,61 +27,58 @@ KIND, either express or implied. See the License for

[GitHub] [flink] MrWhiteSike edited a comment on pull request #18718: [FLINK-25782] [docs] Translate datastream filesystem.md page into Chi…

2022-02-15 Thread GitBox
MrWhiteSike edited a comment on pull request #18718: URL: https://github.com/apache/flink/pull/18718#issuecomment-1039775185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] becketqin commented on pull request #18745: [FLINK-24607] Make OperatorCoordinator closing sequence more robust.

2022-02-15 Thread GitBox
becketqin commented on pull request #18745: URL: https://github.com/apache/flink/pull/18745#issuecomment-1039855608 @wuchong Yes, I think it should be in 1.15. This is a bug fix, so technically speaking, it should be OK to merge even after code freeze. -- This is an automated message

[GitHub] [flink] flinkbot edited a comment on pull request #18769: [FLINK-25188][python][build] Support m1 chip.

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18769: URL: https://github.com/apache/flink/pull/18769#issuecomment-1039977246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #18778: [FLINK-26150][connector/pulsar] enable requestTimeoutMs configuration.

2022-02-15 Thread GitBox
flinkbot commented on pull request #18778: URL: https://github.com/apache/flink/pull/18778#issuecomment-1040181229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dawidwys commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

2022-02-15 Thread GitBox
dawidwys commented on pull request #18726: URL: https://github.com/apache/flink/pull/18726#issuecomment-1039457340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18751: [FLINK-25120][tests] Relax CheckpointIDCounterTestBase assertions

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18751: URL: https://github.com/apache/flink/pull/18751#issuecomment-1038987093 ## CI report: * cdfa7ee10822b83e4afcb442dcedb7d53292484f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18737: [FLINK-26077][runtime] Support operators send request to Coordinator and return a response

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18737: URL: https://github.com/apache/flink/pull/18737#issuecomment-1036982251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] deadwind4 commented on a change in pull request #18769: [FLINK-25188][python][build] Support m1 chip.

2022-02-15 Thread GitBox
deadwind4 commented on a change in pull request #18769: URL: https://github.com/apache/flink/pull/18769#discussion_r806589229 ## File path: flink-python/setup.py ## @@ -308,10 +308,10 @@ def extracted_output_files(base_dir, file_path, output_directory):

[GitHub] [flink] flinkbot edited a comment on pull request #18688: [FLINK-26060][table-planner] Remove persisted plan feature support for Python UDFs

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18688: URL: https://github.com/apache/flink/pull/18688#issuecomment-1033917965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18753: [FLINK-25982] Support idleness with watermark alignment

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18753: URL: https://github.com/apache/flink/pull/18753#issuecomment-1039004781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r806086781 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -52,7 +52,18 @@ */ public class

[GitHub] [flink] flinkbot edited a comment on pull request #18687: [FLINK-24169][tests] Add TimeBased rolling policy and delete OnStartupTriggeringPolicy

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18687: URL: https://github.com/apache/flink/pull/18687#issuecomment-1033868741 ## CI report: * ab574e31a308eb750ef411e0e88f04a64b1c9743 UNKNOWN * d6d90b9e85bf0903100443f8dd0d02b30c06addc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18345: WIP:[FLINK-25440][doc] startCurosr only supports publishTime not eventTime

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18345: URL: https://github.com/apache/flink/pull/18345#issuecomment-1011821419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dawidwys commented on pull request #18754: [FLINK-26130][docs] Expanded the reason to increase network buffer si…

2022-02-15 Thread GitBox
dawidwys commented on pull request #18754: URL: https://github.com/apache/flink/pull/18754#issuecomment-1039984431 Could you please update the commit with the correct JIRA ticket ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #18772: [FLINK-25992][Runtime/Coordination, Tests] For stability, wait until the latest restored checkpoint is not null to avoid race condition

2022-02-15 Thread GitBox
flinkbot commented on pull request #18772: URL: https://github.com/apache/flink/pull/18772#issuecomment-1040071363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18735: [FLINK-26079][state/changelog] Disallow recovery from non-changelog checkpoints

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18735: URL: https://github.com/apache/flink/pull/18735#issuecomment-1036580667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #18762: [Flink-26112][k8s]Port getRestEndpoint method to the specific service type subclass

2022-02-15 Thread GitBox
flinkbot commented on pull request #18762: URL: https://github.com/apache/flink/pull/18762#issuecomment-1039235926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18710: [FLINK-26055][table][annotations] Modified CompiledPlan#getFlinkVersion return type to FlinkVersion

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18710: URL: https://github.com/apache/flink/pull/18710#issuecomment-1035062536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zentol commented on a change in pull request #18761: [FLINK-26107][runtime] AdaptiveScheduler: OperatorCoordinator should …

2022-02-15 Thread GitBox
zentol commented on a change in pull request #18761: URL: https://github.com/apache/flink/pull/18761#discussion_r805956575 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraph.java ## @@ -205,6 +218,14 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18681: [FLINK-26032][streaming] check explicit env allowed on StreamExecutionEnvironment own.

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18681: URL: https://github.com/apache/flink/pull/18681#issuecomment-1033535247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] gaoyunhaii closed pull request #18400: [FLINK-25198][docs] Add doc about name and description of operator

2022-02-15 Thread GitBox
gaoyunhaii closed pull request #18400: URL: https://github.com/apache/flink/pull/18400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] rkhachatryan commented on pull request #18735: [FLINK-26079][state/changelog] Disallow recovery from non-changelog checkpoints

2022-02-15 Thread GitBox
rkhachatryan commented on pull request #18735: URL: https://github.com/apache/flink/pull/18735#issuecomment-1040124532 Thanks for the review! I'll sqash the commits and merge the PR after passing the tests. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] Airblader closed pull request #18695: [hotfix][doc] add javadoc for describing ITCASE_USE_MINICLUSTER rule in details

2022-02-15 Thread GitBox
Airblader closed pull request #18695: URL: https://github.com/apache/flink/pull/18695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18777: [FLINK-26016][hive] Fix FileSystemLookupFunction can't build correct cache when reading columnar storage table

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18777: URL: https://github.com/apache/flink/pull/18777#issuecomment-1040128380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806704643 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15

[GitHub] [flink-statefun] tillrohrmann closed pull request #301: [FLINK-25898] Add README.md to statefun-sdk-js

2022-02-15 Thread GitBox
tillrohrmann closed pull request #301: URL: https://github.com/apache/flink-statefun/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

2022-02-15 Thread GitBox
flinkbot edited a comment on pull request #18726: URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] MrWhiteSike commented on pull request #18718: [FLINK-25782] [docs] Translate datastream filesystem.md page into Chi…

2022-02-15 Thread GitBox
MrWhiteSike commented on pull request #18718: URL: https://github.com/apache/flink/pull/18718#issuecomment-1039775185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    1   2   3   4   5   6   7   8   9   10   >