[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #172: [FLINK-29592] Add Estimator and Transformer for RobustScaler

2022-11-10 Thread GitBox
jiangxin369 commented on code in PR #172: URL: https://github.com/apache/flink-ml/pull/172#discussion_r1019967249 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/robustscaler/RobustScaler.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] flinkbot commented on pull request #21292: [FLINK-28617][SQL Gateway] Support stop job statement in SqlGatewayService

2022-11-10 Thread GitBox
flinkbot commented on PR #21292: URL: https://github.com/apache/flink/pull/21292#issuecomment-1311356322 ## CI report: * 908c2e69bfbeac8634915e90e76284cc78908c31 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28617) Support stop job statement in SqlGatewayService

2022-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28617: --- Labels: pull-request-available (was: ) > Support stop job statement in SqlGatewayService >

[GitHub] [flink] link3280 opened a new pull request, #21292: [FLINK-28617][SQL Gateway] Support stop job statement in SqlGatewayService

2022-11-10 Thread GitBox
link3280 opened a new pull request, #21292: URL: https://github.com/apache/flink/pull/21292 ## What is the purpose of the change Support stop job statement in SqlGatewayService. Subtask of FLIP-222. ## Brief change log - *Support stop job statement in

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-10 Thread GitBox
1996fanrui commented on code in PR #21281: URL: https://github.com/apache/flink/pull/21281#discussion_r1019960875 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java: ## @@ -204,7 +204,8 @@ private void checkFailureAgainstCounter(

[GitHub] [flink] flinkbot commented on pull request #21291: [FLINK-29990][sql-parser] Fix unparsed sql for SqlTableLike with no o…

2022-11-10 Thread GitBox
flinkbot commented on PR #21291: URL: https://github.com/apache/flink/pull/21291#issuecomment-1311342999 ## CI report: * 4303e8f4846f2ede7a4baeb477084d4d6e96000c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29990) Unparsed SQL for SqlTableLike cannot be parsed correctly

2022-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29990: --- Labels: pull-request-available (was: ) > Unparsed SQL for SqlTableLike cannot be parsed

[GitHub] [flink] cshuo opened a new pull request, #21291: [FLINK-29990][sql-parser] Fix unparsed sql for SqlTableLike with no o…

2022-11-10 Thread GitBox
cshuo opened a new pull request, #21291: URL: https://github.com/apache/flink/pull/21291 …ptions ## What is the purpose of the change Fix the problem that unparsed sql for SqlTableLike with no options. ## Brief change log - Fix the unparsing logic in

[jira] [Updated] (FLINK-29990) Unparsed SQL for SqlTableLike cannot be parsed correctly

2022-11-10 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated FLINK-29990: --- Description: Consider the following DDL sql (LIKE without any options): {code:java} create table

[jira] [Updated] (FLINK-29990) Unparsed SQL for SqlTableLike cannot be parsed correctly

2022-11-10 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated FLINK-29990: --- Description: Consider the following DDL sql: {code:java} create table source_table(   a int,   b

[jira] [Created] (FLINK-29990) Unparsed SQL for SqlTableLike cannot be parsed correctly

2022-11-10 Thread Shuo Cheng (Jira)
Shuo Cheng created FLINK-29990: -- Summary: Unparsed SQL for SqlTableLike cannot be parsed correctly Key: FLINK-29990 URL: https://issues.apache.org/jira/browse/FLINK-29990 Project: Flink Issue

[GitHub] [flink] tisonkun merged pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
tisonkun merged PR #21252: URL: https://github.com/apache/flink/pull/21252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-29629) FlameGraph is empty for Legacy Source Threads

2022-11-10 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-29629. --- Resolution: Not A Bug > FlameGraph is empty for Legacy Source Threads >

[jira] [Commented] (FLINK-29629) FlameGraph is empty for Legacy Source Threads

2022-11-10 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632111#comment-17632111 ] Zhu Zhu commented on FLINK-29629: - I opened another improvement ticket FLINK-29989 to track the future

[jira] [Created] (FLINK-29989) Enable FlameGraph for arbitrary thread on TaskManager

2022-11-10 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-29989: --- Summary: Enable FlameGraph for arbitrary thread on TaskManager Key: FLINK-29989 URL: https://issues.apache.org/jira/browse/FLINK-29989 Project: Flink Issue Type:

[jira] [Commented] (FLINK-19200) UNIX_TIMESTAMP function support return in millisecond

2022-11-10 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632108#comment-17632108 ] Xuannan Su commented on FLINK-19200: Any update on this issue? I am also looking for a way to

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019822514 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java: ## @@ -180,6 +180,10 @@ public

[GitHub] [flink-table-store] LadyForest commented on pull request #369: [FLINK-29964] Support Spark/Hive with OSS

2022-11-10 Thread GitBox
LadyForest commented on PR #369: URL: https://github.com/apache/flink-table-store/pull/369#issuecomment-1311287152 > Github supports encrypted secrets for repository (https://docs.github.com/en/actions/security-guides/encrypted-secrets). You might still want to talk with access key

[GitHub] [flink] tisonkun commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
tisonkun commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019864714 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java: ## @@ -180,6 +180,10 @@

[GitHub] [flink] Myasuka commented on a diff in pull request #21269: [FLINK-29322] Expose savepoint format on Web UI

2022-11-10 Thread GitBox
Myasuka commented on code in PR #21269: URL: https://github.com/apache/flink/pull/21269#discussion_r1019859208 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatistics.java: ## @@ -390,6 +390,8 @@ public static final class

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019857265 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/function/ControlSource.java: ## @@ -183,37 +191,58 @@ public List

[GitHub] [flink] Myasuka commented on a diff in pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-10 Thread GitBox
Myasuka commented on code in PR #21281: URL: https://github.com/apache/flink/pull/21281#discussion_r1019856735 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java: ## @@ -204,7 +204,8 @@ private void checkFailureAgainstCounter(

[GitHub] [flink] syhily commented on pull request #21249: [FLINK-26027][Connector/Pulsar] Expose Pulsar metrics

2022-11-10 Thread GitBox
syhily commented on PR #21249: URL: https://github.com/apache/flink/pull/21249#issuecomment-1311260266 @tisonkun `PulsarSinkE2ECase` issue should be resolved in [this PR](https://github.com/apache/flink/pull/21252). We can hold this PR. -- This is an automated message from the Apache Git

[GitHub] [flink] saLeox commented on pull request #21149: [FLINK-29527][formats/parquet] Make unknownFieldsIndices work for single ParquetReader

2022-11-10 Thread GitBox
saLeox commented on PR #21149: URL: https://github.com/apache/flink/pull/21149#issuecomment-1311252558 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] saLeox commented on pull request #21149: [FLINK-29527][formats/parquet] Make unknownFieldsIndices work for single ParquetReader

2022-11-10 Thread GitBox
saLeox commented on PR #21149: URL: https://github.com/apache/flink/pull/21149#issuecomment-1311251003 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019826795 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/function/ControlSource.java: ## @@ -183,37 +191,58 @@ public List

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019825570 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/function/ControlSource.java: ## @@ -183,37 +191,58 @@ public List

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019822514 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java: ## @@ -180,6 +180,10 @@ public

[GitHub] [flink] syhily commented on a diff in pull request #21252: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase

2022-11-10 Thread GitBox
syhily commented on code in PR #21252: URL: https://github.com/apache/flink/pull/21252#discussion_r1019821626 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java: ## @@ -180,6 +180,10 @@ public

[jira] [Commented] (FLINK-29934) maven-assembly-plugin 2.4 make assemble plugin could find xml in flink clients module

2022-11-10 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632061#comment-17632061 ] jackylau commented on FLINK-29934: -- hi [~chesnay] what old stuff still around? > maven-assembly-plugin

[jira] [Created] (FLINK-29988) Improve upper case fields for hive metastore

2022-11-10 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-29988: Summary: Improve upper case fields for hive metastore Key: FLINK-29988 URL: https://issues.apache.org/jira/browse/FLINK-29988 Project: Flink Issue Type:

[GitHub] [flink-table-store] LadyForest commented on pull request #373: [FLINK-29983] Fix Table Store with Hive3 lacking hive-standalone-metastore dependency

2022-11-10 Thread GitBox
LadyForest commented on PR #373: URL: https://github.com/apache/flink-table-store/pull/373#issuecomment-1311180702 The reason why E2E does not reveal this issue is due to the hive docker image is based on Hive2 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink-table-store] LadyForest commented on pull request #373: [FLINK-29983] Fix Table Store with Hive3 lacking hive-standalone-metastore dependency

2022-11-10 Thread GitBox
LadyForest commented on PR #373: URL: https://github.com/apache/flink-table-store/pull/373#issuecomment-1311180158 ![image](https://user-images.githubusercontent.com/55568005/201255438-7397b360-e07d-47e6-91bf-fd273f7d67c8.png) -- This is an automated message from the Apache Git

[GitHub] [flink-table-store] LadyForest commented on pull request #373: [FLINK-29983] Fix Table Store with Hive3 lacking hive-standalone-metastore dependency

2022-11-10 Thread GitBox
LadyForest commented on PR #373: URL: https://github.com/apache/flink-table-store/pull/373#issuecomment-1311178286 > Where is the problem? In Flink? Or in Hive? For all use case where `HiveCatalog` engaged 1. `HiveCatalog` depends on `org.apache.hadoop.hive.metastore.api`

[GitHub] [flink-table-store] JingsongLi commented on pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies

2022-11-10 Thread GitBox
JingsongLi commented on PR #372: URL: https://github.com/apache/flink-table-store/pull/372#issuecomment-1311176797 Thanks @Ge for the contribution and @vvcephei for the review. > PartialUpdateITCase.testForeignKeyJo failure seems to be flaky - I reproduced it without this patch.

[jira] [Created] (FLINK-29987) PartialUpdateITCase.testForeignKeyJo is unstable

2022-11-10 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-29987: Summary: PartialUpdateITCase.testForeignKeyJo is unstable Key: FLINK-29987 URL: https://issues.apache.org/jira/browse/FLINK-29987 Project: Flink Issue Type:

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #171: [FLINK-29911] Improve performance of AgglomerativeClustering

2022-11-10 Thread GitBox
yunfengzhou-hub commented on code in PR #171: URL: https://github.com/apache/flink-ml/pull/171#discussion_r1018560327 ## flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/agglomerativeclustering/AgglomerativeClustering.java: ## @@ -75,6 +76,9 @@ * performs the

[jira] [Updated] (FLINK-29983) Table Store with Hive3 profile lacks hive-standalone-metastore dependency

2022-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29983: --- Labels: pull-request-available (was: ) > Table Store with Hive3 profile lacks

[GitHub] [flink-table-store] JingsongLi commented on pull request #373: [FLINK-29983] Fix Table Store with Hive3 lacking hive-standalone-metastore dependency

2022-11-10 Thread GitBox
JingsongLi commented on PR #373: URL: https://github.com/apache/flink-table-store/pull/373#issuecomment-1311172988 Where is the problem? In Flink? Or in Hive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #21290: [FLINK-29980] Handle partition keys directly in hive bulk format

2022-11-10 Thread GitBox
flinkbot commented on PR #21290: URL: https://github.com/apache/flink/pull/21290#issuecomment-1311172016 ## CI report: * 7c9bcf1a3d55ed59f4dbc075b1f1640b58bf01d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29980) Wrap the HiveSource's bulkFormat to handle the partition keys

2022-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29980: --- Labels: pull-request-available (was: ) > Wrap the HiveSource's bulkFormat to handle the

[GitHub] [flink] Aitozi opened a new pull request, #21290: [FLINK-29980] Handle partition keys directly in hive bulk format

2022-11-10 Thread GitBox
Aitozi opened a new pull request, #21290: URL: https://github.com/apache/flink/pull/21290 ## What is the purpose of the change This is meant to leverage the `FileInfoExtractorBulkFormat` to handle partition keys logic in the hive bulk format. After this it will not depend on the

[GitHub] [flink] dingweiqings commented on a diff in pull request #20755: [FLINK-29092][tests] Use base path bucket assigner

2022-11-10 Thread GitBox
dingweiqings commented on code in PR #20755: URL: https://github.com/apache/flink/pull/20755#discussion_r1019785880 ## flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java: ## @@ -82,13 +84,23 @@ public void

[GitHub] [flink] dingweiqings commented on a diff in pull request #20755: [FLINK-29092][tests] Use base path bucket assigner

2022-11-10 Thread GitBox
dingweiqings commented on code in PR #20755: URL: https://github.com/apache/flink/pull/20755#discussion_r1019785021 ## flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java: ## @@ -82,13 +84,23 @@ public void

[GitHub] [flink-table-store] tsreaper commented on pull request #351: [FLINK-28812] Support to read compacted snapshot only

2022-11-10 Thread GitBox
tsreaper commented on PR #351: URL: https://github.com/apache/flink-table-store/pull/351#issuecomment-1311162542 Hi @zjureel , please resolve conflicts with master so that I can continue reviewing. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #369: [FLINK-29964] Support Spark/Hive with OSS

2022-11-10 Thread GitBox
tsreaper commented on code in PR #369: URL: https://github.com/apache/flink-table-store/pull/369#discussion_r1019776118 ## docs/content/docs/filesystem/overview.md: ## @@ -0,0 +1,91 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /filesystem/overview.html +--- +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #357: [FLINK-29922] Support create external table for hive catalog

2022-11-10 Thread GitBox
SteNicholas commented on code in PR #357: URL: https://github.com/apache/flink-table-store/pull/357#discussion_r1019779486 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/TableType.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #357: [FLINK-29922] Support create external table for hive catalog

2022-11-10 Thread GitBox
SteNicholas commented on code in PR #357: URL: https://github.com/apache/flink-table-store/pull/357#discussion_r1019779213 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CatalogOptions.java: ## @@ -49,6 +50,12 @@ private CatalogOptions() {}

[GitHub] [flink] czy006 commented on pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-11-10 Thread GitBox
czy006 commented on PR #21012: URL: https://github.com/apache/flink/pull/21012#issuecomment-1311133140 @zentol PLAT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (FLINK-29986) How to persist flink catalogs configuration?

2022-11-10 Thread Alvin Ge (Jira)
Alvin Ge created FLINK-29986: Summary: How to persist flink catalogs configuration? Key: FLINK-29986 URL: https://issues.apache.org/jira/browse/FLINK-29986 Project: Flink Issue Type: Improvement

[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #431: [hotfix] Prevent release branches from deleted and force pushes

2022-11-10 Thread GitBox
tisonkun commented on PR #431: URL: https://github.com/apache/flink-kubernetes-operator/pull/431#issuecomment-1311065976 Hi @gyfora! Make sense. I ever try to write a pattern `release-*` like how the branch protection allows us to do. But one INFRA member told me that it's not yet

[GitHub] [flink] dchristle commented on pull request #18823: [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27

2022-11-10 Thread GitBox
dchristle commented on PR #18823: URL: https://github.com/apache/flink/pull/18823#issuecomment-1310992993 Hi @RyanSkraba thanks for your work on pushing this connector closer to the finish line! I'm interested in helping to test it out & get it merged. Can you outline what remaining areas

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-10 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1310983666 Hi @snuyanzin Can you re-check this PR once -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] liuml07 commented on pull request #20877: [hotfix] Make doc ide_setup.md format better for code formatting

2022-11-10 Thread GitBox
liuml07 commented on PR #20877: URL: https://github.com/apache/flink/pull/20877#issuecomment-1310789289 I see you also contributed to the doc file, could you merge this @Airblader? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-11-10 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631859#comment-17631859 ] Sriram Ganesh commented on FLINK-29609: --- I made changes in the reconciliation logic and testing.

[jira] [Closed] (FLINK-29919) Support operator leader election

2022-11-10 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29919. -- Resolution: Fixed merged to main 8c0de99fd25d2bbf99ea0742fb6e2607b8799d80 > Support operator leader

[jira] [Updated] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-24119: --- Priority: Critical (was: Blocker) > KafkaITCase.testTimestamps fails due to "Topic xxx

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
gyfora merged PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631840#comment-17631840 ] Martijn Visser commented on FLINK-24119: The following changes have been merged: master:

[jira] [Updated] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-24119: --- Fix Version/s: 1.17.0 1.15.3 > KafkaITCase.testTimestamps fails due to

[GitHub] [flink] MartijnVisser merged pull request #21287: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

2022-11-10 Thread GitBox
MartijnVisser merged PR #21287: URL: https://github.com/apache/flink/pull/21287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] MartijnVisser merged pull request #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

2022-11-10 Thread GitBox
MartijnVisser merged PR #21288: URL: https://github.com/apache/flink/pull/21288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-29985) TaskManager doesn't close SlotTable on SIGTERM

2022-11-10 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631830#comment-17631830 ] Roman Khachatryan commented on FLINK-29985: --- cc: [~mapohl] , [~pnowojski]  > TaskManager

[jira] [Updated] (FLINK-29985) TaskManager doesn't close SlotTable on SIGTERM

2022-11-10 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-29985: -- Description: When TM is stopped by RM, its slot table is closed, causing all its

[jira] [Updated] (FLINK-29985) TaskManager doesn't close SlotTable on SIGTERM

2022-11-10 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-29985: -- Summary: TaskManager doesn't close SlotTable on SIGTERM (was: SlotTable not close on

[jira] [Commented] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-11-10 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631822#comment-17631822 ] Gyula Fora commented on FLINK-29609: [~sriramgr] I would like to take over this ticket unless you

[jira] [Created] (FLINK-29985) SlotTable not close on TM termination

2022-11-10 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-29985: - Summary: SlotTable not close on TM termination Key: FLINK-29985 URL: https://issues.apache.org/jira/browse/FLINK-29985 Project: Flink Issue Type:

[GitHub] [flink] liuml07 commented on pull request #21266: [FLINK-29940] ExecutionGraph logs job state change at ERROR level when job fails

2022-11-10 Thread GitBox
liuml07 commented on PR #21266: URL: https://github.com/apache/flink/pull/21266#issuecomment-1310674376 CC: @rmetzger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #431: [hotfix] Prevent release branches from deleted and force pushes

2022-11-10 Thread GitBox
gyfora commented on PR #431: URL: https://github.com/apache/flink-kubernetes-operator/pull/431#issuecomment-1310663453 Should we add something about this to the release process? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-29936) Make operator more robust to namespaces access errors

2022-11-10 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29936. -- Resolution: Fixed merged to main 03416c345408b0facd9637c0f9efb9ff7514194d > Make operator more

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #435: [FLINK-29936] Add option to ignore informer errors on startup

2022-11-10 Thread GitBox
gyfora merged PR #435: URL: https://github.com/apache/flink-kubernetes-operator/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
gyfora commented on code in PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434#discussion_r1019438277 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorTest.java: ## @@ -74,4 +93,16 @@ public void

[jira] [Commented] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631800#comment-17631800 ] Lim Qing Wei commented on FLINK-29984: -- I am happy to work on this if we agree this is desirable,

[jira] [Updated] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lim Qing Wei updated FLINK-29984: - Affects Version/s: 1.15.2 1.16.0 (was: 1.13.6)

[jira] [Updated] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lim Qing Wei updated FLINK-29984: - Description: Flink Histogram when using the Prometheus Metrics Reporter only produces *

[jira] [Created] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
Lim Qing Wei created FLINK-29984: Summary: Flink Histogram not emitting min and max when using Prometheus Reporter Key: FLINK-29984 URL: https://issues.apache.org/jira/browse/FLINK-29984 Project:

[jira] [Commented] (FLINK-29037) Flink Histogram not emitting sum while using Metrics Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631793#comment-17631793 ] Lim Qing Wei commented on FLINK-29037: -- I had a closer look, and I think sum is not supported

[jira] (FLINK-29037) Flink Histogram not emitting sum while using Metrics Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29037 ] Lim Qing Wei deleted comment on FLINK-29037: -- was (Author: JIRAUSER289353): [~martijnvisser] , I am happy to take a look at this, can you assign this to me? > Flink Histogram not emitting

[jira] [Comment Edited] (FLINK-29037) Flink Histogram not emitting sum while using Metrics Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631773#comment-17631773 ] Lim Qing Wei edited comment on FLINK-29037 at 11/10/22 4:56 PM:

[GitHub] [flink-kubernetes-operator] tagarr commented on pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-10 Thread GitBox
tagarr commented on PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#issuecomment-1310590127 @morhidi I don't think providing an additional config map to use as an override is a solution. OLM already creates a configmap for the config, but there is no way to get

[jira] [Commented] (FLINK-29037) Flink Histogram not emitting sum while using Metrics Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631773#comment-17631773 ] Lim Qing Wei commented on FLINK-29037: -- [~martijnvisser] , I am happy to take a look at this, I

[jira] [Commented] (FLINK-29037) Flink Histogram not emitting sum while using Metrics Reporter

2022-11-10 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631772#comment-17631772 ] Lim Qing Wei commented on FLINK-29037: -- I believe this is still not supported in Flink 1.15 and

[GitHub] [flink-table-store] Gerrrr commented on pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies

2022-11-10 Thread GitBox
Ge commented on PR #372: URL: https://github.com/apache/flink-table-store/pull/372#issuecomment-1310541736 `PartialUpdateITCase.testForeignKeyJo` failure seems to be flaky - I reproduced it without this patch. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-web] Eeeddieee opened a new pull request, #582: Delete duplicated word "from" from usecases.md and usecases.html

2022-11-10 Thread GitBox
Eeeddieee opened a new pull request, #582: URL: https://github.com/apache/flink-web/pull/582 Old sentence: "Often ETL jobs are periodically triggered to copy data from from transactional database systems to an analytical database or a data warehouse" New sentence: "Often ETL jobs

[GitHub] [flink-table-store] LadyForest opened a new pull request, #373: [FLINK-29848] Fix Table Store with Hive3 lacking hive-standalone-metastore dependency

2022-11-10 Thread GitBox
LadyForest opened a new pull request, #373: URL: https://github.com/apache/flink-table-store/pull/373 For Hive3, `org.apache.hadoop.hive.metastore.api` is moved to `org.apache.hive:hive-standalone-metastore`. We should shade this package as well to avoid `ClassNotFoundException` --

[jira] [Updated] (FLINK-29983) Table Store with Hive3 profile lacks hive-standalone-metastore dependency

2022-11-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29983: -- Description: For Hive3,  {{org.apache.hadoop.hive.metastore.api}} is moved to

[jira] [Created] (FLINK-29983) Table Store with Hive3 profile lacks hive-standalone-metastore dependency

2022-11-10 Thread Jane Chan (Jira)
Jane Chan created FLINK-29983: - Summary: Table Store with Hive3 profile lacks hive-standalone-metastore dependency Key: FLINK-29983 URL: https://issues.apache.org/jira/browse/FLINK-29983 Project: Flink

[GitHub] [flink] ericxiao251 commented on pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-10 Thread GitBox
ericxiao251 commented on PR #21077: URL: https://github.com/apache/flink/pull/21077#issuecomment-1310513240 Thank you @gaoyunhaii for your comments! I've applied the changes :). I am trying to understand when one should add the annotation `@PublicEvolving` to their classes and from

[GitHub] [flink] ericxiao251 commented on a diff in pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-10 Thread GitBox
ericxiao251 commented on code in PR #21077: URL: https://github.com/apache/flink/pull/21077#discussion_r1019305987 ## flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/AsyncRetryStrategies.scala: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache

[GitHub] [flink] RyanSkraba commented on a diff in pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

2022-11-10 Thread GitBox
RyanSkraba commented on code in PR #19897: URL: https://github.com/apache/flink/pull/19897#discussion_r1019286172 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java: ## @@ -34,16 +34,16 @@ /** * Test for

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
gyfora commented on code in PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434#discussion_r1019288321 ## pom.xml: ## @@ -69,7 +69,7 @@ under the License. 3.2.0 5.0.0 -4.1.0 +4.1.1 Review Comment: No this is just

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
gyfora commented on code in PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434#discussion_r1019287141 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java: ## @@ -60,6 +62,7 @@ public

[GitHub] [flink] RyanSkraba commented on a diff in pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

2022-11-10 Thread GitBox
RyanSkraba commented on code in PR #19897: URL: https://github.com/apache/flink/pull/19897#discussion_r1019286172 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java: ## @@ -34,16 +34,16 @@ /** * Test for

[GitHub] [flink] RyanSkraba commented on pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

2022-11-10 Thread GitBox
RyanSkraba commented on PR #19897: URL: https://github.com/apache/flink/pull/19897#issuecomment-1310471015 Hello! I missed replying to this last comment -- my strategy for tests that are part of a large (or in this case, **very** large hierarchy) of related, cross-modules tests is to:

[GitHub] [flink] ericxiao251 commented on a diff in pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-10 Thread GitBox
ericxiao251 commented on code in PR #21077: URL: https://github.com/apache/flink/pull/21077#discussion_r1019275792 ## flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/AsyncRetryStrategies.scala: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
gyfora commented on PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434#issuecomment-1310458568 > +1 LGTM overall. Some e2e would be nice. Is this going to be the recommended prod setup or we're not sure yet? I think the recommended setup is without leader

[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies

2022-11-10 Thread GitBox
Ge commented on code in PR #372: URL: https://github.com/apache/flink-table-store/pull/372#discussion_r1019275378 ## flink-table-store-hive/flink-table-store-hive-catalog/pom.xml: ## @@ -86,6 +86,12 @@ under the License. + +

[jira] [Assigned] (FLINK-29982) Move cassandra connector to dedicated repo

2022-11-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-29982: Assignee: Etienne Chauchot > Move cassandra connector to dedicated repo >

[GitHub] [flink] ericxiao251 commented on a diff in pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-10 Thread GitBox
ericxiao251 commented on code in PR #21077: URL: https://github.com/apache/flink/pull/21077#discussion_r1019260307 ## docs/content/docs/dev/datastream/operators/asyncio.md: ## @@ -140,8 +140,8 @@ DataStream> resultStream = // create an async retry strategy via utility class or

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #434: [FLINK-29919] Support operator leader election

2022-11-10 Thread GitBox
morhidi commented on PR #434: URL: https://github.com/apache/flink-kubernetes-operator/pull/434#issuecomment-1310438255 +1 LGTM overall. Some e2e would be nice. Is this going to be the recommended prod setup or we're not sure yet? -- This is an automated message from the Apache Git

  1   2   3   >