[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-09-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764514#comment-17764514 ] Martijn Visser commented on FLINK-31788: Thanks for driving this [~qingyue] > A

[jira] [Closed] (FLINK-33013) Shade flink-connector-base info flink-sql-connector-connector

2023-09-12 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun closed FLINK-33013. -- Resolution: Won't Do > Shade flink-connector-base info flink-sql-connector-connector > ---

[jira] [Commented] (FLINK-33013) Shade flink-connector-base info flink-sql-connector-connector

2023-09-12 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764511#comment-17764511 ] Hang Ruan commented on FLINK-33013: --- Hi,all. I think we should reject this issue and k

[jira] [Commented] (FLINK-33013) Shade flink-connector-base info flink-sql-connector-connector

2023-09-12 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764512#comment-17764512 ] Jiabao Sun commented on FLINK-33013: Thanks [~ruanhang1993], it make sense to me. A

[GitHub] [flink-connector-mongodb] Jiabao-Sun closed pull request #15: [FLINK-33013][connectors/mongodb] Shade flink-connector-base into flink-sql-connector-mongodb

2023-09-12 Thread via GitHub
Jiabao-Sun closed pull request #15: [FLINK-33013][connectors/mongodb] Shade flink-connector-base into flink-sql-connector-mongodb URL: https://github.com/apache/flink-connector-mongodb/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (FLINK-30400) Stop bundling connector-base in externalized connectors

2023-09-12 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764510#comment-17764510 ] Hang Ruan commented on FLINK-30400: --- Hi, all. I would like to help to check. Thanks.

[jira] [Comment Edited] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-09-12 Thread Kwangin (Dennis) Jung (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764503#comment-17764503 ] Kwangin (Dennis) Jung edited comment on FLINK-28758 at 9/13/23 6:33 AM: --

[jira] [Commented] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-09-12 Thread Kwangin (Dennis) Jung (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764503#comment-17764503 ] Kwangin (Dennis) Jung commented on FLINK-28758: --- [~dwysakowicz] [~markcho]

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large in the example

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Description: The gap between the checkpoint timeout and the interval settings is too large in

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large in the example

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Summary: The gap between the checkpoint timeout and the interval settings is too large in the

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
gyfora commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1324028361 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void se

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Description: The gap between the checkpoint timeout and the interval settings is too large So

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Description: The gap between the checkpoint timeout and the interval settings is too large ht

[jira] [Resolved] (FLINK-14032) Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-14032. -- Fix Version/s: 1.19.0 (was: 1.18.0) Resolution: Fixed merged 367

[GitHub] [flink] masteryhx closed pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread via GitHub
masteryhx closed pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable URL: https://github.com/apache/flink/pull/23376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Attachment: image-2023-09-13-14-19-05-493.png > The gap between the checkpoint timeout and the

[jira] [Updated] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large

2023-09-12 Thread Fangliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangliang Liu updated FLINK-33079: -- Attachment: image-2023-09-13-14-17-12-718.png > The gap between the checkpoint timeout and the

[jira] [Created] (FLINK-33079) The gap between the checkpoint timeout and the interval settings is too large

2023-09-12 Thread Fangliang Liu (Jira)
Fangliang Liu created FLINK-33079: - Summary: The gap between the checkpoint timeout and the interval settings is too large Key: FLINK-33079 URL: https://issues.apache.org/jira/browse/FLINK-33079 Proje

[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-12 Thread via GitHub
venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324012808 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/PushFilterIntoTableSourceScanRuleTest.java: ## @@ -86,6 +86,39 @@ p

[GitHub] [flink] zhongqishang closed pull request #20570: [hotfix][docs] Fix typos in java doc

2023-09-12 Thread via GitHub
zhongqishang closed pull request #20570: [hotfix][docs] Fix typos in java doc URL: https://github.com/apache/flink/pull/20570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (FLINK-33064) Improve the error message when the lookup source is used as the scan source

2023-09-12 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-33064: - Assignee: Yunhong Zheng > Improve the error message when the lookup source is used as t

[jira] [Commented] (FLINK-33064) Improve the error message when the lookup source is used as the scan source

2023-09-12 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764498#comment-17764498 ] Shengkai Fang commented on FLINK-33064: --- Merged into master: be509e6d67471d886e58d

[jira] [Closed] (FLINK-33064) Improve the error message when the lookup source is used as the scan source

2023-09-12 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-33064. - Resolution: Fixed > Improve the error message when the lookup source is used as the scan source

[GitHub] [flink] reswqa commented on a diff in pull request #23404: [FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

2023-09-12 Thread via GitHub
reswqa commented on code in PR #23404: URL: https://github.com/apache/flink/pull/23404#discussion_r1324007518 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java: ## @@ -132,35 +132,34 @@ public void testRandomEmitAndBuffe

[jira] [Commented] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-12 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764496#comment-17764496 ] Panagiotis Garefalakis commented on FLINK-33051: Hey [~wangm92]  – I alr

[GitHub] [flink] huwh commented on a diff in pull request #23399: [FLINK-33061][docs] Translate failure-enricher documentation to Chinese

2023-09-12 Thread via GitHub
huwh commented on code in PR #23399: URL: https://github.com/apache/flink/pull/23399#discussion_r1323974700 ## docs/content/docs/deployment/advanced/failure_enrichers.md: ## @@ -42,7 +42,7 @@ To implement a custom FailureEnricher plugin, you need to: Then, create a jar which

[GitHub] [flink] flinkbot commented on pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread via GitHub
flinkbot commented on PR #23406: URL: https://github.com/apache/flink/pull/23406#issuecomment-1716944631 ## CI report: * 291433141e0c930c751c3e990a159b1f1ab9823c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32884: --- Labels: pull-request-available (was: ) > PyFlink remote execution should support URLs with

[GitHub] [flink] elkhand opened a new pull request, #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread via GitHub
elkhand opened a new pull request, #23406: URL: https://github.com/apache/flink/pull/23406 [FLINK-32884](https://issues.apache.org/jira/browse/FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme ## What is the purpose of the change Currently, t

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #15: [FLINK-33013][connectors/mongodb] Shade flink-connector-base into flink-sql-connector-mongodb

2023-09-12 Thread via GitHub
Jiabao-Sun commented on code in PR #15: URL: https://github.com/apache/flink-connector-mongodb/pull/15#discussion_r1323965537 ## flink-sql-connector-mongodb/pom.xml: ## @@ -60,6 +60,10 @@ under the License.

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #15: [FLINK-33013][connectors/mongodb] Shade flink-connector-base into flink-sql-connector-mongodb

2023-09-12 Thread via GitHub
Jiabao-Sun commented on code in PR #15: URL: https://github.com/apache/flink-connector-mongodb/pull/15#discussion_r1323965389 ## flink-sql-connector-mongodb/pom.xml: ## @@ -60,6 +60,10 @@ under the License.

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764484#comment-17764484 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 4:44 AM: --- Le

[jira] [Updated] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32884: Description: Currently, the `SUBMIT_ARGS=remote -m http://:` format. For local execution

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-09-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764485#comment-17764485 ] lincoln lee commented on FLINK-31788: - [~qingyue] assigned to you. > Add back Suppo

[jira] [Assigned] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-09-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-31788: --- Assignee: Jane Chan > Add back Support emitValueWithRetract for TableAggregateFunction > --

[jira] [Commented] (FLINK-33052) codespeed server is down

2023-09-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764484#comment-17764484 ] Yuan Mei commented on FLINK-33052: -- Let me see whether i can get a new machine for this

[jira] [Assigned] (FLINK-33052) codespeed server is down

2023-09-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-33052: Assignee: Yuan Mei (was: Yanfei Lei) > codespeed server is down > > >

[GitHub] [flink] swuferhong commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-12 Thread via GitHub
swuferhong commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1323892173 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -395,9 +397,19 @@ class RexNodeToExpression

[jira] [Resolved] (FLINK-33034) Incorrect StateBackendTestBase#testGetKeysAndNamespaces

2023-09-12 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-33034. -- Fix Version/s: 1.19.0 Resolution: Fixed merged 36b9da50da9405b5b79f0d4da9393921982ab040

[GitHub] [flink] huwh commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded

2023-09-12 Thread via GitHub
huwh commented on code in PR #23386: URL: https://github.com/apache/flink/pull/23386#discussion_r1323944084 ## flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java: ## @@ -109,6 +109,15 @@ public void testGetFailureEnrichers() { ass

[GitHub] [flink] masteryhx closed pull request #23355: [FLINK-33034][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces

2023-09-12 Thread via GitHub
masteryhx closed pull request #23355: [FLINK-33034][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces URL: https://github.com/apache/flink/pull/23355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323925122 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java: ## @@ -478,6 +478,50 @@ public void

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#issuecomment-1716915082 What happens when users overwrite the configuration with standard memory parameters? Could you please handle these cases and cover with tests? -- This is an automated m

[jira] [Updated] (FLINK-23411) Expose Flink checkpoint details metrics

2023-09-12 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-23411: - Component/s: Runtime / Checkpointing > Expose Flink checkpoint details metrics > ---

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323925122 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java: ## @@ -478,6 +478,50 @@ public void

[jira] [Commented] (FLINK-23411) Expose Flink checkpoint details metrics

2023-09-12 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764477#comment-17764477 ] Hangxiang Yu commented on FLINK-23411: -- Thanks for the quick reply. {quote}Anyway,

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#issuecomment-1716912377 The last column looks good to me, we're not failing on any previous values which is important for backward compatibility reasons. I'm leaning towards accepting the correc

[jira] [Updated] (FLINK-33013) Shade flink-connector-base info flink-sql-connector-connector

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33013: --- Labels: pull-request-available (was: ) > Shade flink-connector-base info flink-sql-connecto

[GitHub] [flink-connector-mongodb] ruanhang1993 commented on a diff in pull request #15: [FLINK-33013][connectors/mongodb] Shade flink-connector-base into flink-sql-connector-mongodb

2023-09-12 Thread via GitHub
ruanhang1993 commented on code in PR #15: URL: https://github.com/apache/flink-connector-mongodb/pull/15#discussion_r1323913992 ## flink-sql-connector-mongodb/pom.xml: ## @@ -60,6 +60,10 @@ under the License.

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #23404: [FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

2023-09-12 Thread via GitHub
TanYuxin-tyx commented on code in PR #23404: URL: https://github.com/apache/flink/pull/23404#discussion_r1323910378 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java: ## @@ -132,35 +132,34 @@ public void testRandomEmitAn

[jira] [Comment Edited] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-09-12 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764475#comment-17764475 ] Jane Chan edited comment on FLINK-31788 at 9/13/23 3:49 AM:

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-09-12 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764475#comment-17764475 ] Jane Chan commented on FLINK-31788: --- Hi, according to the discussion, we're one the co

[jira] [Commented] (FLINK-33065) Optimize the exception message when the program plan could not be fetched

2023-09-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764472#comment-17764472 ] Rui Fan commented on FLINK-33065: - Merged via d5b2cdb618cd7a50818d7eaa575c0fac6aaeac9a

[jira] [Resolved] (FLINK-33065) Optimize the exception message when the program plan could not be fetched

2023-09-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33065. - Fix Version/s: 1.19.0 Resolution: Fixed > Optimize the exception message when the program plan co

[jira] [Commented] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-12 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764473#comment-17764473 ] Matt Wang commented on FLINK-33051: --- [~pgaref] Have you started this tricket? If you a

[GitHub] [flink] flinkbot commented on pull request #23405: [FLINK-31895] Add End-to-end integration tests for failure labels

2023-09-12 Thread via GitHub
flinkbot commented on PR #23405: URL: https://github.com/apache/flink/pull/23405#issuecomment-1716894944 ## CI report: * 6ec84c4729ced192747cff0778d42fa69dc68a39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] wangzzu commented on pull request #23405: [FLINK-31895] Add End-to-end integration tests for failure labels

2023-09-12 Thread via GitHub
wangzzu commented on PR #23405: URL: https://github.com/apache/flink/pull/23405#issuecomment-1716892702 @huwh @pgaref when you have time, help me review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-31895) End-to-end integration tests for failure labels

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31895: --- Labels: pull-request-available (was: ) > End-to-end integration tests for failure labels >

[GitHub] [flink] wangzzu opened a new pull request, #23405: [FLINK-31895] Add End-to-end integration tests for failure labels

2023-09-12 Thread via GitHub
wangzzu opened a new pull request, #23405: URL: https://github.com/apache/flink/pull/23405 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Commented] (FLINK-32863) Improve Flink UI's time precision from second level to millisecond level

2023-09-12 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764464#comment-17764464 ] Jufang He commented on FLINK-32863: --- Hi [~guoyangze], I have created a PR([https://gi

[GitHub] [flink] masteryhx commented on a diff in pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state

2023-09-12 Thread via GitHub
masteryhx commented on code in PR #14611: URL: https://github.com/apache/flink/pull/14611#discussion_r1323873654 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java: ## @@ -30,6 +30,11 @@ /** * A keyed state backend provides methods for managi

[GitHub] [flink] flinkbot commented on pull request #23404: [FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

2023-09-12 Thread via GitHub
flinkbot commented on PR #23404: URL: https://github.com/apache/flink/pull/23404#issuecomment-1716849649 ## CI report: * ae67b21f40ba17fb643acd1e5a410e37562e7119 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33076) broadcastEmit of ChannelSelectorRecordWriter should reuse the serialized record

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33076: --- Labels: pull-request-available (was: ) > broadcastEmit of ChannelSelectorRecordWriter shoul

[GitHub] [flink] reswqa opened a new pull request, #23404: [FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

2023-09-12 Thread via GitHub
reswqa opened a new pull request, #23404: URL: https://github.com/apache/flink/pull/23404 ## What is the purpose of the change *ChannelSelectorRecordWriter#broadcastEmit serialize the record to ByteBuffer but didn't use it. It will re-serialize this record per-channel. We should allo

[jira] [Commented] (FLINK-33066) Enable to inject environment variable from secret/configmap to operatorPod

2023-09-12 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764455#comment-17764455 ] dongwoo.kim commented on FLINK-33066: - Thanks [~gyfora], I have opened the pr :) >

[jira] [Updated] (FLINK-33066) Enable to inject environment variable from secret/configmap to operatorPod

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33066: --- Labels: pull-request-available (was: ) > Enable to inject environment variable from secret/

[GitHub] [flink-kubernetes-operator] dongwoo6kim opened a new pull request, #671: [FLINK-33066] Support all k8s methods to configure env variable in operatorPod

2023-09-12 Thread via GitHub
dongwoo6kim opened a new pull request, #671: URL: https://github.com/apache/flink-kubernetes-operator/pull/671 ## What is the purpose of the change To enhance Helm chart by adding full support for setting environment variables in values.yaml, including valueFrom and envFrom option

[GitHub] [flink] dalelane commented on pull request #23395: [FLINK-33058][formats] Add encoding option to Avro format

2023-09-12 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1716773854 Apologies for the flurry of follow-on commits - this is my first contribution to Flink so I'd missed the checkstyle and spotless rules when testing locally. I think it's ready to

[GitHub] [flink] architgyl commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-12 Thread via GitHub
architgyl commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1323745882 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java: ## @@ -143,6 +165,22 @@ private static Map getLibJars() { return libJ

[GitHub] [flink] venkata91 commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-12 Thread via GitHub
venkata91 commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1323679045 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java: ## @@ -143,6 +165,22 @@ private static Map getLibJars() { return libJ

[GitHub] [flink-kubernetes-operator] srpraneeth commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
srpraneeth commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323676402 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private voi

[jira] [Updated] (FLINK-33018) GCP Pubsub PubSubConsumingTest.testStoppingConnectorWhenDeserializationSchemaIndicatesEndOfStream failed

2023-09-12 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-33018: --- Labels: pull-request-available stale-blocker (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-30774) Introduce flink-utils module

2023-09-12 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-30774: --- Labels: auto-deprioritized-major starter (was: stale-major starter) Priority: Minor (

[jira] [Updated] (FLINK-32564) Support cast from BYTES to NUMBER

2023-09-12 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32564: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-09-12 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31689: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[GitHub] [flink-kubernetes-operator] srpraneeth commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
srpraneeth commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323659448 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java: ## @@ -478,6 +478,50 @@ public v

[GitHub] [flink] architgyl commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-12 Thread via GitHub
architgyl commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1323653567 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java: ## @@ -360,11 +362,27 @@ List registerProvidedLocalResources() {

[jira] [Updated] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32884: Fix Version/s: 1.19.0 > PyFlink remote execution should support URLs with paths and https

[jira] [Updated] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32884: Description: Currently, the `SUBMIT_ARGS=remote -m http://:` format. For local execution

[jira] [Closed] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov closed FLINK-32885. --- > Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used > by RestClusterC

[jira] [Resolved] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov resolved FLINK-32885. - Resolution: Fixed > Refactoring: Moving UrlPrefixDecorator into flink-clients so it can

[GitHub] [flink] tweise merged pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote e

2023-09-12 Thread via GitHub
tweise merged PR #23383: URL: https://github.com/apache/flink/pull/23383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Created] (FLINK-33078) Enhance ParameterTool to support múltiple environments

2023-09-12 Thread Oscar Perez (Jira)
Oscar Perez created FLINK-33078: --- Summary: Enhance ParameterTool to support múltiple environments Key: FLINK-33078 URL: https://issues.apache.org/jira/browse/FLINK-33078 Project: Flink Issue Ty

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323483540 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323483540 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323483540 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
gyfora commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323424948 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void se

[jira] [Updated] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32885: Fix Version/s: 1.19.0 Description: UrlPrefixDecorator is introduced in `flink-sql-ga

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323381133 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#issuecomment-1716182195 Thanks for contributing @srpraneeth. Could you please update the PR and help understand the goal here with specific examples CR examples? -- This is an automated messag

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323382871 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java: ## @@ -478,6 +478,50 @@ public void

[GitHub] [flink] venkata91 commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-12 Thread via GitHub
venkata91 commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1323383321 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java: ## @@ -360,11 +362,27 @@ List registerProvidedLocalResources() {

[jira] [Comment Edited] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai edited comment on FLINK-33017 at 9/12/23 5:55 PM:

[jira] [Comment Edited] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai edited comment on FLINK-33017 at 9/12/23 5:55 PM:

[jira] [Commented] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai commented on FLINK-33017: - Lets only resolve this ticket

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323381133 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[jira] [Commented] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764320#comment-17764320 ] Tzu-Li (Gordon) Tai commented on FLINK-33017: - Fixed via: apache/flink-conne

[jira] [Updated] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-33017: Fix Version/s: kafka-3.0.1 kafka-3.1.0 > Nightly run for Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323380347 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void s

[jira] [Assigned] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-33017: --- Assignee: Alex Sorokoumov > Nightly run for Flink Kafka connector fails > -

  1   2   >