Re: [PR] [hotfix][autoscaler] Fix the StandaloneAutoscalerExecutorTest.testScaling fails occasionally due to race condition [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
1996fanrui merged PR #746: URL: https://github.com/apache/flink-kubernetes-operator/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #23977: URL: https://github.com/apache/flink/pull/23977#discussion_r1441442856 ## flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java: ## @@ -127,6 +129,11 @@ private void runHandleJobsWhenNotEnoughSlots(final Jo

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802610#comment-17802610 ] xuyang commented on FLINK-33490: Hi, [~martijnvisser] and [~fsk119] . Thank you for your

[jira] [Updated] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33009: -- Description: According to [Flink's API compatibility constraints|https://nightlies.apache.org/

[jira] [Assigned] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33009: - Assignee: Wencong Liu > tools/release/update_japicmp_configuration.sh should only enabl

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441443240 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441484531 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802731#comment-17802731 ] Matthias Pohl commented on FLINK-33009: --- Go ahead. I assigned the issue to you. As

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1441489844 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,23 @@ private static double getNumReco

[PR] [FLINK-33009][release] Disable binary compatibility check in master branch and only enable it in the release branch [flink]

2024-01-04 Thread via GitHub
WencongLiu opened a new pull request, #24027: URL: https://github.com/apache/flink/pull/24027 ## What is the purpose of the change *Disable binary compatibility check in master branch and only enable it in the release branch.* ## Does this pull request potentially affect one of

[jira] [Updated] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33009: --- Labels: pull-request-available (was: ) > tools/release/update_japicmp_configuration.sh shou

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441516846 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/datasource/transactions/xa/XaTransaction.java: ## @@ -0,0 +1,295 @@ +package org.apache.

Re: [PR] [FLINK-33009][release] Disable binary compatibility check in master branch and only enable it in the release branch [flink]

2024-01-04 Thread via GitHub
flinkbot commented on PR #24027: URL: https://github.com/apache/flink/pull/24027#issuecomment-1876766234 ## CI report: * e634566487438269e995514720d36fbc58ad5a2c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33009][release] Disable binary compatibility check in master branch and only enable it in the release branch [flink]

2024-01-04 Thread via GitHub
WencongLiu commented on PR #24027: URL: https://github.com/apache/flink/pull/24027#issuecomment-1876767318 I've tested the modified `update_japicmp_configuration` and it could work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441520106 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441520406 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1876772728 @RocMarshal thanks for the review.. the 3 commits are there to allow to review each semantic separately (I thing its easy), we could squash all in one after finishing the review

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
1996fanrui merged PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802829#comment-17802829 ] Rui Fan commented on FLINK-33966: - Merged to main(1.8.0) via 456fb6e9a816d7f4bebdceb5fca

[jira] [Resolved] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33966. - Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed > Fix the getNumRecordsInPerSecond Uti

[jira] [Created] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread RocMarshal (Jira)
RocMarshal created FLINK-33988: -- Summary: Invalid configuration when using initialized root logger level on yarn application mode Key: FLINK-33988 URL: https://issues.apache.org/jira/browse/FLINK-33988 P

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33988: --- Description: from https://issues.apache.org/jira/browse/FLINK-33166 > Invalid configuration when usi

[jira] [Assigned] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33988: --- Assignee: RocMarshal > Invalid configuration when using initialized root logger level on yarn > ap

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33988: --- Description: from https://issues.apache.org/jira/browse/FLINK-33166 When I set env. log. level=DE

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33988: --- Description: from https://issues.apache.org/jira/browse/FLINK-33166 When I set env. log. level=DEBU

[jira] [Updated] (FLINK-33166) Support setting root logger level by config

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33166: Fix Version/s: 1.19.0 > Support setting root logger level by config >

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33988: Affects Version/s: 1.19.0 (was: 1.18.0) (was: 1.17.2)

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33988: Fix Version/s: 1.19.0 > Invalid configuration when using initialized root logger level on yarn > applicat

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33988: Priority: Major (was: Minor) > Invalid configuration when using initialized root logger level on yarn >

[jira] [Updated] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-04 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33988: --- Description: relevant https://issues.apache.org/jira/browse/FLINK-33166 When I set env. log. level=

Re: [PR] [FLINK-30535] Introduce TTL state based benchmarks [flink-benchmarks]

2024-01-04 Thread via GitHub
Myasuka merged PR #83: URL: https://github.com/apache/flink-benchmarks/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Updated] (FLINK-33977) Adaptive scheduler may not minimize the number of TMs during downscaling

2024-01-04 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33977: -- Component/s: Autoscaler > Adaptive scheduler may not minimize the number of TMs during downsca

Re: [PR] [hotfix][docs] Add the -am when generate the docs [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
1996fanrui merged PR #747: URL: https://github.com/apache/flink-kubernetes-operator/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Created] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone in Kafka

2024-01-04 Thread Flaviu Cicio (Jira)
Flaviu Cicio created FLINK-33989: Summary: Insert Statement With Filter Operation Generates Extra Tombstone in Kafka Key: FLINK-33989 URL: https://issues.apache.org/jira/browse/FLINK-33989 Project: Fl

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441676954 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -86,9 +88,10 @@ public class CheckpointStatsTracker { pri

[jira] [Created] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Dan Zou (Jira)
Dan Zou created FLINK-33990: --- Summary: Use default classloader in TaskManager when there are no user jars for job Key: FLINK-33990 URL: https://issues.apache.org/jira/browse/FLINK-33990 Project: Flink

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441683484 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -155,7 +167,12 @@ public CheckpointStatsSnapshot createSnapshot(

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441707237 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -343,6 +376,62 @@ public void reportIncompleteStats( }

[jira] [Updated] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33990: --- Description: TaskManager will create a new class loader for each flink job even when it has no user

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441710885 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -343,6 +376,62 @@ public void reportIncompleteStats( }

[jira] [Assigned] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33990: -- Assignee: Dan Zou > Use default classloader in TaskManager when there are no user jars for jo

[jira] [Assigned] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33990: -- Assignee: Dan Zou (was: Dan Zou) > Use default classloader in TaskManager when there are no

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
rkhachatryan commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441711155 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java: ## @@ -159,6 +160,11 @@ public ExecutionGraph createAndRestore

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803150#comment-17803150 ] Zhongqiang Gong commented on FLINK-33970: - [~tison] I also want to add this chec

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441711709 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -730,57 +739,87 @@ void restoreInternal() throws Exception {

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803156#comment-17803156 ] Benchao Li commented on FLINK-33611: [~dsaisharath] Thanks for the explanation, it h

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441722684 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration fixedDela

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-jdbc]

2024-01-04 Thread via GitHub
GOODBOY008 commented on PR #88: URL: https://github.com/apache/flink-connector-jdbc/pull/88#issuecomment-1877064388 @MartijnVisser Please take a look, Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Summary: Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Con

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803150#comment-17803150 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/4/24 1:13 PM: -

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Component/s: Connectors / Kafka > Insert Statement With Filter Operation Generates Extra Tombsto

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33072) Implement end-to-end tests for AWS Kinesis Connectors

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33072: -- Component/s: Connectors / Kinesis > Implement end-to-end tests for AWS Kinesis Connectors > --

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

Re: [PR] [FLINK-33560][Connectors/AWS] Externalize AWS Python connectors from Flink to AWS project [flink-connector-aws]

2024-01-04 Thread via GitHub
dannycranmer merged PR #121: URL: https://github.com/apache/flink-connector-aws/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Created] (FLINK-33991) Custom Error Handling for Kinesis Polling Consumer

2024-01-04 Thread Emre Kartoglu (Jira)
Emre Kartoglu created FLINK-33991: - Summary: Custom Error Handling for Kinesis Polling Consumer Key: FLINK-33991 URL: https://issues.apache.org/jira/browse/FLINK-33991 Project: Flink Issue T

[jira] [Commented] (FLINK-33560) Externalize Kinesis Python connector code

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803166#comment-17803166 ] Danny Cranmer commented on FLINK-33560: --- Merged commit [{{b7f2e26}}|https://githu

[jira] [Resolved] (FLINK-33560) Externalize Kinesis Python connector code

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-33560. --- Resolution: Fixed > Externalize Kinesis Python connector code >

[jira] [Commented] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2024-01-04 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803167#comment-17803167 ] Emre Kartoglu commented on FLINK-33260: --- We can resolve this in favour of https:/

[jira] [Updated] (FLINK-33991) Custom Error Handling for Kinesis Polling Consumer

2024-01-04 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu updated FLINK-33991: -- Fix Version/s: aws-connector-4.3.0 > Custom Error Handling for Kinesis Polling Consumer > ---

[jira] [Updated] (FLINK-33991) Custom Error Handling for Kinesis Polling Consumer

2024-01-04 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu updated FLINK-33991: -- Description: We introduced custom error handling for the Kinesis EFO Consumer as part of http

[jira] [Updated] (FLINK-33991) Custom Error Handling for Kinesis Polling Consumer

2024-01-04 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu updated FLINK-33991: -- Description: We introduced custom error handling for the Kinesis EFO Consumer as part of http

[jira] [Updated] (FLINK-33260) Custom Error Handling for Kinesis EFO Consumer

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33260: -- Summary: Custom Error Handling for Kinesis EFO Consumer (was: Custom Error Handling for Kines

[jira] [Assigned] (FLINK-33991) Custom Error Handling for Kinesis Polling Consumer

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-33991: - Assignee: Emre Kartoglu > Custom Error Handling for Kinesis Polling Consumer > ---

[jira] [Resolved] (FLINK-33260) Custom Error Handling for Kinesis EFO Consumer

2024-01-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-33260. --- Resolution: Fixed > Custom Error Handling for Kinesis EFO Consumer > ---

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

[jira] [Updated] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-01-04 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flaviu Cicio updated FLINK-33989: - Description: Given the following Flink SQL tables: {code:sql} CREATE TABLE input (   id STRING N

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441782436 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java: ## @@ -159,6 +160,11 @@ public ExecutionGraph createAndRestoreExe

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803176#comment-17803176 ] Piotr Nowojski commented on FLINK-27756: https://dev.azure.com/apache-flink/apac

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441683484 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -155,7 +167,12 @@ public CheckpointStatsSnapshot createSnapshot(

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #24023: URL: https://github.com/apache/flink/pull/24023#discussion_r1441789636 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackendParametersImpl.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-04 Thread via GitHub
pnowojski commented on PR #24023: URL: https://github.com/apache/flink/pull/24023#issuecomment-1877155133 Thanks for the review! > Why only add the download metric? While you are at this, you could have also simply added metrics for, e.g., merge/clip. That was the scope of the

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803179#comment-17803179 ] Martijn Visser commented on FLINK-33970: This shouldn't be fixed per connector,

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803181#comment-17803181 ] Martijn Visser commented on FLINK-33970: Next to this, I believe this only fixes

[jira] [Updated] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33897: --- Issue Type: New Feature (was: Improvement) > Allow triggering unaligned checkpoint via CLI

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803185#comment-17803185 ] Piotr Nowojski commented on FLINK-33897: I have mixed feelings. Shouldn't the so

[jira] [Created] (FLINK-33992) Add option to fetch the jar from private repository in FlinkSessionJob

2024-01-04 Thread Sweta Kalakuntla (Jira)
Sweta Kalakuntla created FLINK-33992: Summary: Add option to fetch the jar from private repository in FlinkSessionJob Key: FLINK-33992 URL: https://issues.apache.org/jira/browse/FLINK-33992 Projec

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803187#comment-17803187 ] Martijn Visser commented on FLINK-33490: Sounds good to me, thank you! > Valid

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
rkhachatryan commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441837132 ## docs/content/docs/ops/traces.md: ## @@ -97,7 +97,7 @@ Flink reports a single span trace for the whole checkpoint once checkpoint reach - org

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803196#comment-17803196 ] Zhongqiang Gong commented on FLINK-33970: - [~martijnvisser] I had tried to use h

Re: [PR] [FLINK-24379][Formats] Avro Glue Schema Registry table format [flink-connector-aws]

2024-01-04 Thread via GitHub
nicusX commented on PR #122: URL: https://github.com/apache/flink-connector-aws/pull/122#issuecomment-1877217949 @dannycranmer please review this PR when you have the chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-04 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-1877219219 @hlteoh37 @dannycranmer please review this PR when you have the chance, so we can proceed with the other related tasks -- This is an automated message from the Apache Git S

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803201#comment-17803201 ] Piotr Nowojski commented on FLINK-33856: Hi, I second that implementing this as

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803201#comment-17803201 ] Piotr Nowojski edited comment on FLINK-33856 at 1/4/24 3:00 PM: --

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803203#comment-17803203 ] Zhongqiang Gong commented on FLINK-33970: - [~martijnvisser] And I checked my pr

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441914909 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration fixedDela

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441915244 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -810,7 +811,8 @@ public RestartStrategies.RestartS

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441916069 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -53,13 +54,14 @@ public class StateTtlConfig implements Serializable { priva

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1877310802 Thanks for picking this up. We should merge FLINK-32570 soon'ish to not miss it for 1.19. I reiterated over the PR once more with the following changes: * I rebased the branch to m

[jira] [Created] (FLINK-33993) Ineffective scaling detection events are misleading

2024-01-04 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33993: -- Summary: Ineffective scaling detection events are misleading Key: FLINK-33993 URL: https://issues.apache.org/jira/browse/FLINK-33993 Project: Flink

[jira] [Updated] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33932: --- Description: Rocksdb uploader will throw exception and decline the current checkpoint if th

[jira] [Updated] (FLINK-33993) Ineffective scaling detection events are misleading

2024-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33993: --- Labels: pull-request-available (was: ) > Ineffective scaling detection events are misleadin

[jira] [Commented] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803237#comment-17803237 ] Piotr Nowojski commented on FLINK-33932: Yes, I don't think this should cause a

Re: [PR] [FLINK-33932][checkpointing] Add retry mechanism in RocksDBStateUploader [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23986: URL: https://github.com/apache/flink/pull/23986#discussion_r1441986930 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateUploader.java: ## @@ -107,13 +122,43 @@ private

  1   2   >