[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-01-26 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811156#comment-17811156 ] Mason Chen commented on FLINK-33545: I do think this issue here is not with the Flin

Re: [PR] [FLINK-34087][tests][JUnit5 Migration] Migarate to junit5 of flink-dist module [flink]

2024-01-26 Thread via GitHub
Jiabao-Sun closed pull request #24092: [FLINK-34087][tests][JUnit5 Migration] Migarate to junit5 of flink-dist module URL: https://github.com/apache/flink/pull/24092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (FLINK-34087) [JUnit5 Migration] Module: flink-dist

2024-01-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-34087. Resolution: Duplicate Resolved by FLIK-33577 > [JUnit5 Migration] Module: flink-dist > --

[jira] [Comment Edited] (FLINK-34087) [JUnit5 Migration] Module: flink-dist

2024-01-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811158#comment-17811158 ] Jiabao Sun edited comment on FLINK-34087 at 1/26/24 8:10 AM: -

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811160#comment-17811160 ] Martijn Visser commented on FLINK-34237: [~leonard] I know, I just wanted to hig

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

2024-01-26 Thread via GitHub
Jiabao-Sun commented on code in PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#discussion_r1467341955 ## pom.xml: ## @@ -339,6 +339,13 @@ under the License. 2.1 + +

Re: [PR] [FLINK-34225][runtime] Fix bugs in input channel multiplexing logic [flink]

2024-01-26 Thread via GitHub
yunfengzhou-hub commented on PR #24151: URL: https://github.com/apache/flink/pull/24151#issuecomment-1911659275 Hi @reswqa could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Updated] (FLINK-34225) HybridShuffleITCase.testHybridSelectiveExchangesRestart failed due to NullPointerException

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34225: --- Labels: github-actions pull-request-available test-stability (was: github-actions test-stab

[jira] [Updated] (FLINK-31953) FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31953: --- Release Note: In kafka-3.1.0, we enable partition discovery by default and set EARLIEST offs

[jira] [Updated] (FLINK-31953) FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31953: --- Fix Version/s: kafka-3.1.0 (was: kafka-4.0.0) > FLIP-288: Enable Dyna

[jira] [Updated] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-25509: --- Fix Version/s: kafka-4.0.0 > FLIP-208: Add RecordEvaluator to dynamically stop source based

[jira] [Updated] (FLINK-32020) Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32020: --- Fix Version/s: kafka-3.1.0 (was: kafka-4.0.0) > Enable Dynamic Partit

[jira] [Updated] (FLINK-32021) Improvement the Javadoc for SpecifiedOffsetsInitializer and TimestampOffsetsInitializer.

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32021: --- Fix Version/s: kafka-3.1.0 (was: kafka-4.0.0) > Improvement the Javad

[jira] [Updated] (FLINK-32019) EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32019: --- Fix Version/s: kafka-3.1.0 (was: kafka-4.0.0) > EARLIEST offset strat

Re: [PR] [FLINK-34225][runtime] Fix bugs in input channel multiplexing logic [flink]

2024-01-26 Thread via GitHub
reswqa commented on code in PR #24151: URL: https://github.com/apache/flink/pull/24151#discussion_r1467354290 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/UnionResultSubpartitionView.java: ## @@ -71,18 +73,35 @@ public class UnionResultSubpartitio

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-26 Thread via GitHub
reswqa commented on PR #24187: URL: https://github.com/apache/flink/pull/24187#issuecomment-1911677206 Thanks for the review. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-26 Thread via GitHub
reswqa merged PR #24187: URL: https://github.com/apache/flink/pull/24187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34204: --- Fix Version/s: 1.19.0 > Dispatch legacy serializer related methods in ExecutionConfig to > Serializ

[jira] [Updated] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34204: --- Component/s: API / Type Serialization System > Dispatch legacy serializer related methods in Executi

[jira] [Updated] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34204: --- Description: Since we already support set serializer related things via config options, we need to d

[jira] [Closed] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34204. -- Resolution: Done master(1.19) via 8d5071984a8543a81574dc69c0c9849a8a4a > Dispatch legacy serializ

[jira] [Assigned] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-34204: -- Assignee: Weijie Guo > Dispatch legacy serializer related methods in ExecutionConfig to > Se

[jira] [Assigned] (FLINK-34217) Update Serialization-related doc with the new way of configuration

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-34217: -- Assignee: Zhanghao Chen > Update Serialization-related doc with the new way of configuration

[jira] [Assigned] (FLINK-34122) Deprecate old serialization config methods and options

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-34122: -- Assignee: Zhanghao Chen (was: Weijie Guo) > Deprecate old serialization config methods and o

[jira] [Updated] (FLINK-34122) Deprecate old serialization config methods and options

2024-01-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34122: --- Fix Version/s: 1.19.0 > Deprecate old serialization config methods and options > ---

[jira] [Commented] (FLINK-34129) MiniBatchGlobalGroupAggFunction will make -D as +I then make +I as -U when state expired

2024-01-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811167#comment-17811167 ] xuyang commented on FLINK-34129: If the upstream CDC data is incomplete, such as receivi

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811170#comment-17811170 ] Leonard Xu commented on FLINK-34237: [~martijnvisser] Got you. Btw, I think external

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811171#comment-17811171 ] Martijn Visser commented on FLINK-34237: [~leonard] I think that makes sense. In

Re: [PR] [FLINK-34228] Add long UTF serializer/deserializer [flink]

2024-01-26 Thread via GitHub
pvary commented on PR #24191: URL: https://github.com/apache/flink/pull/24191#issuecomment-1911704026 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467385245 ## .github/workflows/ci.yml: ## @@ -49,8 +50,18 @@ jobs: -Plicense-check \ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }} + mvn ${MVN

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811178#comment-17811178 ] Leonard Xu commented on FLINK-34237: +1 to record this to release wiki docs, I'll cr

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-26 Thread via GitHub
swuferhong commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1467388040 ## docs/content.zh/docs/dev/table/sql/queries/hints.md: ## @@ -108,6 +108,39 @@ hintOption: | stringLiteral ``` +### 查询提示使用中的冲突 + Key-value 类型查询提示的冲突处理

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-26 Thread via GitHub
swuferhong commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1467389305 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -114,6 +114,42 @@ hintOption: | stringLiteral ``` +### Conflict Cases In Query Hints + Resol

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467389710 ## .github/workflows/ci.yml: ## @@ -49,8 +50,18 @@ jobs: -Plicense-check \ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }} + mvn ${MVN

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #136: URL: https://github.com/apache/flink-shaded/pull/136#issuecomment-1911714197 rebased since have to extract license related update into a separate commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-34241) Transfer external connectors's CI result to Flink Slack #builds channel

2024-01-26 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-34241: -- Summary: Transfer external connectors's CI result to Flink Slack #builds channel Key: FLINK-34241 URL: https://issues.apache.org/jira/browse/FLINK-34241 Project: Flink

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-26 Thread via GitHub
swuferhong commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1467393456 ## docs/content.zh/docs/dev/table/sql/queries/hints.md: ## @@ -108,6 +108,39 @@ hintOption: | stringLiteral ``` +### 查询提示使用中的冲突 + Key-value 类型查询提示的冲突处理

[jira] [Commented] (FLINK-34238) In streaming mode, redundant exchange nodes can be optimally deleted in some cases

2024-01-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811180#comment-17811180 ] Benchao Li commented on FLINK-34238: Make sense to me. Another general way is to let

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

2024-01-26 Thread via GitHub
Jiabao-Sun commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1911718884 CI passes locally https://github.com/Jiabao-Sun/flink-connector-elasticsearch/actions/runs/7665812325/job/20892471652. @MartijnVisser please help take a look. Than

Re: [PR] [FLINK-34225][runtime] Fix bugs in input channel multiplexing logic [flink]

2024-01-26 Thread via GitHub
TanYuxin-tyx commented on code in PR #24151: URL: https://github.com/apache/flink/pull/24151#discussion_r1467398883 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/UnionResultSubpartitionView.java: ## @@ -71,18 +73,35 @@ public class UnionResultSubpa

Re: [PR] [FLINK-34225][runtime] Fix bugs in input channel multiplexing logic [flink]

2024-01-26 Thread via GitHub
TanYuxin-tyx commented on PR #24151: URL: https://github.com/apache/flink/pull/24151#issuecomment-1911725587 @yunfengzhou-hub Thanks for the fix. I left some minor comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (FLINK-34242) External connector should bump its flink version timely after a new flink release

2024-01-26 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-34242: -- Summary: External connector should bump its flink version timely after a new flink release Key: FLINK-34242 URL: https://issues.apache.org/jira/browse/FLINK-34242 Proje

Re: [PR] [FLINK-32142][build][flink-runtime-web] Upgrade frontend-maven-plugin... [flink]

2024-01-26 Thread via GitHub
hlteoh37 commented on PR #22614: URL: https://github.com/apache/flink/pull/22614#issuecomment-1911735572 @elphastori Thanks for the contribution - have we done any form of validation in the final artifact produced to verify the plugin works the same way in the new version? Overall

[jira] [Updated] (FLINK-34241) Transfer external connectors's CI result to Flink Slack #builds channel

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-34241: --- Description: As we discussed in FLINK-34237, we could timely found some blocker issue by monitoring

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2024-01-26 Thread via GitHub
leonardBang commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1911749157 > @leonardBang , thanks for sharing your concerns, I understand where they are coming from. Here are my thoughts: > > * This is probably the trickiest source to migrate, since i

[jira] [Commented] (FLINK-34241) Transfer external connectors's CI result to Flink Slack #builds channel

2024-01-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811184#comment-17811184 ] Zhongqiang Gong commented on FLINK-34241: - [~leonard] I'm willing to take this i

Re: [PR] [FLINK-34117][bugfix][table] Fix CompactCoordinator data loss upon termination [flink]

2024-01-26 Thread via GitHub
leonardBang merged PR #24195: URL: https://github.com/apache/flink/pull/24195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1911754647 > > @libenchao a question to you before merging `squash` also removed the info about all the authors, are you ok if I add you as a co-author since it is based on your work? Or

Re: [PR] [FLINK-34237] Revert the breaking changes to SourceReaderContext [flink]

2024-01-26 Thread via GitHub
xintongsong closed pull request #24197: [FLINK-34237] Revert the breaking changes to SourceReaderContext URL: https://github.com/apache/flink/pull/24197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (FLINK-34117) CompactCoordinator for table file sink loses data upon job termination

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-34117. Fix Version/s: 1.18.2 Resolution: Fixed Fixed via master: 1d0f34e5a4a9127724bd09ecd0d9c0c0

[jira] [Closed] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-26 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-34237. Resolution: Fixed master (1.19): d0829ba3b162c24f2655b35258c9a8dc61cdba67 > MongoDB connector com

Re: [PR] [FLINK-31511][doc-zh] Update the document sql_functions_zh.yml and fix some parts in sql_functions.yml [flink]

2024-01-26 Thread via GitHub
leonardBang merged PR #5: URL: https://github.com/apache/flink/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Resolved] (FLINK-31511) Translate documentation sql_functions_zh.yml to the latest version

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-31511. Resolution: Implemented Resolved via master: 36feab0fb6db9ba2e284352a19db8925cb6e8874 > Translate

[jira] [Updated] (FLINK-31511) Translate documentation sql_functions_zh.yml to the latest version

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-31511: --- Affects Version/s: 1.18.1 (was: 1.17.0) > Translate documentation sql_fun

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811194#comment-17811194 ] Stefan Richter commented on FLINK-34200: [~fanrui] I think you misunderstood my

[jira] [Commented] (FLINK-34241) Transfer external connectors's CI result to Flink Slack #builds channel

2024-01-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811195#comment-17811195 ] Zhongqiang Gong commented on FLINK-34241: - Hi [~leonard]  , This should add bot

[jira] [Assigned] (FLINK-34241) Transfer external connectors's CI result to Flink Slack #builds channel

2024-01-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-34241: -- Assignee: Zhongqiang Gong > Transfer external connectors's CI result to Flink Slack #builds c

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-26 Thread via GitHub
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911798162 @X-czh thanks for discovering the compilation error that was merged into `master`. Could you merge the hotfix commit separately from the bigger change of this PR? The hotfix commit doesn't

Re: [PR] [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs [flink]

2024-01-26 Thread via GitHub
zhuzhurk commented on PR #24186: URL: https://github.com/apache/flink/pull/24186#issuecomment-1911805813 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467476574 ## .github/workflows/ci.yml: ## @@ -49,8 +50,18 @@ jobs: -Plicense-check \ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }} + mvn ${MVN

Re: [PR] [FLINK-34063][runtime] Always flush compression buffers, when retrieving stream position during OperatorState snapshot. [flink]

2024-01-26 Thread via GitHub
echauchot commented on PR #24079: URL: https://github.com/apache/flink/pull/24079#issuecomment-1911828089 I finally had time to take a look at this PR (reduced availability nowadays). Thanks for all the diagnostics and chained fixes @dmvk and sorry for missing the fact that pos was not upda

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
mxm commented on PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#issuecomment-1911834062 This looks good. Any further comments @gyfora? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-26 Thread via GitHub
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911838497 @XComp Thanks for the notice. We've already prepared another separate PR: #24200 on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora commented on PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#issuecomment-1911839594 🚢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora merged PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs [flink]

2024-01-26 Thread via GitHub
zhuzhurk commented on PR #24186: URL: https://github.com/apache/flink/pull/24186#issuecomment-1911841522 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-33803) Add observedGeneration to Operator's status spec

2024-01-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33803. -- Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed merged to main 0fa78d350bd4a6cf2ea5e

Re: [PR] [FLINK-33263][bugfix][table-planner] Update the flink shaded guava version used to 32 [flink]

2024-01-26 Thread via GitHub
XComp merged PR #24200: URL: https://github.com/apache/flink/pull/24200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-26 Thread via GitHub
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911845153 Ah I see, thanks for the pointer. I approved and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-34232][dist] Fix unsupported env.java.home in configuration file. [flink]

2024-01-26 Thread via GitHub
zhuzhurk closed pull request #24194: [FLINK-34232][dist] Fix unsupported env.java.home in configuration file. URL: https://github.com/apache/flink/pull/24194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-26 Thread via GitHub
zhuzhurk closed pull request #24185: [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. URL: https://github.com/apache/flink/pull/24185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Closed] (FLINK-34223) Introduce a migration tool to transfer legacy config file to new config file

2024-01-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-34223. --- Assignee: Junrui Li Resolution: Done master/release-1.19: 8fceb101e7e45f3fdc9357019757230bd8c16aa7 >

[jira] [Closed] (FLINK-34232) Config file unexpectedly lacks support for env.java.home

2024-01-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-34232. --- Assignee: Junrui Li Resolution: Fixed Fixed in master/release-1.19: e623c07f4e56fdef1bd8514ccd02df347a

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811220#comment-17811220 ] Rui Fan commented on FLINK-34200: - Sorry for the bother. If so, let us follow it in this

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467504153 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void testMultipleKubernetes

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-26 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1911877304 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467507163 ## flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml: ## @@ -128,6 +131,7 @@ under the License. org.apache.zookeeper

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467507163 ## flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml: ## @@ -128,6 +131,7 @@ under the License. org.apache.zookeeper

[PR] [FLINK-34206][test] Temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset [flink]

2024-01-26 Thread via GitHub
SinBex opened a new pull request, #24201: URL: https://github.com/apache/flink/pull/24201 ## What is the purpose of the change * In order not to block the CI, we should to temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset, and it will be fixed in 1.19 test phase.*

[jira] [Updated] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34206: --- Labels: pull-request-available test-stability (was: test-stability) > CacheITCase.testRetry

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-26 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811227#comment-17811227 ] xingbe commented on FLINK-34206:  [~mapohl] [~lincoln.86xy] [~zhuzh] We have located the

[jira] [Assigned] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-34206: --- Assignee: xingbe > CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed > --

Re: [PR] [FLINK-34206][test] Temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24201: URL: https://github.com/apache/flink/pull/24201#issuecomment-1911933355 ## CI report: * fbc5f514ab951067381a4e90e10244cd8a7c4943 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34206][test] Temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset [flink]

2024-01-26 Thread via GitHub
zhuzhurk closed pull request #24201: [FLINK-34206][test] Temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset URL: https://github.com/apache/flink/pull/24201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Created] (FLINK-34243) Update fabric8io:kubernetes-client to v6.9.0+ to allow the usage of ReleaseOnCall

2024-01-26 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34243: - Summary: Update fabric8io:kubernetes-client to v6.9.0+ to allow the usage of ReleaseOnCall Key: FLINK-34243 URL: https://issues.apache.org/jira/browse/FLINK-34243 P

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811231#comment-17811231 ] Zhu Zhu commented on FLINK-34206: - Disabled {{CacheITCase.testRetryOnCorruptedClusterDat

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467558102 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

[jira] [Commented] (FLINK-32609) Kafka table source supports projection push down

2024-01-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811233#comment-17811233 ] dalongliu commented on FLINK-32609: --- assigned to you > Kafka table source supports pr

[jira] [Assigned] (FLINK-32609) Kafka table source supports projection push down

2024-01-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-32609: - Assignee: SuDewei > Kafka table source supports projection push down >

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467558102 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467574472 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

[jira] [Updated] (FLINK-34193) Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-34193: --- Priority: Blocker (was: Critical) > Remove usage of Flink-Shaded Jackson and Snakeyaml in f

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467574472 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467582561 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467583895 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467590709 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API [flink]

2024-01-26 Thread via GitHub
MartijnVisser commented on PR #22320: URL: https://github.com/apache/flink/pull/22320#issuecomment-1911985635 @zzzs Are you still working on this PR, or should someone take this over? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions [flink]

2024-01-26 Thread via GitHub
MartijnVisser commented on PR #19873: URL: https://github.com/apache/flink/pull/19873#issuecomment-1911986863 @snuyanzin Are you still working on finalizing this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467610608 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467610608 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

  1   2   3   >