Re: [PR] [FLINK-35531] Avoid calling hsync in flush method in BaseHadoopFsRecoverableFsDataOutputStream [flink]

2024-06-10 Thread via GitHub
ramkrish86 commented on code in PR #24896: URL: https://github.com/apache/flink/pull/24896#discussion_r1634237585 ## flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/BaseHadoopFsRecoverableFsDataOutputStream.java: ## @@ -59,7 +59,7 @@ public void

Re: [PR] [FLINK-35531] Avoid calling hsync in flush method in BaseHadoopFsRecoverableFsDataOutputStream [flink]

2024-06-10 Thread via GitHub
cxzl25 commented on PR #24896: URL: https://github.com/apache/flink/pull/24896#issuecomment-2159856148 > The commit message is not yet update Sorry, it's updated now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-10 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2159830832 > hi @snuyanzin @superdiaodiao do we need supports encoding args ? > db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode > max compute

[jira] [Commented] (FLINK-26951) Add HASH supported in SQL & Table API

2024-06-10 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853901#comment-17853901 ] Kartikey Pant commented on FLINK-26951: --- Hey [~lincoln.86xy], can you please assign this issue to

[jira] [Commented] (FLINK-12450) [Bitwise Functions] Add BIT_LSHIFT, BIT_RSHIFT functions supported in Table API and SQL

2024-06-10 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853900#comment-17853900 ] Kartikey Pant commented on FLINK-12450: --- Hey [~taoran]/[~jark], could you please confirm if this

Re: [PR] [FLINK-35531] Avoid calling hsync in flush method in BaseHadoopFsRecoverableFsDataOutputStream [flink]

2024-06-10 Thread via GitHub
xintongsong commented on PR #24896: URL: https://github.com/apache/flink/pull/24896#issuecomment-2159816793 > Thanks, I've updated. The commit message is not yet update. Have you forgot to push the changes? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-10 Thread via GitHub
liuyongvs commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2159808362 hi @snuyanzin @superdiaodiao do we need supports encoding args ? db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode max compute

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2159778519 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1634155084 ## flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/CustomSSLEngineProvider.java: ## @@ -59,13 +71,38 @@ public TrustManager[]

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1634154163 ## flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java: ## @@ -148,6 +148,17 @@ void testRESTClientSSLWrongPassword(String sslProvider) {

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1634153986 ## flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java: ## @@ -306,6 +341,19 @@ void testInternalSSLWrongKeyPassword(String sslProvider) {

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853894#comment-17853894 ] Weijie Guo commented on FLINK-18476:

[jira] [Commented] (FLINK-34914) FLIP-436: Introduce Catalog-related Syntax

2024-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853893#comment-17853893 ] Weijie Guo commented on FLINK-34914: Hi [~liyubin117] and [~qingyue]. FYI: We expect the feature

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-10 Thread via GitHub
yuxiqian commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1634142791 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related

[jira] [Updated] (FLINK-35563) 'Run kubernetes application test' failed on AZP

2024-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35563: --- Description: {code:java} Jun 08 01:52:28 deployment.apps "flink-native-k8s-application-1" deleted

[jira] [Created] (FLINK-35563) 'Run kubernetes application test' failed on AZP

2024-06-10 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35563: -- Summary: 'Run kubernetes application test' failed on AZP Key: FLINK-35563 URL: https://issues.apache.org/jira/browse/FLINK-35563 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853888#comment-17853888 ] Weijie Guo commented on FLINK-18476: test_cron_jdk21 misc

[jira] [Created] (FLINK-35562) WindowTableFunctionProcTimeRestoreTest produced no output for 900 seconds

2024-06-10 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35562: -- Summary: WindowTableFunctionProcTimeRestoreTest produced no output for 900 seconds Key: FLINK-35562 URL: https://issues.apache.org/jira/browse/FLINK-35562 Project: Flink

[jira] [Updated] (FLINK-35562) WindowTableFunctionProcTimeRestoreTest produced no output for 900 seconds

2024-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35562: --- Description:

Re: [PR] [FLINK-32081][checkpoint] Compatibility between file-merging on and off across job runs [flink]

2024-06-10 Thread via GitHub
ljz2051 commented on code in PR #24873: URL: https://github.com/apache/flink/pull/24873#discussion_r1634123958 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35328] AutoScale supports setting the maximum floating parallelism by the number of Pulsar partitions [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
wenbingshen commented on code in PR #827: URL: https://github.com/apache/flink-kubernetes-operator/pull/827#discussion_r1634118107 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -247,17 +249,36 @@ protected JobTopology

Re: [PR] [FLINK-35531] Avoid calling hsync in flush method in BaseHadoopFsRecoverableFsDataOutputStream [flink]

2024-06-10 Thread via GitHub
cxzl25 commented on PR #24896: URL: https://github.com/apache/flink/pull/24896#issuecomment-2159691770 Gentle ping @xintongsong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35328] AutoScale supports setting the maximum floating parallelism by the number of Pulsar partitions [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
wenbingshen commented on code in PR #827: URL: https://github.com/apache/flink-kubernetes-operator/pull/827#discussion_r1634091321 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -247,17 +249,36 @@ protected JobTopology

Re: [PR] [pipeline-connector][doris] Fix Mysql pipeline to doris will lost precision for timestamp [flink-cdc]

2024-06-10 Thread via GitHub
gong commented on PR #3407: URL: https://github.com/apache/flink-cdc/pull/3407#issuecomment-2159661569 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34908][pipeline-connector][doris] Fix Mysql pipeline to doris will lost precision for timestamp [flink-cdc]

2024-06-10 Thread via GitHub
gong commented on PR #3207: URL: https://github.com/apache/flink-cdc/pull/3207#issuecomment-2159656572 > @gong would you like to open a PR for release-3.1 branch? ok, I will open the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-06-10 Thread via GitHub
reswqa commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1634076649 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-06-10 Thread via GitHub
reswqa commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1634061063 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35328] AutoScale supports setting the maximum floating parallelism by the number of Pulsar partitions [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
1996fanrui commented on code in PR #827: URL: https://github.com/apache/flink-kubernetes-operator/pull/827#discussion_r1634051534 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -247,17 +249,36 @@ protected JobTopology

[jira] [Commented] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853858#comment-17853858 ] Rui Fan commented on FLINK-35489: - Merged to main(1.9.0) via: c3e94aec0c6f081a99b7467bd0bcee551b841600

[jira] [Assigned] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35489: --- Assignee: Nicolas Fraison > Metaspace size can be too little after autotuning change memory

[jira] [Resolved] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-35489. - Fix Version/s: kubernetes-operator-1.9.0 Resolution: Fixed > Metaspace size can be too little

Re: [PR] [FLINK-35489][Autoscaler] Ensure METASPACE size is computed before the heap [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
1996fanrui merged PR #833: URL: https://github.com/apache/flink-kubernetes-operator/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35489][Autoscaler] Ensure METASPACE size is computed before the heap [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
1996fanrui commented on PR #833: URL: https://github.com/apache/flink-kubernetes-operator/pull/833#issuecomment-2159610745 Thanks @ashangit for the fix and everyone for the review! Merging~ -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Comment Edited] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853850#comment-17853850 ] Xintong Song edited comment on FLINK-35557 at 6/11/24 1:26 AM: --- I think

[jira] [Commented] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853850#comment-17853850 ] Xintong Song commented on FLINK-35557: -- I think this is by design. As suggested by the name, the

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1634004521 ## docs/layouts/shortcodes/generated/security_configuration.html: ## @@ -134,6 +134,12 @@ String The secret to decrypt the keystore file

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
ammar-master commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1633910473 ## docs/layouts/shortcodes/generated/security_configuration.html: ## @@ -134,6 +134,12 @@ String The secret to decrypt the keystore file

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-06-10 Thread via GitHub
morazow commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2159296755 Thanks @dongwoo6kim , Tests looks good from my side  (_Recently I faced similar issue which maybe related, when running batch mode with setting

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2159216321 I moved the example application under tests and removed the separate module completely. I added links to the example application in the README. -- This is an automated

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1633781977 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at

[jira] [Commented] (FLINK-30400) Stop bundling connector-base in externalized connectors

2024-06-10 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853754#comment-17853754 ] Robert Metzger commented on FLINK-30400: The problem of marking flink-connector-base provided

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-10 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Priority: Blocker (was: Major) > Shading issue cause class conflict >

[jira] [Commented] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-06-10 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853734#comment-17853734 ] Ahmed Hamdy commented on FLINK-35445: - As discussed offline, there is no docs for Asyncsink, hence

[jira] [Closed] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-06-10 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy closed FLINK-35445. --- Resolution: Not A Problem > Update Async Sink documentation for Timeout configuration >

[jira] [Commented] (FLINK-35140) Release flink-connector-opensearch vX.X.X for Flink 1.19

2024-06-10 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853733#comment-17853733 ] Sergey Nuyanzin commented on FLINK-35140: - Need for PMC help as mentioned at

[jira] [Comment Edited] (FLINK-35140) Release flink-connector-opensearch vX.X.X for Flink 1.19

2024-06-10 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853733#comment-17853733 ] Sergey Nuyanzin edited comment on FLINK-35140 at 6/10/24 4:43 PM: --

[jira] [Assigned] (FLINK-35140) Release flink-connector-opensearch vX.X.X for Flink 1.19

2024-06-10 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-35140: --- Assignee: Sergey Nuyanzin (was: Sergey Nuyanzin) > Release

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
z3d1k commented on PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#issuecomment-2158839029 > There is a risk this will break user code depending on these libs, right? Given this is a bug, and they should not be using the shaded libs, I think this is ok, thoughts?

[jira] [Created] (FLINK-35561) Flink REST API incorrect documentation

2024-06-10 Thread Shyam (Jira)
Shyam created FLINK-35561: - Summary: Flink REST API incorrect documentation Key: FLINK-35561 URL: https://issues.apache.org/jira/browse/FLINK-35561 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter as default element converter [flink-connector-aws]

2024-06-10 Thread via GitHub
dannycranmer commented on PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#issuecomment-2158683163 @hlteoh37 / @z3d1k can you please take a look at this one too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter as default element converter [flink-connector-aws]

2024-06-10 Thread via GitHub
dannycranmer commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1633458080 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DefaultDynamoDbElementConverter.java: ## @@ -0,0

[jira] [Commented] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-06-10 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853713#comment-17853713 ] Danny Cranmer commented on FLINK-35435: --- Merged commit

[jira] [Resolved] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-06-10 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-35435. --- Resolution: Done > [FLIP-451] Introduce timeout configuration to AsyncSink >

[jira] [Assigned] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-06-10 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-35435: - Assignee: Ahmed Hamdy > [FLIP-451] Introduce timeout configuration to AsyncSink >

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-10 Thread via GitHub
dannycranmer merged PR #24839: URL: https://github.com/apache/flink/pull/24839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
dannycranmer commented on PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#issuecomment-2158665814 There is a risk this will break user code depending on these libs, right? Given this is a bug, and they should not be using the shaded libs, I think this is ok, thoughts?

[jira] [Assigned] (FLINK-35559) Shading issue cause class conflict

2024-06-10 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-35559: - Assignee: Aleksandr Pilipenko > Shading issue cause class conflict >

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-10 Thread via GitHub
lincoln-lil commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r164828 ## docs/layouts/shortcodes/generated/optimizer_config_configuration.html: ## @@ -65,6 +71,12 @@ Enum When it is `TRY_RESOLVE`, the

Re: [PR] [FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor [flink]

2024-06-10 Thread via GitHub
ferenc-csaky commented on code in PR #24914: URL: https://github.com/apache/flink/pull/24914#discussion_r1633282273 ## flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/OutputStreamBasedPartFileWriter.java: ## @@

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
z3d1k commented on code in PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#discussion_r1633275869 ## flink-connector-aws/flink-connector-kinesis/pom.xml: ## @@ -354,6 +354,12 @@ under the License.

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#discussion_r1633262253 ## flink-connector-aws/flink-connector-kinesis/pom.xml: ## @@ -354,6 +354,12 @@ under the License.

Re: [PR] [FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi commented on code in PR #24914: URL: https://github.com/apache/flink/pull/24914#discussion_r1633243846 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/operator/CompactService.java: ## @@ -154,23 +158,27 @@

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
pnowojski commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633225150 ## docs/layouts/shortcodes/generated/execution_checkpointing_configuration.html: ## Review Comment: fixed -- This is an automated message from the Apache

Re: [PR] [FLINK-XXX][planner] Support custom shuffle for lookup join [flink]

2024-06-10 Thread via GitHub
flinkbot commented on PR #24920: URL: https://github.com/apache/flink/pull/24920#issuecomment-2158287262 ## CI report: * 97c210a011dd34e0c19deffe746cb3e88b355ce2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-XXX][planner] Support custom shuffle for lookup join [flink]

2024-06-10 Thread via GitHub
WencongLiu opened a new pull request, #24920: URL: https://github.com/apache/flink/pull/24920 ## What is the purpose of the change _Support custom shuffle for lookup join_ ## Verifying this change UT and ITs. ## Does this pull request potentially affect one of the

Re: [PR] [FLINK-35525][yarn] Add a token services configuration to allow obtained token to be passed to Yarn AM [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi commented on PR #24891: URL: https://github.com/apache/flink/pull/24891#issuecomment-2158262913 @wForget thanks for your efforts! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-35525) HDFS delegation token fetched by custom DelegationTokenProvider is not passed to Yarn AM

2024-06-10 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-35525. - > HDFS delegation token fetched by custom DelegationTokenProvider is not > passed to Yarn AM >

[jira] [Resolved] (FLINK-35525) HDFS delegation token fetched by custom DelegationTokenProvider is not passed to Yarn AM

2024-06-10 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-35525. --- Fix Version/s: 1.20.0 Resolution: Fixed 74b100b on master > HDFS delegation token

Re: [PR] [FLINK-35525][yarn] Add a token services configuration to allow obtained token to be passed to Yarn AM [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi merged PR #24891: URL: https://github.com/apache/flink/pull/24891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35489][Autoscaler] Ensure METASPACE size is computed before the heap [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
ashangit commented on PR #833: URL: https://github.com/apache/flink-kubernetes-operator/pull/833#issuecomment-2158258410 Updated the PR to take in account this

[jira] [Commented] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-10 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853647#comment-17853647 ] Nicolas Fraison commented on FLINK-35489: - Thks [~mxm] for the feedback. I've updated the

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633189008 ## docs/layouts/shortcodes/generated/execution_checkpointing_configuration.html: ## Review Comment: I guess a leftover and should be removed? -- This is

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633189008 ## docs/layouts/shortcodes/generated/execution_checkpointing_configuration.html: ## Review Comment: I guess this file is a leftover and should be removed?

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi commented on code in PR #24919: URL: https://github.com/apache/flink/pull/24919#discussion_r1633123484 ## flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java: ## @@ -148,6 +148,17 @@ void testRESTClientSSLWrongPassword(String sslProvider) {

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633185416 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailOptionsImpl.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
pnowojski commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633182865 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailOptionsImpl.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (FLINK-35542) ClassNotFoundException when deserializing CheckpointedOffset

2024-06-10 Thread Jan Gurda (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Gurda updated FLINK-35542: -- Affects Version/s: jdbc-3.2.0 > ClassNotFoundException when deserializing CheckpointedOffset >

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633159087 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailboxExecutor.java: ## @@ -86,6 +87,25 @@ public interface MailboxExecutor { /** A

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1633154332 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailOptionsImpl.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35525][yarn] Add a token services configuration to allow obtained token to be passed to Yarn AM [flink]

2024-06-10 Thread via GitHub
wForget commented on PR #24891: URL: https://github.com/apache/flink/pull/24891#issuecomment-2158200824 > Just seen the error in the pipeline, plz fix it: Thanks @gaborgsomogyi ,I have updated document and CI passed. -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2158109164 Please have a look at the failing test: ``` Jun 10 07:17:02 07:17:02.965 [INFO] Running org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase Jun 10

Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-10 Thread via GitHub
hlteoh37 commented on PR #745: URL: https://github.com/apache/flink-web/pull/745#issuecomment-2158002413 Thanks @1996fanrui - great comments! I've addressed them. I've removed the below JIRAs from the release notes as they related to build infrastructure: ### Subtask -

Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #745: URL: https://github.com/apache/flink-web/pull/745#discussion_r1633036672 ## docs/content/posts/2024-06-14-release-1.19.1.md: ## @@ -0,0 +1,171 @@ +--- +title: "Apache Flink 1.19.1 Release Announcement" +date: "2024-06-14T00:00:00.000Z"

Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #745: URL: https://github.com/apache/flink-web/pull/745#discussion_r1633022942 ## docs/content/posts/2024-06-14-release-1.19.1.md: ## @@ -0,0 +1,171 @@ +--- +title: "Apache Flink 1.19.1 Release Announcement" +date: "2024-06-14T00:00:00.000Z"

Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #745: URL: https://github.com/apache/flink-web/pull/745#discussion_r1633022433 ## docs/content/posts/2024-06-14-release-1.19.1.md: ## @@ -0,0 +1,171 @@ +--- +title: "Apache Flink 1.19.1 Release Announcement" +date: "2024-06-14T00:00:00.000Z"

[jira] [Commented] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-10 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853606#comment-17853606 ] Maximilian Michels commented on FLINK-35489: Hey [~ashangit]! Good idea to switch the order

Re: [PR] [FLINK-35328] AutoScale supports setting the maximum floating parallelism by the number of Pulsar partitions [flink-kubernetes-operator]

2024-06-10 Thread via GitHub
gyfora commented on code in PR #827: URL: https://github.com/apache/flink-kubernetes-operator/pull/827#discussion_r1632931104 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -247,17 +249,36 @@ protected JobTopology

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
pnowojski commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1632887041 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailboxExecutor.java: ## @@ -86,6 +87,25 @@ public interface MailboxExecutor { /** A constant

[jira] [Commented] (FLINK-35556) Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853589#comment-17853589 ] Hong Liang Teoh commented on FLINK-35556: - Changing fix version to 1.19.2 > Wrong constant in

[jira] [Updated] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-35557: Fix Version/s: 1.19.2 (was: 1.19.1) > MemoryManager only reserves

[jira] [Commented] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853588#comment-17853588 ] Hong Liang Teoh commented on FLINK-35557: - Changing this to 1.19.2 release as this is a

[jira] [Updated] (FLINK-35556) Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-35556: Fix Version/s: 1.19.2 (was: 1.19.1) > Wrong constant in

[jira] [Updated] (FLINK-34633) Support unnesting array constants

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-34633: Fix Version/s: 1.20.0 (was: 1.19.1) > Support unnesting array

[jira] [Commented] (FLINK-34633) Support unnesting array constants

2024-06-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853587#comment-17853587 ] Hong Liang Teoh commented on FLINK-34633: - Thanks for checking. Will remove the PR from the

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-10 Thread via GitHub
pnowojski commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1632838546 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailboxExecutor.java: ## @@ -86,6 +87,25 @@ public interface MailboxExecutor { /** A constant

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
z3d1k commented on code in PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#discussion_r1632814622 ## flink-connector-aws/flink-connector-kinesis/pom.xml: ## @@ -354,6 +354,12 @@ under the License.

Re: [PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-10 Thread via GitHub
foxus commented on code in PR #142: URL: https://github.com/apache/flink-connector-aws/pull/142#discussion_r1632803808 ## flink-connector-aws/flink-connector-kinesis/pom.xml: ## @@ -354,6 +354,12 @@ under the License.

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-10 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1632799682 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java: ## @@ -307,18 +307,36 @@ void onProcessingTime(long

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-10 Thread via GitHub
gaborgsomogyi commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2157658542 @ammar-master thanks for this PR, looks quality code from first glance perspective. I'm going to shepherd it this week... -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632777604 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at

  1   2   >