Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2111067387 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/FlinkCalciteTableMappingRule.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110243058 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/FlinkCalciteTableMappingRule.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (FLINK-37844) FLIP-516 Optimization: Push down projections for StreamingMultiJoinOperator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37844: -- Parent: FLINK-37859 Issue Type: Sub-task (was: Improvement) > FLIP-516 Optimization: Push dow

[jira] [Updated] (FLINK-37814) FLIP-516: Adjust FlinkJoinToMultiJoinRule for Multi Join Operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37814: -- Parent: FLINK-37859 Issue Type: Sub-task (was: Improvement) > FLIP-516: Adjust FlinkJoinToMul

[jira] [Updated] (FLINK-37481) FLIP-516: Multi way join operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37481: -- Parent: FLINK-37859 Issue Type: Sub-task (was: New Feature) > FLIP-516: Multi way join operat

[jira] [Updated] (FLINK-37814) FLIP-516: Adjust FlinkJoinToMultiJoinRule for Multi Join Operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37814: -- Parent: (was: FLINK-37481) Issue Type: Improvement (was: Sub-task) > FLIP-516: Adjust Fli

[jira] [Updated] (FLINK-37844) FLIP-516 Optimization: Push down projections for StreamingMultiJoinOperator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37844: -- Parent: (was: FLINK-37481) Issue Type: Improvement (was: Sub-task) > FLIP-516 Optimizatio

[jira] [Updated] (FLINK-37859) [umbrella] FLIP-516: Streaming Multi-Way Join Optimization

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37859: -- Issue Type: New Feature (was: Bug) > [umbrella] FLIP-516: Streaming Multi-Way Join Optimization > ---

[jira] [Created] (FLINK-37859) [umbrella] FLIP-516: Streaming Multi-Way Join Optimization

2025-05-27 Thread dalongliu (Jira)
dalongliu created FLINK-37859: - Summary: [umbrella] FLIP-516: Streaming Multi-Way Join Optimization Key: FLINK-37859 URL: https://issues.apache.org/jira/browse/FLINK-37859 Project: Flink Issue Ty

[jira] [Commented] (FLINK-37481) FLIP-516: Multi way join operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954487#comment-17954487 ] dalongliu commented on FLINK-37481: --- Hi [~gustavodemorais], can you find someone who c

[jira] [Updated] (FLINK-37844) FLIP-516 Optimization: Push down projections for StreamingMultiJoinOperator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37844: -- Parent: FLINK-37481 Issue Type: Sub-task (was: Improvement) > FLIP-516 Optimization: Push dow

[jira] [Updated] (FLINK-37814) FLIP-516: Adjust FlinkJoinToMultiJoinRule for Multi Join Operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-37814: -- Parent: FLINK-37481 Issue Type: Sub-task (was: New Feature) > FLIP-516: Adjust FlinkJoinToMul

[jira] [Commented] (FLINK-37814) FLIP-516: Adjust FlinkJoinToMultiJoinRule for Multi Join Operator

2025-05-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954484#comment-17954484 ] dalongliu commented on FLINK-37814: --- Hi, [~gustavodemorais] Can we convert all these F

Re: [PR] [hotfix]Adds Override annotation [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26604: URL: https://github.com/apache/flink/pull/26604#issuecomment-2914762035 ## CI report: * ec1564677796e7f748b35e399ca22e80983dd14d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix]Adds Override annotation [flink]

2025-05-27 Thread via GitHub
luyizhizaio opened a new pull request, #26604: URL: https://github.com/apache/flink/pull/26604 ## What is the purpose of the change This PR proposes to add `@Override` for `createAndStart()` method in `PekkoRpcServiceBuilder`. since this method is from `RpcSystem.RpcServic

Re: [PR] [FLINK-37840] [table] Row writer should honor null uncompact BigDecimal and Timestamp [flink]

2025-05-27 Thread via GitHub
dengziming commented on code in PR #26594: URL: https://github.com/apache/flink/pull/26594#discussion_r2110781697 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java: ## @@ -372,7 +372,11 @@ public void setDecimal(int pos, Deci

Re: [PR] [FLINK-34864][cdc-connector-mysql] Add the IgnoreNoPrimaryKeyTable parameter to skip tables without primary keys in multi-table synchronization [flink-cdc]

2025-05-27 Thread via GitHub
yzeng1618 commented on code in PR #4027: URL: https://github.com/apache/flink-cdc/pull/4027#discussion_r2110781504 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlChunkSplitter.java: ###

Re: [PR] [FLINK-34864][cdc-connector-mysql] Add the IgnoreNoPrimaryKeyTable parameter to skip tables without primary keys in multi-table synchronization [flink-cdc]

2025-05-27 Thread via GitHub
yzeng1618 commented on code in PR #4027: URL: https://github.com/apache/flink-cdc/pull/4027#discussion_r2110781071 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlChunkSplitterTest.java:

Re: [PR] [FLINK-34864][cdc-connector-mysql] Add the IgnoreNoPrimaryKeyTable parameter to skip tables without primary keys in multi-table synchronization [flink-cdc]

2025-05-27 Thread via GitHub
yzeng1618 commented on code in PR #4027: URL: https://github.com/apache/flink-cdc/pull/4027#discussion_r2110666798 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceOptions.java: ##

Re: [PR] [FLINK-37791][6/N] model sql to rel converter [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26603: URL: https://github.com/apache/flink/pull/26603#issuecomment-2914494836 ## CI report: * 21e25a08d7940e810be122da5fa0a07e861966f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37791) Integrate with sql to rel converter

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37791: --- Labels: pull-request-available (was: ) > Integrate with sql to rel converter >

[PR] [FLINK-37791][6/N] model sql to rel converter [flink]

2025-05-27 Thread via GitHub
lihaosky opened a new pull request, #26603: URL: https://github.com/apache/flink/pull/26603 ## What is the purpose of the change Update rel converter to handle `SqlModelCall` ## Brief change log * Update rel converter to handle `SqlModelCall` * Discover `ModelProvi

Re: [PR] [FLINK-37780][5/N] predict sql function type inference and validation [flink]

2025-05-27 Thread via GitHub
lihaosky commented on code in PR #26583: URL: https://github.com/apache/flink/pull/26583#discussion_r2110555233 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/ml/SqlMLPredictTableFunction.java: ## @@ -87,21 +111,25 @@ public List pa

[jira] [Created] (FLINK-37858) Migrate state processor API from source v1 to source v2 API

2025-05-27 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-37858: - Summary: Migrate state processor API from source v1 to source v2 API Key: FLINK-37858 URL: https://issues.apache.org/jira/browse/FLINK-37858 Project: Flink

Re: [PR] [FLINK-37724] Adds AsyncTableFunction as a fully supported UDF type [flink]

2025-05-27 Thread via GitHub
AlanConfluent commented on code in PR #26567: URL: https://github.com/apache/flink/pull/26567#discussion_r2110482717 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractionUtils.java: ## @@ -373,4 +374,28 @@ public static void validateLambdaType(Class base

Re: [PR] [FLINK-37724] Adds AsyncTableFunction as a fully supported UDF type [flink]

2025-05-27 Thread via GitHub
AlanConfluent commented on code in PR #26567: URL: https://github.com/apache/flink/pull/26567#discussion_r2110383237 ## docs/layouts/shortcodes/generated/sink_configuration.html: ## @@ -0,0 +1,18 @@ + Review Comment: Yes, it is unrelated. Not sure why it was generated. Let

Re: [PR] [FLINK-37857][tests] Add a DSV2 sink implementation to tests which can collect data [flink]

2025-05-27 Thread via GitHub
gaborgsomogyi commented on PR #26602: URL: https://github.com/apache/flink/pull/26602#issuecomment-2914072629 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-37548] Add Model DDL methods in TABLE API [flink]

2025-05-27 Thread via GitHub
yanand0909 commented on code in PR #26385: URL: https://github.com/apache/flink/pull/26385#discussion_r2110353721 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/ModelDescriptor.java: ## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [FLINK-37857][tests] Add a DSV2 sink implementation to tests which can collect data [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26602: URL: https://github.com/apache/flink/pull/26602#issuecomment-2914079101 ## CI report: * ca23218429cbe95860b479a3682c00355fe53f99 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110288376 ## flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd: ## @@ -293,6 +292,8 @@ "DATETIME_DIFF" "DATETIME_INTERVAL_CODE" "DATETIME_INTERVAL_PR

[jira] [Updated] (FLINK-37857) Add a DSV2 sink implementation to tests which can collect data

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37857: --- Labels: pull-request-available (was: ) > Add a DSV2 sink implementation to tests which can

[PR] [FLINK-37857][tests] Add a DSV2 sink implementation to tests which can collect data [flink]

2025-05-27 Thread via GitHub
gaborgsomogyi opened a new pull request, #26602: URL: https://github.com/apache/flink/pull/26602 ## What is the purpose of the change Now there is no DSV2 sink implementation which can be used in tests to collect data. In this PR I've added one. ## Brief change log Add a

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110253073 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/AggConverter.java: ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110253073 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/AggConverter.java: ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110243058 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/FlinkCalciteTableMappingRule.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26547: URL: https://github.com/apache/flink/pull/26547#discussion_r2110243058 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/FlinkCalciteTableMappingRule.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-37840] [table] Row writer should honor null uncompact BigDecimal and Timestamp [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26594: URL: https://github.com/apache/flink/pull/26594#discussion_r2110174177 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/writer/AbstractBinaryWriter.java: ## @@ -165,8 +165,11 @@ public void writeDecimal(int po

Re: [PR] [FLINK-37840] [table] Row writer should honor null uncompact BigDecimal and Timestamp [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26594: URL: https://github.com/apache/flink/pull/26594#discussion_r2110170096 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java: ## @@ -372,7 +372,11 @@ public void setDecimal(int pos, Decim

Re: [PR] [FLINK-37840] [table] Row writer should honor null uncompact BigDecimal and Timestamp [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26594: URL: https://github.com/apache/flink/pull/26594#discussion_r2110174177 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/writer/AbstractBinaryWriter.java: ## @@ -165,8 +165,11 @@ public void writeDecimal(int po

Re: [PR] [FLINK-37840] [table] Row writer should honor null uncompact BigDecimal and Timestamp [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26594: URL: https://github.com/apache/flink/pull/26594#discussion_r2110170096 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java: ## @@ -372,7 +372,11 @@ public void setDecimal(int pos, Decim

Re: [PR] [hotfix] Fix invalid comments in Committer [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26578: URL: https://github.com/apache/flink/pull/26578#discussion_r2110162954 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/Committer.java: ## @@ -38,7 +38,7 @@ @Public public interface Committer extends AutoCloseable {

Re: [PR] [FLINK-37247][FileSystems][Tests] Implement common Hadoop file system integration tests for GCS. [flink]

2025-05-27 Thread via GitHub
cnauroth commented on PR #26102: URL: https://github.com/apache/flink/pull/26102#issuecomment-2913884208 I would still like to contribute this PR. I'll reach out to d...@flink.apache.org to ask for help with review. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-37328][FileSystems] Upgrade GCS connector to 2.2.26. [flink]

2025-05-27 Thread via GitHub
cnauroth commented on PR #26160: URL: https://github.com/apache/flink/pull/26160#issuecomment-2913884376 I would still like to contribute this PR. I'll reach out to d...@flink.apache.org to ask for help with review. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Created] (FLINK-37857) Add a DSV2 sink implementation to tests which can collect data

2025-05-27 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-37857: - Summary: Add a DSV2 sink implementation to tests which can collect data Key: FLINK-37857 URL: https://issues.apache.org/jira/browse/FLINK-37857 Project: Flink

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
gustavodemorais commented on code in PR #26600: URL: https://github.com/apache/flink/pull/26600#discussion_r2109122212 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/process/AbstractProcessTableOperator.java: ## @@ -322,14 +315,18 @@ pr

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109270910 ## flink-core/src/main/java/org/apache/flink/configuration/TraceOptions.java: ## @@ -67,20 +67,6 @@ public static Configuration forReporter(Configuration configurati

Re: [PR] [FLINK-37841][Connectors/DynamoDB] Using standard retry strategy instead of adaptive retry strategy to build ddb streams client [flink-connector-aws]

2025-05-27 Thread via GitHub
gguptp commented on PR #209: URL: https://github.com/apache/flink-connector-aws/pull/209#issuecomment-2913441036 Hi @darenwkt while i agree using adaptive retry strategy prevents throttling better than standard, it does so by throttling at client side. This can cause api calls to delay. Fo

Re: [PR] [FLINK-37833] [table-runtime] Fix BatchExecExchange codegen for BINARY type by evaluating Unsafe.arrayBaseOffset(byte[].class) in TM rather than in JM [flink]

2025-05-27 Thread via GitHub
venkata91 commented on PR #26592: URL: https://github.com/apache/flink/pull/26592#issuecomment-2913387581 > > Thanks for the patch. It is a good catch. > > I understand it might be a little tricky to do unit test. but we may be able to do integration test. We can do the following: > >

Re: [PR] [FLINK-37841][Connectors/DynamoDB] Using standard retry strategy instead of adaptive retry strategy to build ddb streams client [flink-connector-aws]

2025-05-27 Thread via GitHub
darenwkt commented on PR #209: URL: https://github.com/apache/flink-connector-aws/pull/209#issuecomment-2913384033 Thanks for the PR Abhi, the changes look good to me, I just have a few clarification questions: - I see benefits in using adaptive retry strategy as well, as it seems to

Re: [PR] [FLINK-29549]- Flink Glue Catalog integration [flink-connector-aws]

2025-05-27 Thread via GitHub
nicusX commented on code in PR #206: URL: https://github.com/apache/flink-connector-aws/pull/206#discussion_r2109663034 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java: ## @@ -0,0 +1,935 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
twalthr commented on code in PR #26601: URL: https://github.com/apache/flink/pull/26601#discussion_r2108831389 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SinkModifyOperation.java: ## @@ -98,7 +100,7 @@ public SinkModifyOperation(

[jira] [Commented] (FLINK-37125) env.log.max Log4j java.lang.NumberFormatException

2025-05-27 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954325#comment-17954325 ] Ferenc Csaky commented on FLINK-37125: -- Can you share the steps to reproduce this?

[PR] [release] Main branch updates after release cut [flink-kubernetes-operator]

2025-05-27 Thread via GitHub
gaborgsomogyi opened a new pull request, #984: URL: https://github.com/apache/flink-kubernetes-operator/pull/984 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-26821) Refactor Cassandra Sink implementation to the ASync Sink

2025-05-27 Thread Poorvank Bhatia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954268#comment-17954268 ] Poorvank Bhatia edited comment on FLINK-26821 at 5/27/25 9:54 AM:

Re: [PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26601: URL: https://github.com/apache/flink/pull/26601#discussion_r2109244273 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -462,11 +462,14 @@ abstract class PlannerBase(

Re: [PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26601: URL: https://github.com/apache/flink/pull/26601#discussion_r2109233230 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSinkUtils.java: ## @@ -258,6 +259,14 @@ private static RelNode conve

Re: [PR] [FLIP-516][FLINK-37481] Add new multi way join operator [flink]

2025-05-27 Thread via GitHub
gustavodemorais commented on code in PR #26313: URL: https://github.com/apache/flink/pull/26313#discussion_r2106248752 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/state/MultiJoinStateViews.java: ## @@ -0,0 +1,440 @@ +/* +

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
twalthr commented on code in PR #26600: URL: https://github.com/apache/flink/pull/26600#discussion_r2109396093 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/process/AbstractProcessTableOperator.java: ## @@ -322,14 +315,18 @@ private vo

Re: [PR] [FLINK-37125] [conf] fixed env.log.max java.lang.NumberFormatException [flink]

2025-05-27 Thread via GitHub
sehajsandhu123 commented on PR #26037: URL: https://github.com/apache/flink/pull/26037#issuecomment-2912669320 @ferenc-csaky If you see these tickets, you'll see that similar issues have been handled in a targeted manner before, such as in [FLINK-4040](https://issues.apache.org/jira/browse

Re: [PR] [release] Main branch updates after release cut [flink-kubernetes-operator]

2025-05-27 Thread via GitHub
gyfora merged PR #984: URL: https://github.com/apache/flink-kubernetes-operator/pull/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109317486 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -556,12 +559,21 @@ public AdaptiveScheduler( deploym

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109317486 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -556,12 +559,21 @@ public AdaptiveScheduler( deploym

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109311608 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -556,12 +559,21 @@ public AdaptiveScheduler( deploym

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109311608 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -556,12 +559,21 @@ public AdaptiveScheduler( deploym

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109277245 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109277245 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109266102 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109258252 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109253483 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109258252 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109253483 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
davidradl commented on code in PR #26599: URL: https://github.com/apache/flink/pull/26599#discussion_r2109253483 ## docs/content/docs/deployment/event_reporters.md: ## @@ -0,0 +1,91 @@ +--- +title: "Event Reporters" +weight: 8 +type: docs +aliases: + - /deployment/event_reporte

[jira] [Commented] (FLINK-37125) env.log.max Log4j java.lang.NumberFormatException

2025-05-27 Thread sehaj pal singh sandhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954332#comment-17954332 ] sehaj pal singh sandhu commented on FLINK-37125: [~fcsaky] I reproduced

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
twalthr commented on PR #26600: URL: https://github.com/apache/flink/pull/26600#issuecomment-2912381226 Thank you @snuyanzin. I will add the Chinese docs now, I just wanted to wait until the feedback has settled. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Assigned] (FLINK-37125) env.log.max Log4j java.lang.NumberFormatException

2025-05-27 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky reassigned FLINK-37125: Assignee: sehaj pal singh sandhu > env.log.max Log4j java.lang.NumberFormatException > --

[PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
AHeise opened a new pull request, #26601: URL: https://github.com/apache/flink/pull/26601 ## What is the purpose of the change compilePlan and executeSql use two different code paths. The former uses DynamicTableSinkSpec to render the json, the latter directly creates

Re: [PR] [FLINK-37733] Externalise DynamoDB connector IT Test to E2E test package [flink-connector-aws]

2025-05-27 Thread via GitHub
darenwkt closed pull request #203: [FLINK-37733] Externalise DynamoDB connector IT Test to E2E test package URL: https://github.com/apache/flink-connector-aws/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
AHeise commented on code in PR #26601: URL: https://github.com/apache/flink/pull/26601#discussion_r2108870373 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SinkModifyOperation.java: ## @@ -98,7 +100,7 @@ public SinkModifyOperation(

Re: [PR] [FLINK-37688] Implement Amazon CloudWatch Metric Sink Connector [flink-connector-aws]

2025-05-27 Thread via GitHub
darenwkt closed pull request #202: [FLINK-37688] Implement Amazon CloudWatch Metric Sink Connector URL: https://github.com/apache/flink-connector-aws/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
twalthr commented on code in PR #26600: URL: https://github.com/apache/flink/pull/26600#discussion_r2108849045 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -362,6 +362,17 @@ public class OptimizerConfigOpt

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
snuyanzin commented on code in PR #26600: URL: https://github.com/apache/flink/pull/26600#discussion_r2108845092 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -362,6 +362,17 @@ public class OptimizerConfigO

Re: [PR] [FLINK-37856] Ensure sink option hints are present in compiled plan [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26601: URL: https://github.com/apache/flink/pull/26601#issuecomment-2911998760 ## CI report: * 00d38e8448de10f587a5d3f88f096e4c6a65a122 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-37850) Several Union, Except, Intersect with one wrong column type fail with UnsupportedOperationException

2025-05-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954281#comment-17954281 ] Sergey Nuyanzin commented on FLINK-37850: - merged as [bcb6c61f373c9ac2b507cd1ac

[jira] [Resolved] (FLINK-37850) Several Union, Except, Intersect with one wrong column type fail with UnsupportedOperationException

2025-05-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-37850. - Fix Version/s: 2.1.0 Resolution: Fixed > Several Union, Except, Intersect with on

Re: [PR] [FLINK-37850][table] Several Union, Except, Intersect with one wrong column type fail with UnsupportedOperationException [flink]

2025-05-27 Thread via GitHub
snuyanzin merged PR #26597: URL: https://github.com/apache/flink/pull/26597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-37604] Generate static UIDs for pipeline operators [flink-cdc]

2025-05-27 Thread via GitHub
lvyanquan commented on code in PR #3977: URL: https://github.com/apache/flink-cdc/pull/3977#discussion_r2108787484 ## docs/content.zh/docs/core-concept/data-pipeline.md: ## @@ -111,9 +111,10 @@ under the License. # Pipeline 配置 下面 是 Data Pipeline 的一些可选配置: -| 参数

[jira] [Updated] (FLINK-37856) Sink option hints are not present in compiled plan

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37856: --- Labels: pull-request-available (was: ) > Sink option hints are not present in compiled plan

Re: [PR] [FLINK-37479][postgres] Add support for PARTITIONED TABLE [flink-cdc]

2025-05-27 Thread via GitHub
loserwang1024 commented on PR #4004: URL: https://github.com/apache/flink-cdc/pull/4004#issuecomment-2911881878 I agree with you in general. Maybe only a minor discuss on option name. What about `scan.publish-via-partition-root.enabled`? @leonardBang @ruanhang1993 , WDYT? ```xml

[jira] [Created] (FLINK-37856) Sink option hints are not present in compiled plan

2025-05-27 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-37856: --- Summary: Sink option hints are not present in compiled plan Key: FLINK-37856 URL: https://issues.apache.org/jira/browse/FLINK-37856 Project: Flink Issue Type:

[jira] [Commented] (FLINK-26821) Refactor Cassandra Sink implementation to the ASync Sink

2025-05-27 Thread Poorvank Bhatia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954268#comment-17954268 ] Poorvank Bhatia commented on FLINK-26821: - Hey [~rmetzger] [~martijnvisser]  I h

Re: [PR] [hotfix] Update META-INF/NOTICE files [flink-connector-aws]

2025-05-27 Thread via GitHub
darenwkt closed pull request #205: [hotfix] Update META-INF/NOTICE files URL: https://github.com/apache/flink-connector-aws/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-37730] Improve exception recording ts initialization + 2.0 compatibility [flink-kubernetes-operator]

2025-05-27 Thread via GitHub
gyfora merged PR #983: URL: https://github.com/apache/flink-kubernetes-operator/pull/983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26600: URL: https://github.com/apache/flink/pull/26600#issuecomment-2911678200 ## CI report: * 258dc17ad6fe8b727ec354d746e36ba21af5fd96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-37730) Collect job exceptions as kubernetes events

2025-05-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-37730. -- Fix Version/s: kubernetes-operator-1.12.0 Resolution: Fixed > Collect job exceptions as kuberne

[jira] [Updated] (FLINK-37763) Support multiple tables with set semantics

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37763: --- Labels: pull-request-available (was: ) > Support multiple tables with set semantics > -

[jira] [Commented] (FLINK-37730) Collect job exceptions as kubernetes events

2025-05-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954261#comment-17954261 ] Gyula Fora commented on FLINK-37730: Merged to main: 0679d634dc7c2e48b1c5f35cd25a204

[PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]

2025-05-27 Thread via GitHub
twalthr opened a new pull request, #26600: URL: https://github.com/apache/flink/pull/26600 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Created] (FLINK-37855) Reduce the time cost in MySqlSchemaUtils#listTables

2025-05-27 Thread Yanquan Lv (Jira)
Yanquan Lv created FLINK-37855: -- Summary: Reduce the time cost in MySqlSchemaUtils#listTables Key: FLINK-37855 URL: https://issues.apache.org/jira/browse/FLINK-37855 Project: Flink Issue Type: I

[jira] [Commented] (FLINK-37822) OpenTelemetryMetricReporterITCase.testReport test failed of azure ci

2025-05-27 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954243#comment-17954243 ] Piotr Nowojski commented on FLINK-37822: Hi [~lsy], I will try to take a look la

Re: [PR] [FLINK-37560][FLINK-37561][events] Report a bunch of system events and document events reporting system [flink]

2025-05-27 Thread via GitHub
flinkbot commented on PR #26599: URL: https://github.com/apache/flink/pull/26599#issuecomment-2911435316 ## CI report: * a8220e3699d3eb1d3402462a08bada2d2570865e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >