Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121335993
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -329,6 +337,41 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121335927
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1395,50 +1399,25 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121335610
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
---
@@ -37,24 +36,26 @@ import
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4092
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4105
[FLINK-6888] [table] Can not determine TypeInformation of ACC type of
AggregateFunction when ACC is a Scala class
Currently the `ACC TypeInformation
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4104
[FLINK-6817] [table] Add OverWindowWithPreceding class to guide users apply
preceding in over window
This PR is same as #4055 but against to branch 1.3
Thanks for contributing to Apache
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4061
@twalthr @sunjincheng121 `DefinedProctimeAttribute` and
`DefinedRowtimeAttribute` doesn't work in batch table source, currently. BTW, I
don't think batch table source needs `DefinedRowtimeAttribute
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4061#discussion_r121278080
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalTableSourceUtilTest.scala
---
@@ -42,7 +42,7 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4100
Good job!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4055
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4092
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4070
@sunjincheng121 thank you for your advice. I add the `array` and `abs`
test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4071
I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4071
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4060
The error in Travias CI seems not be relative to this PR, it is filed in
https://issues.apache.org/jira/browse/FLINK-6836. So I will merge this...
---
If your project is set up for it, you can
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4060#discussion_r12960
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala
---
@@ -147,7 +147,7 @@ class
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4070
[FLINK-6834] [table] Support scalar functions on Over Window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4050
@sunjincheng121 I've addressed your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4055
@sunjincheng121 I've added a `OverWindowWithPreceding` class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4055#discussion_r119985514
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/windows.scala
---
@@ -91,6 +91,10 @@ class OverWindowWithOrderBy
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4055
[FLINK-6817] [table] Fix NPE when preceding is not set in OVER window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4050
[FLINK-6816] [table] Fix wrong usage of Scala string interpolation in Table
API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3995
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3993
Regarding to (3), I agree with Fabian. From a user's perspective, it is not
easy to implement a `getAccumulatorType()` or `getResultType()` contract
function, as the signature and return type
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3993#discussion_r119520730
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -329,6 +330,21 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4021
+1 We were missing this for a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3943
Hi @sunjincheng121 , thanks for your great work. I like your proposal. The
test structure refactoring looks good to me. I think it's good to put all the
IT cases in one place.
---
If your project
Github user wuchong closed the pull request at:
https://github.com/apache/flink/pull/2673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3667
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
updated the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
@twalthr I have updated this PR regarding to the idea you proposed that
`env.sql(s"SELECT * FROM $table JOIN $otherTable")`
---
If your project is set up for it, you can reply to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
@twalthr Yes, I will update it in these days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3450
Looks good to me too. I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103361639
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,24 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103366163
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -114,7 +114,9 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3426
Hi @haohui , the code looks very good to me. Thanks for investigating this,
waiting for the CI pass.
@twalthr , I think you would like to have a look.
---
If your project is set up
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3418
Thanks for updating, the code looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103126204
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/MapRunnerTest.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127937
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala
---
@@ -43,7 +45,15 @@ class FlatMapRunner[IN, OUT
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127935
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala
---
@@ -43,7 +45,15 @@ class FlatMapRunner[IN, OUT
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127459
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/MapRunnerTest.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102448630
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/UserDefinedScalarFunctionTest.scala
---
@@ -181,6 +181,22 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102475557
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
---
@@ -48,10 +48,16 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102464697
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -87,10 +87,16 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102472512
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +147,25 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102448156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +147,25 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102453140
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -136,8 +136,18 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102470461
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -87,10 +87,16 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102465907
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -87,10 +87,16 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
Thank you @twalthr , I like the idea. So Java users can also use
`env.sql("SELECT * FROM " + table1 + " JOIN " + table2)` as a shortcut. What do
you think @fhueske ?
---
If yo
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
@twalthr do you mean register table in his `toString` method ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2460
Hi @shijinkui , sorry for the delay, the change looks very good to me.
Regarding to your questions,
>1. all the example code moved in flink-examples module, as a sub-module.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3330
Thank your for the steps.
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3330
Yes @fhueske , I would like to help merge it. Is there anything I need to
pay attention to ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3330
Looks good to me. Wait for another committer +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
Hi @twalthr , the `env.sql(s"SELECT * FROM $table JOIN $otherTable")` is a
nice way. But how to handle the table's table name and register it to env ?
---
If your project is set up for i
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3338#discussion_r102040448
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -155,15 +155,15 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r102037328
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ScalarFunction.scala
---
@@ -58,6 +60,11 @@ abstract class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3330
Thanks @sunjincheng121 for updating. Could you rebase the code on the
master?
After that, I can help to merge this.
---
If your project is set up for it, you can reply to this email
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r102032869
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ScalarFunction.scala
---
@@ -58,6 +60,11 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101946735
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -0,0 +1,80
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101907504
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r101887738
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractor.scala
---
@@ -84,6 +105,39 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r101887737
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/NestedFieldsProjectableTableSource.scala
---
@@ -0,0 +1,39
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3338
Hi @fhueske , yes, Calcite forces an Calc after each aggregate that only
renames fields, because we rename every aggregates in Table API which is not
necessary. I changed the logic of getting
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3338#discussion_r101750708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/ExpressionReducer.scala
---
@@ -106,8 +106,16 @@ class
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/3338
[FLINK-5414] [table] Bump up Calcite version to 1.11
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101460153
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101456205
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101450405
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101448753
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetUserDefinedFunctionITCase.scala
---
@@ -0,0 +1,75
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r101447660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101446163
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetUserDefinedFunctionITCase.scala
---
@@ -0,0 +1,75
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101446217
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -0,0 +1,80
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101445690
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -324,4 +325,19 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101445424
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101445544
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -324,4 +325,19 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101445785
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -324,4 +325,19 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3292
It seems that you introduced some commits not belong to this PR. You can
try rebase your branch onto master (not merge).
---
If your project is set up for it, you can reply to this email and have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3292
Thank you for fixing this. This issue is only occurred when submitting
remotely.
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3292#discussion_r100719358
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -842,6 +842,12 @@ protected int executeProgram(PackagedProgram program
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r100483661
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r100470762
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3273
updated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3273#discussion_r100458026
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -138,4 +141,160 @@ class CsvTableSource
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3273#discussion_r100458059
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -44,15 +47,15 @@ import
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3273
Thank you for your advice. I will update the PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3273#discussion_r100458044
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -138,4 +141,160 @@ class CsvTableSource
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r11509
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -210,14 +210,14 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r10375
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala
---
@@ -141,16 +141,18
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99987780
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -271,19 +269,46 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r6840
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -291,13 +292,13 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r7022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r8638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregatePreProcessor.scala
---
@@ -19,30
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r7024
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99987789
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -299,13 +324,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r8655
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
@@ -59,7
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3269
Hi @tonycox , thanks for this PR.
It seems that you are using column names to represent the (nested) fields
that are projected. I'm afraid that it can't work when the composite columns
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/3273
[FLINK-5714] [table] Use a builder pattern for creating CsvTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r99566482
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -220,56 +247,105 @@ class CodeGenerator
201 - 300 of 635 matches
Mail list logo
