jnh5y opened a new pull request, #23878:
URL: https://github.com/apache/flink/pull/23878
## What is the purpose of the change
Implement restore tests for Rank node
## Verifying this change
This change added tests and can be verified as follows:
* Added restore test
flinkbot commented on PR #23878:
URL: https://github.com/apache/flink/pull/23878#issuecomment-1841752000
## CI report:
* 0c6402b8f833df3a05a60b4a5d0fbbc15ae55cda UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dawidwys commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417047962
##
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##
@@ -81,19 +52,20 @@
},
"orderBy" : {
jnh5y commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417448524
##
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##
@@ -81,19 +52,20 @@
},
"orderBy" : {
dawidwys commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417478356
##
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##
@@ -81,19 +52,20 @@
},
"orderBy" : {
jnh5y commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417894843
##
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##
@@ -81,19 +52,20 @@
},
"orderBy" : {
jnh5y commented on PR #23878:
URL: https://github.com/apache/flink/pull/23878#issuecomment-1843578408
Lemme know if you want me to clean up any of the git history. The merge
from master was resolving conflicts in the GitHub UI.
--
This is an automated message from the Apache Git Service.
jnh5y commented on PR #23878:
URL: https://github.com/apache/flink/pull/23878#issuecomment-1845326404
> lgtm
>
> Yes, it would be really nice if you could rebase it on top of current
master.
Cool. I've rebased the commits on to master.
> My personal take is we should n
dawidwys merged PR #23878:
URL: https://github.com/apache/flink/pull/23878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
