[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255207#comment-15255207
]
Duo Zhang commented on HBASE-15693:
---
Before
{noformat}
[INFO] There are 5 errors report
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255219#comment-15255219
]
Sean Busbey commented on HBASE-15693:
-
+1
> Reconsider the ImportOrder rule of check
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255222#comment-15255222
]
Hadoop QA commented on HBASE-15693:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255226#comment-15255226
]
Duo Zhang commented on HBASE-15693:
---
[~busbey] Only master? Seems the checkstyle.xml in
[
https://issues.apache.org/jira/browse/HBASE-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255246#comment-15255246
]
Matt Warhaftig commented on HBASE-15676:
[~chenheng]], you ok if I take this tick
[
https://issues.apache.org/jira/browse/HBASE-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255253#comment-15255253
]
Heng Chen commented on HBASE-15676:
---
Please go ahead. I can't find your name in user l
Duo Zhang created HBASE-15699:
-
Summary: Can not sync AsyncFSWAL if no edit is appended
Key: HBASE-15699
URL: https://issues.apache.org/jira/browse/HBASE-15699
Project: HBase
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Attachment: HBASE-15699.patch
Change SyncFuture.NOT_DONE to -1 so it can accept a zero done txid.
Extr
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Status: Patch Available (was: Open)
> Can not sync AsyncFSWAL if no edit is appended
> ---
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Status: Open (was: Patch Available)
> Can not sync AsyncFSWAL if no edit is appended
> ---
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Attachment: (was: HBASE-15699.patch)
> Can not sync AsyncFSWAL if no edit is appended
> ---
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Status: Patch Available (was: Open)
> Can not sync AsyncFSWAL if no edit is appended
> ---
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Attachment: HBASE-15699.patch
Use a new eclipse and the import order is wrong...
This is the new patch
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255307#comment-15255307
]
Hadoop QA commented on HBASE-15699:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255316#comment-15255316
]
Elliott Clark commented on HBASE-15658:
---
+1 second version looks good to me.
> Reg
[
https://issues.apache.org/jira/browse/HBASE-15696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliott Clark updated HBASE-15696:
--
Attachment: HBASE-15696-v1.patch
> Move region location cache serialization into serde
> --
[
https://issues.apache.org/jira/browse/HBASE-15696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255362#comment-15255362
]
Hadoop QA commented on HBASE-15696:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255365#comment-15255365
]
Ted Yu commented on HBASE-15699:
lgtm
{code}
425 public void testSyncNoAppend() thr
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255401#comment-15255401
]
stack commented on HBASE-15699:
---
You define NOT_DONE but set the doneTxid to something else
[
https://issues.apache.org/jira/browse/HBASE-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255404#comment-15255404
]
stack commented on HBASE-15658:
---
Skimmed. Looks great. Nice tests [~ghelmling] You saw the
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255405#comment-15255405
]
stack commented on HBASE-15693:
---
[~Apache9] I don't see why we'd have different checkstyle
[
https://issues.apache.org/jira/browse/HBASE-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-15691:
--
Issue Type: Sub-task (was: Task)
Parent: HBASE-15240
> Port HBASE-10205 (ConcurrentModificationExcepti
[
https://issues.apache.org/jira/browse/HBASE-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255406#comment-15255406
]
stack commented on HBASE-15691:
---
Thanks [~busbey] Let me take a look since I'm in here and
Dima Spivak created HBASE-15700:
---
Summary: Add accessing web UI to Chaos Monkey actions
Key: HBASE-15700
URL: https://issues.apache.org/jira/browse/HBASE-15700
Project: HBase
Issue Type: New Fe
[
https://issues.apache.org/jira/browse/HBASE-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255451#comment-15255451
]
Elliott Clark commented on HBASE-15700:
---
/jmx and /dump page too maybe?
> Add acce
[
https://issues.apache.org/jira/browse/HBASE-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255453#comment-15255453
]
Dima Spivak commented on HBASE-15700:
-
Can do. Maybe I'll even get fancy and scrape l
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255454#comment-15255454
]
Duo Zhang commented on HBASE-15699:
---
The above comments explain why. We will call reset
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255455#comment-15255455
]
Duo Zhang commented on HBASE-15699:
---
[~tedyu] The bug here is that we will block on wal
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255456#comment-15255456
]
Duo Zhang commented on HBASE-15693:
---
Fine. Let me replace checkstyle.xml on all branche
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.patch
Replace checkstyle.xml with the one on master.
> Reconsider the
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.1.patch
> Reconsider the ImportOrder rule of checkstyle
>
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255462#comment-15255462
]
Sean Busbey commented on HBASE-15693:
-
filed HBASE-15701 for precommit not running ch
Sean Busbey created HBASE-15701:
---
Summary: In precommit, when the checkstyle configs change, we
should re-run checkstyle at root
Key: HBASE-15701
URL: https://issues.apache.org/jira/browse/HBASE-15701
P
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.2.patch
> Reconsider the ImportOrder rule of checkstyle
>
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.3.patch
> Reconsider the ImportOrder rule of checkstyle
>
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.0.patch
> Reconsider the ImportOrder rule of checkstyle
>
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-0.98.patch
> Reconsider the ImportOrder rule of checkstyle
> --
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: (was: HBASE-15693-branch-1.patch)
> Reconsider the ImportOrder rule of checkstyle
> ---
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Attachment: HBASE-15693-branch-1.patch
> Reconsider the ImportOrder rule of checkstyle
> --
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255467#comment-15255467
]
Hadoop QA commented on HBASE-15693:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
--
Affects Version/s: 1.4.0
1.3.0
2.0.0
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15699:
--
Attachment: HBASE-15699-v1.patch
Add a constructor for SyncFuture and do not call reset after the first
[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255480#comment-15255480
]
Hadoop QA commented on HBASE-15693:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255508#comment-15255508
]
Hadoop QA commented on HBASE-15699:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
44 matches
Mail list logo
