[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-710748683 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-710747257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-710736283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-710731386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-710731328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-710730879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506777664 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -152,9 +159,19 @@ private static final

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506777664 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -152,9 +159,19 @@ private static final

[GitHub] [hbase] z3n3r edited a comment on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r edited a comment on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-710722619 @saintstack , I did a rebase and force pushed the updated branch. I'll address your comments. This is an

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506776199 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java ## @@ -257,46 +327,62 @@ private void

[GitHub] [hbase] z3n3r commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-710722619 @saintstack , I did a rebase and force pushed the updateated branch. I'll address your comments. This is an

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506778311 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -430,11 +553,19 @@ private boolean

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506779022 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1926,6 +2225,27 @@ public void

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506778937 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1440,10 +1625,42 @@ private void

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506778454 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -768,6 +944,15 @@ public void

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506778434 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -511,6 +654,39 @@ public boolean

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506778311 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -430,11 +553,19 @@ private boolean

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r50655 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -400,28 +419,132 @@ public boolean

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506777664 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -152,9 +159,19 @@ private static final

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506776199 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java ## @@ -257,46 +327,62 @@ private void

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506776132 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -2986,6 +2988,7 @@ public GetMastersResponse

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775857 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -2531,6 +2531,7 @@ public GetTableStateResponse

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775609 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -124,7 +124,7 @@ import

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775438 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java ## @@ -205,6 +243,37 @@ public void testMetaComparisons2() {

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775285 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -110,6 +111,15 @@ @Deprecated public static final KVComparator

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775224 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -300,8 +300,12 @@ public static CellComparator

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775087 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java ## @@ -158,4 +174,14 @@ default int compareRows(ByteBuffer row, Cell

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775087 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java ## @@ -158,4 +174,14 @@ default int compareRows(ByteBuffer row, Cell

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506775008 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java ## @@ -250,6 +260,7 @@ DEFAULT_VALUES.put(PRIORITY,

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506774952 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java ## @@ -33,6 +33,25 @@ public static final RegionInfo

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506774887 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java ## @@ -33,6 +33,25 @@ public static final RegionInfo

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506774233 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java ## @@ -33,6 +33,25 @@ public static final RegionInfo

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506774118 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -2391,42 +2406,91 @@ public void run(Timeout timeout)

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506773956 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -2391,42 +2406,91 @@ public void run(Timeout timeout)

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506773828 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -2391,42 +2406,91 @@ public void run(Timeout timeout)

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506773341 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -1130,22 +1143,24 @@ public void run(PRESP resp) {

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506772798 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java ## @@ -206,16 +209,20 @@ public TableName getTable() { */

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506772765 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonRootRegionLocator.java ## @@ -174,10 +184,14 @@ private boolean

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506772362 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java ## @@ -126,7 +127,9 @@ private static int checkReplicaId(int

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506771434 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonRootRegionLocator.java ## @@ -667,4 +689,14 @@ int

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506770269 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonRootRegionLocator.java ## @@ -68,9 +70,9 @@ * The asynchronous locator for

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506770199 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/NotAllRootRegionsOnlineException.java ## @@ -25,19 +25,19 @@ * Thrown when an operation

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506770139 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ClientMetaTableAccessor.java ## @@ -193,15 +193,15 @@ private ClientMetaTableAccessor() {

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506770075 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java ## @@ -132,7 +132,7 @@ public static void

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506769908 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506769592 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506769105 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506768383 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506768145 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506767909 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506767895 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506767689 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506767036 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506767100 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506766854 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506766960 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506766409 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] z3n3r commented on a change in pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-16 Thread GitBox
z3n3r commented on a change in pull request #2445: URL: https://github.com/apache/hbase/pull/2445#discussion_r506766297 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2548: URL: https://github.com/apache/hbase/pull/2548#issuecomment-710536441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215613#comment-17215613 ] Huaxiang Sun edited comment on HBASE-18070 at 10/16/20, 7:45 PM: -

[jira] [Commented] (HBASE-25179) Assert format is incorrect in HFilePerformanceEvaluation class.

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215616#comment-17215616 ] Hudson commented on HBASE-25179: Results for branch branch-2.2 [build #100 on

[GitHub] [hbase] huaxiangsun commented on pull request #2522: HBASE-25215 Create a ReplicationEndPoint for meta/root replica replic…

2020-10-16 Thread GitBox
huaxiangsun commented on pull request #2522: URL: https://github.com/apache/hbase/pull/2522#issuecomment-710482867 > First, the issue number is incorrect, it should be HBASE-25125, not HBASE-25215. Thanks Duo, will correct. > > What I concern here is that, this is only an

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215613#comment-17215613 ] Huaxiang Sun commented on HBASE-18070: -- [~apurtell] , We are working on the client side change at

[jira] [Comment Edited] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215597#comment-17215597 ] Andrew Kyle Purtell edited comment on HBASE-18070 at 10/16/20, 6:39 PM:

[jira] [Comment Edited] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215597#comment-17215597 ] Andrew Kyle Purtell edited comment on HBASE-18070 at 10/16/20, 6:39 PM:

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215601#comment-17215601 ] Andrew Kyle Purtell commented on HBASE-18070: - As 2.4 RM [~huaxiangsun] [~stack] [~zhangduo]

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215597#comment-17215597 ] Andrew Kyle Purtell commented on HBASE-18070: - [~zhangduo] I think "we" is colleagues of

[jira] [Comment Edited] (HBASE-18070) Enable memstore replication for meta replica

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215597#comment-17215597 ] Andrew Kyle Purtell edited comment on HBASE-18070 at 10/16/20, 6:35 PM:

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215595#comment-17215595 ] Andrew Kyle Purtell commented on HBASE-25032: - Thanks for the update [~sandeep.guggilam] >

[jira] [Commented] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215594#comment-17215594 ] Andrew Kyle Purtell commented on HBASE-25130: - Thanks for the update [~sandeep.guggilam] >

[jira] [Comment Edited] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215586#comment-17215586 ] Andrew Kyle Purtell edited comment on HBASE-25183 at 10/16/20, 6:19 PM:

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215586#comment-17215586 ] Andrew Kyle Purtell commented on HBASE-25183: - bq. If I just want to keep politeness I could

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215579#comment-17215579 ] Andrew Kyle Purtell commented on HBASE-25183: - bq. We have a ClusterMetrics and usually we

[jira] [Comment Edited] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215570#comment-17215570 ] Andrew Kyle Purtell edited comment on HBASE-25183 at 10/16/20, 6:02 PM:

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215570#comment-17215570 ] Andrew Kyle Purtell commented on HBASE-25183: - I see the conflict has been moved to a thread

[jira] [Commented] (HBASE-25179) Assert format is incorrect in HFilePerformanceEvaluation class.

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215533#comment-17215533 ] Hudson commented on HBASE-25179: Results for branch branch-2.3 [build #84 on

[GitHub] [hbase] shahrs87 commented on pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-16 Thread GitBox
shahrs87 commented on pull request #2551: URL: https://github.com/apache/hbase/pull/2551#issuecomment-710236415 Thank you @virajjasani for the review and commit ! This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-22978) Online slow response log

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215500#comment-17215500 ] Hudson commented on HBASE-22978: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215502#comment-17215502 ] Hudson commented on HBASE-24718: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-24665) MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215504#comment-17215504 ] Hudson commented on HBASE-24665: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-24849) Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215503#comment-17215503 ] Hudson commented on HBASE-24849: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-25179) Assert format is incorrect in HFilePerformanceEvaluation class.

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215498#comment-17215498 ] Hudson commented on HBASE-25179: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-23935) Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215499#comment-17215499 ] Hudson commented on HBASE-23935: Results for branch branch-1 [build #44 on

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215501#comment-17215501 ] Hudson commented on HBASE-24528: Results for branch branch-1 [build #44 on

[GitHub] [hbase] Apache-HBase commented on pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2548: URL: https://github.com/apache/hbase/pull/2548#issuecomment-710124820 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2553: BackPort HBASE-25093 the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2553: URL: https://github.com/apache/hbase/pull/2553#issuecomment-710023279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Resolved] (HBASE-24849) Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-24849. --- Hadoop Flags: Reviewed Resolution: Fixed > Branch-1 Backport : HBASE-24665 MultiWAL : Avoid

[jira] [Updated] (HBASE-24849) Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24849: -- Component/s: wal > Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when > one

[GitHub] [hbase] Reidddddd merged pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread GitBox
Reidd merged pull request #2194: URL: https://github.com/apache/hbase/pull/2194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2553: BackPort HBASE-25093 the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2553: URL: https://github.com/apache/hbase/pull/2553#issuecomment-710021082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Reidddddd commented on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread GitBox
Reidd commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-710021123 We are cool now, thx for the contribution, this is nice @WenFeiYi This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-710018183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-710012394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24628) Region normalizer now respects a rate limit

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215361#comment-17215361 ] Hudson commented on HBASE-24628: Results for branch master [build #96 on

[GitHub] [hbase] Apache-HBase commented on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-709988778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25179) Assert format is incorrect in HFilePerformanceEvaluation class.

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215343#comment-17215343 ] Hudson commented on HBASE-25179: Results for branch branch-2 [build #78 on

[jira] [Commented] (HBASE-24628) Region normalizer now respects a rate limit

2020-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215341#comment-17215341 ] Hudson commented on HBASE-24628: Results for branch branch-2 [build #78 on

[jira] [Commented] (HBASE-25192) s390x support for HBase CI

2020-10-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215340#comment-17215340 ] Duo Zhang commented on HBASE-25192: --- I think first we could have a nightly build to run on the new

[jira] [Created] (HBASE-25192) s390x support for HBase CI

2020-10-16 Thread Aditi Jadhav (Jira)
Aditi Jadhav created HBASE-25192: Summary: s390x support for HBase CI Key: HBASE-25192 URL: https://issues.apache.org/jira/browse/HBASE-25192 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2553: BackPort HBASE-25093 the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-16 Thread GitBox
Apache-HBase commented on pull request #2553: URL: https://github.com/apache/hbase/pull/2553#issuecomment-709962546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

  1   2   >