Apache-HBase commented on pull request #2743:
URL: https://github.com/apache/hbase/pull/2743#issuecomment-739743270
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2744:
URL: https://github.com/apache/hbase/pull/2744#issuecomment-739741254
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2744:
URL: https://github.com/apache/hbase/pull/2744#issuecomment-739741090
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
SWH12 opened a new pull request #2744:
URL: https://github.com/apache/hbase/pull/2744
Fix spelling error :
from DOWNGRANDE_ACTIVE to DOWNGRADE_ACTIVE
This is an automated message from the Apache Git Service.
To respond to
ZhaoBQ opened a new pull request #2743:
URL: https://github.com/apache/hbase/pull/2743
[HBASE-25365](https://issues.apache.org/jira/browse/HBASE-25365)
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wenhao updated HBASE-25366:
---
Attachment: HBASE-25366.001.patch
Status: Patch Available (was: Open)
> [Documentation] Fix
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wenhao updated HBASE-25366:
---
Attachment: (was: HBASE-25366.001.patch)
> [Documentation] Fix spelling error
>
Apache-HBase commented on pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#issuecomment-739720707
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wenhao updated HBASE-25366:
---
Attachment: HBASE-25366.001.patch
> [Documentation] Fix spelling error
> --
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wenhao updated HBASE-25366:
---
Attachment: (was: 0001-Fix-typos-of-sync_replication.adoc.patch)
> [Documentation] Fix spelling error
>
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wenhao updated HBASE-25366:
---
Attachment: 0001-Fix-typos-of-sync_replication.adoc.patch
> [Documentation] Fix spelling error
>
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739713977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739713572
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739709100
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244994#comment-17244994
]
wenhao commented on HBASE-25366:
Hello, I am contributing to the hbase community for the first time. I
wenhao created HBASE-25366:
--
Summary: [Documentation] Fix spelling error
Key: HBASE-25366
URL: https://issues.apache.org/jira/browse/HBASE-25366
Project: HBase
Issue Type: Bug
Components:
ZhaoBQ opened a new pull request #2742:
URL: https://github.com/apache/hbase/pull/2742
[HBASE-25365](https://issues.apache.org/jira/browse/HBASE-25365)
This is an automated message from the Apache Git Service.
To respond to
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739695922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739694022
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739691461
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739679410
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739676523
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739675376
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
shahrs87 commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739673325
@anoopsjohn Addressed all your comments. Please review again. Thank you for
your feedback !
This is an
anoopsjohn commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537234942
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/TagBuilderFactory.java
##
@@ -0,0 +1,89 @@
+/**
+ * Copyright The Apache Software
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537234287
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/TagBuilderFactory.java
##
@@ -0,0 +1,89 @@
+/**
+ * Copyright The Apache Software
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739666331
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537234287
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/TagBuilderFactory.java
##
@@ -0,0 +1,89 @@
+/**
+ * Copyright The Apache Software
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739664939
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537232359
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/RawCell.java
##
@@ -64,4 +65,19 @@ public static void checkForTagsLength(int tagsLength)
anoopsjohn commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537231625
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/TagBuilderFactory.java
##
@@ -0,0 +1,89 @@
+/**
+ * Copyright The Apache Software
[
https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244954#comment-17244954
]
ramkrishna.s.vasudevan commented on HBASE-23811:
[~zhangduo]
yes I agree with you. Let
anoopsjohn commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537229508
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/RawCell.java
##
@@ -64,4 +65,19 @@ public static void checkForTagsLength(int
Baiqiang Zhao created HBASE-25365:
-
Summary: The log in move_servers_rsgroup is incorrect
Key: HBASE-25365
URL: https://issues.apache.org/jira/browse/HBASE-25365
Project: HBase
Issue Type:
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739632203
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244914#comment-17244914
]
Xiaolin Ha commented on HBASE-25334:
Thanks for pointing out this problem, [~stack].
Maybe this PR
[
https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244905#comment-17244905
]
shenshengli commented on HBASE-21874:
-
[~ram_krish] Only one directory can be configured here, but
hsiangawang commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739622609
Thank you for the quick reply! I will add this issue to JIRA later.
This is an automated message from the
Apache9 commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739612622
Oh, have you created an issue on https://issues.apache.org/jira? Apache
HBase still uses JIRA as the issue tracker, not github issues.
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739576697
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739575773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739575561
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739575542
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739574131
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739573729
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739571589
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739570883
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
shahrs87 commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-739570748
@anoopsjohn Thank you for your review. I have tried to address all your
comments in last commit. Could you please review again.
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537131913
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/RawCell.java
##
@@ -64,4 +65,19 @@ public static void checkForTagsLength(int tagsLength)
Apache-HBase commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739570489
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537131395
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TagBuilder.java
##
@@ -0,0 +1,59 @@
+/**
+ * Copyright The Apache Software Foundation
+ *
shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537131322
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferTag.java
##
@@ -44,6 +44,21 @@ public ByteBufferTag(ByteBuffer buffer, int
[
https://issues.apache.org/jira/browse/HBASE-25353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244815#comment-17244815
]
Hudson commented on HBASE-25353:
Results for branch branch-2
[build #123 on
[
https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244814#comment-17244814
]
Hudson commented on HBASE-25361:
Results for branch branch-2
[build #123 on
[
https://issues.apache.org/jira/browse/HBASE-25353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244805#comment-17244805
]
Hudson commented on HBASE-25353:
Results for branch branch-2.4
[build #3 on
[
https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244804#comment-17244804
]
Hudson commented on HBASE-25361:
Results for branch branch-2.4
[build #3 on
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244801#comment-17244801
]
Michael Stack commented on HBASE-25334:
---
Don't know if it helps but this test fails for me on
[
https://issues.apache.org/jira/browse/HBASE-25353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244781#comment-17244781
]
Hudson commented on HBASE-25353:
Results for branch branch-2.3
[build #121 on
[
https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244780#comment-17244780
]
Hudson commented on HBASE-25361:
Results for branch branch-2.3
[build #121 on
Apache9 commented on a change in pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#discussion_r537055988
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##
@@ -501,7 +501,8 @@ public DeadServer getDeadServers() {
Apache9 commented on pull request #2740:
URL: https://github.com/apache/hbase/pull/2740#issuecomment-739514025
I think the correct way to fix here is to change the assertion in
testClassFinderDefaultsToOwnPackage? The return value is a Set, so we should
not expect any particular order of
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739511487
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
GeorryHuang commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r537051205
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -380,143 +378,146 @@ public static Cell
GeorryHuang commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r537050892
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -380,143 +378,146 @@ public static Cell
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739510771
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
nyl3532016 commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r537046002
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -380,143 +378,146 @@ public static Cell
nyl3532016 commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r537045604
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -380,143 +378,146 @@ public static Cell
Apache9 commented on a change in pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#discussion_r537036842
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionCoprocessorHost.java
##
@@ -79,19 +81,36 @@
@Before
public
busbey commented on pull request #2737:
URL: https://github.com/apache/hbase/pull/2737#issuecomment-739500660
Maven profiles too
This is an automated message from the Apache Git Service.
To respond to the message, please log
busbey commented on pull request #2737:
URL: https://github.com/apache/hbase/pull/2737#issuecomment-739500371
Maven properties should be an array and then it should be included as an
expanded array, i.e. `"${MVN_PROPERTIES[@]}"`
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739495874
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739491323
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739490703
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739478414
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
sunhelly commented on pull request #2728:
URL: https://github.com/apache/hbase/pull/2728#issuecomment-739475363
I'm so sorry, didn't merge the master branch, so the UT is always passing.
@Apache9
I think the root cause is that, HBASE-25282 makes
sunhelly commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r536992895
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java
##
@@ -104,15 +93,15 @@ public static void
sunhelly commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r536992653
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java
##
@@ -104,15 +93,15 @@ public static void
Apache-HBase commented on pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#issuecomment-739471895
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#issuecomment-739471166
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
79 matches
Mail list logo
