gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1578844461
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
gvprathyusha6 commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2064857989
> Checked the POC, overall good.
>
> It is a pain that we need to touch the MOB related code.
>
> Anyway, I think first we could first do some refactorings, to move the
r
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571045154
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -822,22 +825,25 @@ private class StoreFileSplitter imp
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571011511
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(f
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571005337
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java:
##
@@ -189,6 +202,107 @@ public final StoreFileWriter
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571002658
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##
@@ -55,12 +65,49 @@ protected void
doAddCompac
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1570996949
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
Apache9 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1569899833
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062421730
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062411590
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062405932
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062398860
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062321856
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062319814
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062313555
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
Apache-HBase commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062297695
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docker
gvprathyusha6 commented on PR #5834:
URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062158504
> Modifies HStoreFile/StoreFileInfo constructors to take SFT interface as a
parameter. Refactors direct interactions of Reference/HFileLink creations to
SFT interface. Also moves getS
17 matches
Mail list logo