[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494950#comment-16494950
]
Ted Yu commented on HBASE-19483:
[~appy]:
Now permission checking is done by RS group endpoint, do we
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323459#comment-16323459
]
Andrew Purtell commented on HBASE-19483:
Thanks!
> Add proper privilege check for rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321605#comment-16321605
]
Guangxu Cheng commented on HBASE-19483:
---
{code}
1. AccessController.isAuthorizationSupported (
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321472#comment-16321472
]
Andrew Purtell commented on HBASE-19483:
Re: my above comment. I am not asking for a restoration
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321045#comment-16321045
]
Hudson commented on HBASE-19483:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4377 (See
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320428#comment-16320428
]
Guangxu Cheng commented on HBASE-19483:
---
Thanks all for patient reviewing.:)
> Add proper
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320333#comment-16320333
]
stack commented on HBASE-19483:
---
Addendum needed on branch-2 and master also [~zghaobac] ? Thanks.
> Add
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320111#comment-16320111
]
Hadoop QA commented on HBASE-19483:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320077#comment-16320077
]
Ted Yu commented on HBASE-19483:
When you use 'git apply' command on branch-1.4, you will see what I
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320054#comment-16320054
]
Guangxu Cheng commented on HBASE-19483:
---
bq.Please attach patch for branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320017#comment-16320017
]
Ted Yu commented on HBASE-19483:
Integrated to branch-1.
Please attach patch for branch-1.4
Thanks
>
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319987#comment-16319987
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319595#comment-16319595
]
Guangxu Cheng commented on HBASE-19483:
---
bq.+1 for branch-2. Thanks for asking.
boss, Thanks for
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318733#comment-16318733
]
stack commented on HBASE-19483:
---
+1 for branch-2. Thanks for asking.
> Add proper privilege check for
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318689#comment-16318689
]
Hudson commented on HBASE-19483:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4370 (See
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318662#comment-16318662
]
Ted Yu commented on HBASE-19483:
Guangxu:
Please prepare patch for branch-1 when you have time.
Thanks
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318404#comment-16318404
]
Hadoop QA commented on HBASE-19483:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318344#comment-16318344
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317823#comment-16317823
]
Guangxu Cheng commented on HBASE-19483:
---
bq.You can attach addendum for the two points Appy left on
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317798#comment-16317798
]
Hadoop QA commented on HBASE-19483:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317755#comment-16317755
]
Hudson commented on HBASE-19483:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4367 (See
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317704#comment-16317704
]
Ted Yu commented on HBASE-19483:
I pushed v14 to master branch.
Guangxu:
You can attach addendum for the
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317693#comment-16317693
]
Appy commented on HBASE-19483:
--
[~stack] yeah, this is security fix, so would be good to take in.
> Add
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316952#comment-16316952
]
Ted Yu commented on HBASE-19483:
[~stack]
Do you think this can go into next RC for beta1 ?
> Add proper
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316938#comment-16316938
]
Hadoop QA commented on HBASE-19483:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316933#comment-16316933
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316467#comment-16316467
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316215#comment-16316215
]
Guangxu Cheng commented on HBASE-19483:
---
bq.There are a few rejected hunks in
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314202#comment-16314202
]
Hudson commented on HBASE-19483:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4350 (See
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314010#comment-16314010
]
Appy commented on HBASE-19483:
--
no worries then :)
> Add proper privilege check for rsgroup commands
>
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313796#comment-16313796
]
Ted Yu commented on HBASE-19483:
bq. lgtm. last few comments, can go in then
I just saw your last
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313750#comment-16313750
]
Appy commented on HBASE-19483:
--
[~tedyu] Reason for the hurry please. Review is ongoing on RB.
> Add proper
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313705#comment-16313705
]
Ted Yu commented on HBASE-19483:
Integrated to master branch.
There are a few rejected hunks in
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313693#comment-16313693
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312107#comment-16312107
]
Appy commented on HBASE-19483:
--
Posted last few comments. Minor stuff. Looks good to go in after them.
>
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310821#comment-16310821
]
Appy commented on HBASE-19483:
--
Sorry, back again, first thing tomorrow morning. There were a lot of nice
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308518#comment-16308518
]
Ted Yu commented on HBASE-19483:
Ping [~appy]
> Add proper privilege check for rsgroup commands
>
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306265#comment-16306265
]
Ted Yu commented on HBASE-19483:
[~appy]:
Mind taking another look ?
> Add proper privilege check for
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306204#comment-16306204
]
Guangxu Cheng commented on HBASE-19483:
---
Checked the test report, TestThriftServerCmdLine failure
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306200#comment-16306200
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306041#comment-16306041
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305947#comment-16305947
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305944#comment-16305944
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305935#comment-16305935
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305647#comment-16305647
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305482#comment-16305482
]
Ted Yu commented on HBASE-19483:
Can you add release note ?
> Add proper privilege check for rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304979#comment-16304979
]
Ted Yu commented on HBASE-19483:
I ran TestScannersWithLabels with patch v9 :
{code}
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303817#comment-16303817
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303011#comment-16303011
]
Appy commented on HBASE-19483:
--
Thinking about it, i think it's great that this topic came up at this time
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302997#comment-16302997
]
Appy commented on HBASE-19483:
--
Need to give another thorough review, holidays in US right now so getting
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302851#comment-16302851
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302513#comment-16302513
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302060#comment-16302060
]
Appy commented on HBASE-19483:
--
[~andrewcheng] raises a good question on rb:
bq. If using
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301974#comment-16301974
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297917#comment-16297917
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297805#comment-16297805
]
Ted Yu commented on HBASE-19483:
[~appy]:
Can you take a look ?
> Add proper privilege check for rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296571#comment-16296571
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296051#comment-16296051
]
Guangxu Cheng commented on HBASE-19483:
---
Sorry for being slow:(, I will update patch today.
> Add
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295833#comment-16295833
]
Appy commented on HBASE-19483:
--
Any update here? beta1 is coming..changing apis after beta is bad thing. So
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292039#comment-16292039
]
Guangxu Cheng commented on HBASE-19483:
---
Thanks for the reviews. I agree to move rs group hooks
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291543#comment-16291543
]
Andrew Purtell commented on HBASE-19483:
In branch-1, as long as current interfaces don't change
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291539#comment-16291539
]
Andrew Purtell commented on HBASE-19483:
So after the proposed refactor, the AccessController and
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291200#comment-16291200
]
Appy commented on HBASE-19483:
--
(y)
> Add proper privilege check for rsgroup commands
>
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290121#comment-16290121
]
Ted Yu commented on HBASE-19483:
Using one JIRA should be fine since all the context is here.
> Add
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290084#comment-16290084
]
Appy commented on HBASE-19483:
--
At first I thought that [~stack]'s suggestion was great, but the current
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289639#comment-16289639
]
Ted Yu commented on HBASE-19483:
The rs group hooks from AccessController.java would be migrated to
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289622#comment-16289622
]
stack commented on HBASE-19483:
---
Endpoint sounds good. How you think it would work?
Not sure it applies to
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289620#comment-16289620
]
Ted Yu commented on HBASE-19483:
[~apurtell]:
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289570#comment-16289570
]
Ted Yu commented on HBASE-19483:
One option I can think of is to move all the prior and new rs group
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289561#comment-16289561
]
stack commented on HBASE-19483:
---
I think that two wrongs do not make a right.
Your suggestion is commit
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289327#comment-16289327
]
Ted Yu commented on HBASE-19483:
bq. The perm check should be baked into RSGroup
The hooks in Guangxu's
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288801#comment-16288801
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288792#comment-16288792
]
stack commented on HBASE-19483:
---
Aint' this just wrong, having hbase-server know about rsgroup? The perm
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288715#comment-16288715
]
Appy commented on HBASE-19483:
--
These are new ones, and not exposing any private class - RSGroupInfo is in
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288701#comment-16288701
]
Anoop Sam John commented on HBASE-19483:
Seems we have to add so many pre/post hooks here. May
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288477#comment-16288477
]
Appy commented on HBASE-19483:
--
{quote}
bq. Is there already a jira to discuss other questions
I don't think
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288461#comment-16288461
]
Ted Yu commented on HBASE-19483:
bq. Is there already a jira to discuss other questions
I don't think
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288454#comment-16288454
]
Appy commented on HBASE-19483:
--
bq. @param rsGroupInfo the group information
It'd be nice to have javadocs
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288429#comment-16288429
]
Appy commented on HBASE-19483:
--
ACL is more important than other topics there like dead nodes,
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288110#comment-16288110
]
Ted Yu commented on HBASE-19483:
TestBlockEvictionFromClient was not related to the patch.
[~appy]:
Can
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288105#comment-16288105
]
Hadoop QA commented on HBASE-19483:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287826#comment-16287826
]
Ted Yu commented on HBASE-19483:
Patch v2 looks good.
> Add proper privilege check for rsgroup commands
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287201#comment-16287201
]
Guangxu Cheng commented on HBASE-19483:
---
bq.nit: add @param for groupName (please check other new
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287199#comment-16287199
]
Guangxu Cheng commented on HBASE-19483:
---
{quote}
Review:
Add documentation in hbase book. RS Group
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286725#comment-16286725
]
Appy commented on HBASE-19483:
--
Review:
- Add documentation in hbase book. [RS Group
[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286269#comment-16286269
]
Ted Yu commented on HBASE-19483:
Looks good overall.
{code}
+ * Called before get rsgroup info for
86 matches
Mail list logo
