[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-29 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540970#comment-13540970 ] Jonathan Hsieh commented on HBASE-7294: --- +1. Thanks Matteo, Jesse. Committed to off

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540849#comment-13540849 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-28 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540393#comment-13540393 ] Jonathan Hsieh commented on HBASE-7294: --- Came back with some consistent failures. Th

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-27 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540242#comment-13540242 ] Jonathan Hsieh commented on HBASE-7294: --- looks good. +1. Running through tests and

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-26 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539614#comment-13539614 ] Jonathan Hsieh commented on HBASE-7294: --- We really push folks to use hbase.snapshot.

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-21 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538233#comment-13538233 ] Jonathan Hsieh commented on HBASE-7294: --- Ok, this make this hard to commit. I'll ad

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-21 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538121#comment-13538121 ] Matteo Bertozzi commented on HBASE-7294: this was written on top of the online bra

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-21 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538118#comment-13538118 ] Jonathan Hsieh commented on HBASE-7294: --- v4 Patch does not apply snapshot branch ff2

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-20 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537293#comment-13537293 ] Jonathan Hsieh commented on HBASE-7294: --- Another consideration is to turn these clea

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-20 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537288#comment-13537288 ] Jesse Yates commented on HBASE-7294: minor nit: we have a lot of snapshot tests that n

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536378#comment-13536378 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536240#comment-13536240 ] Jonathan Hsieh commented on HBASE-7294: --- We need to make sure the snapshots unit tes

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536200#comment-13536200 ] Ted Yu commented on HBASE-7294: --- {code} + * Called at startup, to verify if snapshot opera

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536051#comment-13536051 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536037#comment-13536037 ] Jonathan Hsieh commented on HBASE-7294: --- Please fix the "To been..." comment. It i

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536026#comment-13536026 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-18 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535437#comment-13535437 ] Jonathan Hsieh commented on HBASE-7294: --- seems like info level. {code} + LOG.w

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533815#comment-13533815 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-16 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533605#comment-13533605 ] Jesse Yates commented on HBASE-7294: [~mbertozzi] good on ya for taking this! What do

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533376#comment-13533376 ] Hadoop QA commented on HBASE-7294: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-07 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526484#comment-13526484 ] Jonathan Hsieh commented on HBASE-7294: --- The first should be the simplest -- no abil

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526026#comment-13526026 ] Jesse Yates commented on HBASE-7294: I'd like to see the cleaners added to hbase-defau

[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

2012-12-06 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526023#comment-13526023 ] Jonathan Hsieh commented on HBASE-7294: --- I think we should not allow snapshots if th