Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1962406600
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docke
Apache-HBase commented on PR #5706:
URL: https://github.com/apache/hbase/pull/5706#issuecomment-1962474422
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s | Docke
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1962613863
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s | Docker
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1962723381
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docker
kadirozde commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962788373
> In general, I think this is a good improvement.
>
> But for me, I think we should still keep the architecture clean, so I do
not think we should introduce a new 'DualFileWriter' a
Apache9 commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962840902
For me, I think whether to introduce a new store engine here is clear. If
this is a new layout way, which can not be worked together with other store
engines, we should introduce a new stor
Apache9 commented on code in PR #5688:
URL: https://github.com/apache/hbase/pull/5688#discussion_r1501763135
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java:
##
@@ -85,16 +84,15 @@ class Call {
* Builds a simplified {@link #toString()} that includes just
Apache9 commented on code in PR #5706:
URL: https://github.com/apache/hbase/pull/5706#discussion_r1501766068
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:
##
@@ -800,7 +800,12 @@ public int onlineHbck()
checkRegionBoundaries();
}
-c
Apache9 commented on code in PR #5706:
URL: https://github.com/apache/hbase/pull/5706#discussion_r1501766068
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:
##
@@ -800,7 +800,12 @@ public int onlineHbck()
checkRegionBoundaries();
}
-c
kadirozde commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962855097
@Apache9 , Thank you for this detailed response. Based your feedback, I will
integrate dual file writing into StoreFileWriter. StoreFileWriter will be able
to separate cells into live and
Apache9 commented on code in PR #5688:
URL: https://github.com/apache/hbase/pull/5688#discussion_r1501771164
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -252,35 +268,99 @@ public void operationComplete(Future future)
throws Exception
Apache9 commented on code in PR #5688:
URL: https://github.com/apache/hbase/pull/5688#discussion_r1501771630
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -201,23 +209,31 @@ private void failInit(Channel ch, IOException e) {
// fai
Apache9 commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962862133
Yes, for other store engines, we could add a check that you should not
enable the 'write latest cells to separated file' flag, and open follow on
issues to support this feature for other st
Apache9 merged PR #5694:
URL: https://github.com/apache/hbase/pull/5694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.
Apache9 merged PR #5688:
URL: https://github.com/apache/hbase/pull/5688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.
Apache9 opened a new pull request, #5707:
URL: https://github.com/apache/hbase/pull/5707
…and we use different principal for master and region server (#5688)
Signed-off-by: Bryan Beaudreault
(cherry picked from commit c4a02f7fcd1d74385b87bb761d25b118ce080119)
--
This is an autom
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1962947665
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 13s | Docke
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1962959463
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s | Docke
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963004341
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docker
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963007062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 1s | Docker
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963015255
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 17s | Docke
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963016197
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docker
Apache9 commented on code in PR #5700:
URL: https://github.com/apache/hbase/pull/5700#discussion_r1501953632
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java:
##
@@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin ad
Apache9 commented on code in PR #5700:
URL: https://github.com/apache/hbase/pull/5700#discussion_r1501954722
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java:
##
@@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin ad
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963189918
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
frostruan commented on code in PR #5700:
URL: https://github.com/apache/hbase/pull/5700#discussion_r1501977606
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java:
##
@@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963290172
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963349603
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docker
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963356267
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docker
chrajeshbabu commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963454139
From the discussion agreed to add master and branch-3 accordingly I have
changed the PR.
Is it good to go now? @ndimiduk @Apache9 ?
--
This is an automated message from the Apache
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464252
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464302
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464411
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache9 commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1502133971
##
dev-support/Jenkinsfile_GitHub:
##
@@ -470,6 +471,144 @@ pipeline {
}
}
}
+stage ('yetus
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963466554
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 33s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963466832
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 33s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963467150
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s | Docke
chrajeshbabu commented on PR #5678:
URL: https://github.com/apache/hbase/pull/5678#issuecomment-1963468433
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1502143177
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,122 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
+ w
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1502147916
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,122 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
+ w
pankaj72981 commented on code in PR #5691:
URL: https://github.com/apache/hbase/pull/5691#discussion_r1502147908
##
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java:
##
@@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws
IOExcep
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1502143177
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,122 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
+ w
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1502147916
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,122 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
+ w
pankaj72981 commented on code in PR #5691:
URL: https://github.com/apache/hbase/pull/5691#discussion_r1502147908
##
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java:
##
@@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws
IOExcep
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963500046
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docker
Apache-HBase commented on PR #5705:
URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963513057
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s | Docke
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963523644
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963529616
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963529817
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963530017
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963530362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963530998
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963533401
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963601061
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963601525
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963601524
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963601632
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963601739
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hbase.apache.org/job/H
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963602715
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963602795
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5689:
URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963604843
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s | Docke
jhungund opened a new pull request, #5708:
URL: https://github.com/apache/hbase/pull/5708
HBASE-27230 RegionServer should be aborted when WAL.sync throws Timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jhungund closed pull request #5708: Port HBASE-27230 to branch-2
URL: https://github.com/apache/hbase/pull/5708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jhungund commented on PR #5708:
URL: https://github.com/apache/hbase/pull/5708#issuecomment-1963887526
Abandoned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
guluo2016 commented on code in PR #5706:
URL: https://github.com/apache/hbase/pull/5706#discussion_r1502501590
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:
##
@@ -800,7 +800,12 @@ public int onlineHbck()
checkRegionBoundaries();
}
-
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963986278
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1964014689
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docker
jhungund opened a new pull request, #5711:
URL: https://github.com/apache/hbase/pull/5711
…… (#4641)
Change-Id: I4a413143681376235a250d164fec36ff9eb377b4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Apache-HBase commented on PR #5709:
URL: https://github.com/apache/hbase/pull/5709#issuecomment-1964055654
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s | Docke
Apache-HBase commented on PR #5710:
URL: https://github.com/apache/hbase/pull/5710#issuecomment-1964074271
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docke
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1964098838
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docker
Apache-HBase commented on PR #5706:
URL: https://github.com/apache/hbase/pull/5706#issuecomment-1964128253
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s | Docke
Apache-HBase commented on PR #5712:
URL: https://github.com/apache/hbase/pull/5712#issuecomment-1964233440
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5712:
URL: https://github.com/apache/hbase/pull/5712#issuecomment-1964236236
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s | Docke
Apache-HBase commented on PR #5712:
URL: https://github.com/apache/hbase/pull/5712#issuecomment-1964253964
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docke
ndimiduk commented on PR #112:
URL: https://github.com/apache/hbase-thirdparty/pull/112#issuecomment-1964337792
I can't get a clean unit test run on any branch, with or without this change
involved. Moving forward with the RC.
--
This is an automated message from the Apache Git Service.
T
ndimiduk merged PR #112:
URL: https://github.com/apache/hbase-thirdparty/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hba
Apache-HBase commented on PR #5709:
URL: https://github.com/apache/hbase/pull/5709#issuecomment-1964548379
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docke
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1964564372
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docker
Apache-HBase commented on PR #5709:
URL: https://github.com/apache/hbase/pull/5709#issuecomment-1964584517
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1964630617
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 39s | Docke
Apache-HBase commented on PR #5706:
URL: https://github.com/apache/hbase/pull/5706#issuecomment-1964645624
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 59s | Docke
Apache-HBase commented on PR #5706:
URL: https://github.com/apache/hbase/pull/5706#issuecomment-1964667069
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s | Docke
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1964691003
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
Apache-HBase commented on PR #5710:
URL: https://github.com/apache/hbase/pull/5710#issuecomment-1964723342
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 19s | Docke
Apache-HBase commented on PR #5710:
URL: https://github.com/apache/hbase/pull/5710#issuecomment-1965105048
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s | Docke
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1965231909
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docker
Apache-HBase commented on PR #5711:
URL: https://github.com/apache/hbase/pull/5711#issuecomment-1965261258
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docke
shahrs87 commented on code in PR #5695:
URL: https://github.com/apache/hbase/pull/5695#discussion_r1503642618
##
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##
@@ -1203,12 +1203,6 @@ public void
preDecommissionRegionServers(Observer
Apache-HBase commented on PR #5695:
URL: https://github.com/apache/hbase/pull/5695#issuecomment-1965821942
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s | Docke
NihalJain commented on code in PR #5695:
URL: https://github.com/apache/hbase/pull/5695#discussion_r1503858370
##
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##
@@ -1203,12 +1203,6 @@ public void
preDecommissionRegionServers(Observe
Apache-HBase commented on PR #5695:
URL: https://github.com/apache/hbase/pull/5695#issuecomment-1966116522
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s | Docke
Apache-HBase commented on PR #5695:
URL: https://github.com/apache/hbase/pull/5695#issuecomment-1966130805
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docke
aalhour commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966144703
@frostruan, which part of the code would handle that byte? Also, should that
be added to this PR or yours (https://github.com/apache/hbase/pull/5700)?
--
This is an automated message from
frostruan commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966341246
I think there are two problems here:
1. For in-transition regions, the result of RegionLocation.getServerName()
could be null. In the current PR, we just filter out these regions. With
frostruan commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966344106
Also ping Duo~ @Apache9
This problem is related to my PR you reviewed yesterday, would you mind
taking a look at this too ?
--
This is an automated message from the Apache Git S
Apache-HBase commented on PR #5707:
URL: https://github.com/apache/hbase/pull/5707#issuecomment-1966353273
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s | Docke
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1504055111
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -78,7 +85,10 @@ public Thread newThread(Runnable r) {
+ Path.SEPARAT
aalhour commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966464798
I'm wondering what the byte constant would hold, other than `0`:
- If it held `1`, it would mean that regions that no longer exist would
still get reported with size (maybe?)
- I'm h
frostruan commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966499225
I prefer to use 1 byte to represent unknown region size for two reasons:
1. it cannot be a valid region size because even a minimal keyvalue is
bigger than that.
2. some computin
501 - 600 of 2240 matches
Mail list logo
