liurenjie1024 commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1888570500
> Does this proposal look like following?
>
> let literal = BoundLiteral::builder.with_literal(...).build();
> TableScan scan = scan.filter(Expressions.equal("id", l
ZENOTME commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1888563964
>When user construction UnboundExpression, it's not always from sql. For
example when we integrate it with other sql engines, it may push filter to
iceberg api to construct Unboun
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1449959948
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +213,136 @@ default Table newHmsTable(String hmsTableOwner) {
return
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1449952807
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -166,153 +164,58 @@ protected void doRefresh() {
refreshFromMetadataLocation
nk1506 commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-1888541095
cc: @pvary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
nk1506 opened a new pull request, #9461:
URL: https://github.com/apache/iceberg/pull/9461
Ref: https://github.com/apache/iceberg/pull/8907#discussion_r1441986754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liurenjie1024 commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1888538588
I think we have reached consensus that storing a `BoundLiteral` in
`UnboundExpression` is acceptable. About the visibility of this struct, I would
argue that we still need t
HonahX opened a new pull request, #266:
URL: https://github.com/apache/iceberg-python/pull/266
This PR supports updating table properties by adding the following table
metadata updates:
- SetPropertiesUpdate [Java
Ref](https://github.com/apache/iceberg/blob/2aac63688054ac36540072cfa13aac
liurenjie1024 commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1449911450
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
liurenjie1024 commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1449890234
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,41 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
BsoBird commented on PR #9333:
URL: https://github.com/apache/iceberg/pull/9333#issuecomment-1888504317
@RussellSpitzer
Hi. I've found that if we want to be able to simulate exceptions better, we
need to use PowerMock to proxy some private methods. There are some catalogs
where the exec
HonahX commented on issue #255:
URL: https://github.com/apache/iceberg-python/issues/255#issuecomment-1888457045
Hi @stefnba. I tried `pyiceberg list` using the given config file in
pyiceberg0.5.1 on my Mac and it seemed to work as expected.
You're right that Glue doesn't require a U
HonahX commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449849825
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
HonahX commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449849825
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
syun64 commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449812309
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1888422180
To make the design more simple, I have removed the **WriteResult trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
syun64 commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449807335
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
syun64 commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449806795
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
HonahX commented on code in PR #265:
URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449791012
##
pyiceberg/catalog/sql.py:
##
@@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
Raises:
liurenjie1024 commented on PR #163:
URL: https://github.com/apache/iceberg-rust/pull/163#issuecomment-1888397282
cc @Fokko @Xuanwo @ZENOTME PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
liurenjie1024 commented on PR #162:
URL: https://github.com/apache/iceberg-rust/pull/162#issuecomment-1888373484
cc @Fokko @Xuanwo @ZENOTME PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
liurenjie1024 opened a new pull request, #162:
URL: https://github.com/apache/iceberg-rust/pull/162
File based planning api is done, update the status in README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1888371442
Hi, @hiirrxnn The `cargo sort` check failed, you can run `cargo sort -w` to
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
yyy1000 commented on issue #9458:
URL: https://github.com/apache/iceberg/issues/9458#issuecomment-1888338869
I think the `next` method in `AvroReuseIterator` could access
`AvroIterable.file`, but would make `AvroIterable.file` a static variable
because class `AvroReuseIterator` is static.
ajantha-bhat commented on code in PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#discussion_r1449688656
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -128,6 +133,26 @@ public void initialize(String name, Map
options) {
catalogO
gaoshihang closed issue #9460: Why parquet list must be 3-level representation?
URL: https://github.com/apache/iceberg/issues/9460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
rdblue merged PR #9435:
URL: https://github.com/apache/iceberg/pull/9435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on code in PR #9453:
URL: https://github.com/apache/iceberg/pull/9453#discussion_r1449575363
##
core/src/main/java/org/apache/iceberg/encryption/AesGcmOutputStream.java:
##
@@ -56,6 +58,7 @@ public class AesGcmOutputStream extends PositionOutputStream {
thi
github-actions[bot] commented on issue #6766:
URL: https://github.com/apache/iceberg/issues/6766#issuecomment-1888178876
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #6766: Support adding Delta transaction to
Iceberg
URL: https://github.com/apache/iceberg/issues/6766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] closed issue #6964: Migrating iceberg table on object
storage
URL: https://github.com/apache/iceberg/issues/6964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] commented on issue #6964:
URL: https://github.com/apache/iceberg/issues/6964#issuecomment-1888178799
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
javrasya commented on issue #9410:
URL: https://github.com/apache/iceberg/issues/9410#issuecomment-1888101057
Hi again @pvary. I managed to run it in debug mode and the JSON which is
being deserialized is crammed with delete files (`EQUALITY_DELETES` and
`POSITION_DELETES`). It is a gigan
gaoshihang commented on issue #9418:
URL: https://github.com/apache/iceberg/issues/9418#issuecomment-1888065428
Hi @manuzhang , the error schema is this column:
```
Column(array)
name: array
path: request.context.profile_concrete_event_id.array
max_def
syun64 opened a new pull request, #265:
URL: https://github.com/apache/iceberg-python/pull/265
https://github.com/apache/iceberg-python/issues/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko merged PR #264:
URL: https://github.com/apache/iceberg-python/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #263:
URL: https://github.com/apache/iceberg-python/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
gaoshihang commented on issue #9418:
URL: https://github.com/apache/iceberg/issues/9418#issuecomment-1887935637
[parquet-inspect.log](https://github.com/apache/iceberg/files/13908251/parquet-inspect.log)
Hi @manuzhang thanks for your reply, I'm same team with @hbpeng0115, this is
the par
dependabot[bot] opened a new pull request, #264:
URL: https://github.com/apache/iceberg-python/pull/264
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
Release notes
Sourced from https://github.com/pallets/jinja/releases";>jinja2's releases.
3.1.3
Thi
dependabot[bot] opened a new pull request, #263:
URL: https://github.com/apache/iceberg-python/pull/263
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
Release notes
Sourced from https://github.com/pallets/jinja/releases";>jinja2's releases.
3.1.3
Thi
Fokko merged PR #260:
URL: https://github.com/apache/iceberg-python/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1887912820
First of all, thanks for the explanation of the Literal.
> This sounds a good idea to me, which doesn't introduce extra maintain
effort. The only concern is that it maybe not
Fokko merged PR #261:
URL: https://github.com/apache/iceberg-python/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
gjacoby126 commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1449317695
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (A
gjacoby126 commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1449317360
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (A
gjacoby126 commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1449302007
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (A
ndrluis opened a new pull request, #261:
URL: https://github.com/apache/iceberg-python/pull/261
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
stevenzwu commented on PR #9456:
URL: https://github.com/apache/iceberg/pull/9456#issuecomment-1887717611
@rodmeneses I assume you have checked the diff that nothing is related to
this change, e.g. https://github.com/apache/iceberg/pull/8228
--
This is an automated message from the Apache
gaoshihang opened a new issue, #9460:
URL: https://github.com/apache/iceberg/issues/9460
### Query engine
Spark
### Question
We now have some parquet files with 2-level representation list, can we
build metadata based on these parquet files?
--
This is an automated me
dimas-b commented on code in PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#discussion_r1448996985
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -128,6 +133,26 @@ public void initialize(String name, Map
options) {
catalogOption
szehon-ho commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1448696780
##
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##
@@ -452,6 +454,68 @@ private static void checkSchemaCompatibility(
}
}
+ /**
+ * Estimate
pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1448871275
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
imonteroq commented on issue #8544:
URL: https://github.com/apache/iceberg/issues/8544#issuecomment-1887166823
Hey @wood-dunamu , I am still getting it on S`park 3.4.1-amzn-2`, `EMR
serverless 6.15.0` and `Iceberg 1.4.0-amzn-0`
```
24/01/11 09:59:49 WARN IcebergBuild: Failed to load ve
pvary commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1448828580
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
pvary commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1448827079
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
pvary commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1448824172
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
pvary commented on code in PR #9452:
URL: https://github.com/apache/iceberg/pull/9452#discussion_r1448820134
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/util/FlinkVersionDetector.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
ajantha-bhat commented on PR #9298:
URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1887057080
ping.
Anything else needed for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1448763957
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier or
ajantha-bhat commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887024697
PR title may need update as it is TException now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
ajantha-bhat commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887023716
LGTM aswell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
pvary commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887018214
@ajantha-bhat: I think this looks good. Any more comments on your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ajantha-bhat commented on PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#issuecomment-1886957108
@nk1506: Not just major, I want to conclude on all the comments that are
open. So, we can move forward.
--
This is an automated message from the Apache Git Service.
To respond to
zhongyujiang commented on issue #9404:
URL: https://github.com/apache/iceberg/issues/9404#issuecomment-1886945482
https://github.com/apache/iceberg/blob/31e31fd819c846f49d2bd459b8bfadfdc3c2bc3a/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BaseReader.java#L201-L208
--
Thi
zhongyujiang commented on issue #9404:
URL: https://github.com/apache/iceberg/issues/9404#issuecomment-1886935837
@purna344 I have used migrate procedure to migrate partitioned Parquet
tables to Iceberg tables(no partition columns exists in Parquet files neither),
based on my experience, S
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886827154
Please review .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
nk1506 commented on PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#issuecomment-1886809763
@ajantha-bhat / @pvary I think only major
[comment](https://github.com/apache/iceberg/pull/8907#discussion_r1448341650)
left here is Should we use lock before committing view table or not
ajantha-bhat commented on PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#issuecomment-1886793571
@nk1506, @pvary: I have added this PR to upcoming 1.5.0 release.
I will also do one round of review tomorrow.
@nk1506: Please consolidate what comments are pending as now f
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448606533
##
format/spec.md:
##
@@ -322,14 +322,22 @@ The `void` transform may be used to replace the transform
in an existing partiti
Bucket Transform Details
-Buc
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448596043
##
format/spec.md:
##
@@ -314,7 +314,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
| Transform name| Description
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1448591538
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448582861
##
format/spec.md:
##
@@ -986,6 +994,14 @@ The types below are not currently valid for bucketing, and
so are not hashed. Ho
| **`float`**| `hashLong(double
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886741367
> Should i rebase feature (the branch whose PR this is) with main? Or should
i merge?
I think both are ok to me.
--
This is an automated message from the Apache Git Serv
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448576223
##
format/spec.md:
##
@@ -322,14 +322,22 @@ The `void` transform may be used to replace the transform
in an existing partiti
Bucket Transform Details
-Buc
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448575877
##
format/spec.md:
##
@@ -1073,6 +1097,12 @@ Each sort field in the fields list is stored as an
object with the following pro
|--- |--- |--- |
|**`Sort Field`**|`
advancedxy commented on code in PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#discussion_r1448572967
##
format/spec.md:
##
@@ -1043,21 +1059,29 @@ Partition specs are serialized as a JSON object with
the following fields:
Each partition field in the fields list
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886724423
Should i rebase feature (the branch whose PR this is) with main? Or should i
merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ajantha-bhat opened a new pull request, #9459:
URL: https://github.com/apache/iceberg/pull/9459
Currently default version is v1.
So, If users need V2, they need to configure v2 URI and set the
`client-api-version` to "2".
With this change, just configuring v2 URI is enough.
`
78 matches
Mail list logo
