Re: [PR] Build: Bump actions/upload-artifact from 3 to 4 [iceberg-python]

2024-02-09 Thread via GitHub
dependabot[bot] commented on PR #404: URL: https://github.com/apache/iceberg-python/pull/404#issuecomment-1936906747 OK, I won't notify you about actions/upload-artifact again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Build: Bump actions/upload-artifact from 3 to 4 [iceberg-python]

2024-02-09 Thread via GitHub
dependabot[bot] closed pull request #404: Build: Bump actions/upload-artifact from 3 to 4 URL: https://github.com/apache/iceberg-python/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build: Bump actions/upload-artifact from 3 to 4 [iceberg-python]

2024-02-09 Thread via GitHub
Fokko commented on PR #404: URL: https://github.com/apache/iceberg-python/pull/404#issuecomment-1936906733 @dependabot ignore this dependency We want to stay on version 3 to allow merging the artifacts -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Hive locking [iceberg-python]

2024-02-09 Thread via GitHub
Fokko commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1484994993 ## pyiceberg/catalog/hive.py: ## @@ -155,7 +164,7 @@ def _construct_hive_storage_descriptor(schema: Schema, location: Optional[str]) PROP_TABLE_TYPE =

Re: [I] Does iceberg have a plan to support Multi-Statement and Multi-Table Transactions ? [iceberg]

2024-02-09 Thread via GitHub
ajantha-bhat commented on issue #1074: URL: https://github.com/apache/iceberg/issues/1074#issuecomment-1936798475 Status can be tracked from https://github.com/apache/iceberg/projects/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Does iceberg have a plan to support Multi-Statement and Multi-Table Transactions ? [iceberg]

2024-02-09 Thread via GitHub
ajantha-bhat closed issue #1074: Does iceberg have a plan to support Multi-Statement and Multi-Table Transactions ? URL: https://github.com/apache/iceberg/issues/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Support Nessie catalog [iceberg-python]

2024-02-09 Thread via GitHub
ajantha-bhat commented on issue #19: URL: https://github.com/apache/iceberg-python/issues/19#issuecomment-1936796644 @jbonofre might take it up after java 1.5.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Spark 3.3: Add RemoveDanglingDeletes action [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #6581: URL: https://github.com/apache/iceberg/pull/6581#discussion_r1484909765 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RemoveDanglingDeletesSparkAction.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484905812 ## format/spec.md: ## @@ -1117,7 +1121,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`|

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484906498 ## format/spec.md: ## @@ -301,12 +301,14 @@ Tables are configured with a **partition spec** that defines how to produce a tu * A **transform** that is applied to

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484906929 ## format/spec.md: ## @@ -1130,14 +1140,11 @@ Each partition field in the fields list is stored as an object. See the table fo |**`hour`**|`JSON string:

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484906656 ## format/spec.md: ## @@ -1150,13 +1161,17 @@ Sort orders are serialized as a list of JSON object, each of which contains the Each sort field in the fields list

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484906174 ## format/spec.md: ## @@ -1117,7 +1117,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`|

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484905812 ## format/spec.md: ## @@ -1117,7 +1121,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`|

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484905812 ## format/spec.md: ## @@ -1117,7 +1121,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`|

Re: [I] Add docker demo for iceberg starters [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1081: URL: https://github.com/apache/iceberg/issues/1081#issuecomment-1936760197 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Storing Lot of Sparse Columns [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1078: URL: https://github.com/apache/iceberg/issues/1078#issuecomment-1936760187 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Does iceberg have a plan to support Multi-Statement and Multi-Table Transactions ? [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1074: URL: https://github.com/apache/iceberg/issues/1074#issuecomment-1936760174 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Support container reuse in SparkOrcValueReader [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1058: URL: https://github.com/apache/iceberg/issues/1058#issuecomment-1936760152 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Add retry framework to Hadoop table load [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #758: URL: https://github.com/apache/iceberg/issues/758#issuecomment-1936760052 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] Add retry framework to Hadoop table load [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] closed issue #758: Add retry framework to Hadoop table load URL: https://github.com/apache/iceberg/issues/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Add an option to decide whether to delete data files in Catalog.dropTable() [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] closed issue #751: Add an option to decide whether to delete data files in Catalog.dropTable() URL: https://github.com/apache/iceberg/issues/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] ExpireSnapshots break on top of PR https://github.com/apache/incubator-iceberg/pull/695 [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #744: URL: https://github.com/apache/iceberg/issues/744#issuecomment-1936760024 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] ExpireSnapshots break on top of PR https://github.com/apache/incubator-iceberg/pull/695 [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] closed issue #744: ExpireSnapshots break on top of PR https://github.com/apache/incubator-iceberg/pull/695 URL: https://github.com/apache/iceberg/issues/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Why do we need two avro record readers & writers ? [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1152: URL: https://github.com/apache/iceberg/issues/1152#issuecomment-1936760213 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] [Question]How iceberg read data from metadata, has any paper introduce it? [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1050: URL: https://github.com/apache/iceberg/issues/1050#issuecomment-1936760126 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Adding an attribute in ORC TypeDescription causes failures. [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #1057: URL: https://github.com/apache/iceberg/issues/1057#issuecomment-1936760142 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Add an option to decide whether to delete data files in Catalog.dropTable() [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #751: URL: https://github.com/apache/iceberg/issues/751#issuecomment-1936760039 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] Upsert support [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] closed issue #730: Upsert support URL: https://github.com/apache/iceberg/issues/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Upsert support [iceberg]

2024-02-09 Thread via GitHub
github-actions[bot] commented on issue #730: URL: https://github.com/apache/iceberg/issues/730#issuecomment-1936760013 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

[PR] Build: Bump actions/upload-artifact from 3 to 4 [iceberg-python]

2024-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #404: URL: https://github.com/apache/iceberg-python/pull/404 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. Release notes Sourced from

Re: [PR] Core: rewrite should drop delete files by data sequence number partition wise [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9454: URL: https://github.com/apache/iceberg/pull/9454#discussion_r1484869653 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -289,13 +321,38 @@ private void invalidateFilteredCache() {

[PR] Make thrift transport configurable [iceberg-rust]

2024-02-09 Thread via GitHub
DeaconDesperado opened a new pull request, #194: URL: https://github.com/apache/iceberg-rust/pull/194 Adds an enum `HmsThriftTransport` to the `HmsCatalogConfig` to allow setting the thrift transport type #188 Corresponds to the metastore setting

[I] select distinct on table scan [iceberg-python]

2024-02-09 Thread via GitHub
carcmarc opened a new issue, #403: URL: https://github.com/apache/iceberg-python/issues/403 ### Feature Request / Improvement support table scan that returns distinct values of fields. Example: selected_fields=('distinct column_name',). Potentially added as a PyIceberg Expression or

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484856629 ## open-api/rest-catalog-open-api.yaml: ## @@ -3178,6 +3224,12 @@ components: ListNamespacesResponse: type: object properties: +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484856629 ## open-api/rest-catalog-open-api.yaml: ## @@ -3178,6 +3224,12 @@ components: ListNamespacesResponse: type: object properties: +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484855789 ## open-api/rest-catalog-open-api.yaml: ## @@ -3169,6 +3209,12 @@ components: ListTablesResponse: type: object properties: +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484854975 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,38 @@ components: explode: false example: "vended-credentials,remote-signing" +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484853025 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,38 @@ components: explode: false example: "vended-credentials,remote-signing" +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484852902 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,38 @@ components: explode: false example: "vended-credentials,remote-signing" +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484850869 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,38 @@ components: explode: false example: "vended-credentials,remote-signing" +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-09 Thread via GitHub
danielcweeks commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1484848736 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,38 @@ components: explode: false example: "vended-credentials,remote-signing" +

Re: [PR] Core: rewrite should drop delete files by data sequence number partition wise [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9454: URL: https://github.com/apache/iceberg/pull/9454#discussion_r1484844316 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -289,13 +321,38 @@ private void invalidateFilteredCache() {

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1484814023 ## format/spec.md: ## @@ -301,12 +301,14 @@ Tables are configured with a **partition spec** that defines how to produce a tu * A **transform** that is applied

[PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-09 Thread via GitHub
rahil-c opened a new pull request, #9695: URL: https://github.com/apache/iceberg/pull/9695 Dev list discussion thread for this change: https://lists.apache.org/thread/flmw1qts0hv8n0k4pd9n1nfry322633y cc @jackye1995 @rdblue @danielcweeks ## Testing ran make install,

Re: [PR] Spark 3.5: Add max allowed failed commits to RewriteDataFiles when partial progress is enabled [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9611: URL: https://github.com/apache/iceberg/pull/9611#discussion_r1484745294 ## core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java: ## @@ -227,13 +228,18 @@ private void commitReadyCommitGroups() { try {

Re: [PR] Spark 3.5: Add max allowed failed commits to RewriteDataFiles when partial progress is enabled [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9611: URL: https://github.com/apache/iceberg/pull/9611#discussion_r1484744762 ## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ## @@ -52,6 +52,13 @@ public interface RewriteDataFiles int

[PR] Made IcebergFilesCommitter work with single phase commit [iceberg]

2024-02-09 Thread via GitHub
mudit-97 opened a new pull request, #9694: URL: https://github.com/apache/iceberg/pull/9694 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Support iceberg hadoop catalog in python library [iceberg-python]

2024-02-09 Thread via GitHub
brianfromoregon commented on issue #17: URL: https://github.com/apache/iceberg-python/issues/17#issuecomment-1936434926 We use hadoop catalog on a fs with atomic move support. Would you accept a contributed hadoop catalog to pyiceberg? -- This is an automated message from the Apache Git

Re: [I] java.lang.IllegalArgumentException: requirement failed: length (-6235972) cannot be smaller than -1 [iceberg]

2024-02-09 Thread via GitHub
rjayapalan commented on issue #9689: URL: https://github.com/apache/iceberg/issues/9689#issuecomment-1936419501 @nastra I cannot produce the exact code that I used due to confidential information in there. But these are the steps that I used to reproduce 1. Create an iceberg table

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1484656650 ## api/src/main/java/org/apache/iceberg/ExpireSnapshots.java: ## @@ -118,4 +118,9 @@ public interface ExpireSnapshots extends PendingUpdate> { * @return this

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1484650533 ## api/src/main/java/org/apache/iceberg/ExpireSnapshots.java: ## @@ -118,4 +118,9 @@ public interface ExpireSnapshots extends PendingUpdate> { * @return this

Re: [PR] Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations. [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on PR #8625: URL: https://github.com/apache/iceberg/pull/8625#issuecomment-1936377596 My point in the earlier message is that I am not sure this PR would actually have an effect because changes are not going to be used by our write path in Java. Am I missing anything

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-09 Thread via GitHub
aokolnychyi commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1484642976 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -405,15 +407,18 @@ public boolean equals(Object other) { return

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1484631950 ## core/src/main/java/org/apache/iceberg/BaseMetadata.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1484628175 ## core/src/main/java/org/apache/iceberg/BaseMetadata.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-09 Thread via GitHub
szehon-ho commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1484625251 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -68,21 +61,27 @@ default Integer currentSchemaId() { return currentSchemaId; } +

Re: [I] Support Nessie catalog [iceberg-python]

2024-02-09 Thread via GitHub
seunggs commented on issue #19: URL: https://github.com/apache/iceberg-python/issues/19#issuecomment-1936322637 Any update on supporting nessie catalog? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Support reading and writing snapshot properties [iceberg-python]

2024-02-09 Thread via GitHub
Gowthami03B commented on issue #367: URL: https://github.com/apache/iceberg-python/issues/367#issuecomment-1936299084 @brianfromoregon @Fokko can I take a stab at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Support reading and writing snapshot properties [iceberg-python]

2024-02-09 Thread via GitHub
brianfromoregon commented on issue #367: URL: https://github.com/apache/iceberg-python/issues/367#issuecomment-1936296587 There is a test in the repo called test_glue.py called

Re: [I] rewrite_data_files procedure fails with Premature end of Content-Length when using S3 client [iceberg]

2024-02-09 Thread via GitHub
paulpaul1076 commented on issue #9679: URL: https://github.com/apache/iceberg/issues/9679#issuecomment-1936244579 Btw, as I said the Scala DSL for compaction works, Spark SQL doesn't. I compared the job parameters in the Spark UI tab, they are absolutely identical, so, it's not like

Re: [I] rewrite_data_files procedure fails with Premature end of Content-Length when using S3 client [iceberg]

2024-02-09 Thread via GitHub
paulpaul1076 commented on issue #9679: URL: https://github.com/apache/iceberg/issues/9679#issuecomment-1936239049 @nastra where should I upload the data for you? I will upload it, then you can register the table in your catalog. I used hive catalog, but I don't think it matters.

[I] Strikethrough is broken in the specification [iceberg]

2024-02-09 Thread via GitHub
Fokko opened a new issue, #9693: URL: https://github.com/apache/iceberg/issues/9693 ### Feature Request / Improvement ![image](https://github.com/apache/iceberg/assets/1134248/3e8857e8-1f23-4250-90c2-65e343b1397b) ### Query engine None -- This is an automated

Re: [I] Support to optimize, analyze tables and expire snapshots, remove orphan files [iceberg-python]

2024-02-09 Thread via GitHub
carcmarc commented on issue #31: URL: https://github.com/apache/iceberg-python/issues/31#issuecomment-1936116060 Any progress on this issue? Seems core to table manipulation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Release: add instruction to update doap.rdf file as part of release process [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on PR #9655: URL: https://github.com/apache/iceberg/pull/9655#issuecomment-1936074311 @Fokko what do you think about this PR ? Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484377782 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +161,92 @@ public void testInitialize() {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484373833 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +161,92 @@ public void testInitialize() {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1935969951 @nastra thanks ! I addressed your comments. The PR is ready for a new round  Thanks again ! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484320774 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -81,85 +109,243 @@ final class JdbcUtil { + TABLE_NAME + ")" + ")";

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484319960 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -73,6 +99,8 @@ final class JdbcUtil { + " VARCHAR(1000)," +

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484317280 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -60,16 +61,21 @@ import org.apache.iceberg.relocated.com.google.common.collect.Lists; import

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484306822 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -185,14 +195,39 @@ private void initializeCatalogTables() throws InterruptedException,

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484299675 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +162,66 @@ public void testInitialize() {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484294481 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +162,66 @@ public void testInitialize() {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484294100 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +162,66 @@ public void testInitialize() {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484292812 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -854,4 +918,68 @@ public void report(MetricsReport report) { COUNTER.incrementAndGet();

Re: [I] Iceberg table not able to read data from S3 after few hours using Athena . [iceberg]

2024-02-09 Thread via GitHub
ajsalunkhe commented on issue #9684: URL: https://github.com/apache/iceberg/issues/9684#issuecomment-1935894752 Just to share more details, using below pyspark code to write data to Iceberg table on EMR cluster. **dataframe.writeTo("..").overwritePartitions()** -- This is an

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484293364 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -158,6 +162,66 @@ public void testInitialize() {

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484255806 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -115,7 +124,16 @@ case class

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484196218 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484192464 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484171305 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -83,6 +88,10 @@ case class

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484131996 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -503,6 +560,104 @@ public boolean namespaceExists(Namespace namespace) { return

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484131220 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -185,14 +195,41 @@ private void initializeCatalogTables() throws InterruptedException,

Re: [PR] Build: Bump slf4j from 1.7.36 to 2.0.12 [iceberg]

2024-02-09 Thread via GitHub
jbonofre commented on PR #9688: URL: https://github.com/apache/iceberg/pull/9688#issuecomment-1935668919 That's a -1 for now on this one as we have to check if third parties are happy with that (I will investigate/test). -- This is an automated message from the Apache Git Service. To

Re: [I] Iceberg table not able to read data from S3 after few hours using Athena . [iceberg]

2024-02-09 Thread via GitHub
nastra commented on issue #9684: URL: https://github.com/apache/iceberg/issues/9684#issuecomment-1935563328 It seems suspicious that there are no snapshots anymore. Iceberg writes a new snapshot on any operations that would modify data. Can you please share your full catalog configuration?

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484017802 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -503,6 +560,104 @@ public boolean namespaceExists(Namespace namespace) { return

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484016984 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -185,14 +195,41 @@ private void initializeCatalogTables() throws InterruptedException,

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484015579 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -185,14 +195,41 @@ private void initializeCatalogTables() throws InterruptedException,

Re: [I] Iceberg table not able to read data from S3 after few hours using Athena . [iceberg]

2024-02-09 Thread via GitHub
ajsalunkhe commented on issue #9684: URL: https://github.com/apache/iceberg/issues/9684#issuecomment-1935525146 The files don't get cleaned up, I can still see them at S3 location, while the table doesn't loads it on querying. -- This is an automated message from the Apache Git Service.

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484011553 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -60,16 +61,21 @@ import org.apache.iceberg.relocated.com.google.common.collect.Lists; import

Re: [PR] OpenAPI: Spec updates for statistics [iceberg]

2024-02-09 Thread via GitHub
nastra merged PR #9690: URL: https://github.com/apache/iceberg/pull/9690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-09 Thread via GitHub
Xuanwo commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1483994701 ## crates/iceberg/src/io.rs: ## @@ -240,9 +241,9 @@ impl InputFile { } /// Trait for writing file. -pub trait FileWrite: AsyncWrite {} +pub trait FileWrite:

Re: [I] Iceberg table not able to read data from S3 after few hours using Athena . [iceberg]

2024-02-09 Thread via GitHub
nastra commented on issue #9684: URL: https://github.com/apache/iceberg/issues/9684#issuecomment-1935495525 @ajsalunkhe at this point it's difficult to say what's going wrong here. Do you have any particular bucket policies enabled or anything else that would clean up files? -- This is

Re: [I] java.lang.IllegalArgumentException: requirement failed: length (-6235972) cannot be smaller than -1 [iceberg]

2024-02-09 Thread via GitHub
nastra commented on issue #9689: URL: https://github.com/apache/iceberg/issues/9689#issuecomment-1935494505 @rjayapalan do you have a small reproducible example by any chance? That would greatly help for anyone looking at this issue -- This is an automated message from the Apache Git