Fokko merged PR #9719:
URL: https://github.com/apache/iceberg/pull/9719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #8672:
URL: https://github.com/apache/iceberg/pull/8672#issuecomment-2078739565
I'll go ahead and merge this now. EVery now and then a question around this
pops up on the devlist/Slack, so it is good to get this clarification out.
Thanks everyone for chiming in for the
Fokko commented on PR #9719:
URL: https://github.com/apache/iceberg/pull/9719#issuecomment-2078740347
Thanks @pvary for the review 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Fokko merged PR #8672:
URL: https://github.com/apache/iceberg/pull/8672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580539378
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkColumnarReaderFactory.java:
##
@@ -49,7 +52,9 @@ public PartitionReader
createColumnarReader(I
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580538817
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java:
##
@@ -51,22 +53,37 @@ public class VectorizedSparkParq
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580538480
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##
@@ -353,4 +354,12 @@ private boolean executorCacheLocalityEnabledInternal() {
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580538348
##
gradle.properties:
##
@@ -20,8 +20,8 @@ systemProp.defaultFlinkVersions=1.18
systemProp.knownFlinkVersions=1.16,1.17,1.18
systemProp.defaultHiveVersions=2
syste
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580538128
##
api/src/main/java/org/apache/iceberg/ReaderType.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributo
liurenjie1024 commented on issue #354:
URL: https://github.com/apache/iceberg-rust/issues/354#issuecomment-2078683994
> @Fokko, can you please assign this to me? Thanks!
Done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1580510837
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1580506460
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1580505826
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
liurenjie1024 commented on PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#issuecomment-2078666082
Thanks @sdd for this pr, and @Xuanwo @marvinlanhenke for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
liurenjie1024 merged PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580469059
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580469059
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580446821
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580444775
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
jkolash commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078535487
Ok this is reproducing via the github actions build on my public fork
https://github.com/jkolash/iceberg/actions/runs/8842101257/job/24280206652
```
TestDataFrameWriterV2 >
liurenjie1024 commented on PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#issuecomment-2078490131
Let's wait a moment to see if others have comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
liurenjie1024 commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580334216
##
crates/iceberg/src/scan.rs:
##
@@ -158,8 +196,24 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1580294047
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##
@@ -56,7 +58,8 @@ abstract class BaseDeltaTaskWriter extends
BaseTa
aokolnychyi commented on PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#issuecomment-2078403034
> Also there is a behavioural change that the previous write rolled deletes
@pvary, I don't think that threshold makes sense in this scenario. It was
needed because we kept ro
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1580291026
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
wypoon opened a new pull request, #10228:
URL: https://github.com/apache/iceberg/pull/10228
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
github-actions[bot] commented on issue #2715:
URL: https://github.com/apache/iceberg/issues/2715#issuecomment-2078371964
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2485:
URL: https://github.com/apache/iceberg/issues/2485#issuecomment-2078371768
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2485: Add support for TimeType, ListType,
MapType and StructType in the ArrowReader
URL: https://github.com/apache/iceberg/issues/2485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dependabot[bot] opened a new pull request, #662:
URL: https://github.com/apache/iceberg-python/pull/662
Bumps [getdaft](https://github.com/Eventual-Inc/Daft) from 0.2.16 to 0.2.21.
Release notes
Sourced from https://github.com/Eventual-Inc/Daft/releases";>getdaft's
releases.
dependabot[bot] opened a new pull request, #660:
URL: https://github.com/apache/iceberg-python/pull/660
Bumps [griffe](https://github.com/mkdocstrings/griffe) from 0.40.1 to 0.44.0.
Release notes
Sourced from https://github.com/mkdocstrings/griffe/releases";>griffe's
releases.
dependabot[bot] opened a new pull request, #659:
URL: https://github.com/apache/iceberg-python/pull/659
Bumps [pyspark](https://github.com/apache/spark) from 3.5.0 to 3.5.1.
Commits
https://github.com/apache/spark/commit/fd86f85e181fc2dc0f50a096855acf83a6cc5d9c";>fd86f85
Prepar
dependabot[bot] opened a new pull request, #661:
URL: https://github.com/apache/iceberg-python/pull/661
Bumps [mkdocstrings](https://github.com/mkdocstrings/mkdocstrings) from
0.24.0 to 0.24.3.
Release notes
Sourced from https://github.com/mkdocstrings/mkdocstrings/releases";>mkdoc
vasudhamsr opened a new issue, #10227:
URL: https://github.com/apache/iceberg/issues/10227
### Query engine
Spark
### Question
We have a scenario where the catalog object keeps changing and the custom
FileIO underneath as well. But the loadTable function
(org.apache.spa
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580202486
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn = waterma
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580202486
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn = waterma
stevenzwu commented on code in PR #10151:
URL: https://github.com/apache/iceberg/pull/10151#discussion_r1580188262
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkFileIO.java:
##
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
nickdelnano opened a new issue, #10226:
URL: https://github.com/apache/iceberg/issues/10226
### Apache Iceberg version
1.4.3
### Query engine
Flink
### Please describe the bug 🐞
Hi,
I am observing issues when creating an Iceberg table with a Glue cata
jkolash commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078200948
hmm I think this may be related to the spark version we are using as I
tested on spark-3.4.1 and didn't see the issue but see it on our 3.4.2
--
This is an automated message from
jkolash commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078157080
If/when there is a PR I can test it on my side. where I have exhaustive type
testing.
```
java.lang.ClassCastException: class java.lang.Byte cannot be cast to class
java.
jkolash commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078150463
```kotlin
val df = spark.sql("""select inline(array(from_json('{"b":82}',
'struct')))""")
df.show()
```
```
+---+
| b|
+---+
| 82|
+-
Fokko commented on PR #8625:
URL: https://github.com/apache/iceberg/pull/8625#issuecomment-2078143286
Yes, this is still top of mind! I'm going to see what's needed and make sure
that it will be included in the next Avro release!
--
This is an automated message from the Apache Git Service
Fokko closed pull request #7922: Build: Test Apache Avro 1.11.2
URL: https://github.com/apache/iceberg/pull/7922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
wolfeidau commented on PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#issuecomment-2078141567
@zeroshade I will dig into this in the next few days, I have implemented the
builder for tables but need a way to have a generic path builder.
Given I have time off next week I ca
MehulBatra commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1580084812
##
pyiceberg/table/__init__.py:
##
@@ -235,6 +242,10 @@ class TableProperties:
WRITE_PARTITION_SUMMARY_LIMIT = "write.summary.partition-limit"
WRITE_P
MehulBatra commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1580084812
##
pyiceberg/table/__init__.py:
##
@@ -235,6 +242,10 @@ class TableProperties:
WRITE_PARTITION_SUMMARY_LIMIT = "write.summary.partition-limit"
WRITE_P
MehulBatra commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1580084812
##
pyiceberg/table/__init__.py:
##
@@ -235,6 +242,10 @@ class TableProperties:
WRITE_PARTITION_SUMMARY_LIMIT = "write.summary.partition-limit"
WRITE_P
jkolash commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078099689
@Fokko Thanks for the quick response I will try to write up a code snippet
reproducing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the m
Fokko commented on issue #10225:
URL: https://github.com/apache/iceberg/issues/10225#issuecomment-2078097905
Hey @jkolash Thanks for reporting this. The behavior should stay the same,
due to the logic here:
https://github.com/apache/iceberg/pull/9440/files#diff-8ac59cbdbcc60cc0c55805
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580049448
##
crates/iceberg/src/scan.rs:
##
@@ -158,8 +196,24 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut entries =
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580039092
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +240,25 @@ impl TableScan {
.boxed())
}
+fn create_manifest_evaluator(
+id: i32,
+schema:
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580038792
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +240,25 @@ impl TableScan {
.boxed())
}
+fn create_manifest_evaluator(
+id: i32,
+schema:
jkolash opened a new issue, #10225:
URL: https://github.com/apache/iceberg/issues/10225
### Apache Iceberg version
1.5.0
### Query engine
Spark
### Please describe the bug 🐞
The removal of the code
```java
private static PrimitiveWriter ints(DataT
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1580024955
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
pvary commented on code in PR #10151:
URL: https://github.com/apache/iceberg/pull/10151#discussion_r1580019899
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkFileIO.java:
##
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
simonvandel commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579945951
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579940862
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
simonvandel commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579930294
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579919751
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
simonvandel commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579897701
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579883806
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
stevenzwu commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1579871219
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -40,24 +44,27 @@
import org.apache.iceberg.FileFormat;
im
epgif commented on PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#issuecomment-2077790169
> @epgif can you please address the test failures?
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stevenzwu commented on code in PR #10151:
URL: https://github.com/apache/iceberg/pull/10151#discussion_r1579860068
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkFileIO.java:
##
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579827548
##
crates/integrations/datafusion/Cargo.toml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
tshauck commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579818649
##
crates/integrations/datafusion/Cargo.toml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
marvinlanhenke commented on PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2077663647
> I've left some comment to improve, but it looks great! I'll invite
datafusion community to help review.
@liurenjie1024
Thanks for the review.
I fixed most of the
nastra merged PR #10224:
URL: https://github.com/apache/iceberg/pull/10224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #10224:
URL: https://github.com/apache/iceberg/pull/10224#issuecomment-2077658431
LGTM, thanks @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579755826
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
viirya commented on issue #329:
URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2077637850
Thanks @liurenjie1024. The roadmaps doc looks good to me. I added a few
items under DataFusion integration. Feel free to modify it. Thanks.
--
This is an automated message from t
Xuanwo commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579739285
##
crates/integrations/datafusion/Cargo.toml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
viirya commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579728551
##
crates/integrations/datafusion/README.md:
##
@@ -0,0 +1,22 @@
+
+
+# Apache Iceberg Integrations
+
+This crate contains the official Native Rust implementation of
viirya commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579728551
##
crates/integrations/datafusion/README.md:
##
@@ -0,0 +1,22 @@
+
+
+# Apache Iceberg Integrations
+
+This crate contains the official Native Rust implementation of
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579713512
##
crates/integrations/datafusion/Cargo.toml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
amogh-jahagirdar commented on code in PR #10224:
URL: https://github.com/apache/iceberg/pull/10224#discussion_r1579724014
##
site/docs/releases.md:
##
@@ -73,6 +73,21 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
```
+### 1.5.1 release
+A
nastra commented on code in PR #10224:
URL: https://github.com/apache/iceberg/pull/10224#discussion_r1579716696
##
site/docs/releases.md:
##
@@ -73,6 +73,21 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
```
+### 1.5.1 release
+Apache Iceb
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579715245
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579715245
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579713512
##
crates/integrations/datafusion/Cargo.toml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579654225
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1579601294
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
liurenjie1024 commented on code in PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1579259139
##
crates/catalog/sql/Cargo.toml:
##
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
aajisaka commented on PR #10221:
URL: https://github.com/apache/iceberg/pull/10221#issuecomment-2077332098
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579520268
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579472707
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
bryanck commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1579467601
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -83,4 +90,26 @@ public void testAutoCreateTable(bool
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579466191
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on issue #353:
URL: https://github.com/apache/iceberg-rust/issues/353#issuecomment-2077166551
@s-akhtar-baig Certainly 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
s-akhtar-baig commented on issue #354:
URL: https://github.com/apache/iceberg-rust/issues/354#issuecomment-2077159735
@Fokko, can you please assign this to me? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
s-akhtar-baig commented on issue #353:
URL: https://github.com/apache/iceberg-rust/issues/353#issuecomment-2077159481
@Fokko, can you please assign this to me? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579449633
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579449633
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko opened a new issue, #353:
URL: https://github.com/apache/iceberg-rust/issues/353
Looks like the `field-id` is missing in the Avro metadata generated by
iceberg-rust. This should conform the spec:
https://iceberg.apache.org/spec/#avro
```
avro-tools getschema snap-0-1-a0c0a37
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579426812
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579420662
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579412576
##
crates/iceberg/src/transaction.rs:
##
@@ -95,6 +104,42 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+/// Creates a fast append action.
+pub fn f
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579406252
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
Fokko opened a new issue, #352:
URL: https://github.com/apache/iceberg-rust/issues/352
This is an old bug from Java. Where the Snapshot was set to -1 instead of
`None`:
https://github.com/apache/iceberg-rust/blob/aba620900e99423bbd3fed969618e67e58a03a7b/crates/iceberg/src/spec/table_
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579402269
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
1 - 100 of 148 matches
Mail list logo