Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra merged PR #9367: URL: https://github.com/apache/iceberg/pull/9367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436382864 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -94,7 +95,7 @@ public class TestCreateActions extends SparkCatalog

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436381154 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -516,17 +527,16 @@ public void testProperties() throws Exception {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436380170 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -94,7 +95,7 @@ public class TestCreateActions extends SparkCatalogTestBa

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436379721 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,48 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1869415869 rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1869413632 @chinmay-bhat can you please rebase against latest main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435813342 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435807876 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868322800 rebased on top of #9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868256798 I'll hold off on reviewing this PR once https://github.com/apache/iceberg/pull/9368 is in. @chinmay-bhat in the meantime you might want to rebase this PR on top of the commit from https:/

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435550396 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -118,45 +117,45 @@ public TestRewritePositionDeleteFi

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535518 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -139,36 +138,43 @@ public void testDryRun() throws IOExc

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868244365 adding `TestCreateActions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535457 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -118,45 +117,45 @@ public TestRewritePositionDe

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535260 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -94,9 +96,7 @@ public class TestRewritePosition

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435521777 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -118,45 +117,45 @@ public TestRewritePositionDeleteFi

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435521682 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -94,9 +96,7 @@ public class TestRewritePositionDelete

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435519924 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -938,8 +946,8 @@ public void testRemoveOrphanFilesWithStatisti

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435519148 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -139,36 +138,43 @@ public void testDryRun() throws IOException

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868232570 @chinmay-bhat can you also please include `TestCreateActions` as that's in the same directory -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435511387 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestDeleteReachableFilesAction.java: ## @@ -345,11 +345,10 @@ public void testIgnoreMetadataFile

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435510145 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestDeleteReachableFilesAction.java: ## @@ -345,11 +345,10 @@ public void testIgnoreMetadataFilesNotFo