[jira] [Comment Edited] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943317#comment-16943317 ] Atri Sharma edited comment on LUCENE-8213 at 10/3/19 4:18 AM:

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943317#comment-16943317 ] Atri Sharma commented on LUCENE-8213: - Thanks [~hossman] Interestingly, all but on

[GitHub] [lucene-solr] dsmiley commented on issue #853: SOLR-13737 Moving SolrCloud on the README with some cues.

2019-10-02 Thread GitBox
dsmiley commented on issue #853: SOLR-13737 Moving SolrCloud on the README with some cues. URL: https://github.com/apache/lucene-solr/pull/853#issuecomment-537766519 Hey could you update the README and try again? Also replace "distributed" with "clustered" per recent conversation on the d

[jira] [Commented] (LUCENE-8989) IndexSearcher Should Handle Rejection of Concurrent Task

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943296#comment-16943296 ] Atri Sharma commented on LUCENE-8989: - bq. Hmm, that is a good point – maybe we shou

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2019-10-02 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943283#comment-16943283 ] Ben Manes commented on SOLR-8241: - Thanks [~ab], [~dsmiley], [~elyograg]! > Evaluate W-Ti

[jira] [Updated] (LUCENE-8991) disable java.util.HashMap assertions to avoid spurious vailures due to JDK-8205399

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-8991: --- Fix Version/s: 8.3 master (9.0) Assignee: Chris M. Hostet

[jira] [Commented] (LUCENE-8991) disable java.util.HashMap assertions to avoid spurious vailures due to JDK-8205399

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943255#comment-16943255 ] ASF subversion and git services commented on LUCENE-8991: - Commi

[GitHub] [lucene-solr] KoenDG opened a new pull request #919: LUCENE-8994: Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll().

2019-10-02 Thread GitBox
KoenDG opened a new pull request #919: LUCENE-8994: Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). URL: https://github.com/apache/lucene-solr/pull/919 https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-8994 If you have actu

[GitHub] [lucene-solr] KoenDG commented on issue #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

2019-10-02 Thread GitBox
KoenDG commented on issue #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2 URL: https://github.com/apache/lucene-solr/pull/881#issuecomment-537724000 Updated as requested. Also, the initial changes were not manual, they were automatic with t

[jira] [Commented] (LUCENE-8991) disable java.util.HashMap assertions to avoid spurious vailures due to JDK-8205399

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943222#comment-16943222 ] ASF subversion and git services commented on LUCENE-8991: - Commi

[jira] [Reopened] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened LUCENE-8213: > Cache costly subqueries asynchronously > -- > >

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943217#comment-16943217 ] Chris M. Hostetter commented on LUCENE-8213: FWIW: I just attached thetaphi_

[jira] [Updated] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-8213: --- Attachment: thetaphi_Lucene-Solr-master-Linux_24839.log.txt > Cache costly subquerie

[jira] [Updated] (SOLR-13797) SolrResourceLoader produces inconsistent results when given bad arguments

2019-10-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-13797: - Fix Version/s: master (9.0) Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (SOLR-13797) SolrResourceLoader produces inconsistent results when given bad arguments

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943203#comment-16943203 ] ASF subversion and git services commented on SOLR-13797: Commit 2

[jira] [Commented] (SOLR-13812) SolrTestCaseJ4.params(String...) javadocs, uneven rejection, basic test coverage

2019-10-02 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943196#comment-16943196 ] Lucene/Solr QA commented on SOLR-13812: --- | (/) *{color:green}+1 overall{color}* | \

[jira] [Created] (LUCENE-8998) OverviewImplTest.testIsOptimized reproducible failure

2019-10-02 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created LUCENE-8998: -- Summary: OverviewImplTest.testIsOptimized reproducible failure Key: LUCENE-8998 URL: https://issues.apache.org/jira/browse/LUCENE-8998 Project: Lucene - Co

[GitHub] [lucene-solr] jpountz commented on issue #905: LUCENE-8990: Add estimateDocCount(visitor) method to PointValues

2019-10-02 Thread GitBox
jpountz commented on issue #905: LUCENE-8990: Add estimateDocCount(visitor) method to PointValues URL: https://github.com/apache/lucene-solr/pull/905#issuecomment-537680322 @colings86 pointed me to https://math.stackexchange.com/questions/1175295/urn-problem-probability-of-drawing-balls-of

[GitHub] [lucene-solr] jpountz edited a comment on issue #905: LUCENE-8990: Add estimateDocCount(visitor) method to PointValues

2019-10-02 Thread GitBox
jpountz edited a comment on issue #905: LUCENE-8990: Add estimateDocCount(visitor) method to PointValues URL: https://github.com/apache/lucene-solr/pull/905#issuecomment-537456383 I was more thinking that there should be a better formula, which takes into account the fact that when you mat

[jira] [Comment Edited] (LUCENE-8993) Change Maven POM repository URLs to https

2019-10-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943150#comment-16943150 ] Uwe Schindler edited comment on LUCENE-8993 at 10/2/19 8:41 PM: --

[jira] [Commented] (LUCENE-8993) Change Maven POM repository URLs to https

2019-10-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943150#comment-16943150 ] Uwe Schindler commented on LUCENE-8993: --- After deleting the Maven repo, I had to f

[jira] [Commented] (SOLR-13790) LRUStatsCache size explosion and ineffective caching

2019-10-02 Thread David Wayne Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943149#comment-16943149 ] David Wayne Smiley commented on SOLR-13790: --- Interesting; your proposal makes s

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330756503 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -13

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330755828 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -15

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2019-10-02 Thread David Wayne Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943141#comment-16943141 ] David Wayne Smiley commented on SOLR-8241: -- Woohoo! Thanks [~ab] and for your ex

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330750867 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java ## @@ -81,7

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330751954 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1556,48 +15

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330751354 ## File path: solr/core/src/test/org/apache/solr/rest/schema/TestBulkSchemaAPI.java ## @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

2019-10-02 Thread GitBox
dsmiley commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330752451 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -138,7 +138,

[jira] [Commented] (LUCENE-8989) IndexSearcher Should Handle Rejection of Concurrent Task

2019-10-02 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943135#comment-16943135 ] Michael McCandless commented on LUCENE-8989: {quote}Suppose the executor has

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-10-02 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537648923 pre commit check is still toggling This is an automated message from the Apache Git Service.

[jira] [Commented] (SOLR-13722) Package Management APIs

2019-10-02 Thread David Wayne Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943087#comment-16943087 ] David Wayne Smiley commented on SOLR-13722: --- I'm confused on the status here.

[jira] [Commented] (SOLR-13813) Shared storage online split support

2019-10-02 Thread Yonik Seeley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943070#comment-16943070 ] Yonik Seeley commented on SOLR-13813: - The other notable thing is that I *thought* th

[GitHub] [lucene-solr] magibney edited a comment on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2019-10-02 Thread GitBox
magibney edited a comment on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation URL: https://github.com/apache/lucene-solr/pull/892#issuecomment-537538822 Here's a thought: what if we provided a boolean configuration option like `assumeExt

[jira] [Commented] (SOLR-13813) Shared storage online split support

2019-10-02 Thread Yonik Seeley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943057#comment-16943057 ] Yonik Seeley commented on SOLR-13813: - This PR ( https://github.com/apache/lucene-sol

[GitHub] [lucene-solr] yonik opened a new pull request #918: SOLR-13813: SHARED: add basic test for online shard splitting

2019-10-02 Thread GitBox
yonik opened a new pull request #918: SOLR-13813: SHARED: add basic test for online shard splitting URL: https://github.com/apache/lucene-solr/pull/918 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2019-10-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943041#comment-16943041 ] Andrzej Bialecki commented on SOLR-8241: Updated patch: * reduced contention in st

[jira] [Updated] (SOLR-8241) Evaluate W-TinyLfu cache

2019-10-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-8241: --- Attachment: SOLR-8241.patch > Evaluate W-TinyLfu cache > > >

[jira] [Commented] (LUCENE-8993) Change Maven POM repository URLs to https

2019-10-02 Thread Mark Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943037#comment-16943037 ] Mark Miller commented on LUCENE-8993: - FYI, I’ve done this, though I’ll check stuff

[jira] [Commented] (SOLR-13797) SolrResourceLoader produces inconsistent results when given bad arguments

2019-10-02 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943033#comment-16943033 ] Anshum Gupta commented on SOLR-13797: - [~mdrob] - LGTM. Just a minor question/sugges

[jira] [Created] (SOLR-13813) Shared storage online split support

2019-10-02 Thread Yonik Seeley (Jira)
Yonik Seeley created SOLR-13813: --- Summary: Shared storage online split support Key: SOLR-13813 URL: https://issues.apache.org/jira/browse/SOLR-13813 Project: Solr Issue Type: Sub-task

[GitHub] [lucene-solr] magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2019-10-02 Thread GitBox
magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation URL: https://github.com/apache/lucene-solr/pull/892#issuecomment-537601926 Tried this out, and the performance gain was indeed significant. Comparing apples to apples

[jira] [Updated] (SOLR-13811) possible autoAddReplicas bug and/or (Hdfs)AutoAddReplicasIntegrationTest refactoring / fixes

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-13811: -- Attachment: hoss_local_failure_after_refactoring.log.txt apache_Lucene-S

[jira] [Commented] (SOLR-13811) possible autoAddReplicas bug and/or (Hdfs)AutoAddReplicasIntegrationTest refactoring / fixes

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943010#comment-16943010 ] ASF subversion and git services commented on SOLR-13811: Commit 1

[GitHub] [lucene-solr] cbuescher commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection

2019-10-02 Thread GitBox
cbuescher commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection URL: https://github.com/apache/lucene-solr/pull/913#discussion_r330672796 ## File path: lucene/suggest/src/java/org/apache/lucene/search/suggest/doc

[GitHub] [lucene-solr] cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-10-02 Thread GitBox
cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-537594398 Thanks @diegoceccarelli for the updates and for splitting the unrelated `maxScore` change out into

[jira] [Updated] (SOLR-13812) SolrTestCaseJ4.params(String...) javadocs, uneven rejection, basic test coverage

2019-10-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-13812: --- Status: Patch Available (was: Open) > SolrTestCaseJ4.params(String...) javadocs, une

[jira] [Updated] (SOLR-13812) SolrTestCaseJ4.params(String...) javadocs, uneven rejection, basic test coverage

2019-10-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-13812: --- Attachment: SOLR-13812.patch > SolrTestCaseJ4.params(String...) javadocs, uneven reje

[jira] [Created] (SOLR-13812) SolrTestCaseJ4.params(String...) javadocs, uneven rejection, basic test coverage

2019-10-02 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-13812: -- Summary: SolrTestCaseJ4.params(String...) javadocs, uneven rejection, basic test coverage Key: SOLR-13812 URL: https://issues.apache.org/jira/browse/SOLR-13812

[jira] [Commented] (SOLR-13811) possible autoAddReplicas bug and/or (Hdfs)AutoAddReplicasIntegrationTest refactoring / fixes

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942993#comment-16942993 ] ASF subversion and git services commented on SOLR-13811: Commit a

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942991#comment-16942991 ] ASF subversion and git services commented on SOLR-13101: Commit 8

[GitHub] [lucene-solr] yonik merged pull request #917: SOLR-13101: fix test compilation

2019-10-02 Thread GitBox
yonik merged pull request #917: SOLR-13101: fix test compilation URL: https://github.com/apache/lucene-solr/pull/917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] jimczi commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection

2019-10-02 Thread GitBox
jimczi commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection URL: https://github.com/apache/lucene-solr/pull/913#discussion_r330667847 ## File path: lucene/suggest/src/test/org/apache/lucene/search/suggest/docume

[GitHub] [lucene-solr] jimczi commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection

2019-10-02 Thread GitBox
jimczi commented on a change in pull request #913: LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection URL: https://github.com/apache/lucene-solr/pull/913#discussion_r330659818 ## File path: lucene/suggest/src/java/org/apache/lucene/search/suggest/docume

[jira] [Created] (SOLR-13811) possible autoAddReplicas bug and/or (Hdfs)AutoAddReplicasIntegrationTest refactoring / fixes

2019-10-02 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-13811: - Summary: possible autoAddReplicas bug and/or (Hdfs)AutoAddReplicasIntegrationTest refactoring / fixes Key: SOLR-13811 URL: https://issues.apache.org/jira/browse/SOLR-138

[GitHub] [lucene-solr] yonik opened a new pull request #917: SOLR-13101: fix test compilation

2019-10-02 Thread GitBox
yonik opened a new pull request #917: SOLR-13101: fix test compilation URL: https://github.com/apache/lucene-solr/pull/917 Looks like the merge when the original PR was put up broke test compilation. Here's the simple fix. T

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-10-02 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537570032 Pushed again without ignored binary test This is an automated message from the Apache Git Se

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-10-02 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537560022 > Hi Thomas. I'd really like to get this (#665) in for 8.3, but right now it's bundled to your change in #883. I can't merge this without #883. >

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-10-02 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537560022 > Hi Thomas. I'd really like to get this (#665) in for 8.3, but right now it's bundled to your change in #883. I can't merge this without #883. > > An

[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

2019-10-02 Thread GitBox
gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537556502 Hi Thomas. I'd really like to get this (#665) in for 8.3, but right now it's bundled to your change in #883. I can't merge this without #883. And I haven

[jira] [Commented] (SOLR-13790) LRUStatsCache size explosion and ineffective caching

2019-10-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942908#comment-16942908 ] Andrzej Bialecki commented on SOLR-13790: - Oh, and until the staleness issue is f

[jira] [Commented] (SOLR-13790) LRUStatsCache size explosion and ineffective caching

2019-10-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942904#comment-16942904 ] Andrzej Bialecki commented on SOLR-13790: - Upon further examination it looks like

[jira] [Commented] (SOLR-13764) Parse Interval Query from JSON API

2019-10-02 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942895#comment-16942895 ] Mikhail Khludnev commented on SOLR-13764: - I'm sorry. Need to switch to something

[jira] [Updated] (SOLR-13764) Parse Interval Query from JSON API

2019-10-02 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-13764: Fix Version/s: (was: 8.3) > Parse Interval Query from JSON API > --

[jira] [Updated] (SOLR-13764) Parse Interval Query from JSON API

2019-10-02 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-13764: Priority: Minor (was: Blocker) > Parse Interval Query from JSON API >

[jira] [Comment Edited] (SOLR-13101) Shared storage support in SolrCloud

2019-10-02 Thread Yonik Seeley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942890#comment-16942890 ] Yonik Seeley edited comment on SOLR-13101 at 10/2/19 3:10 PM: -

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

2019-10-02 Thread Yonik Seeley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942890#comment-16942890 ] Yonik Seeley commented on SOLR-13101: - bq. How far do you think is it complete? Do yo

[GitHub] [lucene-solr] magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2019-10-02 Thread GitBox
magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation URL: https://github.com/apache/lucene-solr/pull/892#issuecomment-537538822 Here's a thought: what if we provided a boolean configuration option like `assumeExternalUn

[jira] [Updated] (SOLR-13790) LRUStatsCache size explosion and ineffective caching

2019-10-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-13790: Attachment: SOLR-13790.patch > LRUStatsCache size explosion and ineffective caching > -

[GitHub] [lucene-solr] atris commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#issuecomment-537530015 @jpountz Updated, please see and let me know your thoughts This is a

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942871#comment-16942871 ] ASF subversion and git services commented on SOLR-13105: Commit 9

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942869#comment-16942869 ] ASF subversion and git services commented on SOLR-13105: Commit 4

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942868#comment-16942868 ] ASF subversion and git services commented on SOLR-13105: Commit c

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942866#comment-16942866 ] ASF subversion and git services commented on SOLR-13105: Commit f

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942862#comment-16942862 ] ASF subversion and git services commented on SOLR-13105: Commit a

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330584691 ## File path: lucene/core/src/java/org/apache/lucene/search/QueryCache.java ## @@ -33,4 +35,10 @@

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330582970 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -88,13 +93,36

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330581040 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -389,6 +431,7

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330580984 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -368,10 +400,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2 URL: https://github.com/apache/lucene-solr/pull/881#discussion_r330579248 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/by

[GitHub] [lucene-solr] jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2 URL: https://github.com/apache/lucene-solr/pull/881#discussion_r330578921 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analys

[GitHub] [lucene-solr] jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2 URL: https://github.com/apache/lucene-solr/pull/881#discussion_r330579524 ## File path: lucene/core/src/java/org/apache/lucene/search/BooleanQuer

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330579304 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -813,8 +918,2

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330578984 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -732,8 +821,2

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330577294 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -88,13 +93,36

[GitHub] [lucene-solr] atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330575572 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -88,13 +93,36

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942851#comment-16942851 ] ASF subversion and git services commented on SOLR-13105: Commit 9

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330550479 ## File path: lucene/core/src/java/org/apache/lucene/search/QueryCache.java ## @@ -33,4 +35,10 @

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330554876 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -88,13 +93,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330564331 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -832,5 +952

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330553473 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -389,6 +431

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330546874 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -813,8 +918

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330572346 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -448,13 +49

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330552818 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -368,10 +40

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330549857 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -832,5 +952

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330546325 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -732,8 +821

[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-10-02 Thread GitBox
jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330545241 ## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ## @@ -88,13 +93,

[GitHub] [lucene-solr] jpountz closed pull request #884: LUCENE-8980: optimise SegmentTermsEnum.seekExact performance

2019-10-02 Thread GitBox
jpountz closed pull request #884: LUCENE-8980: optimise SegmentTermsEnum.seekExact performance URL: https://github.com/apache/lucene-solr/pull/884 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene-solr] jpountz commented on issue #884: LUCENE-8980: optimise SegmentTermsEnum.seekExact performance

2019-10-02 Thread GitBox
jpountz commented on issue #884: LUCENE-8980: optimise SegmentTermsEnum.seekExact performance URL: https://github.com/apache/lucene-solr/pull/884#issuecomment-537483307 Closing now that @dsmiley merged this change. This is an

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942791#comment-16942791 ] ASF subversion and git services commented on SOLR-13105: Commit 4

  1   2   >