[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1600: SOLR Move "userfiles" stuff from SolrPaths to CoreContainer.

2020-06-23 Thread GitBox
dsmiley commented on a change in pull request #1600: URL: https://github.com/apache/lucene-solr/pull/1600#discussion_r444641471 ## File path: solr/core/src/java/org/apache/solr/handler/CatStream.java ## @@ -158,28 +157,20 @@ public Explanation toExplanation(StreamFactory factor

[jira] [Commented] (SOLR-14376) Optimize SolrIndexSearcher.getDocSet and getProcessedFilter for empty fq

2020-06-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143509#comment-17143509 ] David Smiley commented on SOLR-14376: - What you found there could be removed (the nee

[jira] [Commented] (SOLR-12698) SolrFeature: no-fq optimisation

2020-06-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143478#comment-17143478 ] David Smiley commented on SOLR-12698: - Looks like it :-) We can close as duplicate t

[GitHub] [lucene-solr] noblepaul commented on pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-06-23 Thread GitBox
noblepaul commented on pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432#issuecomment-648495409 @dsmiley Yes, I want all our components to be written using - Annotations (even our internal components) - All input output to use POJOs

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-23 Thread GitBox
noblepaul commented on a change in pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598#discussion_r444575124 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/TestPolicy2.java ## @@ -516,6 +517,16 @@ public void testInfiniteL

[jira] [Created] (SOLR-14590) Add support for FeatureField in Solr

2020-06-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-14590: Summary: Add support for FeatureField in Solr Key: SOLR-14590 URL: https://issues.apache.org/jira/browse/SOLR-14590 Project: Solr

[jira] [Resolved] (SOLR-14589) Remove IntelliJ //noinspection comments

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14589. --- Fix Version/s: 8.6 Resolution: Fixed > Remove IntelliJ //noinspection comments > -

[jira] [Commented] (SOLR-14589) Remove IntelliJ //noinspection comments

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143405#comment-17143405 ] Erick Erickson commented on SOLR-14589: --- Fat fingered the commit message, here are

[jira] [Issue Comment Deleted] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14541: -- Comment: was deleted (was: Commit 85611f7ee5a654b04e4a6216ef9da76e95fd9088 in lucene-solr's bra

[jira] [Issue Comment Deleted] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14541: -- Comment: was deleted (was: Commit db986086f53e3f7a936817b546edf46ee4548523 in lucene-solr's bra

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143404#comment-17143404 ] ASF subversion and git services commented on SOLR-14541: Commit d

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143403#comment-17143403 ] ASF subversion and git services commented on SOLR-14541: Commit 8

[jira] [Created] (SOLR-14589) Remove IntelliJ //noinspection comments

2020-06-23 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14589: - Summary: Remove IntelliJ //noinspection comments Key: SOLR-14589 URL: https://issues.apache.org/jira/browse/SOLR-14589 Project: Solr Issue Type: Improvemen

[jira] [Resolved] (SOLR-11973) Fail compilation on warnings

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-11973. --- Resolution: Fixed > Fail compilation on warnings > > >

[jira] [Resolved] (SOLR-14534) Investigate cleaning up any remaining warnings in 8x

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14534. --- Resolution: Won't Fix At this point, 8x only has warnings in Lucene since LUCENE-9394 wasn't

[GitHub] [lucene-solr] megancarey commented on a change in pull request #1592: SOLR-14579 First pass at dismantling Utils

2020-06-23 Thread GitBox
megancarey commented on a change in pull request #1592: URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r444544150 ## File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java ## @@ -542,7 +542,7 @@ private AutoScalingConfig handle

[jira] [Commented] (SOLR-12698) SolrFeature: no-fq optimisation

2020-06-23 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143301#comment-17143301 ] Lucene/Solr QA commented on SOLR-12698: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Resolved] (LUCENE-9411) Fail complation on warnings, 9x gradle-only

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-9411. Fix Version/s: master (9.0) Resolution: Fixed with the minor caveat that I backport

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-23 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143295#comment-17143295 ] Michael McCandless commented on LUCENE-8962: Thanks [~simonw], what a deligh

[jira] [Commented] (LUCENE-9411) Fail complation on warnings, 9x gradle-only

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143274#comment-17143274 ] ASF subversion and git services commented on LUCENE-9411: - Commi

[jira] [Commented] (LUCENE-9411) Fail complation on warnings, 9x gradle-only

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143273#comment-17143273 ] ASF subversion and git services commented on LUCENE-9411: - Commi

[jira] [Comment Edited] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143261#comment-17143261 ] BARIS KAZAR edited comment on LUCENE-9221 at 6/23/20, 8:10 PM: ---

[jira] [Comment Edited] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143261#comment-17143261 ] BARIS KAZAR edited comment on LUCENE-9221 at 6/23/20, 8:08 PM: ---

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143263#comment-17143263 ] BARIS KAZAR commented on LUCENE-9221: - Can voters please assume Apache is attached w

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143261#comment-17143261 ] BARIS KAZAR commented on LUCENE-9221: - Ryan, Can voters please assume Apache is att

[jira] [Commented] (LUCENE-9280) Add ability to skip non-competitive documents on field sort

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143257#comment-17143257 ] ASF subversion and git services commented on LUCENE-9280: - Commi

[GitHub] [lucene-solr] mayya-sharipova merged pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-06-23 Thread GitBox
mayya-sharipova merged pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Resolved] (SOLR-13268) Clean up any test failures resulting from defaulting to async logging

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-13268. --- Fix Version/s: 8.6 Resolution: Fixed I'm calling this "fixed" because any future error

[jira] [Commented] (SOLR-13268) Clean up any test failures resulting from defaulting to async logging

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143249#comment-17143249 ] ASF subversion and git services commented on SOLR-13268: Commit e

[jira] [Commented] (SOLR-13268) Clean up any test failures resulting from defaulting to async logging

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143248#comment-17143248 ] ASF subversion and git services commented on SOLR-13268: Commit d

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
anshumg commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r55004 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -1164,6 +1171,16 @@ private SolrCoreMetricManager initCoreMetricManager(Sol

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
anshumg commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r53638 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -224,6 +224,13 @@ private SolrConfig(SolrResourceLoader loader, String nam

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648362568 @madrob Updated, please see and share your thoughts. This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r44004 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread Ryan Ernst (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143212#comment-17143212 ] Ryan Ernst commented on LUCENE-9221: [~bkazar] thanks for the submissions! Please ta

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143205#comment-17143205 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 8 [^lucene_logo8.pdf] > Lucene L

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo8.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143202#comment-17143202 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 6 [^lucene_logo6.pdf] > Lucene L

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143203#comment-17143203 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 7 [^lucene_logo7.pdf] > Lucene L

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo7.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo6.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo5.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143199#comment-17143199 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 4 [^lucene_logo4.pdf] > Lucene L

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143200#comment-17143200 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 5 [^lucene_logo5.pdf] > Lucene L

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r24345 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Softw

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo4.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143195#comment-17143195 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 3 [^lucene_logo3.pdf] > Lucene L

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143197#comment-17143197 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 3.1 [^lucene_logo3_1.pdf] > Luce

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo3_1.pdf > Lucene Logo Contest > --- > > Key

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo3.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143193#comment-17143193 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo2 [^lucene_logo2.pdf] > Lucene Lo

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo2.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143189#comment-17143189 ] BARIS KAZAR commented on LUCENE-9221: - Lucene Logo 1[^lucene_logo1.pdf] > Lucene Lo

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-23 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo1.pdf > Lucene Logo Contest > --- > > Key:

[jira] [Comment Edited] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143179#comment-17143179 ] Cassandra Targett edited comment on SOLR-12823 at 6/23/20, 6:20 PM: ---

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143179#comment-17143179 ] Cassandra Targett commented on SOLR-12823: -- Yes, because unseen in GitHub's rend

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r17940 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r17129 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -224,6 +224,13 @@ private SolrConfig(SolrResourceLoader loader, String name

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r16519 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Soft

[jira] [Assigned] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-23 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma reassigned SOLR-14588: -- Assignee: Atri Sharma > Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker > -

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648326325 To provide some context, I ran this against large facets with the memory circuit breaker tripping in the right place. @madrob Thanks for reviewing, I have raised another

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444394541 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Softw

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444392412 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Softw

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444384399 ## File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444383850 ## File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444382798 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -224,6 +224,9 @@ private SolrConfig(SolrResourceLoader loader, String name,

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143124#comment-17143124 ] Ishan Chattopadhyaya commented on SOLR-12823: - Oh, I see. I was confused due

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143119#comment-17143119 ] Ilan Ginzburg commented on SOLR-12823: -- [~ichattopadhyaya] actually the original PR

[jira] [Comment Edited] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143089#comment-17143089 ] Ilan Ginzburg edited comment on SOLR-12823 at 6/23/20, 5:06 PM: ---

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444375970 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-cache-enable-disable.xml ## @@ -70,6 +70,10 @@ 10 +false + +10

[GitHub] [lucene-solr] murblanc commented on pull request #1607: SOLR-14546: add a Bug Fixes section for Solr 9.0.0 in CHANGES.txt

2020-06-23 Thread GitBox
murblanc commented on pull request #1607: URL: https://github.com/apache/lucene-solr/pull/1607#issuecomment-648287499 Thanks @ErickErickson. I do understand that and likely will get to it eventually but I prefer to do it that way for now, I likely understand SolrCloud better than I underst

[GitHub] [lucene-solr] ErickErickson commented on pull request #1607: SOLR-14546: add a Bug Fixes section for Solr 9.0.0 in CHANGES.txt

2020-06-23 Thread GitBox
ErickErickson commented on pull request #1607: URL: https://github.com/apache/lucene-solr/pull/1607#issuecomment-648285224 Ilan: There’s no need to burden yourself with much process for something this simple/uncontroversial, ditto with spelling corrections and the like. Up

[jira] [Resolved] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilan Ginzburg resolved SOLR-14546. -- Resolution: Fixed > OverseerTaskProcessor can process messages out of order > -

[jira] [Commented] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143091#comment-17143091 ] ASF subversion and git services commented on SOLR-14546: Commit 3

[jira] [Commented] (SOLR-14582) Expose IWC.setMaxCommitMergeWaitSeconds as an expert feature in Solr's index config

2020-06-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143093#comment-17143093 ] Mike Drob commented on SOLR-14582: -- Should we have a warning if somebody tries to use th

[GitHub] [lucene-solr] murblanc merged pull request #1607: SOLR-14546: add a Bug Fixes section for Solr 9.0.0 in CHANGES.txt

2020-06-23 Thread GitBox
murblanc merged pull request #1607: URL: https://github.com/apache/lucene-solr/pull/1607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143089#comment-17143089 ] Ilan Ginzburg commented on SOLR-12823: -- [~ichattopadhyaya] I'll put out a PR with th

[jira] [Commented] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143085#comment-17143085 ] Ilan Ginzburg commented on SOLR-14546: -- [https://github.com/apache/lucene-solr/pull/

[GitHub] [lucene-solr] murblanc opened a new pull request #1607: SOLR-14546: add a Bug Fixes section for Solr 9.0.0 in CHANGES.txt

2020-06-23 Thread GitBox
murblanc opened a new pull request #1607: URL: https://github.com/apache/lucene-solr/pull/1607 # Description Add a "Bug Fixes" section in the Solr 9.0.0 section in CHANGES.txt and move the fix to SOLR-14546 into it. # Solution Text edit. --

[GitHub] [lucene-solr] madrob commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
madrob commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648271244 This has been something that I've wanted for a long time, so I'm really excited to see somebody picking up the work! Thank you @atris ! -

[jira] [Commented] (SOLR-14560) Learning To Rank Interleaving

2020-06-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143078#comment-17143078 ] Christine Poerschke commented on SOLR-14560: Haven't yet had a chance to lear

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444334278 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143073#comment-17143073 ] Ilan Ginzburg commented on SOLR-14546: -- Sure [~ichattopadhyaya], thank for spotting

[jira] [Commented] (SOLR-14376) Optimize SolrIndexSearcher.getDocSet and getProcessedFilter for empty fq

2020-06-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143071#comment-17143071 ] Christine Poerschke commented on SOLR-14376: quick question: just spotted a {

[jira] [Updated] (LUCENE-9411) Fail complation on warnings, 9x gradle-only

2020-06-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9411: --- Summary: Fail complation on warnings, 9x gradle-only (was: Fail complation on warnings) >

[jira] [Commented] (SOLR-12698) SolrFeature: no-fq optimisation

2020-06-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143069#comment-17143069 ] Christine Poerschke commented on SOLR-12698: Returning to this. Looks like [~

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143064#comment-17143064 ] Mike Drob commented on SOLR-14588: -- See also SOLR-6930 > Circuit Breakers Infrastructur

[GitHub] [lucene-solr] madrob commented on a change in pull request #1592: SOLR-14579 First pass at dismantling Utils

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1592: URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r444325409 ## File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java ## @@ -191,7 +190,7 @@ public DocCollection getCol

[GitHub] [lucene-solr] atris opened a new pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-23 Thread GitBox
atris opened a new pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606 This commit consists of two parts: initial circuit breakers infrastructure and real JVM memory based circuit breaker which monitors incoming search requests and rejects them with SERVICE_TOO_BUSY er

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0

2020-06-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143061#comment-17143061 ] Ishan Chattopadhyaya commented on SOLR-12823: - I think we should add an upgra

[GitHub] [lucene-solr] madrob commented on a change in pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-23 Thread GitBox
madrob commented on a change in pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598#discussion_r444323329 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/TestPolicy2.java ## @@ -516,6 +517,16 @@ public void testInfiniteLoop

[jira] [Commented] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143059#comment-17143059 ] Ishan Chattopadhyaya commented on SOLR-14546: - [~ilan], Shouldn't we place th

[jira] [Updated] (SOLR-14502) increase bin/solr's post kill sleep

2020-06-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-14502: --- Fix Version/s: 8.6 master (9.0) > increase bin/solr's post kill sl

[jira] [Resolved] (SOLR-14584) solr.in.cmd and solr.in.sh still reference obsolete jks files

2020-06-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-14584. Fix Version/s: 8.6 master (9.0) Assignee: Christine Poer

[jira] [Commented] (SOLR-14502) increase bin/solr's post kill sleep

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143053#comment-17143053 ] ASF subversion and git services commented on SOLR-14502: Commit 2

[jira] [Commented] (SOLR-14502) increase bin/solr's post kill sleep

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143049#comment-17143049 ] ASF subversion and git services commented on SOLR-14502: Commit 7

[jira] [Commented] (SOLR-14584) solr.in.cmd and solr.in.sh still reference obsolete jks files

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143043#comment-17143043 ] ASF subversion and git services commented on SOLR-14584: Commit 5

[jira] [Commented] (SOLR-14584) solr.in.cmd and solr.in.sh still reference obsolete jks files

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143045#comment-17143045 ] ASF subversion and git services commented on SOLR-14584: Commit 3

[jira] [Commented] (SOLR-14584) solr.in.cmd and solr.in.sh still reference obsolete jks files

2020-06-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143044#comment-17143044 ] ASF subversion and git services commented on SOLR-14584: Commit 3

[GitHub] [lucene-solr] asfgit closed pull request #1597: SOLR-14584: replace obsolete jks references with p12 references

2020-06-23 Thread GitBox
asfgit closed pull request #1597: URL: https://github.com/apache/lucene-solr/pull/1597 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   >