[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169710#comment-17169710
]
David Smiley commented on SOLR-14557:
-
Is there really no fix aside from using \_query_ ? I view
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169700#comment-17169700
]
Gus Heck edited comment on SOLR-14704 at 8/3/20, 3:57 AM:
--
For example:
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169700#comment-17169700
]
Gus Heck commented on SOLR-14704:
-
For example:
{code:java}
./cloud.sh new -t
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667788473
Looks like `doTestStressReplicaion` is a confirmed Bad Apple as defined
here: https://issues.apache.org/jira/browse/SOLR-12028
In other words, moving on to
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667786472
I ran it again and shard split tests didn't fail so there seems to be some
inconsistency there. ReplicationHandler tests still failed. I'm digging as to
what they
gus-asf opened a new pull request #1715:
URL: https://github.com/apache/lucene-solr/pull/1715
Initial cut at this, only tested on mac osx so far.
This is an automated message from the Apache Git Service.
To respond to
Gus Heck created SOLR-14704:
---
Summary: Add download option to solr/cloud-dev/cloud.sh
Key: SOLR-14704
URL: https://issues.apache.org/jira/browse/SOLR-14704
Project: Solr
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169679#comment-17169679
]
Marcus Eagan commented on SOLR-14702:
-
>I suggest we stick to one naming convention. leader follower
MarcusSorealheis commented on pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710#issuecomment-667773267
>There is a precommit failure due to some class cast exception. I think I
can tackle that at the time of merging. Thanks for getting this feature in!
Open
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169674#comment-17169674
]
Noble Paul commented on SOLR-14702:
---
I suggest we stick to one naming convention. leader follower (for
noblepaul opened a new pull request #1714:
URL: https://github.com/apache/lucene-solr/pull/1714
for review and discussion purposes
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169664#comment-17169664
]
Noble Paul commented on SOLR-14701:
---
[~erickerickson]
I like that suggestion. Other than the {{id}}
MarcusSorealheis edited a comment on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667748906
I've gone through and tested these classes individually and they all pass,
yet these tests fail when run with the entire project:
```[junit4] Tests
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667749162
This suggests to me that there must be some shared state that exists between
other tests in the suite or there is flakiness. I don't know anything about the
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667748906
I've gone through and tested these classes individually and they all pass,
yet these tests fail when run with the entire project:
```[junit4] Tests with
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667748559
This also passes:
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667748404
@chatman it looks like the tests pass when I run the TestReplicationHandler
on its own but it fails when I run ant test locally:
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169661#comment-17169661
]
Ilan Ginzburg commented on SOLR-14613:
--
I'm getting closer to being happy with the interfaces. Will
yuriy-b-koval opened a new pull request #1713:
URL: https://github.com/apache/lucene-solr/pull/1713
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464142802
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore
murblanc commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464141895
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
[
https://issues.apache.org/jira/browse/SOLR-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuriy Koval updated SOLR-14703:
---
Summary: Edismax parser replaces whitespace characters with spaces (was:
Edismax parser replaces
Yuriy Koval created SOLR-14703:
--
Summary: Edismax parser replaces whitespace characters to spaces
Key: SOLR-14703
URL: https://issues.apache.org/jira/browse/SOLR-14703
Project: Solr
Issue Type:
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464140926
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667742202
After all the recent changes, making sure the tests pass
This is an automated message from the
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464139788
##
File path: solr/solr-ref-guide/src/query-settings-in-solrconfig.adoc
##
@@ -203,7 +203,7 @@ This setting controls whether search requests
MarcusSorealheis commented on pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710#issuecomment-667741261
Thanks for the review! :)
On Sun, Aug 2, 2020 at 4:27 PM Ishan Chattopadhyaya <
notificati...@github.com> wrote:
> There is a precommit failure due
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464138343
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore
chatman commented on pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710#issuecomment-667738758
There is a precommit failure due to some class cast exception. I think I can
tackle that at the time of merging. Thanks for getting this feature in!
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464134375
##
File path: solr/solr-ref-guide/src/query-settings-in-solrconfig.adoc
##
@@ -203,7 +203,7 @@ This setting controls whether search requests
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169654#comment-17169654
]
Marcus Eagan commented on SOLR-14701:
-
>Even though dev@ list may have been a better place
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169652#comment-17169652
]
Erick Erickson commented on SOLR-14702:
---
I can adapt to whichever convention is most convenient
chatman commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464133924
##
File path: solr/solr-ref-guide/src/query-settings-in-solrconfig.adoc
##
@@ -203,7 +203,7 @@ This setting controls whether search requests for
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169649#comment-17169649
]
Marcus Eagan edited comment on SOLR-14702 at 8/2/20, 10:26 PM:
---
For the
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169649#comment-17169649
]
Marcus Eagan edited comment on SOLR-14702 at 8/2/20, 10:25 PM:
---
For the
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169649#comment-17169649
]
Marcus Eagan commented on SOLR-14702:
-
For the repo, I think trunk would be fine, but I think that we
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169648#comment-17169648
]
Marcus Eagan commented on SOLR-14702:
-
[~erickerickson] Thanks for the contribution, I like
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667730192
> PR description says:
>
> > Replaces master with leader and slave with follower.
>
> Actual replacement is primary/secondary.
>
I've fixed the
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464128075
##
File path:
solr/core/src/java/org/apache/solr/security/JWTVerificationkeyResolver.java
##
@@ -106,7 +106,7 @@ public Key
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
> Unable to parse
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169645#comment-17169645
]
Mikhail Khludnev commented on SOLR-14557:
-
Ok. There are two places where local params are
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev reassigned SOLR-14557:
---
Assignee: Mikhail Khludnev
> Unable to parse local params followed by parenthesis
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169617#comment-17169617
]
Ilan Ginzburg commented on SOLR-14613:
--
In [PR 1684|https://github.com/apache/lucene-solr/pull/1684]
murblanc commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464111546
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
murblanc commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r46468
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
murblanc commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464110429
##
File path:
solr/core/src/java/org/apache/solr/security/JWTVerificationkeyResolver.java
##
@@ -106,7 +106,7 @@ public Key
murblanc commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667710021
PR description says:
> Replaces master with leader and slave with follower.
Actual replacement is primary/secondary.
I don't see the renamed `.png` files.
murblanc commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464108501
##
File path:
solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestContentStreamDataSource.java
##
@@ -120,7 +120,7 @@
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-667706581
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eagan updated SOLR-14702:
Description:
Every time I read _master_ and _slave_, I get pissed.
I think about the last and
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eagan updated SOLR-14702:
Description:
Every time I read _master_ and _slave_, I get pissed.
I think about the last and
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464098026
##
File path: solr/core/src/java/org/apache/solr/util/hll/HLL.java
##
@@ -47,7 +47,7 @@
*
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169550#comment-17169550
]
Erick Erickson commented on SOLR-14702:
---
Personally I like leader/follower, I've been using those
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169548#comment-17169548
]
Erick Erickson commented on SOLR-14701:
---
This was one of those "Elasticsearch is much easier to get
risdenk commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464075185
##
File path: solr/core/src/java/org/apache/solr/util/hll/HLL.java
##
@@ -47,7 +47,7 @@
*
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169538#comment-17169538
]
Mark Robert Miller commented on SOLR-14636:
---
There is not enough fun that goes on in
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller updated SOLR-14636:
--
Attachment: solr-ref-branch.gif
> Provide a reference implementation for SolrCloud
MarcusSorealheis opened a new pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712
…iet.
# Description
This PR removes all references of "master slave" from the Solr code base.
this should've happened years ago as it can result in alienating
MarcusSorealheis closed pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MarcusSorealheis opened a new pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711
# Description
This PR removes all references of "master slave" from the Solr code base.
this should've happened years ago as it can result in alienating many people
MarcusSorealheis commented on pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710#issuecomment-667648035
I don't know why all these commits show up. Maybe it's because I started
this a while ago and then got pulled in different direction and had to merge
over and over
MarcusSorealheis closed pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MarcusSorealheis opened a new pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710
# Description
Developers should be able to uninstall a package they upload via the package
management system. If a package becomes vulnerable, it's code should be
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eagan updated SOLR-14702:
Description:
Every time I read _master_ and _slave_, I get pissed.
I think about the last and
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169479#comment-17169479
]
Marcus Eagan edited comment on SOLR-14702 at 8/2/20, 8:09 AM:
--
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169479#comment-17169479
]
Marcus Eagan commented on SOLR-14702:
-
[~o...@apache.org] and [~simonwillnauer] agree, ate least, on
Marcus Eagan created SOLR-14702:
---
Summary: Remove Master and Slave from Code Base and Docs
Key: SOLR-14702
URL: https://issues.apache.org/jira/browse/SOLR-14702
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169474#comment-17169474
]
Ishan Chattopadhyaya commented on SOLR-14701:
-
+1, this is the default experience today and
Marcus Eagan created SOLR-14701:
---
Summary: Deprecate Schemaless Mode (Discussion)
Key: SOLR-14701
URL: https://issues.apache.org/jira/browse/SOLR-14701
Project: Solr
Issue Type: Improvement
69 matches
Mail list logo
