[GitHub] [lucene] navneet1v commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-28 Thread GitBox
navneet1v commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r932902145 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-07-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572733#comment-17572733 ] Dawid Weiss commented on LUCENE-10662: -- I guess so. But you'd still have to go thr

[jira] [Created] (LUCENE-10668) Should we deprecate/remove DocValuesTermsQuery in sandbox?

2022-07-28 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10668: Summary: Should we deprecate/remove DocValuesTermsQuery in sandbox? Key: LUCENE-10668 URL: https://issues.apache.org/jira/browse/LUCENE-10668 Project: Lucene - Core

[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-07-28 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572672#comment-17572672 ] Michael Sokolov commented on LUCENE-10662: -- Is it possible to redefine a stati

[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-07-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572636#comment-17572636 ] Dawid Weiss commented on LUCENE-10662: -- I'll send a heads up email to the mailing

[GitHub] [lucene] dweiss commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
dweiss commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198519752 I think some generated/ template code still remains in the main sources because it's never been ported after the move from ant?... And those examples you pointed out should be cleaned up. I

[GitHub] [lucene] gsmiller commented on pull request #1020: Add #scoreSupplier support to DocValuesRewriteMethod along with singleton doc value opto

2022-07-28 Thread GitBox
gsmiller commented on PR #1020: URL: https://github.com/apache/lucene/pull/1020#issuecomment-1198490608 Thanks @jpountz for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [lucene] gsmiller merged pull request #1020: Add #scoreSupplier support to DocValuesRewriteMethod along with singleton doc value opto

2022-07-28 Thread GitBox
gsmiller merged PR #1020: URL: https://github.com/apache/lucene/pull/1020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] jtibshirani commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
jtibshirani commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r932521592 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -730,4 +794,61 @@ protected int comparePivot(int j) { return Float.compare(score[p

[jira] [Commented] (LUCENE-10658) Merges should periodically check for abort

2022-07-28 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572582#comment-17572582 ] Vigya Sharma commented on LUCENE-10658: --- Good point.. We use pooled readers and i

[GitHub] [lucene] jtibshirani commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
jtibshirani commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r932513152 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -91,6 +101,9 @@ public class KnnGraphTester { private int beamWidth; private int ma

[GitHub] [lucene] gsmiller commented on pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-28 Thread GitBox
gsmiller commented on PR #1015: URL: https://github.com/apache/lucene/pull/1015#issuecomment-1198440196 Thanks @shaie and @stefanvodita ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Resolved] (LUCENE-10663) KnnVectorQuery explain incorrect when multiple segments

2022-07-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-10663. --- Fix Version/s: 9.4 Resolution: Fixed > KnnVectorQuery explain incorrect when

[jira] [Commented] (LUCENE-10663) KnnVectorQuery explain incorrect when multiple segments

2022-07-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572575#comment-17572575 ] ASF subversion and git services commented on LUCENE-10663: -- Co

[GitHub] [lucene] jtibshirani merged pull request #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments

2022-07-28 Thread GitBox
jtibshirani merged PR #1050: URL: https://github.com/apache/lucene/pull/1050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] tang-hi commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198427351 > > Depends on how you look at it - all the generators are there (along with the resources they use). Previously they lived together with the sources (and required manual exclusions to not

[jira] [Comment Edited] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-07-28 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572569#comment-17572569 ] Deepika Sharma edited comment on LUCENE-10544 at 7/28/22 5:16 PM: ---

[jira] [Comment Edited] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-07-28 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572569#comment-17572569 ] Deepika Sharma edited comment on LUCENE-10544 at 7/28/22 5:15 PM: ---

[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-07-28 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572569#comment-17572569 ] Deepika Sharma commented on LUCENE-10544: - Since query timeout feature is imple

[GitHub] [lucene] jtibshirani commented on pull request #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments

2022-07-28 Thread GitBox
jtibshirani commented on PR #1050: URL: https://github.com/apache/lucene/pull/1050#issuecomment-1198415489 I moved the changelog entry to 9.4 since we've already cut the 9.3 branch and started the release process. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] rmuir commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
rmuir commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198400967 > Depends on how you look at it - all the generators are there (along with the resources they use). Previously they lived together with the sources (and required manual exclusions to not end

[GitHub] [lucene] luyuncheng commented on pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-28 Thread GitBox
luyuncheng commented on PR #987: URL: https://github.com/apache/lucene/pull/987#issuecomment-1198369241 > Also I wonder if the `readNBytes` trick actually helps in practice, or if we end up crossing ByteBuffer boundaries most of the time in practice @jpountz I have the same question

[GitHub] [lucene] nknize commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-28 Thread GitBox
nknize commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1198316145 > We can commit this (once important feedback is addressed) and then PNP iterate. +1 I think this PR is ready and the remaining two items (multi geometry, and visitor pattern)

[GitHub] [lucene] msokolov commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
msokolov commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r932381359 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -730,4 +794,61 @@ protected int comparePivot(int j) { return Float.compare(score[pivo

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-28 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572514#comment-17572514 ] Michael Sokolov commented on LUCENE-10404: -- Yes I think your understanding is

[jira] [Updated] (LUCENE-10667) Multi-Value Support for Binary DocValues

2022-07-28 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Knize updated LUCENE-10667: Summary: Multi-Value Support for Binary DocValues (was: Multi-Value Support for Binary DocValus)

[jira] [Updated] (LUCENE-10666) Multi-Value Support for Binary DocValues

2022-07-28 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Knize updated LUCENE-10666: Summary: Multi-Value Support for Binary DocValues (was: Multi-Value Support for Binary DocValus)

[jira] [Resolved] (LUCENE-10667) Multi-Value Support for Binary DocValus

2022-07-28 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Knize resolved LUCENE-10667. - Resolution: Duplicate Not sure why Jira created more than one... closing > Multi-Value Support

[jira] [Comment Edited] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-07-28 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571529#comment-17571529 ] Marios Trivyzas edited comment on LUCENE-10662 at 7/28/22 3:07 PM: --

[jira] [Created] (LUCENE-10666) Multi-Value Support for Binary DocValus

2022-07-28 Thread Nick Knize (Jira)
Nick Knize created LUCENE-10666: --- Summary: Multi-Value Support for Binary DocValus Key: LUCENE-10666 URL: https://issues.apache.org/jira/browse/LUCENE-10666 Project: Lucene - Core Issue Type: N

[jira] [Comment Edited] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-07-28 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571529#comment-17571529 ] Marios Trivyzas edited comment on LUCENE-10662 at 7/28/22 3:06 PM: --

[jira] [Created] (LUCENE-10667) Multi-Value Support for Binary DocValus

2022-07-28 Thread Nick Knize (Jira)
Nick Knize created LUCENE-10667: --- Summary: Multi-Value Support for Binary DocValus Key: LUCENE-10667 URL: https://issues.apache.org/jira/browse/LUCENE-10667 Project: Lucene - Core Issue Type: N

[GitHub] [lucene] mikemccand commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-28 Thread GitBox
mikemccand commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1198181209 I cannot really understand the exciting geo-speak about centroids and bounding boxes :) It all sounds really cool though. But +1 to take a progress-not-perfection (PNP) approach

[GitHub] [lucene] dweiss commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
dweiss commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198160192 We do have checksum checks in place too - this is what the message looks like, I don't know if it can be easily improved to point at the origin resource: ``` Execution failed for task

[GitHub] [lucene] dweiss commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
dweiss commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198123449 bq. It is really unfortunate that this python code is moved to this strange location https://github.com/apache/lucene/tree/main/gradle/generation/moman, which is not intuitive to anyone at

[GitHub] [lucene] rmuir commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-28 Thread GitBox
rmuir commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1197998678 These sources are auto-generated, please modify the python generation code and not the result. These comments should really be added to `gradle/generation/moman/createLevAutomata.py`.

[jira] [Created] (LUCENE-10665) Deadlock in AnalysisSPILoader

2022-07-28 Thread Jasir KT (Jira)
Jasir KT created LUCENE-10665: - Summary: Deadlock in AnalysisSPILoader Key: LUCENE-10665 URL: https://issues.apache.org/jira/browse/LUCENE-10665 Project: Lucene - Core Issue Type: Bug

[jira] [Commented] (LUCENE-10658) Merges should periodically check for abort

2022-07-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572282#comment-17572282 ] Adrien Grand commented on LUCENE-10658: --- {{Thread#interrupt}} has the side effect

[GitHub] [lucene] kaivalnp commented on pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
kaivalnp commented on PR #932: URL: https://github.com/apache/lucene/pull/932#issuecomment-1197766429 Sorry for the delay! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
kaivalnp commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r931869194 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -730,4 +794,61 @@ protected int comparePivot(int j) { return Float.compare(score[pivo

[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-07-28 Thread GitBox
kaivalnp commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r931863515 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -730,4 +794,61 @@ protected int comparePivot(int j) { return Float.compare(score[pivo