[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520092229 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -536,7 +538,9 @@ public void queueCoreToClose(SolrCore coreToClose) { *

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520058820 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -536,7 +538,9 @@ public void queueCoreToClose(SolrCore coreToClose) { *

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520057072 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -51,7 +51,7 @@ // to essentially queue them up to be handled via pending

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520029778 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -51,7 +51,7 @@ // to essentially queue them up to be handled via pending

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519792336 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -121,8 +101,8 @@ protected void close() { // make a copy of the co

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519473036 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -490,21 +492,19 @@ public CoreDescriptor getCoreDescriptor(String coreName)

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519263690 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -198,35 +188,91 @@ protected SolrCore putCore(CoreDescriptor cd, SolrCore

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r518937449 ## File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java ## @@ -69,7 +71,10 @@ public void startReplication(boolean switchTrans