dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520057072
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##########
@@ -51,7 +51,7 @@
// to essentially queue them up to be handled via pendingCoreOps.
private static final List<SolrCore> pendingCloses = new ArrayList<>();
- private TransientSolrCoreCacheFactory transientSolrCoreCacheFactory;
+ private TransientSolrCoreCacheFactory transientSolrCoreCacheFactory =
TransientSolrCoreCacheFactory.NO_OP;
Review comment:
then SolrCores.load could be called much sooner, basically right after
the resourceLoader is ready.
Also, maybe this other thread ought to wait to start till some later time.
Perhaps ideally there would be an event publishing mechanism, which doesn't
exist currently, I know. Or alternatively just have some CountDownLatch
signal, like signaling when Solr will begin loading cores.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
