dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519473036
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##########
@@ -490,21 +492,19 @@ public CoreDescriptor getCoreDescriptor(String coreName) {
}
/**
- * Get the CoreDescriptors for every SolrCore managed here
- * @return a List of CoreDescriptors
+ * Get the CoreDescriptors for every {@link SolrCore} managed here
(permanent and transient, loaded and unloaded).
+ *
+ * @return An unordered list copy. This list can be modified by the caller
(e.g. sorted).
Review comment:
Collectors.toList says that there is no guarantees on the mutability.
So remove the docs about the mutability guarantee of what we return because we
can't guarantee that.
Or, simply use ArrayList and call addAll. I prefer this; use of Streams
here doesn't appear to add value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
