dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519792336
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##########
@@ -121,8 +101,8 @@ protected void close() {
// make a copy of the cores then clear the map so the core isn't
handed out to a request again
coreList.addAll(cores.values());
cores.clear();
- if (transientSolrCoreCache != null) {
- coreList.addAll(transientSolrCoreCache.prepareForShutdown());
+ if (transientSolrCoreCacheFactory != null) {
Review comment:
Do we still need a null check here? And why the factory vs the cache
itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
