[GitHub] [nifi] exceptionfactory commented on pull request #5073: NIFI-8538 Upgraded Apache Commons IO to 2.8.0

2021-05-12 Thread GitBox
exceptionfactory commented on pull request #5073: URL: https://github.com/apache/nifi/pull/5073#issuecomment-840250808 PR build on Windows timed out but local repository build completed: https://github.com/exceptionfactory/nifi/actions/runs/837405438 -- This is an automated

[jira] [Comment Edited] (NIFI-8461) Queue reports items but cannot list them

2021-05-12 Thread KevinSky (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343648#comment-17343648 ] KevinSky edited comment on NIFI-8461 at 5/13/21, 1:16 AM: -- hi Mark Payne, and

[jira] [Commented] (NIFI-8461) Queue reports items but cannot list them

2021-05-12 Thread KevinSky (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343648#comment-17343648 ] KevinSky commented on NIFI-8461: hi Mark Payne, and [#Matt Burgess],I found ExecuteScript::onTrigger():

[GitHub] [nifi-registry] mtien-apache commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-05-12 Thread GitBox
mtien-apache commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-840183039 Pushed commits that addresses all remaining changes and PR feedback. The PR is ready for a full review. @sardell Would you review the frontend changes?

[jira] [Updated] (NIFI-8536) PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port

2021-05-12 Thread Nadeem (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nadeem updated NIFI-8536: - Status: Patch Available (was: Open) > PrometheusReportingTask and PrometheusRecordSink do not support variable

[GitHub] [nifi] naddym opened a new pull request #5075: NIFI-8536: PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port property

2021-05-12 Thread GitBox
naddym opened a new pull request #5075: URL: https://github.com/apache/nifi/pull/5075 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[jira] [Created] (NIFIREG-454) Unable to write frontend tests

2021-05-12 Thread M Tien (Jira)
M Tien created NIFIREG-454: -- Summary: Unable to write frontend tests Key: NIFIREG-454 URL: https://issues.apache.org/jira/browse/NIFIREG-454 Project: NiFi Registry Issue Type: Bug Affects

[jira] [Assigned] (NIFI-8536) PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port

2021-05-12 Thread Nadeem (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nadeem reassigned NIFI-8536: Assignee: Nadeem > PrometheusReportingTask and PrometheusRecordSink do not support variable > registry

[GitHub] [nifi] thenatog opened a new pull request #5074: NIFI-8343 - Updated solr from 8.4.1 to 8.8.2. Small code changes were…

2021-05-12 Thread GitBox
thenatog opened a new pull request #5074: URL: https://github.com/apache/nifi/pull/5074 … required. Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality;

[GitHub] [nifi-registry] mtien-apache commented on a change in pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-05-12 Thread GitBox
mtien-apache commented on a change in pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#discussion_r631410991 ## File path:

[GitHub] [nifi-registry] mtien-apache commented on a change in pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-05-12 Thread GitBox
mtien-apache commented on a change in pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#discussion_r631404406 ## File path: nifi-registry-core/nifi-registry-web-ui/src/main/webapp/services/nf-registry.api.js ## @@ -75,6 +75,137 @@

[jira] [Updated] (NIFI-8538) Upgrade Apache Commons IO to 2.8.0

2021-05-12 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8538: --- Status: Patch Available (was: Open) > Upgrade Apache Commons IO to 2.8.0 >

[jira] [Updated] (NIFI-8538) Upgrade Apache Commons IO to 2.8.0

2021-05-12 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8538: --- Description: Apache Commons IO version 2.6 and below are vulnerable to

[GitHub] [nifi] exceptionfactory opened a new pull request #5073: NIFI-8538 Upgraded Apache Commons IO to 2.8.0

2021-05-12 Thread GitBox
exceptionfactory opened a new pull request #5073: URL: https://github.com/apache/nifi/pull/5073 Description of PR NIFI-8538 Upgrades Apache Commons IO to 2.8.0 in both direct and transitive dependencies to address

[jira] [Created] (NIFI-8538) Upgrade Apache Commons IO to 2.8.0

2021-05-12 Thread David Handermann (Jira)
David Handermann created NIFI-8538: -- Summary: Upgrade Apache Commons IO to 2.8.0 Key: NIFI-8538 URL: https://issues.apache.org/jira/browse/NIFI-8538 Project: Apache NiFi Issue Type:

[GitHub] [nifi] gresockj opened a new pull request #5072: WIP NIFI-8490: Adding inherited parameter contexts

2021-05-12 Thread GitBox
gresockj opened a new pull request #5072: URL: https://github.com/apache/nifi/pull/5072 Description of PR Adds "Inherited Parameter Contexts" to ParameterContexts. Although these inherited parameter contexts should function as expected in the UI, the UI piece of

[GitHub] [nifi] mattyb149 commented on a change in pull request #5070: NIFI-8535: Better error message in PutDatabaseRecord when table does not exist

2021-05-12 Thread GitBox
mattyb149 commented on a change in pull request #5070: URL: https://github.com/apache/nifi/pull/5070#discussion_r631343009 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestPutDatabaseRecord.groovy

[jira] [Updated] (NIFI-8537) Components become invalid if referencing a disabled controller service, even if referencing property is not in scope due to dependencies

2021-05-12 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8537: - Status: Patch Available (was: Open) > Components become invalid if referencing a disabled controller

[GitHub] [nifi] markap14 opened a new pull request #5071: NIFI-8537: Check that a property's dependencies are satisfied before …

2021-05-12 Thread GitBox
markap14 opened a new pull request #5071: URL: https://github.com/apache/nifi/pull/5071 …checking if the referenced controller service valid/enabled Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here:

[GitHub] [nifi] markap14 commented on a change in pull request #5070: NIFI-8535: Better error message in PutDatabaseRecord when table does not exist

2021-05-12 Thread GitBox
markap14 commented on a change in pull request #5070: URL: https://github.com/apache/nifi/pull/5070#discussion_r631331669 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestPutDatabaseRecord.groovy

[jira] [Created] (NIFI-8537) Components become invalid if referencing a disabled controller service, even if referencing property is not in scope due to dependencies

2021-05-12 Thread Mark Payne (Jira)
Mark Payne created NIFI-8537: Summary: Components become invalid if referencing a disabled controller service, even if referencing property is not in scope due to dependencies Key: NIFI-8537 URL:

[GitHub] [nifi] mattyb149 opened a new pull request #5070: NIFI-8535: Better error message in PutDatabaseRecord when table does not exist

2021-05-12 Thread GitBox
mattyb149 opened a new pull request #5070: URL: https://github.com/apache/nifi/pull/5070 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR If no columns are found for the specified

[jira] [Created] (NIFI-8536) PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port

2021-05-12 Thread Matthew Clarke (Jira)
Matthew Clarke created NIFI-8536: Summary: PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port Key: NIFI-8536 URL: https://issues.apache.org/jira/browse/NIFI-8536

[jira] [Assigned] (NIFI-8535) PutDatabaseRecord should give a better message when the table cannot be found

2021-05-12 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-8535: -- Assignee: Matt Burgess > PutDatabaseRecord should give a better message when the table cannot

[jira] [Created] (NIFI-8535) PutDatabaseRecord should give a better message when the table cannot be found

2021-05-12 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-8535: -- Summary: PutDatabaseRecord should give a better message when the table cannot be found Key: NIFI-8535 URL: https://issues.apache.org/jira/browse/NIFI-8535 Project:

[jira] [Updated] (NIFI-2892) Implement AWS Kinesis Stream Get Processor

2021-05-12 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-2892: -- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-2892) Implement AWS Kinesis Stream Get Processor

2021-05-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343437#comment-17343437 ] ASF subversion and git services commented on NIFI-2892: --- Commit

[GitHub] [nifi] asfgit closed pull request #4822: NIFI-2892 Implement AWS Kinesis Stream Get Processor

2021-05-12 Thread GitBox
asfgit closed pull request #4822: URL: https://github.com/apache/nifi/pull/4822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] markobean commented on pull request #5064: NIFI-8007: Setup background grid

2021-05-12 Thread GitBox
markobean commented on pull request #5064: URL: https://github.com/apache/nifi/pull/5064#issuecomment-839980571 Looks great. Thanks for adding the major/minor option. Here's some testing I did: From context menu, selected each of the Background grid options: Show only major

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-12 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-839940334 @ottobackwards not sure VFS would provide what we need here. Not sure how it deals with all of the authentication etc. But most importantly, it doesn't really provide us the

[jira] [Created] (MINIFICPP-1557) C2VerifyHeartbeatAndStop transient failure

2021-05-12 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1557: Summary: C2VerifyHeartbeatAndStop transient failure Key: MINIFICPP-1557 URL: https://issues.apache.org/jira/browse/MINIFICPP-1557 Project: Apache NiFi MiNiFi

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1070: MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service

2021-05-12 Thread GitBox
lordgamez commented on a change in pull request #1070: URL: https://github.com/apache/nifi-minifi-cpp/pull/1070#discussion_r631092918 ## File path: libminifi/test/aws-tests/PutS3ObjectTests.cpp ## @@ -107,6 +107,17 @@ TEST_CASE_METHOD(PutS3ObjectTestsFixture, "Test required

[jira] [Updated] (NIFI-8534) ConvertExcelToCSVProcessor outputting 0-byte files

2021-05-12 Thread John Wise (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Wise updated NIFI-8534: Affects Version/s: 1.12.1 > ConvertExcelToCSVProcessor outputting 0-byte files >

[jira] [Created] (NIFI-8534) ConvertExcelToCSVProcessor outputting 0-byte files

2021-05-12 Thread John Wise (Jira)
John Wise created NIFI-8534: --- Summary: ConvertExcelToCSVProcessor outputting 0-byte files Key: NIFI-8534 URL: https://issues.apache.org/jira/browse/NIFI-8534 Project: Apache NiFi Issue Type: Bug

[jira] [Comment Edited] (NIFI-8333) Issues with invokehttp/SSL Service after "Terminate Task" (e.g. due to long running transactions) and misleading error-message

2021-05-12 Thread Andreas Klingenstein (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343263#comment-17343263 ] Andreas Klingenstein edited comment on NIFI-8333 at 5/12/21, 2:03 PM: --

[jira] [Comment Edited] (NIFI-8333) Issues with invokehttp/SSL Service after "Terminate Task" (e.g. due to long running transactions) and misleading error-message

2021-05-12 Thread Andreas Klingenstein (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343263#comment-17343263 ] Andreas Klingenstein edited comment on NIFI-8333 at 5/12/21, 2:00 PM: --

[jira] [Commented] (NIFI-8333) Issues with invokehttp/SSL Service after "Terminate Task" (e.g. due to long running transactions) and misleading error-message

2021-05-12 Thread Andreas Klingenstein (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343263#comment-17343263 ] Andreas Klingenstein commented on NIFI-8333: I was able to reproduce the issue in 1.13.2. Same

[jira] [Updated] (NIFI-8333) Issues with invokehttp/SSL Service after "Terminate Task" (e.g. due to long running transactions) and misleading error-message

2021-05-12 Thread Andreas Klingenstein (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Klingenstein updated NIFI-8333: --- Description: There seems to be an issue with InvokeHTTP 1.12.1 or

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1066: MINIFICPP-1532: Create a processor to capture resource consumption me…

2021-05-12 Thread GitBox
martinzink commented on a change in pull request #1066: URL: https://github.com/apache/nifi-minifi-cpp/pull/1066#discussion_r631058529 ## File path: libminifi/test/unit/MemoryUsageTest.cpp ## @@ -20,22 +20,22 @@ #include "utils/OsUtils.h" #include "../TestBase.h"

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1066: MINIFICPP-1532: Create a processor to capture resource consumption me…

2021-05-12 Thread GitBox
martinzink commented on a change in pull request #1066: URL: https://github.com/apache/nifi-minifi-cpp/pull/1066#discussion_r631058212 ## File path: extensions/pdh/tests/PerformanceDataMonitorTests.cpp ## @@ -0,0 +1,268 @@ +/** + * + * Licensed to the Apache Software

[jira] [Updated] (NIFI-8333) Issues with invokehttp/SSL Service after "Terminate Task" (e.g. due to long running transactions) and misleading error-message

2021-05-12 Thread Andreas Klingenstein (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Klingenstein updated NIFI-8333: --- Affects Version/s: 1.13.2 > Issues with invokehttp/SSL Service after "Terminate Task"

[GitHub] [nifi] JonathanKessler commented on pull request #4780: NIFI-8126 Include Total Queued Duration in ConnectionStatus metrics

2021-05-12 Thread GitBox
JonathanKessler commented on pull request #4780: URL: https://github.com/apache/nifi/pull/4780#issuecomment-839779931 > Thanks for the update @JonathanKessler . I do think that you addressed the concerns that I had in the first review. Looked over it again. There are a few places where

[GitHub] [nifi] ottobackwards commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-12 Thread GitBox
ottobackwards commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-839773885 One reason I implemented this by swapping out FileUtils to use VFS is that you don't need to change any of this, you just set the nifi properties paths that VFS urls and the

[GitHub] [nifi] harjitdotsingh commented on pull request #5046: Fix for #Nifi-8646 Added Support for ParQuet, ORC and DataStoreBackup.

2021-05-12 Thread GitBox
harjitdotsingh commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-839768161 I knew that was coming. For some reasons my IDE formatted the code. Let me fix that. I will add that. I didn't see tests for any other cases other than JSON so left it

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
adamdebreceni commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r631034571 ## File path: libminifi/src/utils/FileReaderCallback.cpp ## @@ -0,0 +1,72 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
adamdebreceni commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r631033715 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi] simonbence commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-12 Thread GitBox
simonbence commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-839697425 Thanks @markap14 ! I am on incorporating your ideas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (NIFI-8457) When Load-balanced connections are used, offloading a node may never complete

2021-05-12 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8457. -- Resolution: Fixed > When Load-balanced connections are used, offloading a node may never

[jira] [Commented] (NIFI-8457) When Load-balanced connections are used, offloading a node may never complete

2021-05-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343176#comment-17343176 ] ASF subversion and git services commented on NIFI-8457: --- Commit

[GitHub] [nifi] asfgit closed pull request #5019: NIFI-8457: Fixed bug in load balanced connections that can result in …

2021-05-12 Thread GitBox
asfgit closed pull request #5019: URL: https://github.com/apache/nifi/pull/5019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] pvillard31 commented on pull request #5033: Expanded property description

2021-05-12 Thread GitBox
pvillard31 commented on pull request #5033: URL: https://github.com/apache/nifi/pull/5033#issuecomment-839682048 Hey @dennisjaheruddin - is there is a JIRA for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nifi] pvillard31 commented on pull request #5046: Fix for #Nifi-8646 Added Support for ParQuet, ORC and DataStoreBackup.

2021-05-12 Thread GitBox
pvillard31 commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-839680947 Hi @harjitdotsingh - happy to review these changes but can you make sure the PR is only changing what needs to be changed? there is a lot of formatting related changes that are

[jira] [Updated] (NIFI-1465) Upgrade encryption of sensitive properties

2021-05-12 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-1465: - Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade encryption of

[jira] [Updated] (NIFI-8246) Set Default Sensitive Properties Algorithm with Improved KDF and Encryption

2021-05-12 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8246: - Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-8246) Set Default Sensitive Properties Algorithm with Improved KDF and Encryption

2021-05-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343171#comment-17343171 ] ASF subversion and git services commented on NIFI-8246: --- Commit

[GitHub] [nifi] asfgit closed pull request #5055: NIFI-8246 Set NIFI_PBKDF2_AES_GCM_256 as Default Properties Algorithm

2021-05-12 Thread GitBox
asfgit closed pull request #5055: URL: https://github.com/apache/nifi/pull/5055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (NIFI-8502) Upgrade Spring Framework to latest 5.x version

2021-05-12 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8502: - Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-8502) Upgrade Spring Framework to latest 5.x version

2021-05-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343170#comment-17343170 ] ASF subversion and git services commented on NIFI-8502: --- Commit

[GitHub] [nifi] asfgit closed pull request #5066: NIFI-8502 Upgrade Spring Framework to 5.3.6

2021-05-12 Thread GitBox
asfgit closed pull request #5066: URL: https://github.com/apache/nifi/pull/5066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] pvillard31 commented on pull request #5066: NIFI-8502 Upgrade Spring Framework to 5.3.6

2021-05-12 Thread GitBox
pvillard31 commented on pull request #5066: URL: https://github.com/apache/nifi/pull/5066#issuecomment-839672737 Built the PR and ran some basic flows, everything is looking good on my side AFAICT. Merging. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] turcsanyip commented on a change in pull request #4822: NIFI-2892 Implement AWS Kinesis Stream Get Processor

2021-05-12 Thread GitBox
turcsanyip commented on a change in pull request #4822: URL: https://github.com/apache/nifi/pull/4822#discussion_r630918349 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
arpadboda commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630913672 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
arpadboda commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630913672 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
arpadboda commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630913410 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630912957 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630911063 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi] gschaer opened a new pull request #5069: NIFI-6685: Add align and distribute UI actions

2021-05-12 Thread GitBox
gschaer opened a new pull request #5069: URL: https://github.com/apache/nifi/pull/5069 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Enables align and distribute actions on the core

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1070: MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service

2021-05-12 Thread GitBox
adamdebreceni commented on a change in pull request #1070: URL: https://github.com/apache/nifi-minifi-cpp/pull/1070#discussion_r630897852 ## File path: libminifi/test/aws-tests/PutS3ObjectTests.cpp ## @@ -107,6 +107,17 @@ TEST_CASE_METHOD(PutS3ObjectTestsFixture, "Test

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1070: MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service

2021-05-12 Thread GitBox
adamdebreceni commented on a change in pull request #1070: URL: https://github.com/apache/nifi-minifi-cpp/pull/1070#discussion_r630897852 ## File path: libminifi/test/aws-tests/PutS3ObjectTests.cpp ## @@ -107,6 +107,17 @@ TEST_CASE_METHOD(PutS3ObjectTestsFixture, "Test

[GitHub] [nifi-minifi-cpp] adamdebreceni edited a comment on pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-12 Thread GitBox
adamdebreceni edited a comment on pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#issuecomment-839636962 > Looks good to me, however I think we could also add some tests as well, maybe something along the lines of IntegrationBase where you set the

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-12 Thread GitBox
adamdebreceni commented on pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#issuecomment-839636962 > Looks good to me, however I think we could also add some tests as well, maybe something along the lines of IntegrationBase where you set the

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-12 Thread GitBox
adamdebreceni closed pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-05-12 Thread GitBox
arpadboda commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630885656 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-05-12 Thread GitBox
aminadinari19 commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r630852673 ## File path: controller/MiNiFiController.cpp ## @@ -167,9 +165,10 @@ int main(int argc, char **argv) { socket = secure_context

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-12 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r630823120 ## File path: conf/minifi.properties ## @@ -67,6 +67,7 @@ nifi.content.repository.class.name=DatabaseContentRepository ## define protocol

[jira] [Updated] (NIFI-8532) ConsumeKinesisStream tuning/performance testing

2021-05-12 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8532: -- Description: {{ConsumeKinesisStream}} was added in NIFI-2892 with some seemingly sensible