[jira] [Assigned] (NIFI-12067) MockProcessSession sends created/cloned flowfiles to the input queue on rollback

2023-10-02 Thread Eric Secules (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Secules reassigned NIFI-12067: --- Assignee: Eric Secules > MockProcessSession sends created/cloned flowfiles to the input queu

[jira] [Updated] (MINIFICPP-2233) gcc-13 verification fails

2023-10-02 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2233: --- Status: Patch Available (was: In Progress) > gcc-13 verification fails > ---

[PR] NIFI-12158 MockProcessSession write methods preserves attributes [nifi]

2023-10-02 Thread via GitHub
esecules opened a new pull request, #7828: URL: https://github.com/apache/nifi/pull/7828 # Summary [NIFI-12158](https://issues.apache.org/jira/browse/NIFI-12158) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-11772 Removing flow.xml support [nifi]

2023-10-02 Thread via GitHub
simonbence commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1342363037 ## nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy: ## @@ -722,7 +707,7 @@ class ConfigEncryptionTool {

Re: [PR] NIFI-11772 Removing flow.xml support [nifi]

2023-10-02 Thread via GitHub
simonbence commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1342367861 ## nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy: ## @@ -248,8 +235,6 @@ class ConfigEncryptionTool {

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342392944 ## libminifi/include/core/logging/Logger.h: ## @@ -234,33 +196,46 @@ class Logger : public BaseLogger { std::mutex mutex_; private: - template - inl

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342393674 ## libminifi/include/utils/ResourceQueue.h: ## @@ -108,16 +108,16 @@ class ResourceQueue : public std::enable_shared_from_this resource) { -logDebug("Re

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342394026 ## libminifi/include/utils/ResourceQueue.h: ## @@ -108,16 +108,16 @@ class ResourceQueue : public std::enable_shared_from_this resource) { -logDebug("Re

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342408055 ## libminifi/include/core/logging/Logger.h: ## @@ -145,81 +125,63 @@ class LogBuilder { bool ignore; BaseLogger *ptr; std::stringstream str; - LOG_

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342408998 ## libminifi/include/core/logging/Logger.h: ## @@ -49,59 +50,15 @@ class LoggerControl { std::atomic is_enabled_; }; -template -using has_const_c_str_m

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342410709 ## extensions/windows-event-log/ConsumeWindowsEventLog.cpp: ## @@ -628,7 +628,7 @@ void ConsumeWindowsEventLog::LogWindowsError(const std::string& error) co

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342411655 ## libminifi/include/core/logging/Logger.h: ## @@ -145,81 +125,63 @@ class LogBuilder { bool ignore; BaseLogger *ptr; std::stringstream str; - LOG_

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342403137 ## extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp: ## @@ -245,8 +245,8 @@ bool SourceInitiatedSubscriptionListener::Handler::handlePost

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342410709 ## extensions/windows-event-log/ConsumeWindowsEventLog.cpp: ## @@ -628,7 +628,7 @@ void ConsumeWindowsEventLog::LogWindowsError(const std::string& error) co

[jira] [Created] (MINIFICPP-2238) Disable pull request updates to issues@nifi.apache.org

2023-10-02 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2238: --- Summary: Disable pull request updates to issues@nifi.apache.org Key: MINIFICPP-2238 URL: https://issues.apache.org/jira/browse/MINIFICPP-2238 Project: Apache NiF

[PR] MINIFICPP-2238 Disable pull request updates to issues@nifi.apache.org [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm opened a new pull request, #1673: URL: https://github.com/apache/nifi-minifi-cpp/pull/1673 GitHub is already sending PR updates to subscribed people. I feel like we shouldn't spam the issues@ list with these. These emails started appearing today for some reason, despite the con

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342426788 ## libminifi/include/core/logging/Logger.h: ## @@ -234,33 +190,34 @@ class Logger : public BaseLogger { std::mutex mutex_; private: + std::string trimToM

[jira] [Updated] (NIFI-12148) NiFi Hive3Streaming memory leak

2023-10-02 Thread Dmytro Firsov (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Firsov updated NIFI-12148: - Description: JVM heap size is constantly grows when using Hive3Streaming processor, depending on

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342430096 ## libminifi/src/FlowFileRecord.cpp: ## @@ -50,17 +50,17 @@ std::shared_ptr FlowFileRecord::DeSerialize(const std::string& k std::string value; if (!flo

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342430096 ## libminifi/src/FlowFileRecord.cpp: ## @@ -50,17 +50,17 @@ std::shared_ptr FlowFileRecord::DeSerialize(const std::string& k std::string value; if (!flo

[jira] [Created] (MINIFICPP-2239) Add bandwidth limit to InvokeHTTP processor

2023-10-02 Thread Jira
Gábor Gyimesi created MINIFICPP-2239: Summary: Add bandwidth limit to InvokeHTTP processor Key: MINIFICPP-2239 URL: https://issues.apache.org/jira/browse/MINIFICPP-2239 Project: Apache NiFi MiNiFi

Re: [PR] MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1661: URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1342529913 ## libminifi/src/core/extension/ExtensionManager.cpp: ## @@ -31,9 +31,13 @@ namespace org::apache::nifi::minifi::core::extension { const std::shared_ptr Exten

Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-02 Thread via GitHub
mark-bathori commented on code in PR #7421: URL: https://github.com/apache/nifi/pull/7421#discussion_r1342539976 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/test/java/org/apache/nifi/processors/iceberg/TestIcebergRecordConverter.java: ## @@ -433,11 +494,1

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342552083 ## extensions/standard-processors/processors/TailFile.cpp: ## @@ -499,9 +499,9 @@ bool TailFile::getStateFromLegacyStateFile(const std::shared_ptrlog_info("

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342552974 ## extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp: ## @@ -245,8 +245,8 @@ bool SourceInitiatedSubscriptionListener::Handler::handle

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342553887 ## libminifi/src/FlowFileRecord.cpp: ## @@ -50,17 +50,17 @@ std::shared_ptr FlowFileRecord::DeSerialize(const std::string& k std::string value; if (

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342554280 ## libminifi/include/core/logging/Logger.h: ## @@ -234,33 +190,34 @@ class Logger : public BaseLogger { std::mutex mutex_; private: - template - inl

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342555145 ## libminifi/include/utils/ResourceQueue.h: ## @@ -108,16 +108,16 @@ class ResourceQueue : public std::enable_shared_from_this resource) { -logDebug("Re

Re: [PR] NIFI-12131 Fix potential NPE when FlowAnalyzer and RuleViolationsManager are not set. [nifi]

2023-10-02 Thread via GitHub
tpalfy commented on PR #7809: URL: https://github.com/apache/nifi/pull/7809#issuecomment-1742847325 @exceptionfactory I'm not entirely familiar with all possible NiFi runtimes but in general only the regular NiFi would have FlowAnalyzer and RuleViolationsManager set. At least that was the i

Re: [PR] MINIFICPP-2178 - Move extension tests to their directories [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
lordgamez commented on PR #1658: URL: https://github.com/apache/nifi-minifi-cpp/pull/1658#issuecomment-1742860352 The `bugprone-unchecked-optional-access` issues can be ignored, because they will be removed, but the other clang-tidy issues should be fixed before merging: ``` 2023-0

Re: [PR] MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
lordgamez commented on code in PR #1661: URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1342582388 ## libminifi/src/core/extension/ExtensionManager.cpp: ## @@ -31,9 +31,13 @@ namespace org::apache::nifi::minifi::core::extension { const std::shared_ptr Ex

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342557733 ## extensions/http-curl/protocols/RESTSender.cpp: ## @@ -183,12 +183,12 @@ C2Payload RESTSender::sendPayload(const std::string& url, const Direction direct c

Re: [PR] MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1661: MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI URL: https://github.com/apache/nifi-minifi-cpp/pull/1661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (MINIFICPP-2191) Replace deprecated OpenSSL API calls

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2191: Fix Version/s: 0.16.0 > Replace deprecated OpenSSL API calls >

[jira] [Resolved] (MINIFICPP-2221) Auto-generate CONTROLLERS.md

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2221. - Resolution: Done > Auto-generate CONTROLLERS.md > > >

[jira] [Updated] (MINIFICPP-2196) Integrate cppcoreguideline clang-tidy checks in CI

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2196: Resolution: Done Status: Resolved (was: Patch Available) > Integrate cppcoregu

[jira] [Updated] (MINIFICPP-2207) The HTTP request method field in HTTPClient and InvokeHTTP should be an enum

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2207: Fix Version/s: 0.16.0 > The HTTP request method field in HTTPClient and InvokeHTTP shou

[jira] [Updated] (MINIFICPP-2227) Fix issues with alpine:3.18 base image

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2227: Resolution: Fixed Status: Resolved (was: Patch Available) > Fix issues with al

[jira] [Updated] (MINIFICPP-2228) Fix clang job cache key name in CI

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2228: Resolution: Fixed Status: Resolved (was: Patch Available) > Fix clang job cach

Re: [PR] MINIFICPP-2191 Replace deprecated OpenSSL API calls [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1656: MINIFICPP-2191 Replace deprecated OpenSSL API calls URL: https://github.com/apache/nifi-minifi-cpp/pull/1656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINIFICPP-2207 HttpRequestMethod should be an enum [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1657: MINIFICPP-2207 HttpRequestMethod should be an enum URL: https://github.com/apache/nifi-minifi-cpp/pull/1657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINIFICPP-2221 Auto-generate CONTROLLERS.md [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1665: MINIFICPP-2221 Auto-generate CONTROLLERS.md URL: https://github.com/apache/nifi-minifi-cpp/pull/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] MINIFICPP-2228 Fix clang job cache key name in CI [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1666: MINIFICPP-2228 Fix clang job cache key name in CI URL: https://github.com/apache/nifi-minifi-cpp/pull/1666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINIFICPP-2227 Upgrade docker base image to alpine:3.18 [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1667: MINIFICPP-2227 Upgrade docker base image to alpine:3.18 URL: https://github.com/apache/nifi-minifi-cpp/pull/1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (MINIFICPP-2191) Replace deprecated OpenSSL API calls

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2191. - Resolution: Done > Replace deprecated OpenSSL API calls > ---

[jira] [Updated] (MINIFICPP-2196) Integrate cppcoreguideline clang-tidy checks in CI

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2196: Fix Version/s: 0.16.0 > Integrate cppcoreguideline clang-tidy checks in CI > --

[jira] [Resolved] (MINIFICPP-2207) The HTTP request method field in HTTPClient and InvokeHTTP should be an enum

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2207. - Resolution: Done > The HTTP request method field in HTTPClient and InvokeHTTP should

[jira] [Updated] (MINIFICPP-2228) Fix clang job cache key name in CI

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2228: Fix Version/s: 0.16.0 > Fix clang job cache key name in CI > --

[jira] [Updated] (MINIFICPP-2227) Fix issues with alpine:3.18 base image

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2227: Fix Version/s: 0.16.0 > Fix issues with alpine:3.18 base image > --

Re: [PR] MINIFICPP-2212 use administrative yield duration instead of onschedul… [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on PR #1664: URL: https://github.com/apache/nifi-minifi-cpp/pull/1664#issuecomment-1742892083 Could you check the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342557733 ## extensions/http-curl/protocols/RESTSender.cpp: ## @@ -183,12 +183,12 @@ C2Payload RESTSender::sendPayload(const std::string& url, const Direction direct c

[jira] [Assigned] (NIFI-12159) Flow Analysis results should provide name for Funnels

2023-10-02 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy reassigned NIFI-12159: -- Assignee: Tamas Palfy > Flow Analysis results should provide name for Funnels > --

[jira] [Created] (NIFI-12159) Flow Analysis results should provide name for Funnels

2023-10-02 Thread Tamas Palfy (Jira)
Tamas Palfy created NIFI-12159: -- Summary: Flow Analysis results should provide name for Funnels Key: NIFI-12159 URL: https://issues.apache.org/jira/browse/NIFI-12159 Project: Apache NiFi Issue T

[jira] [Updated] (NIFI-12159) Flow Analysis results should provide name for Funnels

2023-10-02 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-12159: --- Description: Flow Analysis results show a displayed name for the violating component. This defaults

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342622940 ## libminifi/include/core/logging/Logger.h: ## @@ -112,19 +62,42 @@ enum LOG_LEVEL { off = 6 }; +inline spdlog::level::level_enum mapToSpdLogLevel(LOG_

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342624975 ## extensions/http-curl/protocols/RESTSender.cpp: ## @@ -183,12 +183,12 @@ C2Payload RESTSender::sendPayload(const std::string& url, const Direction direct

[jira] [Commented] (NIFI-12038) Create processor to package FlowFiles

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771070#comment-17771070 ] ASF subversion and git services commented on NIFI-12038: Commit 4

[jira] [Updated] (NIFI-12038) Create processor to package FlowFiles

2023-10-02 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-12038: --- Fix Version/s: 1.24.0 > Create processor to package FlowFiles > -

[jira] [Commented] (NIFI-12038) Create processor to package FlowFiles

2023-10-02 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771075#comment-17771075 ] Michael W Moser commented on NIFI-12038: Thanks [~joewitt] .  I merged to support

Re: [PR] NIFI-12099 Repurpose Template icon in top left bar [nifi]

2023-10-02 Thread via GitHub
sardell commented on PR #7811: URL: https://github.com/apache/nifi/pull/7811#issuecomment-1742973498 Reviewing now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-02 Thread via GitHub
mark-bathori commented on code in PR #7421: URL: https://github.com/apache/nifi/pull/7421#discussion_r1342676660 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-common/src/main/java/org/apache/nifi/processors/iceberg/converter/IcebergRecordConverter.java: ## @@ -156,8 +174,

Re: [PR] NIFI-12157 Remove nifi-logging-utils and NiFiLog [nifi]

2023-10-02 Thread via GitHub
exceptionfactory commented on PR #7826: URL: https://github.com/apache/nifi/pull/7826#issuecomment-1743005175 Thanks for the detailed notes on those methods @joewitt, I made the proposed adjustments and pushed the changes. -- This is an automated message from the Apache Git Service. To re

[jira] [Assigned] (MINIFICPP-62) Create SplitText processor

2023-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-62: -- Assignee: Gábor Gyimesi > Create SplitText processor > -- >

Re: [PR] NIFI-11129 - adding PutMongoBulk processor to use the bulkWrite API [nifi]

2023-10-02 Thread via GitHub
exceptionfactory commented on code in PR #6918: URL: https://github.com/apache/nifi/pull/6918#discussion_r1342697444 ## nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java: ## @@ -0,0 +1,304 @@

Re: [PR] NIFI-11772 Removing flow.xml support [nifi]

2023-10-02 Thread via GitHub
exceptionfactory commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1342713418 ## nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy: ## @@ -248,8 +235,6 @@ class ConfigEncryptionT

Re: [PR] NIFI-11772 Removing flow.xml support [nifi]

2023-10-02 Thread via GitHub
exceptionfactory commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1342714169 ## nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy: ## @@ -385,26 +370,26 @@ class ConfigEncryptio

Re: [PR] NIFI-11772 Removing flow.xml support [nifi]

2023-10-02 Thread via GitHub
exceptionfactory commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1342717006 ## nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy: ## @@ -722,7 +707,7 @@ class ConfigEncryptionT

[jira] [Created] (NIFI-12160) Check if all the necessary nars have been fully unpacked before starting a connector

2023-10-02 Thread Peter Gyori (Jira)
Peter Gyori created NIFI-12160: -- Summary: Check if all the necessary nars have been fully unpacked before starting a connector Key: NIFI-12160 URL: https://issues.apache.org/jira/browse/NIFI-12160 Projec

[PR] MINIFICPP-2239 Add bandwidth limit to InvokeHTTP processor [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
lordgamez opened a new pull request, #1674: URL: https://github.com/apache/nifi-minifi-cpp/pull/1674 - Additionally fix ListenHTTP response setting - Add processor name and id if input connection is required or forbidden https://issues.apache.org/jira/browse/MINIFICPP-2239 --

[jira] [Updated] (NIFI-12107) Utilization column in Cluster Table is not sorting properly

2023-10-02 Thread Paulette Hines-Cross (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulette Hines-Cross updated NIFI-12107: Status: Open (was: Patch Available) > Utilization column in Cluster Table is not s

[jira] [Updated] (NIFI-12107) Utilization column in Cluster Table is not sorting properly

2023-10-02 Thread Paulette Hines-Cross (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulette Hines-Cross updated NIFI-12107: Status: Patch Available (was: Open) > Utilization column in Cluster Table is not s

[jira] [Updated] (NIFI-11392) NiFi does not stop gracefully when using CRON scheduling

2023-10-02 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-11392: --- Summary: NiFi does not stop gracefully when using CRON scheduling (was: NiFi does not stop t

Re: [PR] NIFI-12116 Configured ObjectMapper to not allow multiline JSON. [nifi]

2023-10-02 Thread via GitHub
markap14 commented on PR #7782: URL: https://github.com/apache/nifi/pull/7782#issuecomment-1743139339 @dan-s1 @ChrisSamo632 @r-vandenbos I do think we want to be careful here. Breaking it up into two processors that really do essentially the same thing is probably a mistake in my opinion. I

[jira] [Created] (NIFI-12161) System Tests failing on Linux

2023-10-02 Thread Mark Payne (Jira)
Mark Payne created NIFI-12161: - Summary: System Tests failing on Linux Key: NIFI-12161 URL: https://issues.apache.org/jira/browse/NIFI-12161 Project: Apache NiFi Issue Type: Bug Compone

[PR] NIFI-12161: While waiting for node to startup, time out after 5 minut… [nifi]

2023-10-02 Thread via GitHub
markap14 opened a new pull request, #7829: URL: https://github.com/apache/nifi/pull/7829 …es and throw an Exception # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please comple

Re: [PR] NIFI-12116 Configured ObjectMapper to not allow multiline JSON. [nifi]

2023-10-02 Thread via GitHub
joewitt commented on PR #7782: URL: https://github.com/apache/nifi/pull/7782#issuecomment-1743210311 since i was asked i'll just state I don't have any special input here worth sharing. There are more than enough thoughtful perspectives in this so I'll stay out of it at this point. -- T

Re: [PR] NIFI-12157 Remove nifi-logging-utils and NiFiLog [nifi]

2023-10-02 Thread via GitHub
asfgit closed pull request #7826: NIFI-12157 Remove nifi-logging-utils and NiFiLog URL: https://github.com/apache/nifi/pull/7826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (NIFI-12157) Remove nifi-logging-utils and NiFiLog

2023-10-02 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12157: Resolution: Fixed Status: Resolved (was: Patch Available) > Remove nifi-logging-utils and NiFiLog

[jira] [Commented] (NIFI-12157) Remove nifi-logging-utils and NiFiLog

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771163#comment-17771163 ] ASF subversion and git services commented on NIFI-12157: Commit 1

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
lordgamez commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342815709 ## libminifi/src/c2/C2Agent.cpp: ## @@ -1038,7 +1038,7 @@ void C2Agent::handleAssetUpdate(const C2ContentResponse& resp) { } void C2Agent::enqueue_c2_ser

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342891414 ## libminifi/src/c2/C2Agent.cpp: ## @@ -1038,7 +1038,7 @@ void C2Agent::handleAssetUpdate(const C2ContentResponse& resp) { } void C2Agent::enqueue_c2_se

[PR] NIFI-12115 Add ListenOTLP to collect OpenTelemetry [nifi]

2023-10-02 Thread via GitHub
exceptionfactory opened a new pull request, #7830: URL: https://github.com/apache/nifi/pull/7830 # Summary [NIFI-12115](https://issues.apache.org/jira/browse/NIFI-12115) Adds a `ListenOTLP` Processor to collect OpenTelemetry information, supporting [OTLP Specification 1.0.0](https://

[jira] [Updated] (NIFI-12115) Add ListenOTLP Processor for Collecting OpenTelemetry

2023-10-02 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12115: Status: Patch Available (was: In Progress) > Add ListenOTLP Processor for Collecting OpenT

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342962956 ## libminifi/src/c2/C2Agent.cpp: ## @@ -151,16 +151,16 @@ void C2Agent::configure(const std::shared_ptr &configure, bool reconf if (!configure->get(Configu

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342962956 ## libminifi/src/c2/C2Agent.cpp: ## @@ -151,16 +151,16 @@ void C2Agent::configure(const std::shared_ptr &configure, bool reconf if (!configure->get(Configu

Re: [PR] MINIFICPP-2220 Change core::logging::Logger to use fmt format [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342962956 ## libminifi/src/c2/C2Agent.cpp: ## @@ -151,16 +151,16 @@ void C2Agent::configure(const std::shared_ptr &configure, bool reconf if (!configure->get(Configu

[jira] [Updated] (MINIFICPP-2238) Disable pull request updates to issues@nifi.apache.org

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2238: Assignee: Marton Szasz Status: Patch Available (was: Open) > Disable pull reques

Re: [PR] NIFI-11463 Allow IdentifyMimeType to use custom MIME types in addition to defaults [nifi]

2023-10-02 Thread via GitHub
NissimShiman commented on code in PR #7781: URL: https://github.com/apache/nifi/pull/7781#discussion_r1342996242 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -161,31 +180,42 @@ pr

Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]

2023-10-02 Thread via GitHub
markobean commented on PR #7591: URL: https://github.com/apache/nifi/pull/7591#issuecomment-1743517135 @mtien-apache I have updated the UI elements so that the "Apply recursively" checkbox appears immediately underneath the Process Group Parameter Context combo. I think placing it next to t

Re: [PR] MINIFICPP-2212 use administrative yield duration instead of onschedul… [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1664: MINIFICPP-2212 use administrative yield duration instead of onschedul… URL: https://github.com/apache/nifi-minifi-cpp/pull/1664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MINIFICPP-2233 Upgrade bustache to fix gcc13 compatibility [nifi-minifi-cpp]

2023-10-02 Thread via GitHub
szaszm closed pull request #1672: MINIFICPP-2233 Upgrade bustache to fix gcc13 compatibility URL: https://github.com/apache/nifi-minifi-cpp/pull/1672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (MINIFICPP-2233) gcc-13 verification fails

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2233: Fix Version/s: 0.16.0 > gcc-13 verification fails > - > >

[jira] [Updated] (MINIFICPP-2212) Processor onSchedule retry configuration discrepancy with NiFi

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2212: Fix Version/s: 0.16.0 > Processor onSchedule retry configuration discrepancy with NiFi

[jira] [Updated] (MINIFICPP-2233) gcc-13 verification fails

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2233: Resolution: Fixed Status: Resolved (was: Patch Available) > gcc-13 verificatio

[jira] [Updated] (MINIFICPP-2212) Processor onSchedule retry configuration discrepancy with NiFi

2023-10-02 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2212: Resolution: Fixed Status: Resolved (was: Patch Available) > Processor onSchedu

Re: [PR] NIFI-12099 Repurpose Template icon in top left bar [nifi]

2023-10-02 Thread via GitHub
sardell commented on PR #7811: URL: https://github.com/apache/nifi/pull/7811#issuecomment-1743565571 It looks like the draggable icons are no longer centered in their container, which is more obvious when hovering over an icon. Before your changes: ![before](https://github.com

Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]

2023-10-02 Thread via GitHub
markobean commented on PR #7591: URL: https://github.com/apache/nifi/pull/7591#issuecomment-1743592921 Branch has been rebased to main as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] NIFI-12088: Show Dependent Properties when depending on newly created Service [nifi]

2023-10-02 Thread via GitHub
scottyaslan commented on PR #7810: URL: https://github.com/apache/nifi/pull/7810#issuecomment-1743671731 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Updated] (NIFI-12158) NiFi Mock Process Session Does Not Preserve Attributes when Using Wirte

2023-10-02 Thread Eric Secules (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Secules updated NIFI-12158: Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/7828 > NiFi Mock P

[jira] [Updated] (NIFI-12067) MockProcessSession sends created/cloned flowfiles to the input queue on rollback

2023-10-02 Thread Eric Secules (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Secules updated NIFI-12067: Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/7827 > MockProcess

  1   2   >